123290 2013-10-24 14:06:21 -0700 Add level dependent size checks to textureImage2D calls 2013-10-24 16:40:47 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 roger_fong roger_fong commit-queue dino esprehn+autocc gyuyoung.kim kondapallykalyan roger_fong oldest_to_newest 943310 0 roger_fong 2013-10-24 14:06:21 -0700 <rdar://problem/15201382> There are different size limits went calling textureImage2D on different levels of the texture. conformance-suites/1.0.2/conformance/textures/texture-size-limit.html tests for this. 943314 1 215104 roger_fong 2013-10-24 14:18:44 -0700 Created attachment 215104 Patch 943326 2 215104 dino 2013-10-24 15:25:50 -0700 Comment on attachment 215104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=215104&action=review > LayoutTests/ChangeLog:25 > +2013-10-24 Roger Fong <roger_fong@apple.com> > + > + Need a short description (OOPS!). > + Need the bug URL (OOPS!). > + > + Reviewed by NOBODY (OOPS!). > + > + * platform/mac/TestExpectations: > + > +2013-10-24 Roger Fong <roger_fong@apple.com> > + > + Unreviewed gardening. Skip some failing WebGL Conformance suite 1.0.1 tests. > + > + * platform/mac/TestExpectations: > + Oops! 943354 3 roger_fong 2013-10-24 16:40:47 -0700 Committed: http://trac.webkit.org/changeset/157959 215104 2013-10-24 14:18:44 -0700 2013-10-24 15:25:50 -0700 Patch bug-123290-20131024141843.patch text/plain 5828 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Nzk1MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTEwLTI0ICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHRleHR1cmUgbGV2ZWwg ZGVwZW5kZW50IHNpemUgY2hlY2tzIHRvIHRleHR1cmVJbWFnZTJEIGNhbGxzLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMjkwCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xNTIwMTM4Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUZXN0IGNvdmVyZWQgYnkgV2ViR0wgQ29uZm9ybWFuY2Ugc3VpdGUg MS4wLjIgdGVzdCwgdGV4dHVyZXMvdGV4dHVyZS1zaXplLWxpbWl0Lmh0bWwuCisKKyAgICAgICAg VGhlcmUgYXJlIGRpZmZlcmVudCBzaXplIGxpbWl0cyB3aGVuIGNhbGxpbmcgdGV4dHVyZUltYWdl MkQgb24gZGlmZmVyZW50IHRleHR1cmUgbGV2ZWxzLgorICAgICAgICBXZSBzaG91bGQgYmUgdGhy b3dpbmcgYW4gZXJyb3IgaWYgb3VyIHRleHR1cmUgc2l6ZSBleGNlZWRzIHRoZXNlIGxpbWl0cy4K KworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnZhbGlkYXRlVGV4RnVuY1BhcmFt ZXRlcnMpOgorCiAyMDEzLTEwLTI0ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4K IAogICAgICAgICBUcnkgdG8gZml4IGJ1aWxkIHdpdGhvdXQgQ1NTX1NIQVBFUy4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0 LmNwcAkocmV2aXNpb24gMTU3OTAzKQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2Vi R0xSZW5kZXJpbmdDb250ZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTE1Niw5ICs1MTU2LDEw IEBAIGJvb2wgV2ViR0xSZW5kZXJpbmdDb250ZXh0Ojp2YWxpZGF0ZVRleEYKICAgICAgICAgcmV0 dXJuIGZhbHNlOwogICAgIH0KIAorICAgIEdDM0RpbnQgbWF4VGV4dHVyZVNpemVGb3JMZXZlbCA9 IHBvdygyLjAsIG1fbWF4VGV4dHVyZUxldmVsIC0gMSAtIGxldmVsKTsKICAgICBzd2l0Y2ggKHRh cmdldCkgewogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OlRFWFRVUkVfMkQ6Ci0gICAgICAg IGlmICh3aWR0aCA+IG1fbWF4VGV4dHVyZVNpemUgfHwgaGVpZ2h0ID4gbV9tYXhUZXh0dXJlU2l6 ZSkgeworICAgICAgICBpZiAod2lkdGggPiBtYXhUZXh0dXJlU2l6ZUZvckxldmVsIHx8IGhlaWdo dCA+IG1heFRleHR1cmVTaXplRm9yTGV2ZWwpIHsKICAgICAgICAgICAgIHN5bnRoZXNpemVHTEVy cm9yKEdyYXBoaWNzQ29udGV4dDNEOjpJTlZBTElEX1ZBTFVFLCBmdW5jdGlvbk5hbWUsICJ3aWR0 aCBvciBoZWlnaHQgb3V0IG9mIHJhbmdlIik7CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgICAgIH0KQEAgLTUxNzAsMTIgKzUxNzEsMTIgQEAgYm9vbCBXZWJHTFJlbmRlcmluZ0NvbnRl eHQ6OnZhbGlkYXRlVGV4RgogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OlRFWFRVUkVfQ1VC RV9NQVBfUE9TSVRJVkVfWjoKICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpURVhUVVJFX0NV QkVfTUFQX05FR0FUSVZFX1o6CiAgICAgICAgIGlmIChmdW5jdGlvblR5cGUgIT0gVGV4U3ViSW1h Z2UyRCAmJiB3aWR0aCAhPSBoZWlnaHQpIHsKLSAgICAgICAgICBzeW50aGVzaXplR0xFcnJvcihH cmFwaGljc0NvbnRleHQzRDo6SU5WQUxJRF9WQUxVRSwgZnVuY3Rpb25OYW1lLCAid2lkdGggIT0g aGVpZ2h0IGZvciBjdWJlIG1hcCIpOwotICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAg ICAgIHN5bnRoZXNpemVHTEVycm9yKEdyYXBoaWNzQ29udGV4dDNEOjpJTlZBTElEX1ZBTFVFLCBm dW5jdGlvbk5hbWUsICJ3aWR0aCAhPSBoZWlnaHQgZm9yIGN1YmUgbWFwIik7CisgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CiAgICAgICAgIH0KICAgICAgICAgLy8gTm8gbmVlZCB0byBjaGVjayBo ZWlnaHQgaGVyZS4gRm9yIHRleEltYWdlIHdpZHRoID09IGhlaWdodC4KICAgICAgICAgLy8gRm9y IHRleFN1YkltYWdlIHRoYXQgd2lsbCBiZSBjaGVja2VkIHdoZW4gY2hlY2tpbmcgeW9mZnNldCAr IGhlaWdodCBpcyBpbiByYW5nZS4KLSAgICAgICAgaWYgKHdpZHRoID4gbV9tYXhDdWJlTWFwVGV4 dHVyZVNpemUpIHsKKyAgICAgICAgaWYgKHdpZHRoID4gbWF4VGV4dHVyZVNpemVGb3JMZXZlbCkg ewogICAgICAgICAgICAgc3ludGhlc2l6ZUdMRXJyb3IoR3JhcGhpY3NDb250ZXh0M0Q6OklOVkFM SURfVkFMVUUsIGZ1bmN0aW9uTmFtZSwgIndpZHRoIG9yIGhlaWdodCBvdXQgb2YgcmFuZ2UgZm9y IGN1YmUgbWFwIik7CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIH0KSW5kZXg6 IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHJldmlzaW9uIDE1Nzk1MykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDEzLTEwLTI0ICBSb2dlciBGb25nICA8cm9nZXJfZm9u Z0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHRleHR1cmUgbGV2ZWwgZGVwZW5kZW50IHNpemUg Y2hlY2tzIHRvIHRleHR1cmVJbWFnZTJEIGNhbGxzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMjkwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x NTIwMTM4Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOiBVbnNraXAgbm93IHBhc3NpbmcgdGVz dCB0ZXh0dXJlLXNpemUtbGltaXQuaHRtbC4KKworMjAxMy0xMC0yNCAgUm9nZXIgRm9uZyAgPHJv Z2VyX2ZvbmdAYXBwbGUuY29tPgorCisgICAgICAgIE5lZWQgYSBzaG9ydCBkZXNjcmlwdGlvbiAo T09QUyEpLgorICAgICAgICBOZWVkIHRoZSBidWcgVVJMIChPT1BTISkuCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvVGVzdEV4 cGVjdGF0aW9uczoKKworMjAxMy0xMC0yNCAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUu Y29tPgorCisgICAgICAgIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLiBTa2lwIHNvbWUgZmFpbGluZyBX ZWJHTCBDb25mb3JtYW5jZSBzdWl0ZSAxLjAuMSB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3Jt L21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEzLTEwLTI0ICBHcnplZ29yeiBDemFqa293c2tp ICA8Zy5jemFqa293c2tpQHNhbXN1bmcuY29tPgogCiAgICAgICAgIGR1bXBBc1RleHQoKSBpcyB1 bm5lY2Vzc2FyaWx5IGNhbGxlZCBpbiBzcGVsbGNoZWNraW5nIHRlc3RzCkluZGV4OiBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24gMTU3OTA0KQorKysg TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkK QEAgLTcyMywxMyArNzIzLDggQEAgd2ViZ2wvMS4wLjIvY29uZm9ybWFuY2Uvb2dsZXMvR0wvYml1 RGVwdAogd2ViZ2wvMS4wLjIvY29uZm9ybWFuY2Uvb2dsZXMvR0wvZ2xfRnJhZ0Nvb3JkL2dsX0Zy YWdDb29yZF8wMDFfdG9fMDAzLmh0bWwKIHdlYmdsLzEuMC4yL2NvbmZvcm1hbmNlL3JlbmRlcmJ1 ZmZlcnMvZnJhbWVidWZmZXItb2JqZWN0LWF0dGFjaG1lbnQuaHRtbAogd2ViZ2wvMS4wLjIvY29u Zm9ybWFuY2UvcmVuZGVyaW5nL2dsLXNjaXNzb3ItdGVzdC5odG1sCi13ZWJnbC8xLjAuMi9jb25m b3JtYW5jZS90ZXh0dXJlcy90ZXh0dXJlLXNpemUtbGltaXQuaHRtbAogd2ViZ2wvMS4wLjIvY29u Zm9ybWFuY2UvdHlwZWRhcnJheXMvYXJyYXktdW5pdC10ZXN0cy5odG1sCiB3ZWJnbC8xLjAuMi9j b25mb3JtYW5jZS90eXBlZGFycmF5cy9kYXRhLXZpZXctdGVzdC5odG1sCi13ZWJnbC8xLjAuMi9j b25mb3JtYW5jZS9nbHNsL2Z1bmN0aW9ucy9nbHNsLWZ1bmN0aW9uLXNtb290aHN0ZXAtZ2VudHlw ZS5odG1sCi13ZWJnbC8xLjAuMi9jb25mb3JtYW5jZS9nbHNsL3ZhcmlhYmxlcy9nbC1wb2ludGNv b3JkLmh0bWwKLXdlYmdsLzEuMC4yL2NvbmZvcm1hbmNlL29nbGVzL0dML29wZXJhdG9ycy9vcGVy YXRvcnNfMDA5X3RvXzAxNi5odG1sCi1odHRwL3Rlc3RzL3dlYmdsLzEuMC4yL29yaWdpbi1jbGVh bi1jb25mb3JtYW5jZS5odG1sCiAKICMgU2tpcHBpbmcgYWxsIHdlYmdsIGNvbmZvcm1hbmNlIHRl c3RzIG9uIHRydW5rCiB3ZWJnbC9jb25mb3JtYW5jZQpAQCAtNzQzLDggKzczOCwxNSBAQCB3ZWJn bC8xLjAuMS9jb25mb3JtYW5jZS9nbHNsL21pc2Mvc2hhZGVyCiB3ZWJnbC8xLjAuMS9jb25mb3Jt YW5jZS9nbHNsL3NhbXBsZXJzL2dsc2wtZnVuY3Rpb24tdGV4dHVyZTJkbG9kLmh0bWwKIHdlYmds LzEuMC4xL2NvbmZvcm1hbmNlL2dsc2wvc2FtcGxlcnMvZ2xzbC1mdW5jdGlvbi10ZXh0dXJlMmRw cm9qLmh0bWwKIHdlYmdsLzEuMC4xL2NvbmZvcm1hbmNlL3RleHR1cmVzL29yaWdpbi1jbGVhbi1j b25mb3JtYW5jZS5odG1sCit3ZWJnbC8xLjAuMS9jb25mb3JtYW5jZS9jb250ZXh0L2NvbnRleHQt bG9zdC1yZXN0b3JlZC5odG1sCit3ZWJnbC8xLjAuMS9jb25mb3JtYW5jZS9nbHNsL2Z1bmN0aW9u cy9nbHNsLWZ1bmN0aW9uLXNtb290aHN0ZXAtZ2VudHlwZS5odG1sCit3ZWJnbC8xLjAuMS9jb25m b3JtYW5jZS9nbHNsL3ZhcmlhYmxlcy9nbC1wb2ludGNvb3JkLmh0bWwKIHdlYmdsLzEuMC4yL2Nv bmZvcm1hbmNlL2NvbnRleHQvY29udGV4dC1jcmVhdGlvbi1hbmQtZGVzdHJ1Y3Rpb24uaHRtbAog d2ViZ2wvMS4wLjIvY29uZm9ybWFuY2UvcmVuZGVyaW5nL211bHRpc2FtcGxlLWNvcnJ1cHRpb24u aHRtbAord2ViZ2wvMS4wLjIvY29uZm9ybWFuY2UvZ2xzbC9mdW5jdGlvbnMvZ2xzbC1mdW5jdGlv bi1zbW9vdGhzdGVwLWdlbnR5cGUuaHRtbAord2ViZ2wvMS4wLjIvY29uZm9ybWFuY2UvZ2xzbC92 YXJpYWJsZXMvZ2wtcG9pbnRjb29yZC5odG1sCit3ZWJnbC8xLjAuMi9jb25mb3JtYW5jZS9vZ2xl cy9HTC9vcGVyYXRvcnMvb3BlcmF0b3JzXzAwOV90b18wMTYuaHRtbAoraHR0cC90ZXN0cy93ZWJn bC8xLjAuMi9vcmlnaW4tY2xlYW4tY29uZm9ybWFuY2UuaHRtbAogCiAjIFNlbmRpbmcgdGhlIG1v dXNlIGRvd24gZXZlbnQgdG8gdGhlIHNjcm9sbGJhciBzdGFydHMgYSBuZXN0ZWQgcnVuIGxvb3Ag d2hpY2ggY2F1c2VzIGEgaGFuZy4KIGZhc3QvZXZlbnRzL21vdXNlZG93bi1pbi1zdWJmcmFtZS1z Y3JvbGxiYXIuaHRtbAo=