<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>123281</bug_id>
          
          <creation_ts>2013-10-24 11:36:55 -0700</creation_ts>
          <short_desc>Web Inspector: Adjust the precision of byte strings</short_desc>
          <delta_ts>2013-10-24 12:38:09 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Timothy Hatcher">timothy</reporter>
          <assigned_to name="Timothy Hatcher">timothy</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eoconnor</cc>
    
    <cc>graouts</cc>
    
    <cc>joepeck</cc>
    
    <cc>mat</cc>
    
    <cc>timothy</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>943225</commentid>
    <comment_count>0</comment_count>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2013-10-24 11:36:55 -0700</bug_when>
    <thetext>It should show more precision for MB and less precision for &lt; 1024 KB.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943226</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2013-10-24 11:37:30 -0700</bug_when>
    <thetext>&lt;rdar://problem/15311366&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943228</commentid>
    <comment_count>2</comment_count>
    <who name="Mat Marquis">mat</who>
    <bug_when>2013-10-24 11:39:53 -0700</bug_when>
    <thetext>&gt; less precision for &lt; 1024 KB.

I’m not sure why you’d want it to be less precise at any point?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943229</commentid>
    <comment_count>3</comment_count>
      <attachid>215085</attachid>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2013-10-24 11:40:02 -0700</bug_when>
    <thetext>Created attachment 215085
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943230</commentid>
    <comment_count>4</comment_count>
      <attachid>215086</attachid>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2013-10-24 11:43:25 -0700</bug_when>
    <thetext>Created attachment 215086
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943231</commentid>
    <comment_count>5</comment_count>
      <attachid>215086</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2013-10-24 11:44:05 -0700</bug_when>
    <thetext>Comment on attachment 215086
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943232</commentid>
    <comment_count>6</comment_count>
      <attachid>215086</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2013-10-24 11:47:20 -0700</bug_when>
    <thetext>Comment on attachment 215086
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215086&amp;action=review

&gt; Source/WebInspectorUI/UserInterface/Utilities.js:945
&gt; +        if (higherResolution || megabytes &lt; 10)

We could even do the same for kilobytes. if KB &lt; 10 show %.2f</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943234</commentid>
    <comment_count>7</comment_count>
    <who name="Mat Marquis">mat</who>
    <bug_when>2013-10-24 11:47:54 -0700</bug_when>
    <thetext>*** Bug 123280 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943235</commentid>
    <comment_count>8</comment_count>
      <attachid>215087</attachid>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2013-10-24 11:50:05 -0700</bug_when>
    <thetext>Created attachment 215087
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943236</commentid>
    <comment_count>9</comment_count>
    <who name="Mat Marquis">mat</who>
    <bug_when>2013-10-24 11:50:21 -0700</bug_when>
    <thetext>Wait, so this only shows the first decimal place up to 10MB? 

I’m not sure why there needs to be an upper threshold. I’d really rather have the most accurate possible read of bandwidth usage at any point.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943238</commentid>
    <comment_count>10</comment_count>
      <attachid>215087</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2013-10-24 11:52:08 -0700</bug_when>
    <thetext>Comment on attachment 215087
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=215087&amp;action=review

&gt; Source/WebInspectorUI/UserInterface/Utilities.js:942
&gt; +        else if (higherResolution &amp;&amp; kilobytes &lt; 1024)
&gt; +            return WebInspector.UIString(&quot;%.1f KB&quot;).format(kilobytes);

This should be just &quot;kilobytes &lt; 1024&quot;, if higherResolution  were true, the top if would have been taken.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943244</commentid>
    <comment_count>11</comment_count>
      <attachid>215088</attachid>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2013-10-24 12:04:52 -0700</bug_when>
    <thetext>Created attachment 215088
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943247</commentid>
    <comment_count>12</comment_count>
      <attachid>215088</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2013-10-24 12:05:54 -0700</bug_when>
    <thetext>Comment on attachment 215088
Patch

r=me!!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943272</commentid>
    <comment_count>13</comment_count>
      <attachid>215088</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-10-24 12:38:07 -0700</bug_when>
    <thetext>Comment on attachment 215088
Patch

Clearing flags on attachment: 215088

Committed r157947: &lt;http://trac.webkit.org/changeset/157947&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943273</commentid>
    <comment_count>14</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-10-24 12:38:09 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>215085</attachid>
            <date>2013-10-24 11:40:02 -0700</date>
            <delta_ts>2013-10-24 11:43:25 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bytesToString.patch</filename>
            <type>text/plain</type>
            <size>1763</size>
            <attacher name="Timothy Hatcher">timothy</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi
SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJkNGRiYTguLjJlZTZlZDkgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv
clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEwLTI0ICBUaW1vdGh5IEhhdGNo
ZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBBZGp1c3QgdGhlIHByZWNpc2lvbiBv
ZiBieXRlIHN0cmluZ3MgaW4gV2ViIEluc3BlY3Rvci4KKworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMjgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1V0aWxpdGllcy5qczoK
KyAgICAgICAgKE51bWJlci5ieXRlc1RvU3RyaW5nKTogTW9yZSBwcmVjaXNpb24gZm9yIE1CIGFu
ZCBsZXNzIHByZWNpc2lvbiBmb3IgPCAxMDI0IEtCLgorCiAyMDEzLTEwLTIxICBBbGV4YW5kcnUg
Q2hpY3VsaXRhICA8YWNoaWN1QGFkb2JlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBb
Q1NTIFJlZ2lvbnNdIEZsb3dzIGFyZSBub3QgbG9hZGluZyBpZiB5b3UgcmVmcmVzaCB0aGUgcGFn
ZSBzZXZlcmFsIHRpbWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu
dGVyZmFjZS9VdGlsaXRpZXMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj
ZS9VdGlsaXRpZXMuanMKaW5kZXggZDFiNjUwMi4uMmUxZjBjOCAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVXRpbGl0aWVzLmpzCisrKyBiL1NvdXJjZS9X
ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1V0aWxpdGllcy5qcwpAQCAtOTM3LDEzICs5Mzcs
MTUgQEAgT2JqZWN0LmRlZmluZVByb3BlcnR5KE51bWJlciwgImJ5dGVzVG9TdHJpbmciLAogCiAg
ICAgICAgIHZhciBraWxvYnl0ZXMgPSBieXRlcyAvIDEwMjQ7CiAgICAgICAgIGlmIChoaWdoZXJS
ZXNvbHV0aW9uICYmIGtpbG9ieXRlcyA8IDEwMjQpCi0gICAgICAgICAgICByZXR1cm4gV2ViSW5z
cGVjdG9yLlVJU3RyaW5nKCIlLjJmIEtCIikuZm9ybWF0KGtpbG9ieXRlcyk7CisgICAgICAgICAg
ICByZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIlLjFmIEtCIikuZm9ybWF0KGtpbG9ieXRl
cyk7CiAgICAgICAgIGVsc2UgaWYgKGtpbG9ieXRlcyA8IDEwMjQpCiAgICAgICAgICAgICByZXR1
cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIlLjBmIEtCIikuZm9ybWF0KGtpbG9ieXRlcyk7CiAK
ICAgICAgICAgdmFyIG1lZ2FieXRlcyA9IGtpbG9ieXRlcyAvIDEwMjQ7Ci0gICAgICAgIGlmICho
aWdoZXJSZXNvbHV0aW9uKQorICAgICAgICBpZiAoaGlnaGVyUmVzb2x1dGlvbiB8fCBtZWdhYnl0
ZXMgPCAxMCkKICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIiUuMmYg
TUIiKS5mb3JtYXQobWVnYWJ5dGVzKTsKKyAgICAgICAgZWxzZSBpZiAobWVnYWJ5dGVzIDwgMTAw
KQorICAgICAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmluZygiJS4xZiBNQiIpLmZv
cm1hdChtZWdhYnl0ZXMpOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICByZXR1cm4gV2ViSW5z
cGVjdG9yLlVJU3RyaW5nKCIlLjBmIE1CIikuZm9ybWF0KG1lZ2FieXRlcyk7CiAgICAgfQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>215086</attachid>
            <date>2013-10-24 11:43:25 -0700</date>
            <delta_ts>2013-10-24 11:50:05 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bytesToString.patch</filename>
            <type>text/plain</type>
            <size>1735</size>
            <attacher name="Timothy Hatcher">timothy</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi
SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJkNGRiYTguLjJlZTZlZDkgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv
clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEwLTI0ICBUaW1vdGh5IEhhdGNo
ZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBBZGp1c3QgdGhlIHByZWNpc2lvbiBv
ZiBieXRlIHN0cmluZ3MgaW4gV2ViIEluc3BlY3Rvci4KKworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMjgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1V0aWxpdGllcy5qczoK
KyAgICAgICAgKE51bWJlci5ieXRlc1RvU3RyaW5nKTogTW9yZSBwcmVjaXNpb24gZm9yIE1CIGFu
ZCBsZXNzIHByZWNpc2lvbiBmb3IgPCAxMDI0IEtCLgorCiAyMDEzLTEwLTIxICBBbGV4YW5kcnUg
Q2hpY3VsaXRhICA8YWNoaWN1QGFkb2JlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBb
Q1NTIFJlZ2lvbnNdIEZsb3dzIGFyZSBub3QgbG9hZGluZyBpZiB5b3UgcmVmcmVzaCB0aGUgcGFn
ZSBzZXZlcmFsIHRpbWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu
dGVyZmFjZS9VdGlsaXRpZXMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj
ZS9VdGlsaXRpZXMuanMKaW5kZXggZDFiNjUwMi4uYWI4OGZkZCAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVXRpbGl0aWVzLmpzCisrKyBiL1NvdXJjZS9X
ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1V0aWxpdGllcy5qcwpAQCAtOTM3LDE1ICs5Mzcs
MTUgQEAgT2JqZWN0LmRlZmluZVByb3BlcnR5KE51bWJlciwgImJ5dGVzVG9TdHJpbmciLAogCiAg
ICAgICAgIHZhciBraWxvYnl0ZXMgPSBieXRlcyAvIDEwMjQ7CiAgICAgICAgIGlmIChoaWdoZXJS
ZXNvbHV0aW9uICYmIGtpbG9ieXRlcyA8IDEwMjQpCi0gICAgICAgICAgICByZXR1cm4gV2ViSW5z
cGVjdG9yLlVJU3RyaW5nKCIlLjJmIEtCIikuZm9ybWF0KGtpbG9ieXRlcyk7CisgICAgICAgICAg
ICByZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIlLjFmIEtCIikuZm9ybWF0KGtpbG9ieXRl
cyk7CiAgICAgICAgIGVsc2UgaWYgKGtpbG9ieXRlcyA8IDEwMjQpCiAgICAgICAgICAgICByZXR1
cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIlLjBmIEtCIikuZm9ybWF0KGtpbG9ieXRlcyk7CiAK
ICAgICAgICAgdmFyIG1lZ2FieXRlcyA9IGtpbG9ieXRlcyAvIDEwMjQ7Ci0gICAgICAgIGlmICho
aWdoZXJSZXNvbHV0aW9uKQorICAgICAgICBpZiAoaGlnaGVyUmVzb2x1dGlvbiB8fCBtZWdhYnl0
ZXMgPCAxMCkKICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIiUuMmYg
TUIiKS5mb3JtYXQobWVnYWJ5dGVzKTsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgcmV0dXJu
IFdlYkluc3BlY3Rvci5VSVN0cmluZygiJS4wZiBNQiIpLmZvcm1hdChtZWdhYnl0ZXMpOworICAg
ICAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmluZygiJS4xZiBNQiIpLmZvcm1hdCht
ZWdhYnl0ZXMpOwogICAgIH0KIH0pOwogCg==
</data>
<flag name="review"
          id="237733"
          type_id="1"
          status="+"
          setter="joepeck"
    />
    <flag name="commit-queue"
          id="237734"
          type_id="3"
          status="-"
          setter="timothy"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>215087</attachid>
            <date>2013-10-24 11:50:05 -0700</date>
            <delta_ts>2013-10-24 12:04:52 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bytesToString.patch</filename>
            <type>text/plain</type>
            <size>1909</size>
            <attacher name="Timothy Hatcher">timothy</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi
SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJkNGRiYTguLjczYjdkNDkgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv
clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEwLTI0ICBUaW1vdGh5IEhhdGNo
ZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBBZGp1c3QgdGhlIHByZWNpc2lvbiBv
ZiBieXRlIHN0cmluZ3MgaW4gV2ViIEluc3BlY3Rvci4KKworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMjgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1V0aWxpdGllcy5qczoK
KyAgICAgICAgKE51bWJlci5ieXRlc1RvU3RyaW5nKTogTW9yZSBwcmVjaXNpb24gZm9yIE1CIGFu
ZCBsZXNzIHByZWNpc2lvbiBmb3IgMTAuLjEwMjMgS0IuCisKIDIwMTMtMTAtMjEgIEFsZXhhbmRy
dSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6
IFtDU1MgUmVnaW9uc10gRmxvd3MgYXJlIG5vdCBsb2FkaW5nIGlmIHlvdSByZWZyZXNoIHRoZSBw
YWdlIHNldmVyYWwgdGltZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy
SW50ZXJmYWNlL1V0aWxpdGllcy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm
YWNlL1V0aWxpdGllcy5qcwppbmRleCBkMWI2NTAyLi40OGFiODhiIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9VdGlsaXRpZXMuanMKKysrIGIvU291cmNl
L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVXRpbGl0aWVzLmpzCkBAIC05MzYsMTYgKzkz
NiwxOCBAQCBPYmplY3QuZGVmaW5lUHJvcGVydHkoTnVtYmVyLCAiYnl0ZXNUb1N0cmluZyIsCiAg
ICAgICAgICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIlLjBmIEIiKS5mb3JtYXQo
Ynl0ZXMpOwogCiAgICAgICAgIHZhciBraWxvYnl0ZXMgPSBieXRlcyAvIDEwMjQ7Ci0gICAgICAg
IGlmIChoaWdoZXJSZXNvbHV0aW9uICYmIGtpbG9ieXRlcyA8IDEwMjQpCisgICAgICAgIGlmICho
aWdoZXJSZXNvbHV0aW9uIHx8IGtpbG9ieXRlcyA8IDEwKQogICAgICAgICAgICAgcmV0dXJuIFdl
Ykluc3BlY3Rvci5VSVN0cmluZygiJS4yZiBLQiIpLmZvcm1hdChraWxvYnl0ZXMpOworICAgICAg
ICBlbHNlIGlmIChoaWdoZXJSZXNvbHV0aW9uICYmIGtpbG9ieXRlcyA8IDEwMjQpCisgICAgICAg
ICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIlLjFmIEtCIikuZm9ybWF0KGtpbG9i
eXRlcyk7CiAgICAgICAgIGVsc2UgaWYgKGtpbG9ieXRlcyA8IDEwMjQpCiAgICAgICAgICAgICBy
ZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIlLjBmIEtCIikuZm9ybWF0KGtpbG9ieXRlcyk7
CiAKICAgICAgICAgdmFyIG1lZ2FieXRlcyA9IGtpbG9ieXRlcyAvIDEwMjQ7Ci0gICAgICAgIGlm
IChoaWdoZXJSZXNvbHV0aW9uKQorICAgICAgICBpZiAoaGlnaGVyUmVzb2x1dGlvbiB8fCBtZWdh
Ynl0ZXMgPCAxMCkKICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIiUu
MmYgTUIiKS5mb3JtYXQobWVnYWJ5dGVzKTsKICAgICAgICAgZWxzZQotICAgICAgICAgICAgcmV0
dXJuIFdlYkluc3BlY3Rvci5VSVN0cmluZygiJS4wZiBNQiIpLmZvcm1hdChtZWdhYnl0ZXMpOwor
ICAgICAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmluZygiJS4xZiBNQiIpLmZvcm1h
dChtZWdhYnl0ZXMpOwogICAgIH0KIH0pOwogCg==
</data>
<flag name="review"
          id="237736"
          type_id="1"
          status="+"
          setter="joepeck"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>215088</attachid>
            <date>2013-10-24 12:04:52 -0700</date>
            <delta_ts>2013-10-24 12:38:07 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bytesToString.patch</filename>
            <type>text/plain</type>
            <size>1853</size>
            <attacher name="Timothy Hatcher">timothy</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi
SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJkNGRiYTguLjczYjdkNDkgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv
clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEwLTI0ICBUaW1vdGh5IEhhdGNo
ZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBBZGp1c3QgdGhlIHByZWNpc2lvbiBv
ZiBieXRlIHN0cmluZ3MgaW4gV2ViIEluc3BlY3Rvci4KKworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMjgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1V0aWxpdGllcy5qczoK
KyAgICAgICAgKE51bWJlci5ieXRlc1RvU3RyaW5nKTogTW9yZSBwcmVjaXNpb24gZm9yIE1CIGFu
ZCBsZXNzIHByZWNpc2lvbiBmb3IgMTAuLjEwMjMgS0IuCisKIDIwMTMtMTAtMjEgIEFsZXhhbmRy
dSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6
IFtDU1MgUmVnaW9uc10gRmxvd3MgYXJlIG5vdCBsb2FkaW5nIGlmIHlvdSByZWZyZXNoIHRoZSBw
YWdlIHNldmVyYWwgdGltZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy
SW50ZXJmYWNlL1V0aWxpdGllcy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm
YWNlL1V0aWxpdGllcy5qcwppbmRleCBkMWI2NTAyLi5jMGEzNjM3IDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9VdGlsaXRpZXMuanMKKysrIGIvU291cmNl
L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVXRpbGl0aWVzLmpzCkBAIC05MzYsMTYgKzkz
NiwxNiBAQCBPYmplY3QuZGVmaW5lUHJvcGVydHkoTnVtYmVyLCAiYnl0ZXNUb1N0cmluZyIsCiAg
ICAgICAgICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIlLjBmIEIiKS5mb3JtYXQo
Ynl0ZXMpOwogCiAgICAgICAgIHZhciBraWxvYnl0ZXMgPSBieXRlcyAvIDEwMjQ7Ci0gICAgICAg
IGlmIChoaWdoZXJSZXNvbHV0aW9uICYmIGtpbG9ieXRlcyA8IDEwMjQpCisgICAgICAgIGlmICho
aWdoZXJSZXNvbHV0aW9uIHx8IGtpbG9ieXRlcyA8IDEwKQogICAgICAgICAgICAgcmV0dXJuIFdl
Ykluc3BlY3Rvci5VSVN0cmluZygiJS4yZiBLQiIpLmZvcm1hdChraWxvYnl0ZXMpOwogICAgICAg
ICBlbHNlIGlmIChraWxvYnl0ZXMgPCAxMDI0KQotICAgICAgICAgICAgcmV0dXJuIFdlYkluc3Bl
Y3Rvci5VSVN0cmluZygiJS4wZiBLQiIpLmZvcm1hdChraWxvYnl0ZXMpOworICAgICAgICAgICAg
cmV0dXJuIFdlYkluc3BlY3Rvci5VSVN0cmluZygiJS4xZiBLQiIpLmZvcm1hdChraWxvYnl0ZXMp
OwogCiAgICAgICAgIHZhciBtZWdhYnl0ZXMgPSBraWxvYnl0ZXMgLyAxMDI0OwotICAgICAgICBp
ZiAoaGlnaGVyUmVzb2x1dGlvbikKKyAgICAgICAgaWYgKGhpZ2hlclJlc29sdXRpb24gfHwgbWVn
YWJ5dGVzIDwgMTApCiAgICAgICAgICAgICByZXR1cm4gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCIl
LjJmIE1CIikuZm9ybWF0KG1lZ2FieXRlcyk7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIHJl
dHVybiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIiUuMGYgTUIiKS5mb3JtYXQobWVnYWJ5dGVzKTsK
KyAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIiUuMWYgTUIiKS5mb3Jt
YXQobWVnYWJ5dGVzKTsKICAgICB9CiB9KTsKIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>