123275 2013-10-24 09:53:01 -0700 [CSS Regions][CSS Shapes] Update updateShapeAndSegmentsForCurrentLineInFlowThread to deal better with the first lines 2013-10-25 10:24:55 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zoltan zoltan commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 943180 0 zoltan 2013-10-24 09:53:01 -0700 We have a complex condition in updateShapeAndSegmentsForCurrentLineInFlowThread where it's adjusting the first line to the shape's top. This patch adds two boolean to make it clear. 943182 1 215077 zoltan 2013-10-24 09:55:45 -0700 Created attachment 215077 Patch 943636 2 215077 hyatt 2013-10-25 09:58:41 -0700 Comment on attachment 215077 Patch r=me 943644 3 215077 commit-queue 2013-10-25 10:24:53 -0700 Comment on attachment 215077 Patch Clearing flags on attachment: 215077 Committed r158015: <http://trac.webkit.org/changeset/158015> 943645 4 commit-queue 2013-10-25 10:24:55 -0700 All reviewed patches have been landed. Closing bug. 215077 2013-10-24 09:55:45 -0700 2013-10-25 10:24:53 -0700 Patch bug-123275-20131024095544.patch text/plain 2381 zoltan U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3ODk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDJhOGI3ZjVhM2E3MmVh NTdlNTAzOTUxMWRhMGQxZWI4ZmRiNTE3OS4uZTNmN2MxMjAxMzlhZmE5ZjhiZDYxZWIxYTAwODYx YmU3NjQ2MWRmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTEwLTI0ICBab2x0 YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgorCisgICAgICAgIFtDU1MgUmVnaW9uc11b Q1NTIFNoYXBlc10gVXBkYXRlIHVwZGF0ZVNoYXBlQW5kU2VnbWVudHNGb3JDdXJyZW50TGluZUlu Rmxvd1RocmVhZCB0byBkZWFsIGJldHRlciB3aXRoIHRoZSBmaXJzdCBsaW5lcworICAgICAgICA8 aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzI3NT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBoYXZlIGEgY29tcGxl eCBjb25kaXRpb24gaW4gdXBkYXRlU2hhcGVBbmRTZWdtZW50c0ZvckN1cnJlbnRMaW5lSW5GbG93 VGhyZWFkLCB3aGljaCBpcworICAgICAgICBhZGp1c3RpbmcgdGhlIGZpcnN0IGxpbmUgdG8gdGhl IHNoYXBlJ3MgdG9wLiBUaGlzIHBhdGNoIGFkZHMgdHdvIGJvb2xlYW4gdG8gbWFrZSB0aGF0IGNs ZWFyLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJCbG9ja0Zsb3c6OnVwZGF0ZVNoYXBlQW5kU2VnbWVudHNGb3JDdXJyZW50TGlu ZUluRmxvd1RocmVhZCk6CisKIDIwMTMtMTAtMjMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBw bGUuY29tPgogCiAgICAgICAgIFNWR0ZpbHRlckJ1aWxkZXIgc2hvdWxkIG5vdCBiZSByZWYtY291 bnRlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xp bmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxh eW91dC5jcHAKaW5kZXggOTMxZDliMzE4MTAxNjQ5MWZjYmExMWJmYzAyZGZkMDVmMTNhMTljZi4u OWQ1MmU2ZjlhN2QwZDJhYjAyMWVjOTkzOTQwNWM0MWI1MmJlNGFlNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKQEAgLTE0MzUs OCArMTQzNSwxMCBAQCB2b2lkIFJlbmRlckJsb2NrRmxvdzo6dXBkYXRlU2hhcGVBbmRTZWdtZW50 c0ZvckN1cnJlbnRMaW5lSW5GbG93VGhyZWFkKFNoYXBlSW5zaQogICAgIGlmICghc2hhcGVJbnNp ZGVJbmZvKQogICAgICAgICByZXR1cm47CiAKKyAgICBib29sIGlzRmlyc3RMaW5lSW5SZWdpb24g PSBsb2dpY2FsTGluZUJvdHRvbUluRmxvd1RocmVhZCA8PSAobG9naWNhbFJlZ2lvblRvcEluRmxv d1RocmVhZCArIGxpbmVIZWlnaHQpOworICAgIGJvb2wgaXNGaXJzdExpbmVBZGp1c3RlZCA9IChs b2dpY2FsTGluZVRvcEluRmxvd1RocmVhZCAtIGxvZ2ljYWxSZWdpb25Ub3BJbkZsb3dUaHJlYWQp IDwgKGxheW91dFN0YXRlLmFkanVzdGVkTG9naWNhbExpbmVUb3AoKSAtIGN1cnJlbnRSZWdpb24t PmJvcmRlckFuZFBhZGRpbmdCZWZvcmUoKSk7CiAgICAgLy8gV2UgcG9zaXRpb24gdGhlIGZpcnN0 IGxpbmUgdG8gdGhlIHRvcCBvZiB0aGUgc2hhcGUgaW4gdGhlIHJlZ2lvbiBvciB0byB0aGUgcHJl dmlvdXNseSBhZGp1c3RlZCBwb3NpdGlvbiBpbiB0aGUgc2hhcGUKLSAgICBpZiAobG9naWNhbExp bmVCb3R0b21JbkZsb3dUaHJlYWQgPD0gKGxvZ2ljYWxSZWdpb25Ub3BJbkZsb3dUaHJlYWQgKyBs aW5lSGVpZ2h0KSB8fCAobG9naWNhbExpbmVUb3BJbkZsb3dUaHJlYWQgLSBsb2dpY2FsUmVnaW9u VG9wSW5GbG93VGhyZWFkKSA8IChsYXlvdXRTdGF0ZS5hZGp1c3RlZExvZ2ljYWxMaW5lVG9wKCkg LSBjdXJyZW50UmVnaW9uLT5ib3JkZXJBbmRQYWRkaW5nQmVmb3JlKCkpKSB7CisgICAgaWYgKGlz Rmlyc3RMaW5lSW5SZWdpb24gfHwgaXNGaXJzdExpbmVBZGp1c3RlZCkgewogICAgICAgICBMYXlv dXRVbml0IHNoYXBlVG9wT2Zmc2V0ID0gbGF5b3V0U3RhdGUuYWRqdXN0ZWRMb2dpY2FsTGluZVRv cCgpOwogICAgICAgICBpZiAoIXNoYXBlVG9wT2Zmc2V0KQogICAgICAgICAgICAgc2hhcGVUb3BP ZmZzZXQgPSBzaGFwZUluc2lkZUluZm8tPnNoYXBlTG9naWNhbFRvcCgpOwo=