<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>123271</bug_id>
          
          <creation_ts>2013-10-24 08:12:54 -0700</creation_ts>
          <short_desc>Fix broken C Loop LLINT build</short_desc>
          <delta_ts>2013-10-31 23:13:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Lam">mark.lam</reporter>
          <assigned_to name="Mark Lam">mark.lam</assigned_to>
          <cc>changseok</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>mhahnenberg</cc>
    
    <cc>msaboff</cc>
    
    <cc>oliver</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>943123</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-10-24 08:12:54 -0700</bug_when>
    <thetext>Patch coming soon.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943124</commentid>
    <comment_count>1</comment_count>
      <attachid>215065</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-10-24 08:18:03 -0700</bug_when>
    <thetext>Created attachment 215065
the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943127</commentid>
    <comment_count>2</comment_count>
      <attachid>215065</attachid>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2013-10-24 08:23:41 -0700</bug_when>
    <thetext>Comment on attachment 215065
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=215065&amp;action=review

&gt; Source/JavaScriptCore/ChangeLog:7
&gt; +

Please provide a description of what you did.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943134</commentid>
    <comment_count>3</comment_count>
      <attachid>215068</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-10-24 08:51:17 -0700</bug_when>
    <thetext>Created attachment 215068
patch 2: with comments</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943137</commentid>
    <comment_count>4</comment_count>
      <attachid>215068</attachid>
    <who name="Michael Saboff">msaboff</who>
    <bug_when>2013-10-24 08:56:34 -0700</bug_when>
    <thetext>Comment on attachment 215068
patch 2: with comments

View in context: https://bugs.webkit.org/attachment.cgi?id=215068&amp;action=review

r=me with typo fix.

&gt; Source/JavaScriptCore/ChangeLog:23
&gt; +        - The payByVal() macro reifies a slow path which is never taken in one case.

I think you mean *putByVal()*.

&gt; Source/JavaScriptCore/ChangeLog:40
&gt; +        * bytecode/CodeBlock.cpp:
&gt; +        (JSC::CodeBlock::printGetByIdCacheStatus): Added an UNUSED_PARAM().
&gt; +        (JSC::CodeBlock::dumpBytecode): Added #if ENABLE(JIT) to JIT only code.
&gt; +        * bytecode/GetByIdStatus.cpp:
&gt; +        (JSC::GetByIdStatus::computeFor): Added an UNUSED_PARAM().
&gt; +        * bytecode/PutByIdStatus.cpp:
&gt; +        (JSC::PutByIdStatus::computeFor): Added an UNUSED_PARAM().
&gt; +        * bytecode/StructureStubInfo.h:
&gt; +        - Added a stub StubInfoMap for non-JIT builds. StubInfoMap is still used
&gt; +          in function prototypes even when !ENABLE(JIT). Rather that adding #if&apos;s
&gt; +          in many places, we just provide a stub/placeholder implementation that
&gt; +          is unused but keeps the compiler happy.
&gt; +        * jit/JITOperations.h: Added #if ENABLE(JIT).
&gt; +        * llint/LowLevelInterpreter32_64.asm:
&gt; +        * llint/LowLevelInterpreter64.asm:
&gt; +        - The payByVal() macro reifies a slow path which is never taken in one case.
&gt; +          This translates into a label that is never used in the C Loop LLINT. The
&gt; +          C++ compiler doesn&apos;t like unused labels. So, we fix this by adding a
&gt; +          cloopUnusedLabel offline asm instruction that synthesizes the following:
&gt; +
&gt; +              if (false) goto unusedLabel;
&gt; +
&gt; +          This keeps the C++ compiler happy without changing code behavior.
&gt; +        * offlineasm/cloop.rb: Implementing cloopUnusedLabel.
&gt; +        * offlineasm/instructions.rb: Declaring cloopUnusedLabel.
&gt; +        * runtime/Executable.cpp:
&gt; +        (JSC::setupJIT): Added UNUSED_PARAM()s.
&gt; +        (JSC::ScriptExecutable::prepareForExecutionImpl):
&gt; +        - run-javascriptcore-tests have phases that forces the LLINT to be off
&gt; +          which in turn asserts that the JIT is enabled. With the C Loop LLINT,
&gt; +          this combination is illegal. So, we override the setup code here to
&gt; +          always use the LLINT if !ENABLE(JIT) regardless of what options are
&gt; +          passed in.

It didn&apos;t need to be this verbose.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943141</commentid>
    <comment_count>5</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-10-24 08:58:51 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; &gt; Source/JavaScriptCore/ChangeLog:23
&gt; &gt; +        - The payByVal() macro reifies a slow path which is never taken in one case.
&gt; 
&gt; I think you mean *putByVal()*.

Of course.  Will fix.
 
&gt; It didn&apos;t need to be this verbose.

No harm in being thorough, and it&apos;s only in the ChangeLog.  Glad to add details.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943149</commentid>
    <comment_count>6</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-10-24 09:10:08 -0700</bug_when>
    <thetext>Thanks for the review.  Typo fixed.  Landed in r157932: &lt;http://trac.webkit.org/r157932&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943172</commentid>
    <comment_count>7</comment_count>
      <attachid>215068</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2013-10-24 09:34:22 -0700</bug_when>
    <thetext>Comment on attachment 215068
patch 2: with comments

View in context: https://bugs.webkit.org/attachment.cgi?id=215068&amp;action=review

Your fix is a really bad hack.

I don&apos;t like the idea of constantly adding random instructions to offlineasm to appease the cloop.

&gt; Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1394
&gt; +        if C_LOOP
&gt; +            cloopUnusedLabel slowPath
&gt; +        end

This is ugly.

&gt; Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1253
&gt; +        if C_LOOP
&gt; +            cloopUnusedLabel slowPath
&gt; +        end

This is ugly.

&gt; Source/JavaScriptCore/offlineasm/cloop.rb:1115
&gt; +        when &quot;cloopUnusedLabel&quot;
&gt; +            $asm.putc &quot;if (false) goto #{operands[0].cLabel};&quot;
&gt; +

Why don&apos;t you just add such statements for all labels at the top of the generated function, so that the cloop allows any label to be unused?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943177</commentid>
    <comment_count>8</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-10-24 09:47:47 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; Why don&apos;t you just add such statements for all labels at the top of the generated function, so that the cloop allows any label to be unused?

You, sir, are correct.  That is an excellent idea and I should have thought of it.  Will fix with another patch shortly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943178</commentid>
    <comment_count>9</comment_count>
      <attachid>215075</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-10-24 09:51:54 -0700</bug_when>
    <thetext>Created attachment 215075
patch 2+: applied Filip&apos;s suggested cleanup.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943179</commentid>
    <comment_count>10</comment_count>
      <attachid>215075</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-10-24 09:52:24 -0700</bug_when>
    <thetext>Comment on attachment 215075
patch 2+: applied Filip&apos;s suggested cleanup.

Forgot the ChangeLog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943181</commentid>
    <comment_count>11</comment_count>
      <attachid>215076</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-10-24 09:55:35 -0700</bug_when>
    <thetext>Created attachment 215076
patch 2+: with ChangeLog this time.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943185</commentid>
    <comment_count>12</comment_count>
      <attachid>215076</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2013-10-24 10:01:45 -0700</bug_when>
    <thetext>Comment on attachment 215076
patch 2+: with ChangeLog this time.

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>943187</commentid>
    <comment_count>13</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2013-10-24 10:05:30 -0700</bug_when>
    <thetext>Thanks for the review.  Landed in r157937: &lt;http://trac.webkit.org/r157937&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>945840</commentid>
    <comment_count>14</comment_count>
    <who name="ChangSeok Oh">changseok</who>
    <bug_when>2013-10-31 23:13:28 -0700</bug_when>
    <thetext>*** Bug 123317 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>215065</attachid>
            <date>2013-10-24 08:18:03 -0700</date>
            <delta_ts>2013-10-24 08:51:17 -0700</delta_ts>
            <desc>the patch.</desc>
            <filename>bug-123271.patch</filename>
            <type>text/plain</type>
            <size>7465</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3OTI4KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA
CisyMDEzLTEwLTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG
aXggYnJva2VuIEMgTG9vcCBMTElOVCBidWlsZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzI3MS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5jcHA6CisgICAgICAg
IChKU0M6OkNvZGVCbG9jazo6cHJpbnRHZXRCeUlkQ2FjaGVTdGF0dXMpOgorICAgICAgICAoSlND
OjpDb2RlQmxvY2s6OmR1bXBCeXRlY29kZSk6CisgICAgICAgICogYnl0ZWNvZGUvR2V0QnlJZFN0
YXR1cy5jcHA6CisgICAgICAgIChKU0M6OkdldEJ5SWRTdGF0dXM6OmNvbXB1dGVGb3IpOgorICAg
ICAgICAqIGJ5dGVjb2RlL1B1dEJ5SWRTdGF0dXMuY3BwOgorICAgICAgICAoSlNDOjpQdXRCeUlk
U3RhdHVzOjpjb21wdXRlRm9yKToKKyAgICAgICAgKiBieXRlY29kZS9TdHJ1Y3R1cmVTdHViSW5m
by5oOgorICAgICAgICAqIGppdC9KSVRPcGVyYXRpb25zLmg6CisgICAgICAgICogbGxpbnQvTG93
TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbToKKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVy
cHJldGVyNjQuYXNtOgorICAgICAgICAqIG9mZmxpbmVhc20vY2xvb3AucmI6CisgICAgICAgICog
b2ZmbGluZWFzbS9pbnN0cnVjdGlvbnMucmI6CisgICAgICAgICogcnVudGltZS9FeGVjdXRhYmxl
LmNwcDoKKyAgICAgICAgKEpTQzo6c2V0dXBKSVQpOgorICAgICAgICAoSlNDOjpTY3JpcHRFeGVj
dXRhYmxlOjpwcmVwYXJlRm9yRXhlY3V0aW9uSW1wbCk6CisKIDIwMTMtMTAtMjQgIFJ5dWFuIENo
b2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIEJ1aWxkIGJyZWFr
IHdpdGggbGF0ZXN0IEVGTCAxLjggbGlicmFyaWVzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRD
b3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp
cHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAJKHJldmlzaW9uIDE1Nzg5OSkKKysrIFNvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBA
IC00NDQsNiArNDQ0LDggQEAgdm9pZCBDb2RlQmxvY2s6OnByaW50R2V0QnlJZENhY2hlU3RhdHVz
KAogICAgICAgICAgICAgb3V0LnByaW50ZigiKSIpOwogICAgICAgICB9CiAgICAgfQorI2Vsc2UK
KyAgICBVTlVTRURfUEFSQU0obWFwKTsKICNlbmRpZgogfQogCkBAIC01MjIsMTAgKzUyNCwxMiBA
QCB2b2lkIENvZGVCbG9jazo6ZHVtcEJ5dGVjb2RlKFByaW50U3RyZWFtCiAgICAgb3V0LnByaW50
ZigiXG4iKTsKICAgICAKICAgICBTdHViSW5mb01hcCBzdHViSW5mb3M7CisjaWYgRU5BQkxFKEpJ
VCkKICAgICB7CiAgICAgICAgIENvbmN1cnJlbnRKSVRMb2NrZXIgbG9ja2VyKG1fbG9jayk7CiAg
ICAgICAgIGdldFN0dWJJbmZvTWFwKGxvY2tlciwgc3R1YkluZm9zKTsKICAgICB9CisjZW5kaWYK
ICAgICAKICAgICBjb25zdCBJbnN0cnVjdGlvbiogYmVnaW4gPSBpbnN0cnVjdGlvbnMoKS5iZWdp
bigpOwogICAgIGNvbnN0IEluc3RydWN0aW9uKiBlbmQgPSBpbnN0cnVjdGlvbnMoKS5lbmQoKTsK
SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9HZXRCeUlkU3RhdHVzLmNwcAo9
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvR2V0QnlJZFN0YXR1
cy5jcHAJKHJldmlzaW9uIDE1Nzg5OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29k
ZS9HZXRCeUlkU3RhdHVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQ2LDYgKzI0Niw3IEBAIEdl
dEJ5SWRTdGF0dXMgR2V0QnlJZFN0YXR1czo6Y29tcHV0ZUZvcigKICAgICAKICAgICByZXR1cm4g
cmVzdWx0OwogI2Vsc2UgLy8gRU5BQkxFKEpJVCkKKyAgICBVTlVTRURfUEFSQU0obWFwKTsKICAg
ICByZXR1cm4gR2V0QnlJZFN0YXR1cyhOb0luZm9ybWF0aW9uLCBmYWxzZSk7CiAjZW5kaWYgLy8g
RU5BQkxFKEpJVCkKIH0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9QdXRC
eUlkU3RhdHVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv
ZGUvUHV0QnlJZFN0YXR1cy5jcHAJKHJldmlzaW9uIDE1Nzg5OSkKKysrIFNvdXJjZS9KYXZhU2Ny
aXB0Q29yZS9ieXRlY29kZS9QdXRCeUlkU3RhdHVzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQz
LDYgKzE0Myw3IEBAIFB1dEJ5SWRTdGF0dXMgUHV0QnlJZFN0YXR1czo6Y29tcHV0ZUZvcigKICAg
ICAgICAgcmV0dXJuIFB1dEJ5SWRTdGF0dXMoVGFrZXNTbG93UGF0aCwgMCwgMCwgMCwgaW52YWxp
ZE9mZnNldCk7CiAgICAgfQogI2Vsc2UgLy8gRU5BQkxFKEpJVCkKKyAgICBVTlVTRURfUEFSQU0o
bWFwKTsKICAgICByZXR1cm4gUHV0QnlJZFN0YXR1cyhOb0luZm9ybWF0aW9uLCAwLCAwLCAwLCBp
bnZhbGlkT2Zmc2V0KTsKICNlbmRpZiAvLyBFTkFCTEUoSklUKQogfQpJbmRleDogU291cmNlL0ph
dmFTY3JpcHRDb3JlL2J5dGVjb2RlL1N0cnVjdHVyZVN0dWJJbmZvLmgKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
U291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1N0cnVjdHVyZVN0dWJJbmZvLmgJKHJldmlz
aW9uIDE1Nzg5OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TdHJ1Y3R1cmVT
dHViSW5mby5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw4ICsyOCw2IEBACiAKICNpbmNsdWRlIDx3
dGYvUGxhdGZvcm0uaD4KIAotI2lmIEVOQUJMRShKSVQpCi0KICNpbmNsdWRlICJDb2RlT3JpZ2lu
LmgiCiAjaW5jbHVkZSAiSW5zdHJ1Y3Rpb24uaCIKICNpbmNsdWRlICJKSVRTdHViUm91dGluZS5o
IgpAQCAtNDMsNiArNDEsOCBAQAogCiBuYW1lc3BhY2UgSlNDIHsKIAorI2lmIEVOQUJMRShKSVQp
CisKIGNsYXNzIFBvbHltb3JwaGljUHV0QnlJZExpc3Q7CiAKIGVudW0gQWNjZXNzVHlwZSB7CkBA
IC0zMDEsOCArMzAxLDEyIEBAIGlubGluZSBDb2RlT3JpZ2luIGdldFN0cnVjdHVyZVN0dWJJbmZv
Q28KIAogdHlwZWRlZiBIYXNoTWFwPENvZGVPcmlnaW4sIFN0cnVjdHVyZVN0dWJJbmZvKj4gU3R1
YkluZm9NYXA7CiAKLX0gLy8gbmFtZXNwYWNlIEpTQworI2Vsc2UKKwordHlwZWRlZiBIYXNoTWFw
PGludCwgdm9pZCo+IFN0dWJJbmZvTWFwOwogCiAjZW5kaWYgLy8gRU5BQkxFKEpJVCkKIAorfSAv
LyBuYW1lc3BhY2UgSlNDCisKICNlbmRpZiAvLyBTdHJ1Y3R1cmVTdHViSW5mb19oCkluZGV4OiBT
b3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuaAo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT
b3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJhdGlvbnMuaAkocmV2aXNpb24gMTU3ODk5
KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmgJKHdvcmtpbmcg
Y29weSkKQEAgLTI2LDYgKzI2LDggQEAKICNpZm5kZWYgSklUT3BlcmF0aW9uc19oCiAjZGVmaW5l
IEpJVE9wZXJhdGlvbnNfaAogCisjaWYgRU5BQkxFKEpJVCkKKwogI2luY2x1ZGUgIkNhbGxGcmFt
ZS5oIgogI2luY2x1ZGUgIkpJVEV4Y2VwdGlvbnMuaCIKICNpbmNsdWRlICJKU0FycmF5LmgiCkBA
IC0yNzUsNSArMjc3LDcgQEAgdm9pZCBKSVRfT1BFUkFUSU9OIG9wZXJhdGlvblB1dFRvU2NvcGUo
RQogCiB9IC8vIG5hbWVzcGFjZSBKU0MKIAorI2VuZGlmIC8vIEVOQUJMRShKSVQpCisKICNlbmRp
ZiAvLyBKSVRPcGVyYXRpb25zX2gKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50
L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT
Y3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20JKHJldmlzaW9uIDE1
Nzg5OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVy
MzJfNjQuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC0xMzg5LDYgKzEzODksOSBAQCBfbGxpbnRfb3Bf
cHV0X2J5X3ZhbDoKIAogX2xsaW50X29wX3B1dF9ieV92YWxfZGlyZWN0OgogICAgIHB1dEJ5VmFs
KG1hY3JvKGFkZHIsIHNsb3dQYXRoKQorICAgICAgICBpZiBDX0xPT1AKKyAgICAgICAgICAgIGNs
b29wVW51c2VkTGFiZWwgc2xvd1BhdGgKKyAgICAgICAgZW5kCiAgICAgZW5kLCBfbGxpbnRfc2xv
d19wYXRoX3B1dF9ieV92YWxfZGlyZWN0KQogCiBfbGxpbnRfb3Bfam1wOgpJbmRleDogU291cmNl
L0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc20KPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5h
c20JKHJldmlzaW9uIDE1Nzg5OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dM
ZXZlbEludGVycHJldGVyNjQuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC0xMjQ4LDYgKzEyNDgsOSBA
QCBfbGxpbnRfb3BfcHV0X2J5X3ZhbDoKIAogX2xsaW50X29wX3B1dF9ieV92YWxfZGlyZWN0Ogog
ICAgIHB1dEJ5VmFsKG1hY3JvKHNsb3QsIHNsb3dQYXRoKQorICAgICAgICBpZiBDX0xPT1AKKyAg
ICAgICAgICAgIGNsb29wVW51c2VkTGFiZWwgc2xvd1BhdGgKKyAgICAgICAgZW5kCiAgICAgZW5k
LCBfbGxpbnRfc2xvd19wYXRoX3B1dF9ieV92YWxfZGlyZWN0KQogCiAKSW5kZXg6IFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2Nsb29wLnJiCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2Nsb29wLnJiCShyZXZpc2lvbiAxNTc4OTkpCisrKyBT
b3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9jbG9vcC5yYgkod29ya2luZyBjb3B5KQpA
QCAtMTExMCw2ICsxMTEwLDkgQEAgY2xhc3MgSW5zdHJ1Y3Rpb24KICAgICAgICAgd2hlbiAiY2xv
b3BDYWxsU2xvd1BhdGgiCiAgICAgICAgICAgICBjbG9vcEVtaXRDYWxsU2xvd1BhdGgob3BlcmFu
ZHMpCiAKKyAgICAgICAgd2hlbiAiY2xvb3BVbnVzZWRMYWJlbCIKKyAgICAgICAgICAgICRhc20u
cHV0YyAiaWYgKGZhbHNlKSBnb3RvICN7b3BlcmFuZHNbMF0uY0xhYmVsfTsiCisKICAgICAgICAg
IyBGb3IgZGVidWdnaW5nIG9ubHkuIFRoaXMgaXMgdXNlZCB0byBpbnNlcnQgaW5zdHJ1bWVudGF0
aW9uIGludG8gdGhlCiAgICAgICAgICMgZ2VuZXJhdGVkIExMSW50QXNzZW1ibHkuaCBkdXJpbmcg
bGxpbnQgZGV2ZWxvcG1lbnQgb25seS4gRG8gbm90IHVzZQogICAgICAgICAjIGZvciBwcm9kdWN0
aW9uIGNvZGUuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9pbnN0cnVj
dGlvbnMucmIKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20v
aW5zdHJ1Y3Rpb25zLnJiCShyZXZpc2lvbiAxNTc4OTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvb2ZmbGluZWFzbS9pbnN0cnVjdGlvbnMucmIJKHdvcmtpbmcgY29weSkKQEAgLTI5NSw2ICsy
OTUsNyBAQCBDWFhfSU5TVFJVQ1RJT05TID0KICAgICAgImNsb29wQ2FsbEpTRnVuY3Rpb24iLCAg
IyBvcGVyYW5kczogY2FsbGVlCiAgICAgICJjbG9vcENhbGxOYXRpdmUiLCAgICAgICMgb3BlcmFu
ZHM6IGNhbGxlZQogICAgICAiY2xvb3BDYWxsU2xvd1BhdGgiLCAgICAjIG9wZXJhbmRzOiBjYWxs
VGFyZ2V0LCBjdXJyZW50RnJhbWUsIGN1cnJlbnRQQworICAgICAiY2xvb3BVbnVzZWRMYWJlbCIs
ICAgICAjIG9wZXJhbmRzOiBsYWJlbAogCiAgICAgICMgRm9yIGRlYnVnZ2luZyBvbmx5OgogICAg
ICAjIFRha2VzIG5vIG9wZXJhbmRzIGJ1dCBzaW1wbHkgZW1pdHMgd2hhdGV2ZXIgZm9sbG93cyBp
biAvLyBjb21tZW50cyBhcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhl
Y3V0YWJsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv
RXhlY3V0YWJsZS5jcHAJKHJldmlzaW9uIDE1Nzg5OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9ydW50aW1lL0V4ZWN1dGFibGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNzcsNiArMjc3LDgg
QEAgc3RhdGljIHZvaWQgc2V0dXBKSVQoVk0mIHZtLCBDb2RlQmxvY2sqIAogICAgIENvbXBpbGF0
aW9uUmVzdWx0IHJlc3VsdCA9IEpJVDo6Y29tcGlsZSgmdm0sIGNvZGVCbG9jaywgSklUQ29tcGls
YXRpb25NdXN0U3VjY2VlZCk7CiAgICAgUkVMRUFTRV9BU1NFUlQocmVzdWx0ID09IENvbXBpbGF0
aW9uU3VjY2Vzc2Z1bCk7CiAjZWxzZQorICAgIFVOVVNFRF9QQVJBTSh2bSk7CisgICAgVU5VU0VE
X1BBUkFNKGNvZGVCbG9jayk7CiAgICAgVU5SRUFDSEFCTEVfRk9SX1BMQVRGT1JNKCk7CiAjZW5k
aWYKIH0KQEAgLTMwMCw3ICszMDIsMTAgQEAgSlNPYmplY3QqIFNjcmlwdEV4ZWN1dGFibGU6OnBy
ZXBhcmVGb3JFeAogI2Vsc2UKICAgICBzaG91bGRVc2VMTEludCA9IGZhbHNlOwogI2VuZGlmCi0g
ICAgCisjaWYgIUVOQUJMRShKSVQpCisgICAgc2hvdWxkVXNlTExJbnQgPSB0cnVlOyAvLyBPdmVy
cmlkaW5nIGZvciBDIExvb3AgTExJTlQuCisjZW5kaWYKKwogICAgIGlmIChzaG91bGRVc2VMTElu
dCkKICAgICAgICAgc2V0dXBMTEludCh2bSwgY29kZUJsb2NrLmdldCgpKTsKICAgICBlbHNlCg==
</data>
<flag name="review"
          id="237705"
          type_id="1"
          status="-"
          setter="msaboff"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>215068</attachid>
            <date>2013-10-24 08:51:17 -0700</date>
            <delta_ts>2013-10-24 09:34:22 -0700</delta_ts>
            <desc>patch 2: with comments</desc>
            <filename>bug-123271.patch</filename>
            <type>text/plain</type>
            <size>8892</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3OTI4KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQ0IEBA
CisyMDEzLTEwLTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG
aXggYnJva2VuIEMgTG9vcCBMTElOVCBidWlsZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzI3MS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5jcHA6CisgICAgICAg
IChKU0M6OkNvZGVCbG9jazo6cHJpbnRHZXRCeUlkQ2FjaGVTdGF0dXMpOiBBZGRlZCBhbiBVTlVT
RURfUEFSQU0oKS4KKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjpkdW1wQnl0ZWNvZGUpOiBBZGRl
ZCAjaWYgRU5BQkxFKEpJVCkgdG8gSklUIG9ubHkgY29kZS4KKyAgICAgICAgKiBieXRlY29kZS9H
ZXRCeUlkU3RhdHVzLmNwcDoKKyAgICAgICAgKEpTQzo6R2V0QnlJZFN0YXR1czo6Y29tcHV0ZUZv
cik6IEFkZGVkIGFuIFVOVVNFRF9QQVJBTSgpLgorICAgICAgICAqIGJ5dGVjb2RlL1B1dEJ5SWRT
dGF0dXMuY3BwOgorICAgICAgICAoSlNDOjpQdXRCeUlkU3RhdHVzOjpjb21wdXRlRm9yKTogQWRk
ZWQgYW4gVU5VU0VEX1BBUkFNKCkuCisgICAgICAgICogYnl0ZWNvZGUvU3RydWN0dXJlU3R1Yklu
Zm8uaDoKKyAgICAgICAgLSBBZGRlZCBhIHN0dWIgU3R1YkluZm9NYXAgZm9yIG5vbi1KSVQgYnVp
bGRzLiBTdHViSW5mb01hcCBpcyBzdGlsbCB1c2VkCisgICAgICAgICAgaW4gZnVuY3Rpb24gcHJv
dG90eXBlcyBldmVuIHdoZW4gIUVOQUJMRShKSVQpLiBSYXRoZXIgdGhhdCBhZGRpbmcgI2lmJ3MK
KyAgICAgICAgICBpbiBtYW55IHBsYWNlcywgd2UganVzdCBwcm92aWRlIGEgc3R1Yi9wbGFjZWhv
bGRlciBpbXBsZW1lbnRhdGlvbiB0aGF0CisgICAgICAgICAgaXMgdW51c2VkIGJ1dCBrZWVwcyB0
aGUgY29tcGlsZXIgaGFwcHkuCisgICAgICAgICogaml0L0pJVE9wZXJhdGlvbnMuaDogQWRkZWQg
I2lmIEVOQUJMRShKSVQpLgorICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82
NC5hc206CisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbToKKyAgICAg
ICAgLSBUaGUgcGF5QnlWYWwoKSBtYWNybyByZWlmaWVzIGEgc2xvdyBwYXRoIHdoaWNoIGlzIG5l
dmVyIHRha2VuIGluIG9uZSBjYXNlLgorICAgICAgICAgIFRoaXMgdHJhbnNsYXRlcyBpbnRvIGEg
bGFiZWwgdGhhdCBpcyBuZXZlciB1c2VkIGluIHRoZSBDIExvb3AgTExJTlQuIFRoZQorICAgICAg
ICAgIEMrKyBjb21waWxlciBkb2Vzbid0IGxpa2UgdW51c2VkIGxhYmVscy4gU28sIHdlIGZpeCB0
aGlzIGJ5IGFkZGluZyBhCisgICAgICAgICAgY2xvb3BVbnVzZWRMYWJlbCBvZmZsaW5lIGFzbSBp
bnN0cnVjdGlvbiB0aGF0IHN5bnRoZXNpemVzIHRoZSBmb2xsb3dpbmc6CisKKyAgICAgICAgICAg
ICAgaWYgKGZhbHNlKSBnb3RvIHVudXNlZExhYmVsOworCisgICAgICAgICAgVGhpcyBrZWVwcyB0
aGUgQysrIGNvbXBpbGVyIGhhcHB5IHdpdGhvdXQgY2hhbmdpbmcgY29kZSBiZWhhdmlvci4KKyAg
ICAgICAgKiBvZmZsaW5lYXNtL2Nsb29wLnJiOiBJbXBsZW1lbnRpbmcgY2xvb3BVbnVzZWRMYWJl
bC4KKyAgICAgICAgKiBvZmZsaW5lYXNtL2luc3RydWN0aW9ucy5yYjogRGVjbGFyaW5nIGNsb29w
VW51c2VkTGFiZWwuCisgICAgICAgICogcnVudGltZS9FeGVjdXRhYmxlLmNwcDoKKyAgICAgICAg
KEpTQzo6c2V0dXBKSVQpOiBBZGRlZCBVTlVTRURfUEFSQU0oKXMuCisgICAgICAgIChKU0M6OlNj
cmlwdEV4ZWN1dGFibGU6OnByZXBhcmVGb3JFeGVjdXRpb25JbXBsKToKKyAgICAgICAgLSBydW4t
amF2YXNjcmlwdGNvcmUtdGVzdHMgaGF2ZSBwaGFzZXMgdGhhdCBmb3JjZXMgdGhlIExMSU5UIHRv
IGJlIG9mZgorICAgICAgICAgIHdoaWNoIGluIHR1cm4gYXNzZXJ0cyB0aGF0IHRoZSBKSVQgaXMg
ZW5hYmxlZC4gV2l0aCB0aGUgQyBMb29wIExMSU5ULAorICAgICAgICAgIHRoaXMgY29tYmluYXRp
b24gaXMgaWxsZWdhbC4gU28sIHdlIG92ZXJyaWRlIHRoZSBzZXR1cCBjb2RlIGhlcmUgdG8KKyAg
ICAgICAgICBhbHdheXMgdXNlIHRoZSBMTElOVCBpZiAhRU5BQkxFKEpJVCkgcmVnYXJkbGVzcyBv
ZiB3aGF0IG9wdGlvbnMgYXJlCisgICAgICAgICAgcGFzc2VkIGluLgorCiAyMDEzLTEwLTI0ICBS
eXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBCdWls
ZCBicmVhayB3aXRoIGxhdGVzdCBFRkwgMS44IGxpYnJhcmllcy4KSW5kZXg6IFNvdXJjZS9KYXZh
U2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwCShyZXZpc2lvbiAxNTc4OTkpCisr
KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAkod29ya2luZyBj
b3B5KQpAQCAtNDQ0LDYgKzQ0NCw4IEBAIHZvaWQgQ29kZUJsb2NrOjpwcmludEdldEJ5SWRDYWNo
ZVN0YXR1cygKICAgICAgICAgICAgIG91dC5wcmludGYoIikiKTsKICAgICAgICAgfQogICAgIH0K
KyNlbHNlCisgICAgVU5VU0VEX1BBUkFNKG1hcCk7CiAjZW5kaWYKIH0KIApAQCAtNTIyLDEwICs1
MjQsMTIgQEAgdm9pZCBDb2RlQmxvY2s6OmR1bXBCeXRlY29kZShQcmludFN0cmVhbQogICAgIG91
dC5wcmludGYoIlxuIik7CiAgICAgCiAgICAgU3R1YkluZm9NYXAgc3R1YkluZm9zOworI2lmIEVO
QUJMRShKSVQpCiAgICAgewogICAgICAgICBDb25jdXJyZW50SklUTG9ja2VyIGxvY2tlcihtX2xv
Y2spOwogICAgICAgICBnZXRTdHViSW5mb01hcChsb2NrZXIsIHN0dWJJbmZvcyk7CiAgICAgfQor
I2VuZGlmCiAgICAgCiAgICAgY29uc3QgSW5zdHJ1Y3Rpb24qIGJlZ2luID0gaW5zdHJ1Y3Rpb25z
KCkuYmVnaW4oKTsKICAgICBjb25zdCBJbnN0cnVjdGlvbiogZW5kID0gaW5zdHJ1Y3Rpb25zKCku
ZW5kKCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvR2V0QnlJZFN0YXR1
cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0dldEJ5
SWRTdGF0dXMuY3BwCShyZXZpc2lvbiAxNTc4OTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv
Ynl0ZWNvZGUvR2V0QnlJZFN0YXR1cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI0Niw2ICsyNDYs
NyBAQCBHZXRCeUlkU3RhdHVzIEdldEJ5SWRTdGF0dXM6OmNvbXB1dGVGb3IoCiAgICAgCiAgICAg
cmV0dXJuIHJlc3VsdDsKICNlbHNlIC8vIEVOQUJMRShKSVQpCisgICAgVU5VU0VEX1BBUkFNKG1h
cCk7CiAgICAgcmV0dXJuIEdldEJ5SWRTdGF0dXMoTm9JbmZvcm1hdGlvbiwgZmFsc2UpOwogI2Vu
ZGlmIC8vIEVOQUJMRShKSVQpCiB9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv
ZGUvUHV0QnlJZFN0YXR1cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl
L2J5dGVjb2RlL1B1dEJ5SWRTdGF0dXMuY3BwCShyZXZpc2lvbiAxNTc4OTkpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvUHV0QnlJZFN0YXR1cy5jcHAJKHdvcmtpbmcgY29weSkK
QEAgLTE0Myw2ICsxNDMsNyBAQCBQdXRCeUlkU3RhdHVzIFB1dEJ5SWRTdGF0dXM6OmNvbXB1dGVG
b3IoCiAgICAgICAgIHJldHVybiBQdXRCeUlkU3RhdHVzKFRha2VzU2xvd1BhdGgsIDAsIDAsIDAs
IGludmFsaWRPZmZzZXQpOwogICAgIH0KICNlbHNlIC8vIEVOQUJMRShKSVQpCisgICAgVU5VU0VE
X1BBUkFNKG1hcCk7CiAgICAgcmV0dXJuIFB1dEJ5SWRTdGF0dXMoTm9JbmZvcm1hdGlvbiwgMCwg
MCwgMCwgaW52YWxpZE9mZnNldCk7CiAjZW5kaWYgLy8gRU5BQkxFKEpJVCkKIH0KSW5kZXg6IFNv
dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TdHJ1Y3R1cmVTdHViSW5mby5oCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TdHJ1Y3R1cmVTdHViSW5mby5o
CShyZXZpc2lvbiAxNTc4OTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvU3Ry
dWN0dXJlU3R1YkluZm8uaAkod29ya2luZyBjb3B5KQpAQCAtMjgsOCArMjgsNiBAQAogCiAjaW5j
bHVkZSA8d3RmL1BsYXRmb3JtLmg+CiAKLSNpZiBFTkFCTEUoSklUKQotCiAjaW5jbHVkZSAiQ29k
ZU9yaWdpbi5oIgogI2luY2x1ZGUgIkluc3RydWN0aW9uLmgiCiAjaW5jbHVkZSAiSklUU3R1YlJv
dXRpbmUuaCIKQEAgLTQzLDYgKzQxLDggQEAKIAogbmFtZXNwYWNlIEpTQyB7CiAKKyNpZiBFTkFC
TEUoSklUKQorCiBjbGFzcyBQb2x5bW9ycGhpY1B1dEJ5SWRMaXN0OwogCiBlbnVtIEFjY2Vzc1R5
cGUgewpAQCAtMzAxLDggKzMwMSwxMiBAQCBpbmxpbmUgQ29kZU9yaWdpbiBnZXRTdHJ1Y3R1cmVT
dHViSW5mb0NvCiAKIHR5cGVkZWYgSGFzaE1hcDxDb2RlT3JpZ2luLCBTdHJ1Y3R1cmVTdHViSW5m
byo+IFN0dWJJbmZvTWFwOwogCi19IC8vIG5hbWVzcGFjZSBKU0MKKyNlbHNlCisKK3R5cGVkZWYg
SGFzaE1hcDxpbnQsIHZvaWQqPiBTdHViSW5mb01hcDsKIAogI2VuZGlmIC8vIEVOQUJMRShKSVQp
CiAKK30gLy8gbmFtZXNwYWNlIEpTQworCiAjZW5kaWYgLy8gU3RydWN0dXJlU3R1YkluZm9faApJ
bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmgKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmgJKHJldmlzaW9u
IDE1Nzg5OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5oCSh3
b3JraW5nIGNvcHkpCkBAIC0yNiw2ICsyNiw4IEBACiAjaWZuZGVmIEpJVE9wZXJhdGlvbnNfaAog
I2RlZmluZSBKSVRPcGVyYXRpb25zX2gKIAorI2lmIEVOQUJMRShKSVQpCisKICNpbmNsdWRlICJD
YWxsRnJhbWUuaCIKICNpbmNsdWRlICJKSVRFeGNlcHRpb25zLmgiCiAjaW5jbHVkZSAiSlNBcnJh
eS5oIgpAQCAtMjc1LDUgKzI3Nyw3IEBAIHZvaWQgSklUX09QRVJBVElPTiBvcGVyYXRpb25QdXRU
b1Njb3BlKEUKIAogfSAvLyBuYW1lc3BhY2UgSlNDCiAKKyNlbmRpZiAvLyBFTkFCTEUoSklUKQor
CiAjZW5kaWYgLy8gSklUT3BlcmF0aW9uc19oCiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtCShyZXZp
c2lvbiAxNTc4OTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRl
cnByZXRlcjMyXzY0LmFzbQkod29ya2luZyBjb3B5KQpAQCAtMTM4OSw2ICsxMzg5LDkgQEAgX2xs
aW50X29wX3B1dF9ieV92YWw6CiAKIF9sbGludF9vcF9wdXRfYnlfdmFsX2RpcmVjdDoKICAgICBw
dXRCeVZhbChtYWNybyhhZGRyLCBzbG93UGF0aCkKKyAgICAgICAgaWYgQ19MT09QCisgICAgICAg
ICAgICBjbG9vcFVudXNlZExhYmVsIHNsb3dQYXRoCisgICAgICAgIGVuZAogICAgIGVuZCwgX2xs
aW50X3Nsb3dfcGF0aF9wdXRfYnlfdmFsX2RpcmVjdCkKIAogX2xsaW50X29wX2ptcDoKSW5kZXg6
IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJl
dGVyNjQuYXNtCShyZXZpc2lvbiAxNTc4OTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxp
bnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbQkod29ya2luZyBjb3B5KQpAQCAtMTI0OCw2ICsx
MjQ4LDkgQEAgX2xsaW50X29wX3B1dF9ieV92YWw6CiAKIF9sbGludF9vcF9wdXRfYnlfdmFsX2Rp
cmVjdDoKICAgICBwdXRCeVZhbChtYWNybyhzbG90LCBzbG93UGF0aCkKKyAgICAgICAgaWYgQ19M
T09QCisgICAgICAgICAgICBjbG9vcFVudXNlZExhYmVsIHNsb3dQYXRoCisgICAgICAgIGVuZAog
ICAgIGVuZCwgX2xsaW50X3Nsb3dfcGF0aF9wdXRfYnlfdmFsX2RpcmVjdCkKIAogCkluZGV4OiBT
b3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9jbG9vcC5yYgo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT
b3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9jbG9vcC5yYgkocmV2aXNpb24gMTU3ODk5
KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vY2xvb3AucmIJKHdvcmtpbmcg
Y29weSkKQEAgLTExMTAsNiArMTExMCw5IEBAIGNsYXNzIEluc3RydWN0aW9uCiAgICAgICAgIHdo
ZW4gImNsb29wQ2FsbFNsb3dQYXRoIgogICAgICAgICAgICAgY2xvb3BFbWl0Q2FsbFNsb3dQYXRo
KG9wZXJhbmRzKQogCisgICAgICAgIHdoZW4gImNsb29wVW51c2VkTGFiZWwiCisgICAgICAgICAg
ICAkYXNtLnB1dGMgImlmIChmYWxzZSkgZ290byAje29wZXJhbmRzWzBdLmNMYWJlbH07IgorCiAg
ICAgICAgICMgRm9yIGRlYnVnZ2luZyBvbmx5LiBUaGlzIGlzIHVzZWQgdG8gaW5zZXJ0IGluc3Ry
dW1lbnRhdGlvbiBpbnRvIHRoZQogICAgICAgICAjIGdlbmVyYXRlZCBMTEludEFzc2VtYmx5Lmgg
ZHVyaW5nIGxsaW50IGRldmVsb3BtZW50IG9ubHkuIERvIG5vdCB1c2UKICAgICAgICAgIyBmb3Ig
cHJvZHVjdGlvbiBjb2RlLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20v
aW5zdHJ1Y3Rpb25zLnJiCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZs
aW5lYXNtL2luc3RydWN0aW9ucy5yYgkocmV2aXNpb24gMTU3ODk5KQorKysgU291cmNlL0phdmFT
Y3JpcHRDb3JlL29mZmxpbmVhc20vaW5zdHJ1Y3Rpb25zLnJiCSh3b3JraW5nIGNvcHkpCkBAIC0y
OTUsNiArMjk1LDcgQEAgQ1hYX0lOU1RSVUNUSU9OUyA9CiAgICAgICJjbG9vcENhbGxKU0Z1bmN0
aW9uIiwgICMgb3BlcmFuZHM6IGNhbGxlZQogICAgICAiY2xvb3BDYWxsTmF0aXZlIiwgICAgICAj
IG9wZXJhbmRzOiBjYWxsZWUKICAgICAgImNsb29wQ2FsbFNsb3dQYXRoIiwgICAgIyBvcGVyYW5k
czogY2FsbFRhcmdldCwgY3VycmVudEZyYW1lLCBjdXJyZW50UEMKKyAgICAgImNsb29wVW51c2Vk
TGFiZWwiLCAgICAgIyBvcGVyYW5kczogbGFiZWwKIAogICAgICAjIEZvciBkZWJ1Z2dpbmcgb25s
eToKICAgICAgIyBUYWtlcyBubyBvcGVyYW5kcyBidXQgc2ltcGx5IGVtaXRzIHdoYXRldmVyIGZv
bGxvd3MgaW4gLy8gY29tbWVudHMgYXMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50
aW1lL0V4ZWN1dGFibGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y
dW50aW1lL0V4ZWN1dGFibGUuY3BwCShyZXZpc2lvbiAxNTc4OTkpCisrKyBTb3VyY2UvSmF2YVNj
cmlwdENvcmUvcnVudGltZS9FeGVjdXRhYmxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjc3LDYg
KzI3Nyw4IEBAIHN0YXRpYyB2b2lkIHNldHVwSklUKFZNJiB2bSwgQ29kZUJsb2NrKiAKICAgICBD
b21waWxhdGlvblJlc3VsdCByZXN1bHQgPSBKSVQ6OmNvbXBpbGUoJnZtLCBjb2RlQmxvY2ssIEpJ
VENvbXBpbGF0aW9uTXVzdFN1Y2NlZWQpOwogICAgIFJFTEVBU0VfQVNTRVJUKHJlc3VsdCA9PSBD
b21waWxhdGlvblN1Y2Nlc3NmdWwpOwogI2Vsc2UKKyAgICBVTlVTRURfUEFSQU0odm0pOworICAg
IFVOVVNFRF9QQVJBTShjb2RlQmxvY2spOwogICAgIFVOUkVBQ0hBQkxFX0ZPUl9QTEFURk9STSgp
OwogI2VuZGlmCiB9CkBAIC0yOTUsNyArMjk3LDExIEBAIEpTT2JqZWN0KiBTY3JpcHRFeGVjdXRh
YmxlOjpwcmVwYXJlRm9yRXgKICAgICB9CiAgICAgCiAgICAgYm9vbCBzaG91bGRVc2VMTEludDsK
LSNpZiBFTkFCTEUoTExJTlQpCisjaWYgIUVOQUJMRShKSVQpCisgICAgLy8gTm8gSklUIGltcGxp
ZXMgdXNlIG9mIHRoZSBDIExvb3AgTExJTlQuIE92ZXJyaWRlIHRoZSBvcHRpb25zIHRvIHJlZmxl
Y3QgdGhpcy4gCisgICAgT3B0aW9uczo6dXNlTExJbnQoKSA9IHRydWU7CisgICAgc2hvdWxkVXNl
TExJbnQgPSB0cnVlOworI2VsaWYgRU5BQkxFKExMSU5UKQogICAgIHNob3VsZFVzZUxMSW50ID0g
T3B0aW9uczo6dXNlTExJbnQoKTsKICNlbHNlCiAgICAgc2hvdWxkVXNlTExJbnQgPSBmYWxzZTsK
</data>
<flag name="review"
          id="237709"
          type_id="1"
          status="+"
          setter="msaboff"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>215075</attachid>
            <date>2013-10-24 09:51:54 -0700</date>
            <delta_ts>2013-10-24 09:55:35 -0700</delta_ts>
            <desc>patch 2+: applied Filip&apos;s suggested cleanup.</desc>
            <filename>bug-123271b.patch</filename>
            <type>text/plain</type>
            <size>2959</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJf
NjQuYXNtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZl
bEludGVycHJldGVyMzJfNjQuYXNtCShyZXZpc2lvbiAxNTc5MzIpCisrKyBTb3VyY2UvSmF2YVNj
cmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQkod29ya2luZyBjb3B5
KQpAQCAtMTM4OSw5ICsxMzg5LDYgQEAgX2xsaW50X29wX3B1dF9ieV92YWw6CiAKIF9sbGludF9v
cF9wdXRfYnlfdmFsX2RpcmVjdDoKICAgICBwdXRCeVZhbChtYWNybyhhZGRyLCBzbG93UGF0aCkK
LSAgICAgICAgaWYgQ19MT09QCi0gICAgICAgICAgICBjbG9vcFVudXNlZExhYmVsIHNsb3dQYXRo
Ci0gICAgICAgIGVuZAogICAgIGVuZCwgX2xsaW50X3Nsb3dfcGF0aF9wdXRfYnlfdmFsX2RpcmVj
dCkKIAogX2xsaW50X29wX2ptcDoKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9M
b3dMZXZlbEludGVycHJldGVyNjQuYXNtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0
Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtCShyZXZpc2lvbiAxNTc5MzIpCisr
KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbQko
d29ya2luZyBjb3B5KQpAQCAtMTI0OCw5ICsxMjQ4LDYgQEAgX2xsaW50X29wX3B1dF9ieV92YWw6
CiAKIF9sbGludF9vcF9wdXRfYnlfdmFsX2RpcmVjdDoKICAgICBwdXRCeVZhbChtYWNybyhzbG90
LCBzbG93UGF0aCkKLSAgICAgICAgaWYgQ19MT09QCi0gICAgICAgICAgICBjbG9vcFVudXNlZExh
YmVsIHNsb3dQYXRoCi0gICAgICAgIGVuZAogICAgIGVuZCwgX2xsaW50X3Nsb3dfcGF0aF9wdXRf
YnlfdmFsX2RpcmVjdCkKIAogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93
TGV2ZWxJbnRlcnByZXRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl
L2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuY3BwCShyZXZpc2lvbiAxNTc5MzIpCisrKyBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5jcHAJKHdvcmtpbmcg
Y29weSkKQEAgLTk4LDcgKzk4LDEwIEBAIHVzaW5nIG5hbWVzcGFjZSBKU0M6OkxMSW50OwogICAg
ICNkZWZpbmUgT0ZGTElORV9BU01fR0xVRV9MQUJFTChsYWJlbCkgIGNhc2UgbGFiZWw6IGxhYmVs
OgogI2VuZGlmCiAKLSNkZWZpbmUgT0ZGTElORV9BU01fTE9DQUxfTEFCRUwobGFiZWwpICAgbGFi
ZWw6CisjZGVmaW5lIE9GRkxJTkVfQVNNX0xPQ0FMX0xBQkVMKGxhYmVsKSBcCisgICAgbGFiZWw6
IFwKKyAgICAgICAgaWYgKGZhbHNlKSBcCisgICAgICAgICAgICBnb3RvIGxhYmVsOwogCiAKIC8v
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVh
c20vY2xvb3AucmIKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVh
c20vY2xvb3AucmIJKHJldmlzaW9uIDE1NzkzMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9v
ZmZsaW5lYXNtL2Nsb29wLnJiCSh3b3JraW5nIGNvcHkpCkBAIC0xMTEwLDkgKzExMTAsNiBAQCBj
bGFzcyBJbnN0cnVjdGlvbgogICAgICAgICB3aGVuICJjbG9vcENhbGxTbG93UGF0aCIKICAgICAg
ICAgICAgIGNsb29wRW1pdENhbGxTbG93UGF0aChvcGVyYW5kcykKIAotICAgICAgICB3aGVuICJj
bG9vcFVudXNlZExhYmVsIgotICAgICAgICAgICAgJGFzbS5wdXRjICJpZiAoZmFsc2UpIGdvdG8g
I3tvcGVyYW5kc1swXS5jTGFiZWx9OyIKLQogICAgICAgICAjIEZvciBkZWJ1Z2dpbmcgb25seS4g
VGhpcyBpcyB1c2VkIHRvIGluc2VydCBpbnN0cnVtZW50YXRpb24gaW50byB0aGUKICAgICAgICAg
IyBnZW5lcmF0ZWQgTExJbnRBc3NlbWJseS5oIGR1cmluZyBsbGludCBkZXZlbG9wbWVudCBvbmx5
LiBEbyBub3QgdXNlCiAgICAgICAgICMgZm9yIHByb2R1Y3Rpb24gY29kZS4KSW5kZXg6IFNvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2luc3RydWN0aW9ucy5yYgo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t
LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9pbnN0cnVjdGlvbnMucmIJKHJldmlz
aW9uIDE1NzkzMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2luc3RydWN0
aW9ucy5yYgkod29ya2luZyBjb3B5KQpAQCAtMjk1LDcgKzI5NSw2IEBAIENYWF9JTlNUUlVDVElP
TlMgPQogICAgICAiY2xvb3BDYWxsSlNGdW5jdGlvbiIsICAjIG9wZXJhbmRzOiBjYWxsZWUKICAg
ICAgImNsb29wQ2FsbE5hdGl2ZSIsICAgICAgIyBvcGVyYW5kczogY2FsbGVlCiAgICAgICJjbG9v
cENhbGxTbG93UGF0aCIsICAgICMgb3BlcmFuZHM6IGNhbGxUYXJnZXQsIGN1cnJlbnRGcmFtZSwg
Y3VycmVudFBDCi0gICAgICJjbG9vcFVudXNlZExhYmVsIiwgICAgICMgb3BlcmFuZHM6IGxhYmVs
CiAKICAgICAgIyBGb3IgZGVidWdnaW5nIG9ubHk6CiAgICAgICMgVGFrZXMgbm8gb3BlcmFuZHMg
YnV0IHNpbXBseSBlbWl0cyB3aGF0ZXZlciBmb2xsb3dzIGluIC8vIGNvbW1lbnRzIGFzCg==
</data>
<flag name="review"
          id="237719"
          type_id="1"
          status="-"
          setter="mark.lam"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>215076</attachid>
            <date>2013-10-24 09:55:35 -0700</date>
            <delta_ts>2013-10-24 10:01:45 -0700</delta_ts>
            <desc>patch 2+: with ChangeLog this time.</desc>
            <filename>bug-123271b.patch</filename>
            <type>text/plain</type>
            <size>3726</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3OTM1KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA
CisyMDEzLTEwLTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBC
ZXR0ZXIgd2F5IHRvIGZpeCBwYXJ0IG9mIGJyb2tlbiBDIExvb3AgTExJTlQgYnVpbGQuCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjMyNzEuCisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5kb2luZyBvZmZs
aW5lIGFzbSBoYWNrZXJ5LgorCisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5j
cHA6CisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbToKKyAgICAg
ICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyNjQuYXNtOgorICAgICAgICAqIG9mZmxpbmVh
c20vY2xvb3AucmI6CisgICAgICAgICogb2ZmbGluZWFzbS9pbnN0cnVjdGlvbnMucmI6CisKIDIw
MTMtMTAtMjQgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBi
cm9rZW4gQyBMb29wIExMSU5UIGJ1aWxkLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xs
aW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph
dmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20JKHJldmlzaW9u
IDE1NzkzMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJl
dGVyMzJfNjQuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC0xMzg5LDkgKzEzODksNiBAQCBfbGxpbnRf
b3BfcHV0X2J5X3ZhbDoKIAogX2xsaW50X29wX3B1dF9ieV92YWxfZGlyZWN0OgogICAgIHB1dEJ5
VmFsKG1hY3JvKGFkZHIsIHNsb3dQYXRoKQotICAgICAgICBpZiBDX0xPT1AKLSAgICAgICAgICAg
IGNsb29wVW51c2VkTGFiZWwgc2xvd1BhdGgKLSAgICAgICAgZW5kCiAgICAgZW5kLCBfbGxpbnRf
c2xvd19wYXRoX3B1dF9ieV92YWxfZGlyZWN0KQogCiBfbGxpbnRfb3Bfam1wOgpJbmRleDogU291
cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc20KPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2
NC5hc20JKHJldmlzaW9uIDE1NzkzMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9M
b3dMZXZlbEludGVycHJldGVyNjQuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC0xMjQ4LDkgKzEyNDgs
NiBAQCBfbGxpbnRfb3BfcHV0X2J5X3ZhbDoKIAogX2xsaW50X29wX3B1dF9ieV92YWxfZGlyZWN0
OgogICAgIHB1dEJ5VmFsKG1hY3JvKHNsb3QsIHNsb3dQYXRoKQotICAgICAgICBpZiBDX0xPT1AK
LSAgICAgICAgICAgIGNsb29wVW51c2VkTGFiZWwgc2xvd1BhdGgKLSAgICAgICAgZW5kCiAgICAg
ZW5kLCBfbGxpbnRfc2xvd19wYXRoX3B1dF9ieV92YWxfZGlyZWN0KQogCiAKSW5kZXg6IFNvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmNwcAo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5jcHAJ
KHJldmlzaW9uIDE1NzkzMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZl
bEludGVycHJldGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTgsNyArOTgsMTAgQEAgdXNpbmcg
bmFtZXNwYWNlIEpTQzo6TExJbnQ7CiAgICAgI2RlZmluZSBPRkZMSU5FX0FTTV9HTFVFX0xBQkVM
KGxhYmVsKSAgY2FzZSBsYWJlbDogbGFiZWw6CiAjZW5kaWYKIAotI2RlZmluZSBPRkZMSU5FX0FT
TV9MT0NBTF9MQUJFTChsYWJlbCkgICBsYWJlbDoKKyNkZWZpbmUgT0ZGTElORV9BU01fTE9DQUxf
TEFCRUwobGFiZWwpIFwKKyAgICBsYWJlbDogXAorICAgICAgICBpZiAoZmFsc2UpIFwKKyAgICAg
ICAgICAgIGdvdG8gbGFiZWw7CiAKIAogLy89PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CkluZGV4OiBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9jbG9vcC5yYgo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9jbG9vcC5yYgkocmV2aXNpb24gMTU3OTMyKQor
KysgU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vY2xvb3AucmIJKHdvcmtpbmcgY29w
eSkKQEAgLTExMTAsOSArMTExMCw2IEBAIGNsYXNzIEluc3RydWN0aW9uCiAgICAgICAgIHdoZW4g
ImNsb29wQ2FsbFNsb3dQYXRoIgogICAgICAgICAgICAgY2xvb3BFbWl0Q2FsbFNsb3dQYXRoKG9w
ZXJhbmRzKQogCi0gICAgICAgIHdoZW4gImNsb29wVW51c2VkTGFiZWwiCi0gICAgICAgICAgICAk
YXNtLnB1dGMgImlmIChmYWxzZSkgZ290byAje29wZXJhbmRzWzBdLmNMYWJlbH07IgotCiAgICAg
ICAgICMgRm9yIGRlYnVnZ2luZyBvbmx5LiBUaGlzIGlzIHVzZWQgdG8gaW5zZXJ0IGluc3RydW1l
bnRhdGlvbiBpbnRvIHRoZQogICAgICAgICAjIGdlbmVyYXRlZCBMTEludEFzc2VtYmx5LmggZHVy
aW5nIGxsaW50IGRldmVsb3BtZW50IG9ubHkuIERvIG5vdCB1c2UKICAgICAgICAgIyBmb3IgcHJv
ZHVjdGlvbiBjb2RlLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vaW5z
dHJ1Y3Rpb25zLnJiCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5l
YXNtL2luc3RydWN0aW9ucy5yYgkocmV2aXNpb24gMTU3OTMyKQorKysgU291cmNlL0phdmFTY3Jp
cHRDb3JlL29mZmxpbmVhc20vaW5zdHJ1Y3Rpb25zLnJiCSh3b3JraW5nIGNvcHkpCkBAIC0yOTUs
NyArMjk1LDYgQEAgQ1hYX0lOU1RSVUNUSU9OUyA9CiAgICAgICJjbG9vcENhbGxKU0Z1bmN0aW9u
IiwgICMgb3BlcmFuZHM6IGNhbGxlZQogICAgICAiY2xvb3BDYWxsTmF0aXZlIiwgICAgICAjIG9w
ZXJhbmRzOiBjYWxsZWUKICAgICAgImNsb29wQ2FsbFNsb3dQYXRoIiwgICAgIyBvcGVyYW5kczog
Y2FsbFRhcmdldCwgY3VycmVudEZyYW1lLCBjdXJyZW50UEMKLSAgICAgImNsb29wVW51c2VkTGFi
ZWwiLCAgICAgIyBvcGVyYW5kczogbGFiZWwKIAogICAgICAjIEZvciBkZWJ1Z2dpbmcgb25seToK
ICAgICAgIyBUYWtlcyBubyBvcGVyYW5kcyBidXQgc2ltcGx5IGVtaXRzIHdoYXRldmVyIGZvbGxv
d3MgaW4gLy8gY29tbWVudHMgYXMK
</data>
<flag name="review"
          id="237720"
          type_id="1"
          status="+"
          setter="ggaren"
    />
          </attachment>
      

    </bug>

</bugzilla>