12326 2007-01-18 14:50:46 -0800 Changes to mouse events to make them work with windows native widgets 2007-03-12 06:29:07 -0700 1 1 1 Unclassified WebKit Platform 420+ PC OS X 10.4 RESOLVED INVALID P2 Normal --- 0 whereismichelleb2 webkit-unassigned oldest_to_newest 34387 0 whereismichelleb2 2007-01-18 14:50:46 -0800 In the windows port, we are using some instances of native widgets, and we'd like mouse events to be able to pass through the EventHandler into the appropriate widget. There is some plumbing for this already for the mouse-down event, but not for other events. There appears to be some confusion around whether this is for a traditional windows-style SetCapture() or something else. Without an equivalent NSView, I see no way to get mouse events to widgets other than to pass all 3 mouse event types (mouse-down, mouse-release, mouse-move) to the widgets. Capturing still needs to be done, albeit a separate issue from this bug. This patch just plumbs these and adds a couple of stubs for the mac version in a benign way. Also store the native mouse event information (hwnd, msg, wparam, and lparam) into the PlatformMouseEvent.h so that we don't convert back and forth obsessively. There is a chance I'm not understanding the underlying design for windows; if so, let me know. But after looking at the code, it appears that the windows version doesn't quite work yet, and this simple patch is a reasonable way to fix it. Advice welcome! 34388 1 12544 whereismichelleb2 2007-01-18 14:54:02 -0800 Created attachment 12544 Patch for passing mouse events to windows widgets. 33227 2 mjs 2007-01-22 23:17:19 -0800 I don't think this is needed, because the plan for windows is to use all engine-rendered and operated form controls, as for Mac. Which form controls need native widgets (by this I assume you mean an HWND)? It's hard to evaluate this code without knowing what is going to make use of it. 33229 3 12544 mjs 2007-01-22 23:49:37 -0800 Comment on attachment 12544 Patch for passing mouse events to windows widgets. I checked with someone who knows more about the windows form controls and this patch definitely seems wrong. r-. But maybe there's some reason for this that I am not getting. 32653 4 whereismichelleb2 2007-01-25 15:12:05 -0800 OK - The reason for the native widgets is because I'm working on getting Flash to work as an NPAPI plugin. The NPAPI spec has "windowed" and "windowless" widgets. For windowed widgets, you need to hand the plugin a native HWND and let it work. For windowless, you need to pass the mouse events manually to the plugin. If this is the wrong way to pass events - what is the right way to pass them? 19474 5 whereismichelleb2 2007-03-12 06:29:07 -0700 Since I picked up later revisions of webkit, I see the Widget::handleEvent method is the right way to do this. 12544 2007-01-18 14:54:02 -0800 2007-01-22 23:49:37 -0800 Patch for passing mouse events to windows widgets. MouseEventsPatch.txt text/plain 6490 whereismichelleb2 SW5kZXg6IFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwDQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2Vi Q29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAJKHJldmlzaW9uIDE4ODg4KQorKysgV2ViQ29yZS9w YWdlL0V2ZW50SGFuZGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5MCw2ICsyOTAsOSBAQCBi b29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlTW91c2VNb3ZlRXZlbnQoCiAgICAgaWYgKGhhbmRsZURy YWcoZXZlbnQpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAorICAgIGlmIChwYXNzV2lkZ2V0TW91 c2VNb3ZlRXZlbnRUb1dpZGdldChldmVudCkpCisgICAgICAgIHJldHVybiB0cnVlOworCiAgICAg Ly8gTW91c2Ugbm90IHByZXNzZWQuIERvIG5vdGhpbmcuCiAgICAgaWYgKCFtX21vdXNlUHJlc3Nl ZCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMzU4LDYgKzM2MSw5IEBAIGJvb2wgRXZlbnRI YW5kbGVyOjpoYW5kbGVNb3VzZVJlbGVhc2VFdmUKICAgICBpZiAoaGFuZGxlTW91c2VVcChldmVu dCkpCiAgICAgICAgIHJldHVybiB0cnVlOwogCisgICAgaWYgKHBhc3NXaWRnZXRNb3VzZVJlbGVh c2VFdmVudFRvV2lkZ2V0KGV2ZW50KSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisKICAgICAvLyBV c2VkIHRvIHByZXZlbnQgbW91c2VNb3ZlRXZlbnQgZnJvbSBpbml0aWF0aW5nIGEgZHJhZyBiZWZv cmUKICAgICAvLyB0aGUgbW91c2UgaXMgcHJlc3NlZCBhZ2Fpbi4KICAgICBtX2ZyYW1lLT5zZWxl Y3Rpb25Db250cm9sbGVyKCktPnNldENhcmV0QmxpbmtpbmdTdXNwZW5kZWQoZmFsc2UpOwpJbmRl eDogV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9w YWdlL0V2ZW50SGFuZGxlci5oCShyZXZpc2lvbiAxODg4OCkKKysrIFdlYkNvcmUvcGFnZS9FdmVu dEhhbmRsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMjAzLDYgKzIwMyw4IEBAIHByaXZhdGU6CiAg ICAgYm9vbCBwYXNzTW91c2VQcmVzc0V2ZW50VG9TY3JvbGxiYXIoTW91c2VFdmVudFdpdGhIaXRU ZXN0UmVzdWx0cyYsIFBsYXRmb3JtU2Nyb2xsYmFyKik7CiAKICAgICBib29sIHBhc3NXaWRnZXRN b3VzZURvd25FdmVudFRvV2lkZ2V0KGNvbnN0IE1vdXNlRXZlbnRXaXRoSGl0VGVzdFJlc3VsdHMm KTsKKyAgICBib29sIHBhc3NXaWRnZXRNb3VzZU1vdmVFdmVudFRvV2lkZ2V0KGNvbnN0IE1vdXNl RXZlbnRXaXRoSGl0VGVzdFJlc3VsdHMmKTsKKyAgICBib29sIHBhc3NXaWRnZXRNb3VzZVJlbGVh c2VFdmVudFRvV2lkZ2V0KGNvbnN0IE1vdXNlRXZlbnRXaXRoSGl0VGVzdFJlc3VsdHMmKTsKICAg ICBib29sIHBhc3NXaWRnZXRNb3VzZURvd25FdmVudFRvV2lkZ2V0KFJlbmRlcldpZGdldCopOwog CiAgICAgYm9vbCBwYXNzTW91c2VEb3duRXZlbnRUb1dpZGdldChXaWRnZXQqKTsKSW5kZXg6IFdl YkNvcmUvcGFnZS9tYWMvRXZlbnRIYW5kbGVyTWFjLm1tDQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29y ZS9wYWdlL21hYy9FdmVudEhhbmRsZXJNYWMubW0JKHJldmlzaW9uIDE4NzI2KQorKysgV2ViQ29y ZS9wYWdlL21hYy9FdmVudEhhbmRsZXJNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTIyOSw2ICsy MjksMTcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OnBhc3NXaWRnZXRNb3VzZURvd25FdgogICAgIHJl dHVybiBwYXNzTW91c2VEb3duRXZlbnRUb1dpZGdldChyZW5kZXJXaWRnZXQtPndpZGdldCgpKTsK IH0KIAorYm9vbCBFdmVudEhhbmRsZXI6OnBhc3NXaWRnZXRNb3VzZU1vdmVFdmVudFRvV2lkZ2V0 KGNvbnN0IE1vdXNlRXZlbnRXaXRoSGl0VGVzdFJlc3VsdHMmIGV2ZW50KQoreworICAgIHJldHVy biBmYWxzZTsKK30KKworYm9vbCBFdmVudEhhbmRsZXI6OnBhc3NXaWRnZXRNb3VzZVJlbGVhc2VF dmVudFRvV2lkZ2V0KGNvbnN0IE1vdXNlRXZlbnRXaXRoSGl0VGVzdFJlc3VsdHMmIGV2ZW50KQor eworICAgIHJldHVybiBmYWxzZTsKK30KKworCiBib29sIEV2ZW50SGFuZGxlcjo6cGFzc01vdXNl RG93bkV2ZW50VG9XaWRnZXQoV2lkZ2V0KiB3aWRnZXQpCiB7CiAgICAgLy8gRklYTUU6IHRoaXMg bWV0aG9kIGFsd2F5cyByZXR1cm5zIHRydWUKSW5kZXg6IFdlYkNvcmUvcGFnZS93aW4vRXZlbnRI YW5kbGVyV2luLmNwcA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUvcGFnZS93aW4vRXZlbnRIYW5k bGVyV2luLmNwcAkocmV2aXNpb24gMTg5MDkpCisrKyBXZWJDb3JlL3BhZ2Uvd2luL0V2ZW50SGFu ZGxlcldpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYzLDE1ICs2MywzNyBAQCBib29sIEV2ZW50 SGFuZGxlcjo6cGFzc01vdXNlUHJlc3NFdmVudFRvCiBib29sIEV2ZW50SGFuZGxlcjo6cGFzc1dp ZGdldE1vdXNlRG93bkV2ZW50VG9XaWRnZXQoY29uc3QgTW91c2VFdmVudFdpdGhIaXRUZXN0UmVz dWx0cyYgZXZlbnQpCiB7CiAgICAgLy8gRmlndXJlIG91dCB3aGljaCB2aWV3IHRvIHNlbmQgdGhl IGV2ZW50IHRvLgotICAgIGlmICghZXZlbnQudGFyZ2V0Tm9kZSgpIHx8ICFldmVudC50YXJnZXRO b2RlKCktPnJlbmRlcmVyKCkgfHwgIWV2ZW50LnRhcmdldE5vZGUoKS0+cmVuZGVyZXIoKS0+aXNX aWRnZXQoKSkKKyAgICBpZiAoIW1ldi50YXJnZXROb2RlKCkgfHwgIW1ldi50YXJnZXROb2RlKCkt PnJlbmRlcmVyKCkgfHwgIW1ldi50YXJnZXROb2RlKCktPnJlbmRlcmVyKCktPmlzV2lkZ2V0KCkp CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAKLSAgICByZXR1cm4gcGFzc01vdXNlRG93bkV2 ZW50VG9XaWRnZXQoc3RhdGljX2Nhc3Q8UmVuZGVyV2lkZ2V0Kj4oZXZlbnQudGFyZ2V0Tm9kZSgp LT5yZW5kZXJlcigpKS0+d2lkZ2V0KCkpOworICAgIFdpZGdldCogd2lkZ2V0ID0gc3RhdGljX2Nh c3Q8UmVuZGVyV2lkZ2V0Kj4obWV2LnRhcmdldE5vZGUoKS0+cmVuZGVyZXIoKSktPndpZGdldCgp OworICAgIGlmICh3aWRnZXQpCisgICAgICAgIHJldHVybiB3aWRnZXQtPmhhbmRsZU1vdXNlRG93 bkV2ZW50KG1ldi5ldmVudCgpKTsKKyAgICByZXR1cm4gZmFsc2U7CiB9CiAKLWJvb2wgRXZlbnRI YW5kbGVyOjpwYXNzV2lkZ2V0TW91c2VEb3duRXZlbnRUb1dpZGdldChSZW5kZXJXaWRnZXQqIHJl bmRlcldpZGdldCkKK2Jvb2wgRXZlbnRIYW5kbGVyOjpwYXNzV2lkZ2V0TW91c2VNb3ZlRXZlbnRU b1dpZGdldChjb25zdCBNb3VzZUV2ZW50V2l0aEhpdFRlc3RSZXN1bHRzJiBtZXYpCiB7Ci0gICAg cmV0dXJuIHBhc3NNb3VzZURvd25FdmVudFRvV2lkZ2V0KHJlbmRlcldpZGdldC0+d2lkZ2V0KCkp OworICAgIC8vIEZpZ3VyZSBvdXQgd2hpY2ggdmlldyB0byBzZW5kIHRoZSBldmVudCB0by4KKyAg ICBpZiAoIW1ldi50YXJnZXROb2RlKCkgfHwgIW1ldi50YXJnZXROb2RlKCktPnJlbmRlcmVyKCkg fHwgIW1ldi50YXJnZXROb2RlKCktPnJlbmRlcmVyKCktPmlzV2lkZ2V0KCkpCisgICAgICAgIHJl dHVybiBmYWxzZTsKKyAgICAKKyAgICBXaWRnZXQqIHdpZGdldCA9IHN0YXRpY19jYXN0PFJlbmRl cldpZGdldCo+KG1ldi50YXJnZXROb2RlKCktPnJlbmRlcmVyKCkpLT53aWRnZXQoKTsKKyAgICBp ZiAod2lkZ2V0KSAKKyAgICAgICAgcmV0dXJuIHdpZGdldC0+aGFuZGxlTW91c2VNb3ZlRXZlbnQo bWV2LmV2ZW50KCkpOworICAgIHJldHVybiBmYWxzZTsKK30KKworYm9vbCBFdmVudEhhbmRsZXI6 OnBhc3NXaWRnZXRNb3VzZVJlbGVhc2VFdmVudFRvV2lkZ2V0KGNvbnN0IE1vdXNlRXZlbnRXaXRo SGl0VGVzdFJlc3VsdHMmIG1ldikKK3sKKyAgICAvLyBGaWd1cmUgb3V0IHdoaWNoIHZpZXcgdG8g c2VuZCB0aGUgZXZlbnQgdG8uCisgICAgaWYgKCFtZXYudGFyZ2V0Tm9kZSgpIHx8ICFtZXYudGFy Z2V0Tm9kZSgpLT5yZW5kZXJlcigpIHx8ICFtZXYudGFyZ2V0Tm9kZSgpLT5yZW5kZXJlcigpLT5p c1dpZGdldCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgCisgICAgV2lkZ2V0KiB3aWRn ZXQgPSBzdGF0aWNfY2FzdDxSZW5kZXJXaWRnZXQqPihtZXYudGFyZ2V0Tm9kZSgpLT5yZW5kZXJl cigpKS0+d2lkZ2V0KCk7CisgICAgaWYgKHdpZGdldCkgCisgICAgICAgIHJldHVybiB3aWRnZXQt PmhhbmRsZU1vdXNlUmVsZWFzZUV2ZW50KG1ldi5ldmVudCgpKTsKKyAgICByZXR1cm4gZmFsc2U7 CiB9CiAKIH0KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1Nb3VzZUV2ZW50LmgNCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0NCi0tLSBXZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtTW91c2VFdmVudC5oCShyZXZp c2lvbiAxODcyNikKKysrIFdlYkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1Nb3VzZUV2ZW50LmgJKHdv cmtpbmcgY29weSkKQEAgLTQyLDEwICs0Miw3IEBAIGNsYXNzIE5TV2luZG93OwogI2VuZGlmCiAK ICNpZiBQTEFURk9STShXSU4pCi10eXBlZGVmIHN0cnVjdCBIV05EX18qIEhXTkQ7Ci10eXBlZGVm IHVuc2lnbmVkIFVJTlQ7Ci10eXBlZGVmIHVuc2lnbmVkIFdQQVJBTTsKLXR5cGVkZWYgbG9uZyBM UEFSQU07CisjaW5jbHVkZSAid3R5cGVzLmgiCiAjZW5kaWYKIAogI2lmIFBMQVRGT1JNKEdESykK QEAgLTEwOCw2ICsxMDUsMTAgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB2b2lkIHNl dENsaWNrQ291bnQoaW50IGNvdW50KSB7IG1fY2xpY2tDb3VudCA9IGNvdW50OyB9CiAgICAgICAg IGRvdWJsZSB0aW1lc3RhbXAoKSBjb25zdCB7IHJldHVybiBtX3RpbWVzdGFtcDsgfQogICAgICAg ICBib29sIGFjdGl2YXRlZFdlYlZpZXcoKSBjb25zdCB7IHJldHVybiBtX2FjdGl2YXRlZFdlYlZp ZXc7IH0KKyAgICAgICAgSFdORCBod25kKCkgY29uc3QgeyByZXR1cm4gbV9od25kOyB9CisgICAg ICAgIFVJTlQgbXNnKCkgY29uc3QgeyByZXR1cm4gbV9tc2c7IH0KKyAgICAgICAgV1BBUkFNIHdQ YXJhbSgpIGNvbnN0IHsgcmV0dXJuIG1fd1BhcmFtOyB9CisgICAgICAgIExQQVJBTSBsUGFyYW0o KSBjb25zdCB7IHJldHVybiBtX2xQYXJhbTsgfQogI2VuZGlmCiAjaWYgUExBVEZPUk0oR0RLKSAK ICAgICAgICAgUGxhdGZvcm1Nb3VzZUV2ZW50KEdka0V2ZW50Kik7CkBAIC0xMjksNiArMTMwLDEw IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICNpZiBQTEFURk9STShXSU4pCiAgICAgICAgIGRvdWJs ZSBtX3RpbWVzdGFtcDsgLy8gdW5pdDogc2Vjb25kcwogICAgICAgICBib29sIG1fYWN0aXZhdGVk V2ViVmlldzsKKyAgICAgICAgSFdORCBtX2h3bmQ7CisgICAgICAgIFVJTlQgbV9tc2c7CisgICAg ICAgIFdQQVJBTSBtX3dQYXJhbTsKKyAgICAgICAgTFBBUkFNIG1fbFBhcmFtOwogI2VuZGlmCiAg ICAgfTsKIApJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9XaWRnZXQuaA0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0t IFdlYkNvcmUvcGxhdGZvcm0vV2lkZ2V0LmgJKHJldmlzaW9uIDE4ODg4KQorKysgV2ViQ29yZS9w bGF0Zm9ybS9XaWRnZXQuaAkod29ya2luZyBjb3B5KQpAQCAtMTM3LDcgKzEzNywxMSBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIGJvb2wgc3VwcHJlc3NJbnZhbGlkYXRpb24oKSBjb25z dDsKICAgICAgICAgdm9pZCBzZXRTdXBwcmVzc0ludmFsaWRhdGlvbihib29sKTsKIAotICAgICAg ICAvLyBUaGVzZSBtZXRob2RzIHdpbGwgYmUgY2FsbGVkIG9uIGEgd2lkZ2V0IHdoaWxlIGl0IGlz IGNhcHR1cmluZyB0aGUgbW91c2UuIAorCisgICAgICAgIC8vIFRoZXNlIG1ldGhvZHMgZXhpc3Qg Zm9yIHdpZGdldHMgdGhhdCBuZWVkIHRvIGhhbmRsZSBtb3VzZSBldmVudHMgbWFudWFsbHkuCisg ICAgICAgIC8vIE9uIE1hYyB0aGUgdW5kZXJseWluZyBOU1ZpZXcganVzdCBkb2VzIHRoZSBzY3Jv bGxpbmcsIGJ1dCBvbiBvdGhlciBwbGF0Zm9ybXMKKyAgICAgICAgLy8gKGxpa2UgV2luZG93cyks IHdlIG5lZWQgdGhpcyBtZXRob2QgaW4gb3JkZXIgdG8gZG8gdGhlIHNjcm9sbCBvdXJzZWx2ZXMu CisgICAgICAgIHZpcnR1YWwgYm9vbCBoYW5kbGVNb3VzZURvd25FdmVudChjb25zdCBQbGF0Zm9y bU1vdXNlRXZlbnQmKSB7IHJldHVybiBmYWxzZTsgfQogICAgICAgICB2aXJ0dWFsIGJvb2wgaGFu ZGxlTW91c2VNb3ZlRXZlbnQoY29uc3QgUGxhdGZvcm1Nb3VzZUV2ZW50JikgeyByZXR1cm4gZmFs c2U7IH0gCiAgICAgICAgIHZpcnR1YWwgYm9vbCBoYW5kbGVNb3VzZVJlbGVhc2VFdmVudChjb25z dCBQbGF0Zm9ybU1vdXNlRXZlbnQmKSB7IHJldHVybiBmYWxzZTsgfQogI2VuZGlmCg==