123257 2013-10-24 01:12:37 -0700 [GTK] Disable css-image-orientation 2013-10-24 08:58:32 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim cgarcia commit-queue dbates mrobinson oldest_to_newest 943020 0 gyuyoung.kim 2013-10-24 01:12:37 -0700 About 30 tests have been failed since r157909 on GTK port only. I think these regressions happen because GTK port only enables css-image-orientation now. So, I'd like to disable it at the moment. I file a bug(Bug 123256) to enable this feature again. I'd like to investigate why those regression occur on the bug. 943022 1 215036 gyuyoung.kim 2013-10-24 01:24:08 -0700 Created attachment 215036 Patch 943023 2 gyuyoung.kim 2013-10-24 01:25:23 -0700 Added Martin and Carlos. 943107 3 215036 mrobinson 2013-10-24 06:43:17 -0700 Comment on attachment 215036 Patch Are the tests skipped now or are they still failing on the bot? 943121 4 gyuyoung.kim 2013-10-24 07:50:26 -0700 (In reply to comment #3) > (From update of attachment 215036 [details]) > Are the tests skipped now or are they still failing on the bot? They are still failing on the bot. Do you want to skip them instead of disabling the css-image-orientation ? 943126 5 215066 gyuyoung.kim 2013-10-24 08:22:17 -0700 Created attachment 215066 Patch It looks Martin wants to skip failure tests instead of disabling this feature. 943129 6 mrobinson 2013-10-24 08:30:47 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 215036 [details] [details]) > > Are the tests skipped now or are they still failing on the bot? > > They are still failing on the bot. Do you want to skip them instead of disabling the css-image-orientation ? Sorry, for the confusion. I didn't reply in time. I just wanted to ensure that if they were skipped, that your patch unskipped them. Since they aren't skipped now, this isn'tan issue. If you don't mind, I prefer your original patch. 943130 7 215036 gyuyoung.kim 2013-10-24 08:32:37 -0700 Comment on attachment 215036 Patch I want to handle this patch according to your guide. 943139 8 215036 commit-queue 2013-10-24 08:58:29 -0700 Comment on attachment 215036 Patch Clearing flags on attachment: 215036 Committed r157929: <http://trac.webkit.org/changeset/157929> 943140 9 commit-queue 2013-10-24 08:58:32 -0700 All reviewed patches have been landed. Closing bug. 215036 2013-10-24 01:24:08 -0700 2013-10-24 08:58:29 -0700 Patch bug-123257-20131024172406.patch text/plain 1705 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3OTE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGU2OWQ5NDkxNjUxMjcwODMzNGFiN2I1MmFkNzFkY2Zi ODQzZDU2OC4uYzY1NmQ0NjdlNjNjNGQyNzlkOGNkZGIyZGZkZjkxM2NiNjBhMmYxNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEzLTEwLTI0ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+ CisKKyAgICAgICAgW0dUS10gRGlzYWJsZSBjc3MtaW1hZ2Utb3JpZW50YXRpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzI1NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENTUyBpbWFnZSBvcmllbnRh dGlvbiBpc24ndCBzdGFibGUgeWV0LiBTbywgdGVzdCByZWdyZXNzaW9uIGhhcHBlbiBzaW5jZSBy MTU3OTA5LgorICAgICAgICBUaGlzIGZlYXR1cmUgc2hvdWxkIGJlIGVuYWJsZWQgYWdhaW4gYWZ0 ZXIgaXQgaXMgc3RhYmxlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVM aXN0LnBtOgorCiAyMDEzLTEwLTIzICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KIAogICAgICAgICBBZGQgdHdvIG1vcmUgbWFjIGJvdHMgdG8gdGhlIE1hdmVyaWNrcyBU ZXN0IFF1ZXVlLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVM aXN0LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtCmluZGV4IDNk NDYwNWU4NmYzNmRjYjQwMDZiZGY0MzkyMTZlN2JkYjY3MWM5OWUuLmNlNWFmMWU2YjQyZmJiMDRi MjNiZGJlNjRiZWE1NDgxNGIzYWNhODkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cGVybC9GZWF0dXJlTGlzdC5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVy ZUxpc3QucG0KQEAgLTIwNyw3ICsyMDcsNyBAQCBteSBAZmVhdHVyZXMgPSAoCiAgICAgICBkZWZp bmUgPT4gIkVOQUJMRV9DU1NfQk9YX0RFQ09SQVRJT05fQlJFQUsiLCBkZWZhdWx0ID0+IDEsIHZh bHVlID0+IFwkY3NzQm94RGVjb3JhdGlvbkJyZWFrU3VwcG9ydCB9LAogCiAgICAgeyBvcHRpb24g PT4gImNzcy1pbWFnZS1vcmllbnRhdGlvbiIsIGRlc2MgPT4gIlRvZ2dsZSBDU1MgaW1hZ2Utb3Jp ZW50YXRpb24gc3VwcG9ydCIsCi0gICAgICBkZWZpbmUgPT4gIkVOQUJMRV9DU1NfSU1BR0VfT1JJ RU5UQVRJT04iLCBkZWZhdWx0ID0+IGlzR3RrKCksIHZhbHVlID0+IFwkY3NzSW1hZ2VPcmllbnRh dGlvblN1cHBvcnQgfSwKKyAgICAgIGRlZmluZSA9PiAiRU5BQkxFX0NTU19JTUFHRV9PUklFTlRB VElPTiIsIGRlZmF1bHQgPT4gMCwgdmFsdWUgPT4gXCRjc3NJbWFnZU9yaWVudGF0aW9uU3VwcG9y dCB9LAogCiAgICAgeyBvcHRpb24gPT4gImNzcy1pbWFnZS1yZXNvbHV0aW9uIiwgZGVzYyA9PiAi VG9nZ2xlIENTUyBpbWFnZS1yZXNvbHV0aW9uIHN1cHBvcnQiLAogICAgICAgZGVmaW5lID0+ICJF TkFCTEVfQ1NTX0lNQUdFX1JFU09MVVRJT04iLCBkZWZhdWx0ID0+IChpc0JsYWNrQmVycnkoKSB8 fCBpc0d0aygpKSwgdmFsdWUgPT4gXCRjc3NJbWFnZVJlc29sdXRpb25TdXBwb3J0IH0sCg== 215066 2013-10-24 08:22:17 -0700 2013-10-24 08:31:55 -0700 Patch patch.patch text/plain 3899 gyuyoung.kim ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwMDRlMDMwLi5lNjc3NmMzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTMtMTAt MjQgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBb R1RLXSBBZGQgZmFpbHVyZSBleHBlY3RhdGlvbnMgYmVjYXVzZSBvZiByMTU3OTA5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjMyNTcKKworICAgICAg ICBVbnJldmlld2VkIEdUSyBnYXJkZW5pbmcuIEFkZGluZyBmYWlsdXJlIGV4cGVjdGF0aW9ucyBm b3IgY2FudmFzIGZhaWxpbmcgdGVzdHMKKyAgICAgICAgc2luY2UgcjE1NzkwOS4gQ1NTIGltYWdl IG9yaWVudGF0aW9uIHBhdGNoIGluZmx1ZW5jZXMgb24gdGhlIGZhaWx1cmUgdGVzdHMuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMy0xMC0yNCAgSmF2 aWVyIEZlcm5hbmRleiAgPGpmZXJuYW5kZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBS ZW1vdmluZyBmbGFncyBmb3IgdGVzdHMgZml4ZWQgaW4gYnVnIDEyMTgyOApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBjNzU1MzIwLi5lNjM2NWMwIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTQyNSw2ICsxNDI1 LDM5IEBAIHdlYmtpdC5vcmcvYi8xMjIxNDcgZmFzdC9jc3MvZHJvcC1zaGFkb3ctdmlld3BvcnQt d2lkdGguaHRtbCBbIEltYWdlT25seUZhaWx1cmUKIAogd2Via2l0Lm9yZy9iLzEyMjE1MCBmYXN0 L2NzczMtdGV4dC9jc3MzLXRleHQtaW5kZW50L2dldENvbXB1dGVkU3R5bGUvZ2V0Q29tcHV0ZWRT dHlsZS10ZXh0LWluZGVudC5odG1sIFsgRmFpbHVyZSBdCiAKKyMgQ2FudmFzIHRlc3RzIGFyZSBm YWlsaW5nIGFmdGVyIGltcGxlbWVudGluZyBjc3MtaW1hZ2Utb3JpZW50YXRpb24KK3dlYmtpdC5v cmcvYi8xMjMyNTYgY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5wYXR0ZXJuLm1vZGlmeS5jYW52YXMy Lmh0bWwgWyBGYWlsdXJlIF0KK3dlYmtpdC5vcmcvYi8xMjMyNTYgY2FudmFzL3BoaWxpcC90ZXN0 cy8yZC5wYXR0ZXJuLnBhaW50Lm9yaWVudGF0aW9uLmNhbnZhcy5odG1sIFsgRmFpbHVyZSBdCit3 ZWJraXQub3JnL2IvMTIzMjU2IGNhbnZhcy9waGlsaXAvdGVzdHMvaW5pdGlhbC5yZXNldC5wYXR0 ZXJuLmh0bWwgWyBGYWlsdXJlIF0KK3dlYmtpdC5vcmcvYi8xMjMyNTYgY2FudmFzL3BoaWxpcC90 ZXN0cy9zZWN1cml0eS5kYXRhVVJJLmh0bWwgWyBGYWlsdXJlIF0KK3dlYmtpdC5vcmcvYi8xMjMy NTYgY2FudmFzL3BoaWxpcC90ZXN0cy9pbml0aWFsLnJlc2V0LnBhdHRlcm4uaHRtbCBbIEZhaWx1 cmUgXQord2Via2l0Lm9yZy9iLzEyMzI1NiBjYW52YXMvcGhpbGlwL3Rlc3RzL3NlY3VyaXR5LmRh dGFVUkkuaHRtbCBbIEZhaWx1cmUgXQord2Via2l0Lm9yZy9iLzEyMzI1NiBjYW52YXMvcGhpbGlw L3Rlc3RzL3RvRGF0YVVSTC5qcGVnLmFscGhhLmh0bWwgWyBGYWlsdXJlIF0KK3dlYmtpdC5vcmcv Yi8xMjMyNTYgY2FudmFzL3BoaWxpcC90ZXN0cy90b0RhdGFVUkwuanBlZy5wcmltYXJ5Y29sb3Vy cy5odG1sIFsgRmFpbHVyZSBdCit3ZWJraXQub3JnL2IvMTIzMjU2IGNhbnZhcy9waGlsaXAvdGVz dHMvdG9EYXRhVVJMLmpwZWcucXVhbGl0eS5iYXNpYy5odG1sIFsgRmFpbHVyZSBdCit3ZWJraXQu b3JnL2IvMTIzMjU2IGNhbnZhcy9waGlsaXAvdGVzdHMvdG9EYXRhVVJMLnBuZy5jb21wbGV4Y29s b3Vycy5odG1sIFsgRmFpbHVyZSBdCit3ZWJraXQub3JnL2IvMTIzMjU2IGNhbnZhcy9waGlsaXAv dGVzdHMvdG9EYXRhVVJMLnBuZy5wcmltYXJ5Y29sb3Vycy5odG1sIFsgRmFpbHVyZSBdCit3ZWJr aXQub3JnL2IvMTIzMjU2IGZhc3QvY2FudmFzL2NhbnZhcy1ibGVuZGluZy1jb2xvci1vdmVyLWlt YWdlLmh0bWwgWyBGYWlsdXJlIF0KK3dlYmtpdC5vcmcvYi8xMjMyNTYgZmFzdC9jYW52YXMvY2Fu dmFzLWJsZW5kaW5nLWdyYWRpZW50LW92ZXItaW1hZ2UuaHRtbCBbIEZhaWx1cmUgXQord2Via2l0 Lm9yZy9iLzEyMzI1NiBmYXN0L2NhbnZhcy9jYW52YXMtYmxlbmRpbmctaW1hZ2Utb3Zlci1jb2xv ci5odG1sIFsgRmFpbHVyZSBdCit3ZWJraXQub3JnL2IvMTIzMjU2IGZhc3QvY2FudmFzL2NhbnZh cy1ibGVuZGluZy1pbWFnZS1vdmVyLWdyYWRpZW50Lmh0bWwgWyBGYWlsdXJlIF0KK3dlYmtpdC5v cmcvYi8xMjMyNTYgZmFzdC9jYW52YXMvY2FudmFzLWJsZW5kaW5nLWltYWdlLW92ZXItaW1hZ2Uu aHRtbCBbIEZhaWx1cmUgXQord2Via2l0Lm9yZy9iLzEyMzI1NiBmYXN0L2NhbnZhcy9jYW52YXMt YmxlbmRpbmctaW1hZ2Utb3Zlci1wYXR0ZXJuLmh0bWwgWyBGYWlsdXJlIF0KK3dlYmtpdC5vcmcv Yi8xMjMyNTYgZmFzdC9jYW52YXMvY2FudmFzLWJsZW5kaW5nLXBhdHRlcm4tb3Zlci1pbWFnZS5o dG1sIFsgRmFpbHVyZSBdCit3ZWJraXQub3JnL2IvMTIzMjU2IGZhc3QvY2FudmFzL2NhbnZhcy1k cmF3SW1hZ2Utc2hhZG93Lmh0bWwgWyBGYWlsdXJlIF0KK3dlYmtpdC5vcmcvYi8xMjMyNTYgZmFz dC9jYW52YXMvY2FudmFzLXBhdHRlcm4tYmVoYXZpb3VyLmh0bWwgWyBGYWlsdXJlIF0KK3dlYmtp dC5vcmcvYi8xMjMyNTYgZmFzdC9jYW52YXMvY2FudmFzLXBhdHRlcm4tbW9kaWZ5Lmh0bWwgWyBG YWlsdXJlIF0KK3dlYmtpdC5vcmcvYi8xMjMyNTYgZmFzdC9jYW52YXMvY2FudmFzLXNjYWxlLWRy YXdJbWFnZS1zaGFkb3cuaHRtbCBbIEZhaWx1cmUgXQord2Via2l0Lm9yZy9iLzEyMzI1NiBmYXN0 L2NhbnZhcy9kcmF3SW1hZ2Utd2l0aC1pbnZhbGlkLWFyZ3MuaHRtbCBbIEZhaWx1cmUgXQord2Vi a2l0Lm9yZy9iLzEyMzI1NiBmYXN0L2NhbnZhcy9wYXR0ZXJuLXdpdGgtdHJhbnNmb3JtLmh0bWwg WyBGYWlsdXJlIF0KK3dlYmtpdC5vcmcvYi8xMjMyNTYgZmFzdC9kb20vaW1hZ2Utb2JqZWN0Lmh0 bWwgWyBGYWlsdXJlIF0KK3dlYmtpdC5vcmcvYi8xMjMyNTYgZmFzdC9pbWFnZXMvY215ay1qcGVn LXdpdGgtY29sb3ItcHJvZmlsZS5odG1sIFsgRmFpbHVyZSBdCit3ZWJraXQub3JnL2IvMTIzMjU2 IGZhc3QvaW1hZ2VzL2V4aWYtb3JpZW50YXRpb24taW1hZ2UtZG9jdW1lbnQuaHRtbCBbIEZhaWx1 cmUgXQord2Via2l0Lm9yZy9iLzEyMzI1NiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3htbGh0 dHByZXF1ZXN0LWltYWdlLW5vdC1sb2FkZWQuaHRtbCBbIEZhaWx1cmUgXQord2Via2l0Lm9yZy9i LzEyMzI1NiBtZWRpYS92aWRlby1jYW52YXMtZHJhd2luZy1vdXRwdXQuaHRtbCBbIEZhaWx1cmUg XQord2Via2l0Lm9yZy9iLzEyMzI1NiBzdmcvYXMtaW1hZ2Uvc3ZnLWNhbnZhcy1saW5rLW5vdC1j b2xvcmVkLmh0bWwgWyBGYWlsdXJlIF0KK3dlYmtpdC5vcmcvYi8xMjMyNTYgc3ZnL2FzLWltYWdl L3N2Zy1jYW52YXMteGh0bWwtdGFpbnRlZC5odG1sIFsgRmFpbHVyZSBdCisKICMvLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vCiAjIEVuZCBvZiBUZXN0cyBmYWlsaW5nCiAjLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLwo=