123254 2013-10-24 00:40:44 -0700 [WINCE]spin button of input tag of number is not panited 2013-11-19 18:10:25 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 zhuangzg webkit-unassigned bfulgham commit-queue esprehn+autocc glenn kondapallykalyan paroga oldest_to_newest 943011 0 zhuangzg 2013-10-24 00:40:44 -0700 The method of adjustInnerSpinButtonStyle and paintInnerSpinButton is not implemented for WinCE port. 943052 1 215046 zhuangzg 2013-10-24 03:26:32 -0700 Created attachment 215046 paint spin button of number input for wince 945451 2 215046 paroga 2013-10-31 01:42:21 -0700 Comment on attachment 215046 paint spin button of number input for wince Please set the r? flag to get the patch reviewed and into the tree. 945453 3 commit-queue 2013-10-31 01:44:58 -0700 Attachment 215046 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderThemeWinCE.cpp', u'Source/WebCore/rendering/RenderThemeWinCE.h']" exit_code: 1 Source/WebCore/rendering/RenderThemeWinCE.h:117: The parameter name "style" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/rendering/RenderThemeWinCE.h:117: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] Source/WebCore/rendering/RenderThemeWinCE.h:118: The parameter name "i" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/rendering/RenderThemeWinCE.h:118: The parameter name "r" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/rendering/RenderThemeWinCE.cpp:676: This { should be at the end of the previous line [whitespace/braces] [4] Source/WebCore/rendering/RenderThemeWinCE.cpp:680: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/WebCore/rendering/RenderThemeWinCE.cpp:680: Missing space before ( in if( [whitespace/parens] [5] Source/WebCore/rendering/RenderThemeWinCE.cpp:681: This { should be at the end of the previous line [whitespace/braces] [4] Source/WebCore/rendering/RenderThemeWinCE.cpp:682: Missing space before ( in if( [whitespace/parens] [5] Total errors found: 9 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 945480 4 215641 zhuangzg 2013-10-31 03:15:12 -0700 Created attachment 215641 a new patch that passed Tools/Scripts/check-webkit-style 945549 5 bfulgham 2013-10-31 09:41:16 -0700 Patrick, does this patch seem okay to you? 945862 6 paroga 2013-11-01 01:35:17 -0700 (In reply to comment #5) > Patrick, does this patch seem okay to you? Yes, looks ok to me. 945863 7 215641 paroga 2013-11-01 01:36:51 -0700 Comment on attachment 215641 a new patch that passed Tools/Scripts/check-webkit-style View in context: https://bugs.webkit.org/attachment.cgi?id=215641&action=review > Source/WebCore/rendering/RenderThemeWinCE.cpp:660 > +bool RenderThemeWinCE::paintInnerSpinButton(RenderObject* o, const PaintInfo& i, const IntRect& r) please rename "i" to "paintInfo", like in the other functions. 945878 8 215728 zhuangzg 2013-11-01 03:01:41 -0700 Created attachment 215728 updated patch:rename "i" to "paintInfo" 945879 9 zhuangzg 2013-11-01 03:04:40 -0700 (In reply to comment #7) > (From update of attachment 215641 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215641&action=review > > > Source/WebCore/rendering/RenderThemeWinCE.cpp:660 > > +bool RenderThemeWinCE::paintInnerSpinButton(RenderObject* o, const PaintInfo& i, const IntRect& r) > > please rename "i" to "paintInfo", like in the other functions. OK, "i" was renamed to "paintInfo". Please check the new patch! 945883 10 215728 paroga 2013-11-01 03:34:39 -0700 Comment on attachment 215728 updated patch:rename "i" to "paintInfo" looks ok to me 945904 11 215728 bfulgham 2013-11-01 08:45:36 -0700 Comment on attachment 215728 updated patch:rename "i" to "paintInfo" View in context: https://bugs.webkit.org/attachment.cgi?id=215728&action=review Let's rephrase the ChangeLog slightly. Otherwise, it's ready to land. > Source/WebCore/ChangeLog:3 > + Paint spin button of input of number type on WinCE port. Let's rephrase this as "Implement spin control on WinCE port" 946530 12 215885 zhuangzg 2013-11-03 19:36:51 -0800 Created attachment 215885 updated patch： rephrase the ChangeLog 946531 13 zhuangzg 2013-11-03 19:45:39 -0800 (In reply to comment #11) > (From update of attachment 215728 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=215728&action=review > > Let's rephrase the ChangeLog slightly. Otherwise, it's ready to land. > > > Source/WebCore/ChangeLog:3 > > + Paint spin button of input of number type on WinCE port. > > Let's rephrase this as "Implement spin control on WinCE port" OK! It was done. Please check it in new patch. 952346 14 215885 bfulgham 2013-11-19 17:46:52 -0800 Comment on attachment 215885 updated patch： rephrase the ChangeLog Thanks for addressing those earlier comments. r=me! 952357 15 215885 commit-queue 2013-11-19 18:10:21 -0800 Comment on attachment 215885 updated patch： rephrase the ChangeLog Clearing flags on attachment: 215885 Committed r159534: <http://trac.webkit.org/changeset/159534> 952358 16 commit-queue 2013-11-19 18:10:25 -0800 All reviewed patches have been landed. Closing bug. 215046 2013-10-24 03:26:32 -0700 2013-11-01 03:01:41 -0700 paint spin button of number input for wince patch2.txt text/plain 3214 zhuangzg SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NzkxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEwLTI0ICBaaHVhbmcg WmhpZ2FuZyAgPHpodWFuZ3pnQGNuLmZ1aml0c3UuY29tPgorCisgICAgICAgIFBhaW50IHNwaW4g YnV0dG9uIG9mIGlucHV0IG9mIG51bWJlciB0eXBlIG9uIFdpbkNFIHBvcnQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjMyNTQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJU aGVtZVdpbkNFLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lV2luQ0U6OmFkanVz dElubmVyU3BpbkJ1dHRvblN0eWxlKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lV2lu Q0U6OnBhaW50SW5uZXJTcGluQnV0dG9uKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhl bWVXaW5DRS5oOgorCiAyMDEzLTEwLTE0ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBp Z2FsaWEuY29tPgogCiAgICAgICAgIFVzZSBhIFZlY3RvciBpbnN0ZWFkIG9mIEhhc2hTZXQgdG8g Y29tcHV0ZWQgdGhlIG9yZGVyVmFsdWVzIGluIFJlbmRlckZsZXhpYmxlQm94CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW5DRS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luQ0UuY3BwCShyZXZpc2lvbiAx NTc5MTcpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW5DRS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTY0OCw0ICs2NDgsNDcgQEAKIH0KICNlbmRpZgogCit2b2lkIFJl bmRlclRoZW1lV2luQ0U6OmFkanVzdElubmVyU3BpbkJ1dHRvblN0eWxlKFN0eWxlUmVzb2x2ZXIq LCBSZW5kZXJTdHlsZSogc3R5bGUsIEVsZW1lbnQqKSBjb25zdAoreworICAgIGludCB3aWR0aCA9 IDo6R2V0U3lzdGVtTWV0cmljcyhTTV9DWFZTQ1JPTEwpOworICAgIGlmICh3aWR0aCA8PSAwKQor ICAgICAgICB3aWR0aCA9IDE3OyAvLyBWaXN0YSdzIGRlZmF1bHQuCisgICAgc3R5bGUtPnNldFdp ZHRoKExlbmd0aCh3aWR0aCwgRml4ZWQpKTsKKyAgICBzdHlsZS0+c2V0TWluV2lkdGgoTGVuZ3Ro KHdpZHRoLCBGaXhlZCkpOworfQorCitib29sIFJlbmRlclRoZW1lV2luQ0U6OnBhaW50SW5uZXJT cGluQnV0dG9uKFJlbmRlck9iamVjdCogbywgY29uc3QgUGFpbnRJbmZvJiBpLCBjb25zdCBJbnRS ZWN0JiByKQoreworICAgIC8vIFdlIHNwbGl0IHRoZSBzcGVjaWZpZWQgcmVjdGFuZ2xlIGludG8g dHdvIHZlcnRpY2FsbHkuIFdlIGNhbid0IGRyYXcgYQorICAgIC8vIHNwaW4gYnV0dG9uIG9mIHdo aWNoIGhlaWdodCBpcyBsZXNzIHRoYW4gMnB4LgorICAgIGlmIChyLmhlaWdodCgpIDwgMikKKyAg ICAgICAgcmV0dXJuIGZhbHNlOworICAgIEludFJlY3QgdXBSZWN0KHIpOworICAgIHVwUmVjdC5z ZXRIZWlnaHQoci5oZWlnaHQoKSAvIDIpOworICAgIEludFJlY3QgZG93blJlY3Qocik7CisgICAg ZG93blJlY3Quc2V0WSh1cFJlY3QubWF4WSgpKTsKKyAgICBkb3duUmVjdC5zZXRIZWlnaHQoci5o ZWlnaHQoKSAtIHVwUmVjdC5oZWlnaHQoKSk7CisKKyAgICB1bnNpZ25lZCBzdGF0ZVVwID0gREZD U19TQ1JPTExVUDsKKyAgICB1bnNpZ25lZCBzdGF0ZURvd24gPSBERkNTX1NDUk9MTERPV047CisK KyAgICBpZiAoIWlzRW5hYmxlZChvKSB8fCBpc1JlYWRPbmx5Q29udHJvbChvKSkKKyAgICB7Cisg ICAgICAgIHN0YXRlVXAgfD0gREZDU19JTkFDVElWRTsKKyAgICAgICAgc3RhdGVEb3duIHw9IERG Q1NfSU5BQ1RJVkU7CisgICAgfQorICAgIGVsc2UgaWYoaXNQcmVzc2VkKG8pKQorICAgIHsKKyAg ICAgICAgaWYoaXNTcGluVXBCdXR0b25QYXJ0UHJlc3NlZChvKSkKKyAgICAgICAgICAgIHN0YXRl VXAgfD0gREZDU19QVVNIRUQ7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHN0YXRlRG93biB8 PSBERkNTX1BVU0hFRDsKKyAgICB9CisKKyAgICBpLmNvbnRleHQtPmRyYXdGcmFtZUNvbnRyb2wo dXBSZWN0LCBERkNfU0NST0xMLCBzdGF0ZVVwKTsKKyAgICBpLmNvbnRleHQtPmRyYXdGcmFtZUNv bnRyb2woZG93blJlY3QsIERGQ19TQ1JPTEwsIHN0YXRlRG93bik7CisKKyAgICByZXR1cm4gZmFs c2U7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUaGVtZVdpbkNFLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lV2luQ0UuaAkocmV2aXNpb24gMTU3OTE3KQorKysgU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luQ0UuaAkod29ya2luZyBjb3B5KQpAQCAt MTE0LDYgKzExNCw5IEBACiAgICAgICAgIHZpcnR1YWwgdm9pZCBhZGp1c3RUZXh0RmllbGRTdHls ZShTdHlsZVJlc29sdmVyKiwgUmVuZGVyU3R5bGUqIHN0eWxlLCBFbGVtZW50KikgY29uc3QgeyB9 CiAgICAgICAgIHZpcnR1YWwgdm9pZCBhZGp1c3RUZXh0QXJlYVN0eWxlKFN0eWxlUmVzb2x2ZXIq LCBSZW5kZXJTdHlsZSogc3R5bGUsIEVsZW1lbnQqKSBjb25zdCB7IH0KIAorICAgICAgICB2aXJ0 dWFsIHZvaWQgYWRqdXN0SW5uZXJTcGluQnV0dG9uU3R5bGUoU3R5bGVSZXNvbHZlciosIFJlbmRl clN0eWxlKiBzdHlsZSwgRWxlbWVudCopIGNvbnN0IDsKKyAgICAgICAgdmlydHVhbCBib29sIHBh aW50SW5uZXJTcGluQnV0dG9uKFJlbmRlck9iamVjdCosIGNvbnN0IFBhaW50SW5mbyYgaSwgY29u c3QgSW50UmVjdCYgcik7CisKICAgICAgICAgc3RhdGljIHZvaWQgc2V0V2ViS2l0SXNCZWluZ1Vu bG9hZGVkKCk7CiAKICAgICAgICAgdmlydHVhbCBib29sIHN1cHBvcnRzRm9jdXNSaW5nKGNvbnN0 IFJlbmRlclN0eWxlKikgY29uc3Q7Cg== 215641 2013-10-31 03:15:12 -0700 2013-11-01 03:01:41 -0700 a new patch that passed Tools/Scripts/check-webkit-style patch_123254.txt text/plain 3185 zhuangzg SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODM1NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEwLTMxICBaaHVhbmcg WmhpZ2FuZyAgPHpodWFuZ3pnQGNuLmZ1aml0c3UuY29tPgorCisgICAgICAgIFBhaW50IHNwaW4g YnV0dG9uIG9mIGlucHV0IG9mIG51bWJlciB0eXBlIG9uIFdpbkNFIHBvcnQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjMyNTQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJU aGVtZVdpbkNFLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lV2luQ0U6OmFkanVz dElubmVyU3BpbkJ1dHRvblN0eWxlKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lV2lu Q0U6OnBhaW50SW5uZXJTcGluQnV0dG9uKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhl bWVXaW5DRS5oOgorCiAyMDEzLTEwLTMxICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlh LmNvbT4KIAogICAgICAgICBbR1RLXSBVbmRlZmluZWQgcmVmZXJlbmNlcyB0byBSZW5kZXJPYmpl Y3Q6OnN0eWxlKCkgd2hlbiBkaXNhYmxpbmcgdmlkZW8gc3VwcG9ydApJbmRleDogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luQ0UuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVdpbkNFLmNwcAkocmV2aXNpb24gMTU4MzU1 KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luQ0UuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC02NDgsNCArNjQ4LDQ0IEBACiB9CiAjZW5kaWYKIAordm9pZCBSZW5kZXJU aGVtZVdpbkNFOjphZGp1c3RJbm5lclNwaW5CdXR0b25TdHlsZShTdHlsZVJlc29sdmVyKiwgUmVu ZGVyU3R5bGUqIHN0eWxlLCBFbGVtZW50KikgY29uc3QKK3sKKyAgICBpbnQgd2lkdGggPSA6Okdl dFN5c3RlbU1ldHJpY3MoU01fQ1hWU0NST0xMKTsKKyAgICBpZiAod2lkdGggPD0gMCkKKyAgICAg ICAgd2lkdGggPSAxNzsgLy8gVmlzdGEncyBkZWZhdWx0LgorICAgIHN0eWxlLT5zZXRXaWR0aChM ZW5ndGgod2lkdGgsIEZpeGVkKSk7CisgICAgc3R5bGUtPnNldE1pbldpZHRoKExlbmd0aCh3aWR0 aCwgRml4ZWQpKTsKK30KKworYm9vbCBSZW5kZXJUaGVtZVdpbkNFOjpwYWludElubmVyU3BpbkJ1 dHRvbihSZW5kZXJPYmplY3QqIG8sIGNvbnN0IFBhaW50SW5mbyYgaSwgY29uc3QgSW50UmVjdCYg cikKK3sKKyAgICAvLyBXZSBzcGxpdCB0aGUgc3BlY2lmaWVkIHJlY3RhbmdsZSBpbnRvIHR3byB2 ZXJ0aWNhbGx5LiBXZSBjYW4ndCBkcmF3IGEKKyAgICAvLyBzcGluIGJ1dHRvbiBvZiB3aGljaCBo ZWlnaHQgaXMgbGVzcyB0aGFuIDJweC4KKyAgICBpZiAoci5oZWlnaHQoKSA8IDIpCisgICAgICAg IHJldHVybiBmYWxzZTsKKyAgICBJbnRSZWN0IHVwUmVjdChyKTsKKyAgICB1cFJlY3Quc2V0SGVp Z2h0KHIuaGVpZ2h0KCkgLyAyKTsKKyAgICBJbnRSZWN0IGRvd25SZWN0KHIpOworICAgIGRvd25S ZWN0LnNldFkodXBSZWN0Lm1heFkoKSk7CisgICAgZG93blJlY3Quc2V0SGVpZ2h0KHIuaGVpZ2h0 KCkgLSB1cFJlY3QuaGVpZ2h0KCkpOworCisgICAgdW5zaWduZWQgc3RhdGVVcCA9IERGQ1NfU0NS T0xMVVA7CisgICAgdW5zaWduZWQgc3RhdGVEb3duID0gREZDU19TQ1JPTExET1dOOworCisgICAg aWYgKCFpc0VuYWJsZWQobykgfHwgaXNSZWFkT25seUNvbnRyb2wobykpIHsKKyAgICAgICAgc3Rh dGVVcCB8PSBERkNTX0lOQUNUSVZFOworICAgICAgICBzdGF0ZURvd24gfD0gREZDU19JTkFDVElW RTsKKyAgICB9IGVsc2UgaWYgKGlzUHJlc3NlZChvKSkgeworICAgICAgICBpZiAoaXNTcGluVXBC dXR0b25QYXJ0UHJlc3NlZChvKSkKKyAgICAgICAgICAgIHN0YXRlVXAgfD0gREZDU19QVVNIRUQ7 CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHN0YXRlRG93biB8PSBERkNTX1BVU0hFRDsKKyAg ICB9CisKKyAgICBpLmNvbnRleHQtPmRyYXdGcmFtZUNvbnRyb2wodXBSZWN0LCBERkNfU0NST0xM LCBzdGF0ZVVwKTsKKyAgICBpLmNvbnRleHQtPmRyYXdGcmFtZUNvbnRyb2woZG93blJlY3QsIERG Q19TQ1JPTEwsIHN0YXRlRG93bik7CisKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKIH0gLy8gbmFt ZXNwYWNlIFdlYkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVt ZVdpbkNFLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRo ZW1lV2luQ0UuaAkocmV2aXNpb24gMTU4MzU1KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRoZW1lV2luQ0UuaAkod29ya2luZyBjb3B5KQpAQCAtMTE0LDYgKzExNCw5IEBACiAg ICAgICAgIHZpcnR1YWwgdm9pZCBhZGp1c3RUZXh0RmllbGRTdHlsZShTdHlsZVJlc29sdmVyKiwg UmVuZGVyU3R5bGUqIHN0eWxlLCBFbGVtZW50KikgY29uc3QgeyB9CiAgICAgICAgIHZpcnR1YWwg dm9pZCBhZGp1c3RUZXh0QXJlYVN0eWxlKFN0eWxlUmVzb2x2ZXIqLCBSZW5kZXJTdHlsZSogc3R5 bGUsIEVsZW1lbnQqKSBjb25zdCB7IH0KIAorICAgICAgICB2aXJ0dWFsIHZvaWQgYWRqdXN0SW5u ZXJTcGluQnV0dG9uU3R5bGUoU3R5bGVSZXNvbHZlciosIFJlbmRlclN0eWxlKiwgRWxlbWVudCop IGNvbnN0OworICAgICAgICB2aXJ0dWFsIGJvb2wgcGFpbnRJbm5lclNwaW5CdXR0b24oUmVuZGVy T2JqZWN0KiwgY29uc3QgUGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOworCiAgICAgICAgIHN0 YXRpYyB2b2lkIHNldFdlYktpdElzQmVpbmdVbmxvYWRlZCgpOwogCiAgICAgICAgIHZpcnR1YWwg Ym9vbCBzdXBwb3J0c0ZvY3VzUmluZyhjb25zdCBSZW5kZXJTdHlsZSopIGNvbnN0Owo= 215728 2013-11-01 03:01:41 -0700 2013-11-19 17:45:22 -0800 updated patch:rename "i" to "paintInfo" patch_123254_3.txt text/plain 3192 zhuangzg SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODQyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTExLTAxICBaaHVhbmcg WmhpZ2FuZyAgPHpodWFuZ3pnQGNuLmZ1aml0c3UuY29tPgorCisgICAgICAgIFBhaW50IHNwaW4g YnV0dG9uIG9mIGlucHV0IG9mIG51bWJlciB0eXBlIG9uIFdpbkNFIHBvcnQuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjMyNTQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJU aGVtZVdpbkNFLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lV2luQ0U6OmFkanVz dElubmVyU3BpbkJ1dHRvblN0eWxlKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lV2lu Q0U6OnBhaW50SW5uZXJTcGluQnV0dG9uKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhl bWVXaW5DRS5oOgorCiAyMDEzLTExLTAxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUu Y29tPgogCiAgICAgICAgIEFkZCBhIE1hYyBXZWJDcnlwdG8gaW1wbGVtZW50YXRpb24gb2YgSE1B QyBpbXBvcnRLZXkvc2lnbi92ZXJpZnkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUaGVtZVdpbkNFLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGhlbWVXaW5DRS5jcHAJKHJldmlzaW9uIDE1ODQyNykKKysrIFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVdpbkNFLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjQ5 LDQgKzY0OSw0NCBAQAogfQogI2VuZGlmCiAKK3ZvaWQgUmVuZGVyVGhlbWVXaW5DRTo6YWRqdXN0 SW5uZXJTcGluQnV0dG9uU3R5bGUoU3R5bGVSZXNvbHZlciosIFJlbmRlclN0eWxlKiBzdHlsZSwg RWxlbWVudCopIGNvbnN0Cit7CisgICAgaW50IHdpZHRoID0gOjpHZXRTeXN0ZW1NZXRyaWNzKFNN X0NYVlNDUk9MTCk7CisgICAgaWYgKHdpZHRoIDw9IDApCisgICAgICAgIHdpZHRoID0gMTc7IC8v IFZpc3RhJ3MgZGVmYXVsdC4KKyAgICBzdHlsZS0+c2V0V2lkdGgoTGVuZ3RoKHdpZHRoLCBGaXhl ZCkpOworICAgIHN0eWxlLT5zZXRNaW5XaWR0aChMZW5ndGgod2lkdGgsIEZpeGVkKSk7Cit9CisK K2Jvb2wgUmVuZGVyVGhlbWVXaW5DRTo6cGFpbnRJbm5lclNwaW5CdXR0b24oUmVuZGVyT2JqZWN0 KiBvLCBjb25zdCBQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgSW50UmVjdCYgcikKK3sKKyAg ICAvLyBXZSBzcGxpdCB0aGUgc3BlY2lmaWVkIHJlY3RhbmdsZSBpbnRvIHR3byB2ZXJ0aWNhbGx5 LiBXZSBjYW4ndCBkcmF3IGEKKyAgICAvLyBzcGluIGJ1dHRvbiBvZiB3aGljaCBoZWlnaHQgaXMg bGVzcyB0aGFuIDJweC4KKyAgICBpZiAoci5oZWlnaHQoKSA8IDIpCisgICAgICAgIHJldHVybiBm YWxzZTsKKyAgICBJbnRSZWN0IHVwUmVjdChyKTsKKyAgICB1cFJlY3Quc2V0SGVpZ2h0KHIuaGVp Z2h0KCkgLyAyKTsKKyAgICBJbnRSZWN0IGRvd25SZWN0KHIpOworICAgIGRvd25SZWN0LnNldFko dXBSZWN0Lm1heFkoKSk7CisgICAgZG93blJlY3Quc2V0SGVpZ2h0KHIuaGVpZ2h0KCkgLSB1cFJl Y3QuaGVpZ2h0KCkpOworCisgICAgdW5zaWduZWQgc3RhdGVVcCA9IERGQ1NfU0NST0xMVVA7Cisg ICAgdW5zaWduZWQgc3RhdGVEb3duID0gREZDU19TQ1JPTExET1dOOworCisgICAgaWYgKCFpc0Vu YWJsZWQobykgfHwgaXNSZWFkT25seUNvbnRyb2wobykpIHsKKyAgICAgICAgc3RhdGVVcCB8PSBE RkNTX0lOQUNUSVZFOworICAgICAgICBzdGF0ZURvd24gfD0gREZDU19JTkFDVElWRTsKKyAgICB9 IGVsc2UgaWYgKGlzUHJlc3NlZChvKSkgeworICAgICAgICBpZiAoaXNTcGluVXBCdXR0b25QYXJ0 UHJlc3NlZChvKSkKKyAgICAgICAgICAgIHN0YXRlVXAgfD0gREZDU19QVVNIRUQ7CisgICAgICAg IGVsc2UKKyAgICAgICAgICAgIHN0YXRlRG93biB8PSBERkNTX1BVU0hFRDsKKyAgICB9CisKKyAg ICBwYWludEluZm8uY29udGV4dC0+ZHJhd0ZyYW1lQ29udHJvbCh1cFJlY3QsIERGQ19TQ1JPTEws IHN0YXRlVXApOworICAgIHBhaW50SW5mby5jb250ZXh0LT5kcmF3RnJhbWVDb250cm9sKGRvd25S ZWN0LCBERkNfU0NST0xMLCBzdGF0ZURvd24pOworCisgICAgcmV0dXJuIGZhbHNlOworfQorCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGhlbWVXaW5DRS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUaGVtZVdpbkNFLmgJKHJldmlzaW9uIDE1ODQyNykKKysrIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUaGVtZVdpbkNFLmgJKHdvcmtpbmcgY29weSkKQEAgLTExNCw2ICsxMTQs OSBAQAogICAgICAgICB2aXJ0dWFsIHZvaWQgYWRqdXN0VGV4dEZpZWxkU3R5bGUoU3R5bGVSZXNv bHZlciosIFJlbmRlclN0eWxlKiBzdHlsZSwgRWxlbWVudCopIGNvbnN0IHsgfQogICAgICAgICB2 aXJ0dWFsIHZvaWQgYWRqdXN0VGV4dEFyZWFTdHlsZShTdHlsZVJlc29sdmVyKiwgUmVuZGVyU3R5 bGUqIHN0eWxlLCBFbGVtZW50KikgY29uc3QgeyB9CiAKKyAgICAgICAgdmlydHVhbCB2b2lkIGFk anVzdElubmVyU3BpbkJ1dHRvblN0eWxlKFN0eWxlUmVzb2x2ZXIqLCBSZW5kZXJTdHlsZSosIEVs ZW1lbnQqKSBjb25zdDsKKyAgICAgICAgdmlydHVhbCBib29sIHBhaW50SW5uZXJTcGluQnV0dG9u KFJlbmRlck9iamVjdCosIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IEludFJlY3QmKTsKKwogICAg ICAgICBzdGF0aWMgdm9pZCBzZXRXZWJLaXRJc0JlaW5nVW5sb2FkZWQoKTsKIAogICAgICAgICB2 aXJ0dWFsIGJvb2wgc3VwcG9ydHNGb2N1c1JpbmcoY29uc3QgUmVuZGVyU3R5bGUqKSBjb25zdDsK 215885 2013-11-03 19:36:51 -0800 2013-11-19 18:10:21 -0800 updated patch： rephrase the ChangeLog patch_123254_4.txt text/plain 3154 zhuangzg SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1ODU1MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTExLTAzICBaaHVhbmcg WmhpZ2FuZyAgPHpodWFuZ3pnQGNuLmZ1aml0c3UuY29tPgorCisgICAgICAgIEltcGxlbWVudCBz cGluIGNvbnRyb2wgb24gV2luQ0UgcG9ydC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyMzI1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luQ0UuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVXaW5DRTo6YWRqdXN0SW5uZXJTcGluQnV0dG9uU3R5 bGUpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVXaW5DRTo6cGFpbnRJbm5lclNwaW5C dXR0b24pOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZVdpbkNFLmg6CisKIDIwMTMt MTEtMDMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmRl clRleHRGcmFnbWVudDogVGlnaHRlbiBmaXJzdC1sZXR0ZXIgbG9naWMuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW5DRS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luQ0UuY3BwCShyZXZpc2lvbiAxNTg1 NTEpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW5DRS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTY0OSw0ICs2NDksNDQgQEAKIH0KICNlbmRpZgogCit2b2lkIFJlbmRl clRoZW1lV2luQ0U6OmFkanVzdElubmVyU3BpbkJ1dHRvblN0eWxlKFN0eWxlUmVzb2x2ZXIqLCBS ZW5kZXJTdHlsZSogc3R5bGUsIEVsZW1lbnQqKSBjb25zdAoreworICAgIGludCB3aWR0aCA9IDo6 R2V0U3lzdGVtTWV0cmljcyhTTV9DWFZTQ1JPTEwpOworICAgIGlmICh3aWR0aCA8PSAwKQorICAg ICAgICB3aWR0aCA9IDE3OyAvLyBWaXN0YSdzIGRlZmF1bHQuCisgICAgc3R5bGUtPnNldFdpZHRo KExlbmd0aCh3aWR0aCwgRml4ZWQpKTsKKyAgICBzdHlsZS0+c2V0TWluV2lkdGgoTGVuZ3RoKHdp ZHRoLCBGaXhlZCkpOworfQorCitib29sIFJlbmRlclRoZW1lV2luQ0U6OnBhaW50SW5uZXJTcGlu QnV0dG9uKFJlbmRlck9iamVjdCogbywgY29uc3QgUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0 IEludFJlY3QmIHIpCit7CisgICAgLy8gV2Ugc3BsaXQgdGhlIHNwZWNpZmllZCByZWN0YW5nbGUg aW50byB0d28gdmVydGljYWxseS4gV2UgY2FuJ3QgZHJhdyBhCisgICAgLy8gc3BpbiBidXR0b24g b2Ygd2hpY2ggaGVpZ2h0IGlzIGxlc3MgdGhhbiAycHguCisgICAgaWYgKHIuaGVpZ2h0KCkgPCAy KQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgSW50UmVjdCB1cFJlY3Qocik7CisgICAgdXBS ZWN0LnNldEhlaWdodChyLmhlaWdodCgpIC8gMik7CisgICAgSW50UmVjdCBkb3duUmVjdChyKTsK KyAgICBkb3duUmVjdC5zZXRZKHVwUmVjdC5tYXhZKCkpOworICAgIGRvd25SZWN0LnNldEhlaWdo dChyLmhlaWdodCgpIC0gdXBSZWN0LmhlaWdodCgpKTsKKworICAgIHVuc2lnbmVkIHN0YXRlVXAg PSBERkNTX1NDUk9MTFVQOworICAgIHVuc2lnbmVkIHN0YXRlRG93biA9IERGQ1NfU0NST0xMRE9X TjsKKworICAgIGlmICghaXNFbmFibGVkKG8pIHx8IGlzUmVhZE9ubHlDb250cm9sKG8pKSB7Cisg ICAgICAgIHN0YXRlVXAgfD0gREZDU19JTkFDVElWRTsKKyAgICAgICAgc3RhdGVEb3duIHw9IERG Q1NfSU5BQ1RJVkU7CisgICAgfSBlbHNlIGlmIChpc1ByZXNzZWQobykpIHsKKyAgICAgICAgaWYg KGlzU3BpblVwQnV0dG9uUGFydFByZXNzZWQobykpCisgICAgICAgICAgICBzdGF0ZVVwIHw9IERG Q1NfUFVTSEVEOworICAgICAgICBlbHNlCisgICAgICAgICAgICBzdGF0ZURvd24gfD0gREZDU19Q VVNIRUQ7CisgICAgfQorCisgICAgcGFpbnRJbmZvLmNvbnRleHQtPmRyYXdGcmFtZUNvbnRyb2wo dXBSZWN0LCBERkNfU0NST0xMLCBzdGF0ZVVwKTsKKyAgICBwYWludEluZm8uY29udGV4dC0+ZHJh d0ZyYW1lQ29udHJvbChkb3duUmVjdCwgREZDX1NDUk9MTCwgc3RhdGVEb3duKTsKKworICAgIHJl dHVybiBmYWxzZTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luQ0UuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW5DRS5oCShyZXZpc2lvbiAxNTg1NTEpCisr KyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW5DRS5oCSh3b3JraW5nIGNv cHkpCkBAIC0xMTQsNiArMTE0LDkgQEAKICAgICAgICAgdmlydHVhbCB2b2lkIGFkanVzdFRleHRG aWVsZFN0eWxlKFN0eWxlUmVzb2x2ZXIqLCBSZW5kZXJTdHlsZSogc3R5bGUsIEVsZW1lbnQqKSBj b25zdCB7IH0KICAgICAgICAgdmlydHVhbCB2b2lkIGFkanVzdFRleHRBcmVhU3R5bGUoU3R5bGVS ZXNvbHZlciosIFJlbmRlclN0eWxlKiBzdHlsZSwgRWxlbWVudCopIGNvbnN0IHsgfQogCisgICAg ICAgIHZpcnR1YWwgdm9pZCBhZGp1c3RJbm5lclNwaW5CdXR0b25TdHlsZShTdHlsZVJlc29sdmVy KiwgUmVuZGVyU3R5bGUqLCBFbGVtZW50KikgY29uc3Q7CisgICAgICAgIHZpcnR1YWwgYm9vbCBw YWludElubmVyU3BpbkJ1dHRvbihSZW5kZXJPYmplY3QqLCBjb25zdCBQYWludEluZm8mLCBjb25z dCBJbnRSZWN0Jik7CisKICAgICAgICAgc3RhdGljIHZvaWQgc2V0V2ViS2l0SXNCZWluZ1VubG9h ZGVkKCk7CiAKICAgICAgICAgdmlydHVhbCBib29sIHN1cHBvcnRzRm9jdXNSaW5nKGNvbnN0IFJl bmRlclN0eWxlKikgY29uc3Q7Cg==