123232 2013-10-23 16:41:24 -0700 When running with the FTL, the other execution engine shouldn't assume that tagTypeNumber/tagMask registers are special 2013-10-24 09:38:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 112840 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 942899 0 fpizlo 2013-10-23 16:41:24 -0700 All that you're allowed to assume is that they're callee-saved. 942900 1 215011 fpizlo 2013-10-23 16:42:33 -0700 Created attachment 215011 the patch 942903 2 215011 mhahnenberg 2013-10-23 16:47:40 -0700 Comment on attachment 215011 the patch r=me. We're going to have to save these for the FTL at some point (since they're callee save). 943175 3 fpizlo 2013-10-24 09:38:46 -0700 (In reply to comment #2) > (From update of attachment 215011 [details]) > r=me. We're going to have to save these for the FTL at some point (since they're callee save). Heh. I think this small comment of yours proves that this patch is wrong. 215011 2013-10-23 16:42:33 -0700 2013-10-23 16:47:39 -0700 the patch blah.patch text/plain 3143 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3ODk5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTEwLTIzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg V2hlbiBydW5uaW5nIHdpdGggdGhlIEZUTCwgdGhlIG90aGVyIGV4ZWN1dGlvbiBlbmdpbmUgc2hv dWxkbid0IGFzc3VtZSB0aGF0IHRhZ1R5cGVOdW1iZXIvdGFnTWFzayByZWdpc3RlcnMgYXJlIHNw ZWNpYWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy MzIzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAg ICAgICAgQWxsIHRoYXQgeW91J3JlIGFsbG93ZWQgdG8gYXNzdW1lIGlzIHRoYXQgdGhleSdyZSBj YWxsZWUtc2F2ZWQuCisKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgorICAg ICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlKToKKyAgICAgICAgKiBqaXQv SklULmNwcDoKKyAgICAgICAgKEpTQzo6SklUOjpwcml2YXRlQ29tcGlsZSk6CisgICAgICAgICog bGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc206CisKIDIwMTMtMTAtMjMgIEZpbGlwIFBpemxv ICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBQdXQgYWxsIHVzZXMgb2YgTExWTSBpbnRy aW5zaWNzIGJlaGluZCBhIHNpbmdsZSBPcHRpb24KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCShyZXZpc2lvbiAxNTc4NzIpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTg2Myw2ICsxODYzLDE0IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNoZWNrQXJn dW1lbnRUeXBlcygKIAogYm9vbCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZSgpCiB7CisgICAgLy8g U2V0IHVwIHRhZyByZWdpc3RlcnMgaWYgd2UncmUgbWl4aW5nIGV4ZWN1dGlvbiB3aXRoIHRoZSBG VEwuCisjaWYgRU5BQkxFKEZUTF9KSVQpCisgICAgaWYgKE9wdGlvbnM6OnVzZUV4cGVyaW1lbnRh bEZUTCgpKSB7CisgICAgICAgIG1faml0Lm1vdmUoVHJ1c3RlZEltbTY0KFRhZ1R5cGVOdW1iZXIp LCBHUFJJbmZvOjp0YWdUeXBlTnVtYmVyUmVnaXN0ZXIpOworICAgICAgICBtX2ppdC5hZGQ2NChU cnVzdGVkSW1tMzIoVGFnQml0VHlwZU90aGVyKSwgR1BSSW5mbzo6dGFnVHlwZU51bWJlclJlZ2lz dGVyLCBHUFJJbmZvOjp0YWdNYXNrUmVnaXN0ZXIpOworICAgIH0KKyNlbmRpZgorCiAgICAgY2hl Y2tBcmd1bWVudFR5cGVzKCk7CiAKICAgICBBU1NFUlQoIW1fY3VycmVudE5vZGUpOwpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcAkocmV2aXNpb24gMTU3ODcyKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9KSVQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OTIsNiArNTkyLDE0 IEBAIENvbXBpbGF0aW9uUmVzdWx0IEpJVDo6cHJpdmF0ZUNvbXBpbGUoSkkKIAogICAgIExhYmVs IGZ1bmN0aW9uQm9keSA9IGxhYmVsKCk7CiAgICAgCisgICAgLy8gU2V0IHVwIHRhZyByZWdpc3Rl cnMgaWYgd2UncmUgbWl4aW5nIGV4ZWN1dGlvbiB3aXRoIHRoZSBGVEwuCisjaWYgRU5BQkxFKEZU TF9KSVQpCisgICAgaWYgKE9wdGlvbnM6OnVzZUV4cGVyaW1lbnRhbEZUTCgpKSB7CisgICAgICAg IG1vdmUoVHJ1c3RlZEltbTY0KFRhZ1R5cGVOdW1iZXIpLCBHUFJJbmZvOjp0YWdUeXBlTnVtYmVy UmVnaXN0ZXIpOworICAgICAgICBhZGQ2NChUcnVzdGVkSW1tMzIoVGFnQml0VHlwZU90aGVyKSwg R1BSSW5mbzo6dGFnVHlwZU51bWJlclJlZ2lzdGVyLCBHUFJJbmZvOjp0YWdNYXNrUmVnaXN0ZXIp OworICAgIH0KKyNlbmRpZgorICAgIAogICAgIHByaXZhdGVDb21waWxlTWFpblBhc3MoKTsKICAg ICBwcml2YXRlQ29tcGlsZUxpbmtQYXNzKCk7CiAgICAgcHJpdmF0ZUNvbXBpbGVTbG93Q2FzZXMo KTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVy LmFzbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJ bnRlcnByZXRlci5hc20JKHJldmlzaW9uIDE1Nzg3MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQkod29ya2luZyBjb3B5KQpAQCAtMzA0LDYg KzMwNCwxMSBAQCBlbmQKICMgRG8gdGhlIGJhcmUgbWluaW11bSByZXF1aXJlZCB0byBleGVjdXRl IGNvZGUuIFNldHMgdXAgdGhlIFBDLCBsZWF2ZSB0aGUgQ29kZUJsb2NrKgogIyBpbiB0MS4gTWF5 IGFsc28gdHJpZ2dlciBwcm9sb2d1ZSBlbnRyeSBPU1IuCiBtYWNybyBwcm9sb2d1ZShjb2RlQmxv Y2tHZXR0ZXIsIGNvZGVCbG9ja1NldHRlciwgb3NyU2xvd1BhdGgsIHRyYWNlU2xvd1BhdGgpCisg ICAgaWYgSlNWQUxVRTY0CisgICAgICAgIG1vdmUgMHhGRkZGMDAwMDAwMDAwMDAwLCB0YWdUeXBl TnVtYmVyCisgICAgICAgIGFkZHEgVGFnQml0VHlwZU90aGVyLCB0YWdUeXBlTnVtYmVyLCB0YWdN YXNrCisgICAgZW5kCisgICAgCiAgICAgcHJlc2VydmVSZXR1cm5BZGRyZXNzQWZ0ZXJDYWxsKHQy KQogICAgIAogICAgICMgU2V0IHVwIHRoZSBjYWxsIGZyYW1lIGFuZCBjaGVjayBpZiB3ZSBzaG91 bGQgT1NSLgo=