123222 2013-10-23 14:38:09 -0700 SVGFilterBuilder should not be ref-counted. 2013-10-23 16:21:38 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue dino d-r esprehn+autocc fmalita glenn gyuyoung.kim kondapallykalyan pdr schenney zimmermann oldest_to_newest 942846 0 kling 2013-10-23 14:38:09 -0700 SVGFilterBuild is single-owner. 942847 1 214999 kling 2013-10-23 14:44:10 -0700 Created attachment 214999 Patch 942865 2 214999 andersca 2013-10-23 15:29:54 -0700 Comment on attachment 214999 Patch is gud poch. 942890 3 214999 commit-queue 2013-10-23 16:21:35 -0700 Comment on attachment 214999 Patch Clearing flags on attachment: 214999 Committed r157899: <http://trac.webkit.org/changeset/157899> 942891 4 commit-queue 2013-10-23 16:21:38 -0700 All reviewed patches have been landed. Closing bug. 214999 2013-10-23 14:44:10 -0700 2013-10-23 16:21:35 -0700 Patch bug-123222.diff text/plain 6596 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzMjY1ODM1Li40MWNmYzQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQg QEAKIDIwMTMtMTAtMjMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIFNWR0ZpbHRlckJ1aWxkZXIgc2hvdWxkIG5vdCBiZSByZWYtY291bnRlZC4KKyAgICAgICAg PGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyMzIyMj4KKworICAgICAgICBUaGVzZSBvYmplY3RzIGFy ZSBzaW5nbHktb3duZWQgYW5kIGRvIG5vdCBuZWVkIHJlZiBjb3VudGluZy4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworMjAxMy0xMC0yMyAgQW5kcmVhcyBLbGluZyAg PGFrbGluZ0BhcHBsZS5jb20+CisKICAgICAgICAgQ2xvY2sgc2hvdWxkIG5vdCBiZSByZWYtY291 bnRlZC4KICAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyMzIxNz4KIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0ZpbHRlckVmZmVjdFJlbmRlcmVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GaWx0ZXJFZmZlY3RSZW5kZXJlci5jcHAKaW5kZXggNTll ZTBkMi4uNDA2OTEwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0ZpbHRl ckVmZmVjdFJlbmRlcmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRmlsdGVy RWZmZWN0UmVuZGVyZXIuY3BwCkBAIC0xNTksNyArMTU5LDcgQEAgUGFzc1JlZlB0cjxGaWx0ZXJF ZmZlY3Q+IEZpbHRlckVmZmVjdFJlbmRlcmVyOjpidWlsZFJlZmVyZW5jZUZpbHRlcihSZW5kZXJF bGVtZW4KICAgICAvLyB3cm9uZy4gV2Ugc2hvdWxkIHByb2JhYmx5IGJlIGV4dHJhY3RpbmcgdGhl IGFscGhhIGZyb20gdGhlIAogICAgIC8vIHByZXZpb3VzRWZmZWN0LCBidXQgdGhpcyByZXF1aXJl cyBzb21lIG1vcmUgcHJvY2Vzc2luZy4gIAogICAgIC8vIFRoaXMgbWF5IG5lZWQgYSBzcGVjIGNs YXJpZmljYXRpb24uCi0gICAgUmVmUHRyPFNWR0ZpbHRlckJ1aWxkZXI+IGJ1aWxkZXIgPSBTVkdG aWx0ZXJCdWlsZGVyOjpjcmVhdGUocHJldmlvdXNFZmZlY3QsIFNvdXJjZUFscGhhOjpjcmVhdGUo dGhpcykpOworICAgIGF1dG8gYnVpbGRlciA9IHN0ZDo6bWFrZV91bmlxdWU8U1ZHRmlsdGVyQnVp bGRlcj4ocHJldmlvdXNFZmZlY3QsIFNvdXJjZUFscGhhOjpjcmVhdGUodGhpcykpOwogCiAgICAg YXV0byBhdHRyaWJ1dGVzQ2hpbGRyZW4gPSBjaGlsZHJlbk9mVHlwZTxTVkdGaWx0ZXJQcmltaXRp dmVTdGFuZGFyZEF0dHJpYnV0ZXM+KGZpbHRlcik7CiAgICAgZm9yIChhdXRvIGl0ID0gYXR0cmli dXRlc0NoaWxkcmVuLmJlZ2luKCksIGVuZCA9IGF0dHJpYnV0ZXNDaGlsZHJlbi5lbmQoKTsgaXQg IT0gZW5kOyArK2l0KSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3Zn L1JlbmRlclNWR1Jlc291cmNlRmlsdGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9z dmcvUmVuZGVyU1ZHUmVzb3VyY2VGaWx0ZXIuY3BwCmluZGV4IDA4ODUwYWQuLjIwZGQ2MGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VG aWx0ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVz b3VyY2VGaWx0ZXIuY3BwCkBAIC04OSwxMiArODksMTIgQEAgdm9pZCBSZW5kZXJTVkdSZXNvdXJj ZUZpbHRlcjo6cmVtb3ZlQ2xpZW50RnJvbUNhY2hlKFJlbmRlck9iamVjdCogY2xpZW50LCBib29s IG0KICAgICBtYXJrQ2xpZW50Rm9ySW52YWxpZGF0aW9uKGNsaWVudCwgbWFya0ZvckludmFsaWRh dGlvbiA/IEJvdW5kYXJpZXNJbnZhbGlkYXRpb24gOiBQYXJlbnRPbmx5SW52YWxpZGF0aW9uKTsK IH0KIAotUGFzc1JlZlB0cjxTVkdGaWx0ZXJCdWlsZGVyPiBSZW5kZXJTVkdSZXNvdXJjZUZpbHRl cjo6YnVpbGRQcmltaXRpdmVzKFNWR0ZpbHRlciogZmlsdGVyKQorc3RkOjp1bmlxdWVfcHRyPFNW R0ZpbHRlckJ1aWxkZXI+IFJlbmRlclNWR1Jlc291cmNlRmlsdGVyOjpidWlsZFByaW1pdGl2ZXMo U1ZHRmlsdGVyKiBmaWx0ZXIpCiB7CiAgICAgRmxvYXRSZWN0IHRhcmdldEJvdW5kaW5nQm94ID0g ZmlsdGVyLT50YXJnZXRCb3VuZGluZ0JveCgpOwogCiAgICAgLy8gQWRkIGVmZmVjdHMgdG8gdGhl IGJ1aWxkZXIKLSAgICBSZWZQdHI8U1ZHRmlsdGVyQnVpbGRlcj4gYnVpbGRlciA9IFNWR0ZpbHRl ckJ1aWxkZXI6OmNyZWF0ZShTb3VyY2VHcmFwaGljOjpjcmVhdGUoZmlsdGVyKSwgU291cmNlQWxw aGE6OmNyZWF0ZShmaWx0ZXIpKTsKKyAgICBhdXRvIGJ1aWxkZXIgPSBzdGQ6Om1ha2VfdW5pcXVl PFNWR0ZpbHRlckJ1aWxkZXI+KFNvdXJjZUdyYXBoaWM6OmNyZWF0ZShmaWx0ZXIpLCBTb3VyY2VB bHBoYTo6Y3JlYXRlKGZpbHRlcikpOwogICAgIGF1dG8gY2hpbGRyZW4gPSBjaGlsZHJlbk9mVHlw ZTxTVkdGaWx0ZXJQcmltaXRpdmVTdGFuZGFyZEF0dHJpYnV0ZXM+KCZmaWx0ZXJFbGVtZW50KCkp OwogICAgIGZvciAoYXV0byBlbGVtZW50ID0gY2hpbGRyZW4uYmVnaW4oKSwgZW5kID0gY2hpbGRy ZW4uZW5kKCk7IGVsZW1lbnQgIT0gZW5kOyArK2VsZW1lbnQpIHsKICAgICAgICAgUmVmUHRyPEZp bHRlckVmZmVjdD4gZWZmZWN0ID0gZWxlbWVudC0+YnVpbGQoYnVpbGRlci5nZXQoKSwgZmlsdGVy KTsKQEAgLTEwOCw3ICsxMDgsNyBAQCBQYXNzUmVmUHRyPFNWR0ZpbHRlckJ1aWxkZXI+IFJlbmRl clNWR1Jlc291cmNlRmlsdGVyOjpidWlsZFByaW1pdGl2ZXMoU1ZHRmlsdGVyKgogICAgICAgICBl ZmZlY3QtPnNldE9wZXJhdGluZ0NvbG9yU3BhY2UoZWxlbWVudC0+cmVuZGVyZXIoKS0+c3R5bGUo KS0+c3ZnU3R5bGUoKS0+Y29sb3JJbnRlcnBvbGF0aW9uRmlsdGVycygpID09IENJX0xJTkVBUlJH QiA/IENvbG9yU3BhY2VMaW5lYXJSR0IgOiBDb2xvclNwYWNlRGV2aWNlUkdCKTsKICAgICAgICAg YnVpbGRlci0+YWRkKGVsZW1lbnQtPnJlc3VsdCgpLCBlZmZlY3QucmVsZWFzZSgpKTsKICAgICB9 Ci0gICAgcmV0dXJuIGJ1aWxkZXIucmVsZWFzZSgpOworICAgIHJldHVybiBidWlsZGVyOwogfQog CiBib29sIFJlbmRlclNWR1Jlc291cmNlRmlsdGVyOjpmaXRzSW5NYXhpbXVtSW1hZ2VTaXplKGNv bnN0IEZsb2F0U2l6ZSYgc2l6ZSwgRmxvYXRTaXplJiBzY2FsZSkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VGaWx0ZXIuaCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VGaWx0ZXIuaAppbmRleCA2 MTc5N2U4Li4xMGEyNDkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3Zn L1JlbmRlclNWR1Jlc291cmNlRmlsdGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L3N2Zy9SZW5kZXJTVkdSZXNvdXJjZUZpbHRlci5oCkBAIC00MSw2ICs0MSw3IEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIAogc3RydWN0IEZpbHRlckRhdGEgewogICAgIFdURl9NQUtFX0ZBU1RfQUxM T0NBVEVEOworICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKEZpbHRlckRhdGEpOwogcHVibGljOgog ICAgIGVudW0gRmlsdGVyRGF0YVN0YXRlIHsgUGFpbnRpbmdTb3VyY2UsIEFwcGx5aW5nLCBCdWls dCwgQ3ljbGVEZXRlY3RlZCwgTWFya2VkRm9yUmVtb3ZhbCB9OwogCkBAIC01MSw3ICs1Miw3IEBA IHB1YmxpYzoKICAgICB9CiAKICAgICBSZWZQdHI8U1ZHRmlsdGVyPiBmaWx0ZXI7Ci0gICAgUmVm UHRyPFNWR0ZpbHRlckJ1aWxkZXI+IGJ1aWxkZXI7CisgICAgc3RkOjp1bmlxdWVfcHRyPFNWR0Zp bHRlckJ1aWxkZXI+IGJ1aWxkZXI7CiAgICAgT3duUHRyPEltYWdlQnVmZmVyPiBzb3VyY2VHcmFw aGljQnVmZmVyOwogICAgIEdyYXBoaWNzQ29udGV4dCogc2F2ZWRDb250ZXh0OwogICAgIEFmZmlu ZVRyYW5zZm9ybSBzaGVhckZyZWVBYnNvbHV0ZVRyYW5zZm9ybTsKQEAgLTc4LDcgKzc5LDcgQEAg cHVibGljOgogCiAgICAgdmlydHVhbCBGbG9hdFJlY3QgcmVzb3VyY2VCb3VuZGluZ0JveChSZW5k ZXJPYmplY3QqKTsKIAotICAgIFBhc3NSZWZQdHI8U1ZHRmlsdGVyQnVpbGRlcj4gYnVpbGRQcmlt aXRpdmVzKFNWR0ZpbHRlciopOworICAgIHN0ZDo6dW5pcXVlX3B0cjxTVkdGaWx0ZXJCdWlsZGVy PiBidWlsZFByaW1pdGl2ZXMoU1ZHRmlsdGVyKik7CiAKICAgICBTVkdVbml0VHlwZXM6OlNWR1Vu aXRUeXBlIGZpbHRlclVuaXRzKCkgY29uc3QgeyByZXR1cm4gZmlsdGVyRWxlbWVudCgpLmZpbHRl clVuaXRzKCk7IH0KICAgICBTVkdVbml0VHlwZXM6OlNWR1VuaXRUeXBlIHByaW1pdGl2ZVVuaXRz KCkgY29uc3QgeyByZXR1cm4gZmlsdGVyRWxlbWVudCgpLnByaW1pdGl2ZVVuaXRzKCk7IH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHUmVuZGVyVHJlZUFzVGV4 dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1JlbmRlclRyZWVBc1RleHQu Y3BwCmluZGV4IDRlMjAxOTguLjg4OTdjYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdmcvU1ZHUmVuZGVyVHJlZUFzVGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N2Zy9TVkdSZW5kZXJUcmVlQXNUZXh0LmNwcApAQCAtNTA2LDcgKzUwNiw3IEBA IHZvaWQgd3JpdGVTVkdSZXNvdXJjZUNvbnRhaW5lcihUZXh0U3RyZWFtJiB0cywgY29uc3QgUmVu ZGVyT2JqZWN0JiBvYmplY3QsIGludCBpCiAgICAgICAgIC8vIENyZWF0aW5nIGEgcGxhY2Vob2xk ZXIgZmlsdGVyIHdoaWNoIGlzIHBhc3NlZCB0byB0aGUgYnVpbGRlci4KICAgICAgICAgRmxvYXRS ZWN0IGR1bW15UmVjdDsKICAgICAgICAgUmVmUHRyPFNWR0ZpbHRlcj4gZHVtbXlGaWx0ZXIgPSBT VkdGaWx0ZXI6OmNyZWF0ZShBZmZpbmVUcmFuc2Zvcm0oKSwgZHVtbXlSZWN0LCBkdW1teVJlY3Qs IGR1bW15UmVjdCwgdHJ1ZSk7Ci0gICAgICAgIGlmIChSZWZQdHI8U1ZHRmlsdGVyQnVpbGRlcj4g YnVpbGRlciA9IGZpbHRlci0+YnVpbGRQcmltaXRpdmVzKGR1bW15RmlsdGVyLmdldCgpKSkgewor ICAgICAgICBpZiAoYXV0byBidWlsZGVyID0gZmlsdGVyLT5idWlsZFByaW1pdGl2ZXMoZHVtbXlG aWx0ZXIuZ2V0KCkpKSB7CiAgICAgICAgICAgICBpZiAoRmlsdGVyRWZmZWN0KiBsYXN0RWZmZWN0 ID0gYnVpbGRlci0+bGFzdEVmZmVjdCgpKQogICAgICAgICAgICAgICAgIGxhc3RFZmZlY3QtPmV4 dGVybmFsUmVwcmVzZW50YXRpb24odHMsIGluZGVudCArIDEpOwogICAgICAgICB9CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvZmlsdGVycy9TVkdGaWx0ZXJCdWlsZGVy LmggYi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvZmlsdGVycy9TVkdGaWx0ZXJCdWlsZGVy LmgKaW5kZXggYTdmZDI3My4uZDc4OWI3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3Zn L2dyYXBoaWNzL2ZpbHRlcnMvU1ZHRmlsdGVyQnVpbGRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3N2Zy9ncmFwaGljcy9maWx0ZXJzL1NWR0ZpbHRlckJ1aWxkZXIuaApAQCAtMzQsMTEgKzM0LDEx IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgUmVuZGVyT2JqZWN0OwogCi1jbGFzcyBT VkdGaWx0ZXJCdWlsZGVyIDogcHVibGljIFJlZkNvdW50ZWQ8U1ZHRmlsdGVyQnVpbGRlcj4gewor Y2xhc3MgU1ZHRmlsdGVyQnVpbGRlciB7CiBwdWJsaWM6CiAgICAgdHlwZWRlZiBIYXNoU2V0PEZp bHRlckVmZmVjdCo+IEZpbHRlckVmZmVjdFNldDsKIAotICAgIHN0YXRpYyBQYXNzUmVmUHRyPFNW R0ZpbHRlckJ1aWxkZXI+IGNyZWF0ZShQYXNzUmVmUHRyPEZpbHRlckVmZmVjdD4gc291cmNlR3Jh cGhpYywgUGFzc1JlZlB0cjxGaWx0ZXJFZmZlY3Q+IHNvdXJjZUFscGhhKSB7IHJldHVybiBhZG9w dFJlZihuZXcgU1ZHRmlsdGVyQnVpbGRlcihzb3VyY2VHcmFwaGljLCBzb3VyY2VBbHBoYSkpOyB9 CisgICAgU1ZHRmlsdGVyQnVpbGRlcihQYXNzUmVmUHRyPEZpbHRlckVmZmVjdD4gc291cmNlR3Jh cGhpYywgUGFzc1JlZlB0cjxGaWx0ZXJFZmZlY3Q+IHNvdXJjZUFscGhhKTsKIAogICAgIHZvaWQg YWRkKGNvbnN0IEF0b21pY1N0cmluZyYgaWQsIFBhc3NSZWZQdHI8RmlsdGVyRWZmZWN0Pik7CiAK QEAgLTYxLDggKzYxLDYgQEAgcHVibGljOgogICAgIHZvaWQgY2xlYXJSZXN1bHRzUmVjdXJzaXZl KEZpbHRlckVmZmVjdCopOwogCiBwcml2YXRlOgotICAgIFNWR0ZpbHRlckJ1aWxkZXIoUGFzc1Jl ZlB0cjxGaWx0ZXJFZmZlY3Q+IHNvdXJjZUdyYXBoaWMsIFBhc3NSZWZQdHI8RmlsdGVyRWZmZWN0 PiBzb3VyY2VBbHBoYSk7Ci0KICAgICBpbmxpbmUgdm9pZCBhZGRCdWlsdGluRWZmZWN0cygpCiAg ICAgewogICAgICAgICBIYXNoTWFwPEF0b21pY1N0cmluZywgUmVmUHRyPEZpbHRlckVmZmVjdD4+ OjppdGVyYXRvciBlbmQgPSBtX2J1aWx0aW5FZmZlY3RzLmVuZCgpOwo=