123219 2013-10-23 13:49:26 -0700 Put all uses of LLVM intrinsics behind a single Option 2013-10-23 13:56:39 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 122318 1 fpizlo fpizlo atrick barraclough ggaren mark.lam mhahnenberg msaboff nrotem oliver sam oldest_to_newest 942820 0 fpizlo 2013-10-23 13:49:26 -0700 It turns out that the code can't handle turning on IC-with-patchpoint while leaving OSR-with-stackmap off. And I don't think it would be worthwhile to fix that bug since in the long run, we just want to always use the intrinsics. So, we should unify these different options into one. 942821 1 214992 fpizlo 2013-10-23 13:50:07 -0700 Created attachment 214992 the patch 942824 2 214992 mhahnenberg 2013-10-23 13:53:27 -0700 Comment on attachment 214992 the patch r=me 942827 3 fpizlo 2013-10-23 13:56:39 -0700 Landed in http://trac.webkit.org/changeset/157883 214992 2013-10-23 13:50:07 -0700 2013-10-23 13:53:27 -0700 the patch blah.patch text/plain 4758 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3ODgwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDEzLTEwLTIzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UHV0IGFsbCB1c2VzIG9mIExMVk0gaW50cmluc2ljcyBiZWhpbmQgYSBzaW5nbGUgT3B0aW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjMyMTkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZ0bC9GVExF eGl0VGh1bmtHZW5lcmF0b3IuY3BwOgorICAgICAgICAoSlNDOjpGVEw6OkV4aXRUaHVua0dlbmVy YXRvcjo6ZW1pdFRodW5rKToKKyAgICAgICAgKiBmdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwOgor ICAgICAgICAoSlNDOjpGVEw6OmdlbmVyYXRlRXhpdFRodW5rcyk6CisgICAgICAgIChKU0M6OkZU TDo6TG93ZXJERkdUb0xMVk06OmNvbXBpbGVHZXRCeUlkKToKKyAgICAgICAgKEpTQzo6RlRMOjpM b3dlckRGR1RvTExWTTo6ZW1pdE9TUkV4aXRDYWxsKToKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dl ckRGR1RvTExWTTo6YWRkRXhpdEFyZ3VtZW50Rm9yTm9kZSk6CisgICAgICAgICogZnRsL0ZUTE9T UkV4aXRDb21waWxlci5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6Y29tcGlsZUZUTE9TUkV4aXQp OgorICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5oOgorCiAyMDEzLTEwLTIzICBEYW5pZWwgQmF0 ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggSmF2YVNjcmlwdENvcmUgYnVp bGQgdGFyZ2V0cyBmb2xsb3dpbmcgPGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzE1 Nzg2ND4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMRXhpdFRodW5rR2VuZXJh dG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEV4aXRU aHVua0dlbmVyYXRvci5jcHAJKHJldmlzaW9uIDE1Nzg3NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9mdGwvRlRMRXhpdFRodW5rR2VuZXJhdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTEs NyArNTEsNyBAQCB2b2lkIEV4aXRUaHVua0dlbmVyYXRvcjo6ZW1pdFRodW5rKHVuc2lnCiAgICAg T1NSRXhpdENvbXBpbGF0aW9uSW5mbyYgaW5mbyA9IG1fc3RhdGUuZmluYWxpemVyLT5vc3JFeGl0 W2luZGV4XTsKICAgICAKICAgICBpbmZvLm1fdGh1bmtMYWJlbCA9IGxhYmVsKCk7Ci0gICAgaWYg KE9wdGlvbnM6OmZ0bE9TUkV4aXRVc2VzU3RhY2ttYXAoKSkKKyAgICBpZiAoT3B0aW9uczo6ZnRs VXNlc1N0YWNrbWFwcygpKQogICAgICAgICBwdXNoKFRydXN0ZWRJbW0zMihpbmRleCkpOwogICAg IGVsc2UKICAgICAgICAgbW92ZShUcnVzdGVkSW1tMzIoaW5kZXgpLCBHUFJJbmZvOjpub25BcmdH UFIwKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0u Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdU b0xMVk0uY3BwCShyZXZpc2lvbiAxNTc4NzYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRs L0ZUTExvd2VyREZHVG9MTFZNLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTUsNyArNTUsNyBAQCBz dGF0aWMgaW50IGNvbXBpbGVDb3VudGVyOwogCiBzdGF0aWMgYm9vbCBnZW5lcmF0ZUV4aXRUaHVu a3MoKQogewotICAgIHJldHVybiAhT3B0aW9uczo6dXNlTExWTU9TUkV4aXRJbnRyaW5zaWMoKSAm JiAhT3B0aW9uczo6ZnRsT1NSRXhpdFVzZXNTdGFja21hcCgpOworICAgIHJldHVybiAhT3B0aW9u czo6dXNlTExWTU9TUkV4aXRJbnRyaW5zaWMoKSAmJiAhT3B0aW9uczo6ZnRsVXNlc1N0YWNrbWFw cygpOwogfQogCiAvLyBVc2luZyB0aGlzIGluc3RlYWQgb2YgdHlwZUNoZWNrKCkgaGVscHMgdG8g cmVkdWNlIHRoZSBsb2FkIG9uIExMVk0sIGJ5IGNyZWF0aW5nCkBAIC0xMjMzLDcgKzEyMzMsNyBA QCBwcml2YXRlOgogICAgICAgICBMVmFsdWUgYmFzZSA9IGxvd0NlbGwobV9ub2RlLT5jaGlsZDEo KSk7CiAgICAgICAgIFN0cmluZ0ltcGwqIHVpZCA9IG1fZ3JhcGguaWRlbnRpZmllcnMoKVttX25v ZGUtPmlkZW50aWZpZXJOdW1iZXIoKV07CiAKLSAgICAgICAgaWYgKCFPcHRpb25zOjpmdGxJQ1Vz ZXNQYXRjaHBvaW50KCkpIHsKKyAgICAgICAgaWYgKCFPcHRpb25zOjpmdGxVc2VzU3RhY2ttYXBz KCkpIHsKICAgICAgICAgICAgIHNldEpTVmFsdWUodm1DYWxsKG1fb3V0Lm9wZXJhdGlvbihvcGVy YXRpb25HZXRCeUlkKSwgbV9jYWxsRnJhbWUsIG1fb3V0LmludFB0clplcm8sIGJhc2UsIG1fb3V0 LmNvbnN0SW50UHRyKHVpZCkpKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQpAQCAt MzM5OSw3ICszMzk5LDcgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAg fQogICAgICAgICAKLSAgICAgICAgaWYgKE9wdGlvbnM6OmZ0bE9TUkV4aXRVc2VzU3RhY2ttYXAo KSkgeworICAgICAgICBpZiAoT3B0aW9uczo6ZnRsVXNlc1N0YWNrbWFwcygpKSB7CiAgICAgICAg ICAgICBleGl0Lm1fc3RhY2ttYXBJRCA9IG1fc3RhY2ttYXBJRHMrKzsKICAgICAgICAgICAgIGFy Z3VtZW50cy5pbnNlcnQoMCwgbV9vdXQuY29uc3RJbnQzMihNYWNyb0Fzc2VtYmxlcjo6bWF4SnVt cFJlcGxhY2VtZW50U2l6ZSgpKSk7CiAgICAgICAgICAgICBhcmd1bWVudHMuaW5zZXJ0KDAsIG1f b3V0LmNvbnN0SW50MzIoZXhpdC5tX3N0YWNrbWFwSUQpKTsKQEAgLTM0OTIsNyArMzQ5Miw3IEBA IHByaXZhdGU6CiAgICAgICAgIHZhbHVlID0gbV9ib29sZWFuVmFsdWVzLmdldChub2RlKTsKICAg ICAgICAgaWYgKGlzVmFsaWQodmFsdWUpKSB7CiAgICAgICAgICAgICBMVmFsdWUgdmFsdWVUb1Bh c3M7Ci0gICAgICAgICAgICBpZiAoT3B0aW9uczo6ZnRsT1NSRXhpdFVzZXNTdGFja21hcCgpKQor ICAgICAgICAgICAgaWYgKE9wdGlvbnM6OmZ0bFVzZXNTdGFja21hcHMoKSkKICAgICAgICAgICAg ICAgICB2YWx1ZVRvUGFzcyA9IG1fb3V0Lnplcm9FeHQodmFsdWUudmFsdWUoKSwgbV9vdXQuaW50 MzIpOwogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIHZhbHVlVG9QYXNzID0gdmFs dWUudmFsdWUoKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMT1NSRXhpdENv bXBpbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTE9T UkV4aXRDb21waWxlci5jcHAJKHJldmlzaW9uIDE1Nzg3NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9mdGwvRlRMT1NSRXhpdENvbXBpbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzYxLDcg KzM2MSw3IEBAIGV4dGVybiAiQyIgdm9pZCogY29tcGlsZUZUTE9TUkV4aXQoRXhlY1MKICAgICAK ICAgICBwcmVwYXJlQ29kZU9yaWdpbkZvck9TUkV4aXQoZXhlYywgZXhpdC5tX2NvZGVPcmlnaW4p OwogICAgIAotICAgIGlmIChPcHRpb25zOjpmdGxPU1JFeGl0VXNlc1N0YWNrbWFwKCkpCisgICAg aWYgKE9wdGlvbnM6OmZ0bFVzZXNTdGFja21hcHMoKSkKICAgICAgICAgY29tcGlsZVN0dWJXaXRo T1NSRXhpdFN0YWNrbWFwKGV4aXRJRCwgaml0Q29kZSwgZXhpdCwgdm0sIGNvZGVCbG9jayk7CiAg ICAgZWxzZQogICAgICAgICBjb21waWxlU3R1YldpdGhvdXRPU1JFeGl0U3RhY2ttYXAoZXhpdElE LCBleGl0LCB2bSwgY29kZUJsb2NrKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL09wdGlvbnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PcHRpb25zLmgJKHJldmlzaW9uIDE1Nzg3NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL09wdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtMTI2LDggKzEyNiw3IEBAIHR5cGVk ZWYgT3B0aW9uUmFuZ2Ugb3B0aW9uUmFuZ2U7CiAgICAgdihib29sLCB1c2VMTFZNU21hbGxDb2Rl TW9kZWwsIGZhbHNlKSBcCiAgICAgdihib29sLCBmdGxUcmFwc09uT1NSRXhpdCwgZmFsc2UpIFwK ICAgICB2KGJvb2wsIGZ0bE9TUkV4aXRPbWl0c01hcnNoYWxsaW5nLCBmYWxzZSkgXAotICAgIHYo Ym9vbCwgZnRsT1NSRXhpdFVzZXNTdGFja21hcCwgZmFsc2UpIFwKLSAgICB2KGJvb2wsIGZ0bElD VXNlc1BhdGNocG9pbnQsIGZhbHNlKSBcCisgICAgdihib29sLCBmdGxVc2VzU3RhY2ttYXBzLCBm YWxzZSkgXAogICAgIHYoYm9vbCwgdXNlTExWTU9TUkV4aXRJbnRyaW5zaWMsIGZhbHNlKSBcCiAg ICAgdihib29sLCBkdW1wTExWTUlSLCBmYWxzZSkgXAogICAgIHYoYm9vbCwgbGx2bUFsd2F5c0Zh aWxzQmVmb3JlQ29tcGlsZSwgZmFsc2UpIFwK