123207 2013-10-23 07:35:12 -0700 Clean-up in Atomics.h 2013-10-23 10:40:25 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen benjamin cmarcelo commit-queue eflews.bot gyuyoung.kim rego+ews xan.lopez oldest_to_newest 942679 0 allan.jensen 2013-10-23 07:35:12 -0700 Atomics.h has two confusing and bit-rotted ifdefs with comments. The first about CPU(SPARC64) was rendered obsolete when we switch from __exchange_and_add to __sync_add_and_fetch. The second was caused by a wrong definition that apparently only caused trouble on GCC. 942680 1 214959 allan.jensen 2013-10-23 07:37:17 -0700 Created attachment 214959 Patch 942681 2 214959 eflews.bot 2013-10-23 07:42:02 -0700 Comment on attachment 214959 Patch Attachment 214959 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/9858014 942684 3 214961 allan.jensen 2013-10-23 07:55:12 -0700 Created attachment 214961 Patch 942733 4 214961 commit-queue 2013-10-23 10:40:23 -0700 Comment on attachment 214961 Patch Clearing flags on attachment: 214961 Committed r157865: <http://trac.webkit.org/changeset/157865> 942734 5 commit-queue 2013-10-23 10:40:25 -0700 All reviewed patches have been landed. Closing bug. 214959 2013-10-23 07:37:17 -0700 2013-10-23 07:55:06 -0700 Patch bug-123207-20131023163716.patch text/plain 2362 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3ODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI2ZDNhZDIwZjBiMjI3MzUyNjM3ZWE4 OGU4YjUxNjk3NTFhMTIwOWQuLmEwM2U1NWQ4MGY2MjRkZGZjNTA1YzRhYjQzMDQ0YjIyNWU5YmMw OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTMtMTAtMjMgIEFsbGFuIFNhbmRmZWxkIEplbnNl biAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CisKKyAgICAgICAgQ2xlYW4tdXAgaW4gQXRvbWlj cy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjMy MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBdG9t aWNzLmggaGFzIHR3byBjb25mdXNpbmcgYW5kIGJpdC1yb3R0ZWQgaWZkZWZzIHdpdGggY29tbWVu dHMuCisKKyAgICAgICAgVGhlIGZpcnN0IGFib3V0IENQVShTUEFSQzY0KSB3YXMgcmVuZGVyZWQg b2Jzb2xldGUgd2hlbiB3ZSBzd2l0Y2hlZAorICAgICAgICBmcm9tIF9fZXhjaGFuZ2VfYW5kX2Fk ZCB0byBfX3N5bmNfYWRkX2FuZF9mZXRjaC4KKworICAgICAgICBUaGUgc2Vjb25kIHdhcyBjYXVz ZWQgYnkgYSB3cm9uZyBkZWZpbml0aW9uIHRoYXQgYXBwYXJlbnRseSBvbmx5CisgICAgICAgIGNh dXNlZCB0cm91YmxlIG9uIEdDQy4KKworICAgICAgICAqIHd0Zi9BdG9taWNzLmg6CisKIDIwMTMt MTAtMjIgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFN0cmlu Z0ltcGw6Omxvd2VyKCkgc2hvdWxkIHJldHVybiBhIFBhc3NSZWYuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9BdG9taWNzLmggYi9Tb3VyY2UvV1RGL3d0Zi9BdG9taWNzLmgKaW5kZXggOTBl YzlhNmI5NWRjZTU2ZmY1YTExMmRkM2E0MTg2NDg3NzNjYjI1Mi4uY2VlNmY0OTUwNGI5NGY0MTI2 MTU0MzZhMzg5M2UzYjZiMGYyYWQwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQXRvbWlj cy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0F0b21pY3MuaApAQCAtMTAxLDcgKzEwMSw3IEBAIGlu bGluZSBpbnQ2NF90IGF0b21pY0RlY3JlbWVudChpbnQ2NF90IHZvbGF0aWxlKiBhZGRlbmQpIHsg cmV0dXJuIEludGVybG9ja2VkRGVjCiBpbmxpbmUgaW50IGF0b21pY0luY3JlbWVudChpbnQgdm9s YXRpbGUqIGFkZGVuZCkgeyByZXR1cm4gc3RhdGljX2Nhc3Q8aW50PihhdG9taWNfYWRkX3ZhbHVl KHJlaW50ZXJwcmV0X2Nhc3Q8dW5zaWduZWQgdm9sYXRpbGUqPihhZGRlbmQpLCAxKSkgKyAxOyB9 CiBpbmxpbmUgaW50IGF0b21pY0RlY3JlbWVudChpbnQgdm9sYXRpbGUqIGFkZGVuZCkgeyByZXR1 cm4gc3RhdGljX2Nhc3Q8aW50PihhdG9taWNfc3ViX3ZhbHVlKHJlaW50ZXJwcmV0X2Nhc3Q8dW5z aWduZWQgdm9sYXRpbGUqPihhZGRlbmQpLCAxKSkgLSAxOyB9CiAKLSNlbGlmIENPTVBJTEVSKEdD QykgJiYgIUNQVShTUEFSQzY0KSAvLyBzaXplb2YoX0F0b21pY193b3JkKSAhPSBzaXplb2YoaW50 KSBvbiBzcGFyYzY0IGdjYworI2VsaWYgQ09NUElMRVIoR0NDKQogI2RlZmluZSBXVEZfVVNFX0xP Q0tGUkVFX1RIUkVBRFNBRkVSRUZDT1VOVEVEIDEKIAogaW5saW5lIGludCBhdG9taWNJbmNyZW1l bnQoaW50IHZvbGF0aWxlKiBhZGRlbmQpIHsgcmV0dXJuIF9fc3luY19hZGRfYW5kX2ZldGNoKGFk ZGVuZCwgMSk7IH0KQEAgLTEyNywxMSArMTI3LDggQEAgaW5saW5lIGJvb2wgd2Vha0NvbXBhcmVB bmRTd2FwKHZvaWQqdm9sYXRpbGUqIGxvY2F0aW9uLCB2b2lkKiBleHBlY3RlZCwgdm9pZCogbmUK ICAgICByZXR1cm4gSW50ZXJsb2NrZWRDb21wYXJlRXhjaGFuZ2VQb2ludGVyKGxvY2F0aW9uLCBu ZXdWYWx1ZSwgZXhwZWN0ZWQpID09IGV4cGVjdGVkOwogfQogI2Vsc2UgLy8gT1MoV0lORE9XUykg LS0+IG5vdCB3aW5kb3dzCi0jaWYgQ09NUElMRVIoR0NDKSAmJiAhQ09NUElMRVIoQ0xBTkcpIC8v IFdvcmsgYXJvdW5kIGEgZ2NjIGJ1ZyAKKyNpZiBDT01QSUxFUihHQ0MpCiBpbmxpbmUgYm9vbCB3 ZWFrQ29tcGFyZUFuZFN3YXAodm9sYXRpbGUgdW5zaWduZWQqIGxvY2F0aW9uLCB1bnNpZ25lZCBl eHBlY3RlZCwgdW5zaWduZWQgbmV3VmFsdWUpIAotI2Vsc2UKLWlubGluZSBib29sIHdlYWtDb21w YXJlQW5kU3dhcCh1bnNpZ25lZCogbG9jYXRpb24sIHVuc2lnbmVkIGV4cGVjdGVkLCB1bnNpZ25l ZCBuZXdWYWx1ZSkKLSNlbmRpZgogewogI2lmIEVOQUJMRShDT01QQVJFX0FORF9TV0FQKQogI2lm IENQVShYODYpIHx8IENQVShYODZfNjQpCg== 214961 2013-10-23 07:55:12 -0700 2013-10-23 10:40:23 -0700 Patch bug-123207-20131023165510.patch text/plain 2343 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3ODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI2ZDNhZDIwZjBiMjI3MzUyNjM3ZWE4 OGU4YjUxNjk3NTFhMTIwOWQuLmEwM2U1NWQ4MGY2MjRkZGZjNTA1YzRhYjQzMDQ0YjIyNWU5YmMw OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTMtMTAtMjMgIEFsbGFuIFNhbmRmZWxkIEplbnNl biAgPGFsbGFuLmplbnNlbkBkaWdpYS5jb20+CisKKyAgICAgICAgQ2xlYW4tdXAgaW4gQXRvbWlj cy5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjMy MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBdG9t aWNzLmggaGFzIHR3byBjb25mdXNpbmcgYW5kIGJpdC1yb3R0ZWQgaWZkZWZzIHdpdGggY29tbWVu dHMuCisKKyAgICAgICAgVGhlIGZpcnN0IGFib3V0IENQVShTUEFSQzY0KSB3YXMgcmVuZGVyZWQg b2Jzb2xldGUgd2hlbiB3ZSBzd2l0Y2hlZAorICAgICAgICBmcm9tIF9fZXhjaGFuZ2VfYW5kX2Fk ZCB0byBfX3N5bmNfYWRkX2FuZF9mZXRjaC4KKworICAgICAgICBUaGUgc2Vjb25kIHdhcyBjYXVz ZWQgYnkgYSB3cm9uZyBkZWZpbml0aW9uIHRoYXQgYXBwYXJlbnRseSBvbmx5CisgICAgICAgIGNh dXNlZCB0cm91YmxlIG9uIEdDQy4KKworICAgICAgICAqIHd0Zi9BdG9taWNzLmg6CisKIDIwMTMt MTAtMjIgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFN0cmlu Z0ltcGw6Omxvd2VyKCkgc2hvdWxkIHJldHVybiBhIFBhc3NSZWYuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9BdG9taWNzLmggYi9Tb3VyY2UvV1RGL3d0Zi9BdG9taWNzLmgKaW5kZXggOTBl YzlhNmI5NWRjZTU2ZmY1YTExMmRkM2E0MTg2NDg3NzNjYjI1Mi4uNWIzZGY4MDU0MmMwN2RjMWRi MmY4MGU4ZTIyMzZlMTZhMmU5YjIxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQXRvbWlj cy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0F0b21pY3MuaApAQCAtMTAxLDcgKzEwMSw3IEBAIGlu bGluZSBpbnQ2NF90IGF0b21pY0RlY3JlbWVudChpbnQ2NF90IHZvbGF0aWxlKiBhZGRlbmQpIHsg cmV0dXJuIEludGVybG9ja2VkRGVjCiBpbmxpbmUgaW50IGF0b21pY0luY3JlbWVudChpbnQgdm9s YXRpbGUqIGFkZGVuZCkgeyByZXR1cm4gc3RhdGljX2Nhc3Q8aW50PihhdG9taWNfYWRkX3ZhbHVl KHJlaW50ZXJwcmV0X2Nhc3Q8dW5zaWduZWQgdm9sYXRpbGUqPihhZGRlbmQpLCAxKSkgKyAxOyB9 CiBpbmxpbmUgaW50IGF0b21pY0RlY3JlbWVudChpbnQgdm9sYXRpbGUqIGFkZGVuZCkgeyByZXR1 cm4gc3RhdGljX2Nhc3Q8aW50PihhdG9taWNfc3ViX3ZhbHVlKHJlaW50ZXJwcmV0X2Nhc3Q8dW5z aWduZWQgdm9sYXRpbGUqPihhZGRlbmQpLCAxKSkgLSAxOyB9CiAKLSNlbGlmIENPTVBJTEVSKEdD QykgJiYgIUNQVShTUEFSQzY0KSAvLyBzaXplb2YoX0F0b21pY193b3JkKSAhPSBzaXplb2YoaW50 KSBvbiBzcGFyYzY0IGdjYworI2VsaWYgQ09NUElMRVIoR0NDKQogI2RlZmluZSBXVEZfVVNFX0xP Q0tGUkVFX1RIUkVBRFNBRkVSRUZDT1VOVEVEIDEKIAogaW5saW5lIGludCBhdG9taWNJbmNyZW1l bnQoaW50IHZvbGF0aWxlKiBhZGRlbmQpIHsgcmV0dXJuIF9fc3luY19hZGRfYW5kX2ZldGNoKGFk ZGVuZCwgMSk7IH0KQEAgLTEyNywxMSArMTI3LDcgQEAgaW5saW5lIGJvb2wgd2Vha0NvbXBhcmVB bmRTd2FwKHZvaWQqdm9sYXRpbGUqIGxvY2F0aW9uLCB2b2lkKiBleHBlY3RlZCwgdm9pZCogbmUK ICAgICByZXR1cm4gSW50ZXJsb2NrZWRDb21wYXJlRXhjaGFuZ2VQb2ludGVyKGxvY2F0aW9uLCBu ZXdWYWx1ZSwgZXhwZWN0ZWQpID09IGV4cGVjdGVkOwogfQogI2Vsc2UgLy8gT1MoV0lORE9XUykg LS0+IG5vdCB3aW5kb3dzCi0jaWYgQ09NUElMRVIoR0NDKSAmJiAhQ09NUElMRVIoQ0xBTkcpIC8v IFdvcmsgYXJvdW5kIGEgZ2NjIGJ1ZyAKIGlubGluZSBib29sIHdlYWtDb21wYXJlQW5kU3dhcCh2 b2xhdGlsZSB1bnNpZ25lZCogbG9jYXRpb24sIHVuc2lnbmVkIGV4cGVjdGVkLCB1bnNpZ25lZCBu ZXdWYWx1ZSkgCi0jZWxzZQotaW5saW5lIGJvb2wgd2Vha0NvbXBhcmVBbmRTd2FwKHVuc2lnbmVk KiBsb2NhdGlvbiwgdW5zaWduZWQgZXhwZWN0ZWQsIHVuc2lnbmVkIG5ld1ZhbHVlKQotI2VuZGlm CiB7CiAjaWYgRU5BQkxFKENPTVBBUkVfQU5EX1NXQVApCiAjaWYgQ1BVKFg4NikgfHwgQ1BVKFg4 Nl82NCkK