123199 2013-10-23 01:47:48 -0700 [WINCE]Input tag of range type is not painted 2013-10-31 10:15:52 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 zhuangzg webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 942618 0 zhuangzg 2013-10-23 01:47:48 -0700 On WinCE port, the Input tag of number type is not painted. Such as below: <input type="number" name="number" value="100" > In fact, the method of "RenderThemeWinCE::paintSliderTrack" and "RenderThemeWinCE::paintSliderThumb" was implemented, but wrong value was returned. It is expected a value of false if we want to paint it. 942624 1 214940 zhuangzg 2013-10-23 02:02:59 -0700 Created attachment 214940 paint input tag of number type on WINCE port A patch that can fix this problem. 942932 2 zhuangzg 2013-10-23 17:45:57 -0700 (In reply to comment #0) > On WinCE port, the Input tag of number type is not painted. > Such as below: > <input type="number" name="number" value="100" > > > In fact, the method of "RenderThemeWinCE::paintSliderTrack" and "RenderThemeWinCE::paintSliderThumb" was implemented, but wrong value was returned. > It is expected a value of false if we want to paint it. Sorry, I made a mistake.It is the problem of input range type. Changed the summary and will upload a new patch. the Input tag of range type is not painted on WINCE port Such as below: <input type="range" name="range" value="100" > 942933 3 215014 zhuangzg 2013-10-23 17:47:44 -0700 Created attachment 215014 Paint the input tag of range type on WinCE port. 945450 4 215014 paroga 2013-10-31 01:41:49 -0700 Comment on attachment 215014 Paint the input tag of range type on WinCE port. Please set the r? flag to get the patch reviewed and into the tree. 945556 5 215014 bfulgham 2013-10-31 09:50:09 -0700 Comment on attachment 215014 Paint the input tag of range type on WinCE port. View in context: https://bugs.webkit.org/attachment.cgi?id=215014&action=review r=me > Source/WebCore/rendering/RenderThemeWinCE.cpp:512 > + return false; It's strange that we expect these methods to always return 'false'. Doesn't seem like there is much point in having a return value! 945562 6 215014 commit-queue 2013-10-31 10:15:50 -0700 Comment on attachment 215014 Paint the input tag of range type on WinCE port. Clearing flags on attachment: 215014 Committed r158364: <http://trac.webkit.org/changeset/158364> 945563 7 commit-queue 2013-10-31 10:15:52 -0700 All reviewed patches have been landed. Closing bug. 214940 2013-10-23 02:02:59 -0700 2013-10-23 18:11:15 -0700 paint input tag of number type on WINCE port patch.txt text/plain 1820 zhuangzg SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Nzg1MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEwLTIzICBaaHVhbmcg WmhpZ2FuZyAgPHpodWFuZ3pnQGNuLmZ1aml0c3UuY29tPgorCisgICAgICAgIFBhaW50IHRoZSBp bnB1dCB0YWcgb2YgbnVtYmVyIHR5cGUgb24gV2luQ0UgcG9ydC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzE5OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLiAgICAgICAgCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVy VGhlbWVXaW5DRS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZVdpbkNFOjpwYWlu dFNsaWRlclRyYWNrKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lV2luQ0U6OnBhaW50 U2xpZGVyVGh1bWIpOgorCiAyMDEzLTEwLTIyICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJlZmFjdG9yIExpbmVCcmVha2VyOjpuZXh0U2VnbWVudEJyZWFr LCBhZGQgQnJlYWtpbmdDb250ZXh0IHRoYXQgaG9sZHMgYWxsIGl0cyBzdGF0ZQpJbmRleDogU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luQ0UuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVdpbkNFLmNwcAkocmV2aXNpb24g MTU3ODQ5KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luQ0UuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC01MDksNyArNTA5LDcgQEAKICAgICBpLmNvbnRleHQtPnNldFN0 cm9rZUNvbG9yKENvbG9yOjpibGFjaywgQ29sb3JTcGFjZURldmljZVJHQik7CiAgICAgaS5jb250 ZXh0LT5kcmF3TGluZShsZWZ0LCBJbnRQb2ludChyLm1heFgoKSAtIDIsIGxlZnQueSgpKSk7CiAg ICAgaS5jb250ZXh0LT5yZXN0b3JlKCk7Ci0gICAgcmV0dXJuIHJjOworICAgIHJldHVybiBmYWxz ZTsKIH0KIAogYm9vbCBSZW5kZXJUaGVtZVdpbkNFOjpwYWludFNsaWRlclRodW1iKFJlbmRlck9i amVjdCogbywgY29uc3QgUGFpbnRJbmZvJiBpLCBjb25zdCBJbnRSZWN0JiByKQpAQCAtNTE4LDYg KzUxOCw3IEBACiAgICAgaS5jb250ZXh0LT5zYXZlKCk7CiAgICAgaS5jb250ZXh0LT5zZXRTdHJv a2VDb2xvcihDb2xvcjo6YmxhY2ssIENvbG9yU3BhY2VEZXZpY2VSR0IpOwogICAgIGkuY29udGV4 dC0+c2V0RmlsbENvbG9yKENvbG9yOjpibGFjaywgQ29sb3JTcGFjZURldmljZVJHQik7CisgICAg aS5jb250ZXh0LT5maWxsUmVjdChyKTsKICNpZiBFTkFCTEUoVklERU8pCiAgICAgSFRNTE1lZGlh RWxlbWVudCogbWVkaWFFbGVtZW50ID0gbWVkaWFFbGVtZW50UGFyZW50KG8tPm5vZGUoKSk7CiAg ICAgaWYgKG1lZGlhRWxlbWVudCkgewpAQCAtNTI5LDcgKzUzMCw3IEBACiAgICAgfQogI2VuZGlm CiAgICAgaS5jb250ZXh0LT5yZXN0b3JlKCk7Ci0gICAgcmV0dXJuIHJjOworICAgIHJldHVybiBm YWxzZTsKIH0KIAogdm9pZCBSZW5kZXJUaGVtZVdpbkNFOjphZGp1c3RTZWFyY2hGaWVsZFN0eWxl KFN0eWxlUmVzb2x2ZXIqLCBSZW5kZXJTdHlsZSogc3R5bGUsIEVsZW1lbnQqKSBjb25zdAo= 215014 2013-10-23 17:47:44 -0700 2013-10-31 10:15:50 -0700 Paint the input tag of range type on WinCE port. patch.txt text/plain 1819 zhuangzg SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Nzg1MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEwLTIzICBaaHVhbmcg WmhpZ2FuZyAgPHpodWFuZ3pnQGNuLmZ1aml0c3UuY29tPgorCisgICAgICAgIFBhaW50IHRoZSBp bnB1dCB0YWcgb2YgcmFuZ2UgdHlwZSBvbiBXaW5DRSBwb3J0LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMTk5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuICAgICAgICAKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJU aGVtZVdpbkNFLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lV2luQ0U6OnBhaW50 U2xpZGVyVHJhY2spOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVXaW5DRTo6cGFpbnRT bGlkZXJUaHVtYik6CisKIDIwMTMtMTAtMjIgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CiAKICAgICAgICAgUmVmYWN0b3IgTGluZUJyZWFrZXI6Om5leHRTZWdtZW50QnJlYWss IGFkZCBCcmVha2luZ0NvbnRleHQgdGhhdCBob2xkcyBhbGwgaXRzIHN0YXRlCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW5DRS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luQ0UuY3BwCShyZXZpc2lvbiAx NTc4NDkpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW5DRS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTUwOSw3ICs1MDksNyBAQAogICAgIGkuY29udGV4dC0+c2V0U3Ry b2tlQ29sb3IoQ29sb3I6OmJsYWNrLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKICAgICBpLmNvbnRl eHQtPmRyYXdMaW5lKGxlZnQsIEludFBvaW50KHIubWF4WCgpIC0gMiwgbGVmdC55KCkpKTsKICAg ICBpLmNvbnRleHQtPnJlc3RvcmUoKTsKLSAgICByZXR1cm4gcmM7CisgICAgcmV0dXJuIGZhbHNl OwogfQogCiBib29sIFJlbmRlclRoZW1lV2luQ0U6OnBhaW50U2xpZGVyVGh1bWIoUmVuZGVyT2Jq ZWN0KiBvLCBjb25zdCBQYWludEluZm8mIGksIGNvbnN0IEludFJlY3QmIHIpCkBAIC01MTgsNiAr NTE4LDcgQEAKICAgICBpLmNvbnRleHQtPnNhdmUoKTsKICAgICBpLmNvbnRleHQtPnNldFN0cm9r ZUNvbG9yKENvbG9yOjpibGFjaywgQ29sb3JTcGFjZURldmljZVJHQik7CiAgICAgaS5jb250ZXh0 LT5zZXRGaWxsQ29sb3IoQ29sb3I6OmJsYWNrLCBDb2xvclNwYWNlRGV2aWNlUkdCKTsKKyAgICBp LmNvbnRleHQtPmZpbGxSZWN0KHIpOwogI2lmIEVOQUJMRShWSURFTykKICAgICBIVE1MTWVkaWFF bGVtZW50KiBtZWRpYUVsZW1lbnQgPSBtZWRpYUVsZW1lbnRQYXJlbnQoby0+bm9kZSgpKTsKICAg ICBpZiAobWVkaWFFbGVtZW50KSB7CkBAIC01MjksNyArNTMwLDcgQEAKICAgICB9CiAjZW5kaWYK ICAgICBpLmNvbnRleHQtPnJlc3RvcmUoKTsKLSAgICByZXR1cm4gcmM7CisgICAgcmV0dXJuIGZh bHNlOwogfQogCiB2b2lkIFJlbmRlclRoZW1lV2luQ0U6OmFkanVzdFNlYXJjaEZpZWxkU3R5bGUo U3R5bGVSZXNvbHZlciosIFJlbmRlclN0eWxlKiBzdHlsZSwgRWxlbWVudCopIGNvbnN0Cg==