123196 2013-10-22 20:35:27 -0700 jitCompileAndSetHeuristics should DeferGCForAWhile 2013-10-23 10:54:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo ap barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 942562 0 fpizlo 2013-10-22 20:35:27 -0700 Patch forthcoming. This was causing crashes like: 0 com.apple.JavaScriptCore 0x000000010c7ff5d0 JSC::ConservativeRoots::add(void*, void*, JSC::JITStubRoutineSet&, JSC::CodeBlockSet&) + 80 (ConservativeRoots.cpp:108) 1 com.apple.JavaScriptCore 0x000000010c90ba95 JSC::Heap::markRoots() + 181 (Heap.cpp:469) 2 com.apple.JavaScriptCore 0x000000010c90ce39 JSC::Heap::collect(JSC::Heap::SweepToggle) + 409 (Heap.cpp:784) 3 com.apple.JavaScriptCore 0x000000010ca1afa5 JSC::LLInt::jitCompileAndSetHeuristics(JSC::CodeBlock*, JSC::ExecState*) + 373 (DeferGC.h:46) 4 com.apple.JavaScriptCore 0x000000010ca1476c llint_replace + 140 (LLIntSlowPaths.cpp:413) 5 com.apple.JavaScriptCore 0x000000010ca1e557 llint_op_ret + 28 ... 942565 1 214922 fpizlo 2013-10-22 20:42:35 -0700 Created attachment 214922 the patch 942570 2 214922 mhahnenberg 2013-10-22 21:06:04 -0700 Comment on attachment 214922 the patch r=me 942745 3 fpizlo 2013-10-23 10:54:36 -0700 Landed in http://trac.webkit.org/changeset/157868 214922 2013-10-22 20:42:35 -0700 2013-10-22 21:06:04 -0700 the patch blah.patch text/plain 1604 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3ODQ1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTEwLTIyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg aml0Q29tcGlsZUFuZFNldEhldXJpc3RpY3Mgc2hvdWxkIERlZmVyR0NGb3JBV2hpbGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzE5NgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGhpcyBm aXhlcyByYW5kb20gY3Jhc2hlcyBpbiBWOHY3L3JheXRyYWNlLiBJIG9ubHkgc2VlIHRob3NlIGNy YXNoZXMgb24gZXhhY3RseSBvbmUgb2YKKyAgICAgICAgbXkgbWFjaGluZXMuIEkgZG9uJ3QgdGhp bmsgdGhpcyBpcyB0ZXN0YWJsZTsgd2UganVzdCBuZWVkIHRvIHN0ZWFkaWx5IGNvbnZlcmdlIHRv d2FyZHMKKyAgICAgICAgZ2V0dGluZyBvdXIgdXNlcyBvZiBEZWZlckdDIHRvIGJlIHJpZ2h0IGFu ZCB0aGVuIGJlIGNhcmVmdWwgbm90IHRvIHJlZ3Jlc3MuIFdlJ3JlIG5vdAorICAgICAgICB0aGVy ZSB5ZXQsIG9idmlvdXNseS4KKyAgICAgICAgCisgICAgICAgICogbGxpbnQvTExJbnRTbG93UGF0 aHMuY3BwOgorICAgICAgICAoSlNDOjpMTEludDo6aml0Q29tcGlsZUFuZFNldEhldXJpc3RpY3Mp OgorCiAyMDEzLTEwLTIyICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAg ICAgICBNaW5vciBWTSogLT4gVk0mIGNsZWFudXBzIGluIEhhc2hUYWJsZSBhbmQgS2V5d29yZHMu CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnRTbG93UGF0aHMuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTEludFNsb3dQYXRocy5j cHAJKHJldmlzaW9uIDE1Nzg0MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9MTElu dFNsb3dQYXRocy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3OCw3ICsyNzgsNyBAQCBpbmxpbmUg Ym9vbCBzaG91bGRKSVQoRXhlY1N0YXRlKiBleGVjKQogaW5saW5lIGJvb2wgaml0Q29tcGlsZUFu ZFNldEhldXJpc3RpY3MoQ29kZUJsb2NrKiBjb2RlQmxvY2ssIEV4ZWNTdGF0ZSogZXhlYykKIHsK ICAgICBWTSYgdm0gPSBleGVjLT52bSgpOwotICAgIERlZmVyR0MgZGVmZXJHQyh2bS5oZWFwKTsK KyAgICBEZWZlckdDRm9yQVdoaWxlIGRlZmVyR0Modm0uaGVhcCk7IC8vIE15IGNhbGxlcnMgZG9u J3Qgc2V0IHRvcCBjYWxsZnJhbWUsIHNvIHdlIGRvbid0IHdhbnQgdG8gR0MgaGVyZSBhdCBhbGwu CiAgICAgCiAgICAgY29kZUJsb2NrLT51cGRhdGVBbGxWYWx1ZVByb2ZpbGVQcmVkaWN0aW9ucygp OwogICAgIAo=