123136 2013-10-21 22:06:29 -0700 [Cocoa] Add load delegate method for didChangeBackForwardList 2013-10-21 22:15:16 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz oldest_to_newest 942153 0 mitz 2013-10-21 22:06:29 -0700 [Cocoa] Add load delegate method for didChangeBackForwardList 942154 1 214817 mitz 2013-10-21 22:08:09 -0700 Created attachment 214817 Patch 942155 2 214817 andersca 2013-10-21 22:13:39 -0700 Comment on attachment 214817 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214817&action=review > Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm:496 > + if ([browsingContext.loadDelegate respondsToSelector:@selector(browsingContextControllerDidChangedBackForwardList:addedItem:removedItems:)]) { I think this would look better with an early return (unless this is the parttern we're using elsewhere). 942156 3 mitz 2013-10-21 22:15:16 -0700 Committed <http://trac.webkit.org/r157776>. 214817 2013-10-21 22:08:09 -0700 2013-10-21 22:13:39 -0700 Patch bug-123136-20131021220812.patch text/plain 3598 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1Nzc3NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEwLTIxICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBBZGQgbG9hZCBkZWxl Z2F0ZSBtZXRob2QgZm9yIGRpZENoYW5nZUJhY2tGb3J3YXJkTGlzdAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMTM2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS0Jy b3dzaW5nQ29udGV4dENvbnRyb2xsZXIubW06CisgICAgICAgIChkaWRDaGFuZ2VCYWNrRm9yd2Fy ZExpc3QpOiBBZGRlZC4gQ2FsbHMgbmV3IGRlbGVnYXRlIG1ldGhvZC4KKyAgICAgICAgKHNldFVw UGFnZUxvYWRlckNsaWVudCk6ICBIb29rIHVwIG5ldyBjbGllbnQgZnVuY3Rpb24uCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9tYWMvV0tCcm93c2luZ0NvbnRleHRMb2FkRGVsZWdhdGUuaDogRGVj bGFyZSBuZXcgZGVsZWdhdGUgbWV0aG9kLgorCiAyMDEzLTEwLTIxICBNYXJrIFJvd2UgIDxtcm93 ZUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgdmVyc2lvbiBvZiBXZWJLaXRTeXN0ZW1JbnRl cmZhY2UgZm9yIE1hdmVyaWNrcy4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv bWFjL1dLQnJvd3NpbmdDb250ZXh0Q29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIubW0J KHJldmlzaW9uIDE1Nzc3NSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dL QnJvd3NpbmdDb250ZXh0Q29udHJvbGxlci5tbQkod29ya2luZyBjb3B5KQpAQCAtMzAsOCArMzAs MTAgQEAKIAogI2ltcG9ydCAiT2JqQ09iamVjdEdyYXBoLmgiCiAjaW1wb3J0ICJXS0JhY2tGb3J3 YXJkTGlzdEludGVybmFsLmgiCisjaW1wb3J0ICJXS0JhY2tGb3J3YXJkTGlzdEl0ZW1JbnRlcm5h bC5oIgogI2ltcG9ydCAiV0tFcnJvckNGLmgiCiAjaW1wb3J0ICJXS0ZyYW1lLmgiCisjaW1wb3J0 ICJXS05TQXJyYXkuaCIKICNpbXBvcnQgIldLUGFnZVByaXZhdGUuaCIKICNpbXBvcnQgIldLUmV0 YWluUHRyLmgiCiAjaW1wb3J0ICJXS1N0cmluZ0NGLmgiCkBAIC00ODgsNiArNDkwLDE4IEBAIHN0 YXRpYyB2b2lkIGRpZEZpbmlzaFByb2dyZXNzKFdLUGFnZVJlZiAKICAgICAgICAgW2Jyb3dzaW5n Q29udGV4dC5sb2FkRGVsZWdhdGUgYnJvd3NpbmdDb250ZXh0Q29udHJvbGxlckRpZEZpbmlzaFBy b2dyZXNzOmJyb3dzaW5nQ29udGV4dF07CiB9CiAKK3N0YXRpYyB2b2lkIGRpZENoYW5nZUJhY2tG b3J3YXJkTGlzdChXS1BhZ2VSZWYgcGFnZSwgV0tCYWNrRm9yd2FyZExpc3RJdGVtUmVmIGFkZGVk SXRlbSwgV0tBcnJheVJlZiByZW1vdmVkSXRlbXMsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pCit7 CisgICAgV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyICpicm93c2luZ0NvbnRleHQgPSAoV0tC cm93c2luZ0NvbnRleHRDb250cm9sbGVyICopY2xpZW50SW5mbzsKKyAgICBpZiAoW2Jyb3dzaW5n Q29udGV4dC5sb2FkRGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcihicm93c2lu Z0NvbnRleHRDb250cm9sbGVyRGlkQ2hhbmdlZEJhY2tGb3J3YXJkTGlzdDphZGRlZEl0ZW06cmVt b3ZlZEl0ZW1zOildKSB7CisgICAgICAgIFdLQmFja0ZvcndhcmRMaXN0SXRlbSAqYWRkZWQgPSBh ZGRlZEl0ZW0gPyBbW1dLQmFja0ZvcndhcmRMaXN0SXRlbSBhbGxvY10gX2luaXRXaXRoSXRlbToq dG9JbXBsKGFkZGVkSXRlbSldIDogbmlsOworICAgICAgICBOU0FycmF5ICpyZW1vdmVkID0gcmVt b3ZlZEl0ZW1zID8gW1tXS05TQXJyYXkgYWxsb2NdIHdlYl9pbml0V2l0aEltbXV0YWJsZUFycmF5 Oip0b0ltcGwocmVtb3ZlZEl0ZW1zKV0gOiBuaWw7CisgICAgICAgIFticm93c2luZ0NvbnRleHQu bG9hZERlbGVnYXRlIGJyb3dzaW5nQ29udGV4dENvbnRyb2xsZXJEaWRDaGFuZ2VkQmFja0Zvcndh cmRMaXN0OmJyb3dzaW5nQ29udGV4dCBhZGRlZEl0ZW06YWRkZWQgcmVtb3ZlZEl0ZW1zOnJlbW92 ZWRdOworICAgICAgICBbYWRkZWQgcmVsZWFzZV07CisgICAgICAgIFtyZW1vdmVkIHJlbGVhc2Vd OworICAgIH0KK30KKwogc3RhdGljIHZvaWQgc2V0VXBQYWdlTG9hZGVyQ2xpZW50KFdLQnJvd3Np bmdDb250ZXh0Q29udHJvbGxlciAqYnJvd3NpbmdDb250ZXh0LCBXS1BhZ2VSZWYgcGFnZVJlZikK IHsKICAgICBXS1BhZ2VMb2FkZXJDbGllbnQgbG9hZGVyQ2xpZW50OwpAQCAtNTA2LDYgKzUyMCw4 IEBAIHN0YXRpYyB2b2lkIHNldFVwUGFnZUxvYWRlckNsaWVudChXS0Jyb3cKICAgICBsb2FkZXJD bGllbnQuZGlkQ2hhbmdlUHJvZ3Jlc3MgPSBkaWRDaGFuZ2VQcm9ncmVzczsKICAgICBsb2FkZXJD bGllbnQuZGlkRmluaXNoUHJvZ3Jlc3MgPSBkaWRGaW5pc2hQcm9ncmVzczsKIAorICAgIGxvYWRl ckNsaWVudC5kaWRDaGFuZ2VCYWNrRm9yd2FyZExpc3QgPSBkaWRDaGFuZ2VCYWNrRm9yd2FyZExp c3Q7CisKICAgICBXS1BhZ2VTZXRQYWdlTG9hZGVyQ2xpZW50KHBhZ2VSZWYsICZsb2FkZXJDbGll bnQpOwogfQogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS0Jyb3dz aW5nQ29udGV4dExvYWREZWxlZ2F0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvbWFjL1dLQnJvd3NpbmdDb250ZXh0TG9hZERlbGVnYXRlLmgJKHJldmlzaW9u IDE1Nzc3NSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLQnJvd3NpbmdD b250ZXh0TG9hZERlbGVnYXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTUyLDQgKzUyLDYgQEAKIC0g KHZvaWQpYnJvd3NpbmdDb250ZXh0Q29udHJvbGxlcjooV0tCcm93c2luZ0NvbnRleHRDb250cm9s bGVyICopc2VuZGVyIGVzdGltYXRlZFByb2dyZXNzQ2hhbmdlZFRvOihkb3VibGUpZXN0aW1hdGVk UHJvZ3Jlc3M7CiAtICh2b2lkKWJyb3dzaW5nQ29udGV4dENvbnRyb2xsZXJEaWRGaW5pc2hQcm9n cmVzczooV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVyICopc2VuZGVyOwogCistICh2b2lkKWJy b3dzaW5nQ29udGV4dENvbnRyb2xsZXJEaWRDaGFuZ2VkQmFja0ZvcndhcmRMaXN0OihXS0Jyb3dz aW5nQ29udGV4dENvbnRyb2xsZXIgKilzZW5kZXIgYWRkZWRJdGVtOihXS0JhY2tGb3J3YXJkTGlz dEl0ZW0gKilhZGRlZEl0ZW0gcmVtb3ZlZEl0ZW1zOihOU0FycmF5ICopcmVtb3ZlZEl0ZW1zOwor CiBAZW5kCg==