123120 2013-10-21 15:13:19 -0700 Remove platform #ifdefs from WebDataSourcePrivate.h 2013-10-21 15:44:59 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Mac Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates andersca ddkilzer oldest_to_newest 942039 0 dbates 2013-10-21 15:13:19 -0700 WebKit API/SPI headers should not use platform #ifdefs. Currently we only declare the SPI functions -[WebDataSource _setAllowToBeMemoryMapped], -[WebDataSource setDataSourceDelegate:], and -[WebDataSource dataSourceDelegate] when building with disk image cache enabled on iOS. Instead we should always declare these functions and provide a trivial implementation for them when building with disk image cache disabled. 942040 1 dbates 2013-10-21 15:17:08 -0700 <rdar://problem/15275533> 942041 2 214783 dbates 2013-10-21 15:18:31 -0700 Created attachment 214783 Patch 942048 3 dbates 2013-10-21 15:44:59 -0700 Committed r157753: <http://trac.webkit.org/changeset/157753> 214783 2013-10-21 15:18:31 -0700 2013-10-21 15:37:39 -0700 Patch bug-123120-20131021151831.patch text/plain 3547 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3NzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggM2RjNWZlYjMy YWEwZDhkNjA1MmQyMGEyNDU3YzA0ODVhODBlM2IzNC4uZjZlOTA1OTZmMmFlOGMwNTRmMWIwMDRj N2M4OTI3NjcyNmZkMmRkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEz LTEwLTIxICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1v dmUgcGxhdGZvcm0gI2lmZGVmcyBmcm9tIFdlYkRhdGFTb3VyY2VQcml2YXRlLmgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzEyMAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMTUyNzU1MzM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkRhdGFTb3VyY2UubW06CisgICAgICAgICgt W1dlYkRhdGFTb3VyY2UgX3NldEFsbG93VG9CZU1lbW9yeU1hcHBlZF0pOiBEZWZpbmUgZW1wdHkg aW1wbGVtZW50YXRpb24gd2hlbiBidWlsZGluZyB3aXRob3V0CisgICAgICAgIGRpc2sgaW1hZ2Ug Y2FjaGUgZW5hYmxlZC4KKyAgICAgICAgKC1bV2ViRGF0YVNvdXJjZSBzZXREYXRhU291cmNlRGVs ZWdhdGU6XSk6IERpdHRvLgorICAgICAgICAoLVtXZWJEYXRhU291cmNlIGRhdGFTb3VyY2VEZWxl Z2F0ZV0pOiBSZXR1cm4gbnVsbHB0ciB3aGVuIGJ1aWxkaW5nIHdpdGhvdXQgZGlzayBpbWFnZSBj YWNoZQorICAgICAgICBlbmFibGVkIG9uIGlPUy4KKyAgICAgICAgKiBXZWJWaWV3L1dlYkRhdGFT b3VyY2VQcml2YXRlLmg6IFJlbW92ZWQgcGxhdGZvcm0gI2lmZGVmcyBhZGRlZCBpbgorICAgICAg ICA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTU2OTE4PiAoaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTk4NSkKKwogMjAxMy0xMC0xOSAgSmVyIE5v YmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIHJvbGwgb3V0 IG9mIHIxNTc2OTU7IGJyb2tlIE1hYyBidWlsZHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L21hYy9XZWJWaWV3L1dlYkRhdGFTb3VyY2UubW0gYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3 L1dlYkRhdGFTb3VyY2UubW0KaW5kZXggMTE0ZGU5ZmIwODRkNTA1ZTExOWE3OWI3NWExODA3M2Zl N2FkMTBiYi4uMGVmYjJhZDA2ZWU2MWM4NjlmZThjMjNmYzI4YzU5MmJhY2M4YTczMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJEYXRhU291cmNlLm1tCisrKyBiL1Nv dXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRGF0YVNvdXJjZS5tbQpAQCAtMjA4LDkgKzIwOCw5 IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBhZGRUeXBlc0Zyb21DbGFzcyhOU011dGFibGVEaWN0aW9u YXJ5ICphbGxUeXBlcywgQ2xhc3Mgb2JqQ0NsCiAgICAgdG9Qcml2YXRlKF9wcml2YXRlKS0+bG9h ZGVyLT5zZXREZWZlck1haW5SZXNvdXJjZURhdGFMb2FkKGZsYWcpOwogfQogCi0jaWYgRU5BQkxF KERJU0tfSU1BR0VfQ0FDSEUpICYmIFBMQVRGT1JNKElPUykKIC0gKHZvaWQpX3NldEFsbG93VG9C ZU1lbW9yeU1hcHBlZAogeworI2lmIEVOQUJMRShESVNLX0lNQUdFX0NBQ0hFKSAmJiBQTEFURk9S TShJT1MpCiAgICAgUmVmUHRyPFJlc291cmNlQnVmZmVyPiBtYWluUmVzb3VyY2VCdWZmZXIgPSB0 b1ByaXZhdGUoX3ByaXZhdGUpLT5sb2FkZXItPm1haW5SZXNvdXJjZURhdGEoKTsKICAgICBpZiAo IW1haW5SZXNvdXJjZUJ1ZmZlcikKICAgICAgICAgcmV0dXJuOwpAQCAtMjM2LDE5ICsyMzYsMjUg QEAgc3RhdGljIGlubGluZSB2b2lkIGFkZFR5cGVzRnJvbUNsYXNzKE5TTXV0YWJsZURpY3Rpb25h cnkgKmFsbFR5cGVzLCBDbGFzcyBvYmpDQ2wKICAgICAgICAgcmV0dXJuOwogICAgIH0KICAgICBB U1NFUlRfTk9UX1JFQUNIRUQoKTsKKyNlbmRpZgogfQogCiAtICh2b2lkKXNldERhdGFTb3VyY2VE ZWxlZ2F0ZTooTlNPYmplY3Q8V2ViRGF0YVNvdXJjZVByaXZhdGVEZWxlZ2F0ZT4gKilkZWxlZ2F0 ZQogeworI2lmIEVOQUJMRShESVNLX0lNQUdFX0NBQ0hFKSAmJiBQTEFURk9STShJT1MpCiAgICAg QVNTRVJUKCF0b1ByaXZhdGUoX3ByaXZhdGUpLT5fZGF0YVNvdXJjZURlbGVnYXRlKTsKICAgICB0 b1ByaXZhdGUoX3ByaXZhdGUpLT5fZGF0YVNvdXJjZURlbGVnYXRlID0gZGVsZWdhdGU7CisjZW5k aWYKIH0KIAogLSAoTlNPYmplY3Q8V2ViRGF0YVNvdXJjZVByaXZhdGVEZWxlZ2F0ZT4gKilkYXRh U291cmNlRGVsZWdhdGUKIHsKKyNpZiBFTkFCTEUoRElTS19JTUFHRV9DQUNIRSkgJiYgUExBVEZP Uk0oSU9TKQogICAgIHJldHVybiB0b1ByaXZhdGUoX3ByaXZhdGUpLT5fZGF0YVNvdXJjZURlbGVn YXRlOworI2Vsc2UKKyAgICByZXR1cm4gbnVsbHB0cjsKKyNlbmRpZgogfQotI2VuZGlmIC8vIEVO QUJMRShESVNLX0lNQUdFX0NBQ0hFKSAmJiBQTEFURk9STShJT1MpCiAKIEBlbmQKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJEYXRhU291cmNlUHJpdmF0ZS5oIGIv U291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJEYXRhU291cmNlUHJpdmF0ZS5oCmluZGV4IGZm MjBmYWVlZjQ1ZDA4MzVhNmFlOWM1YzYzMmM0Zjc0NmE5OTg1YmIuLjhhOWZhMzU3ZjZkZmQwY2U3 ZjVkOWZlYjE4Nzc5MWExYzgwYzRkYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dl YlZpZXcvV2ViRGF0YVNvdXJjZVByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJW aWV3L1dlYkRhdGFTb3VyY2VQcml2YXRlLmgKQEAgLTI4LDEzICsyOCwxMSBAQAogCiAjaW1wb3J0 IDxXZWJLaXQvV2ViRGF0YVNvdXJjZS5oPgogCi0jaWYgRU5BQkxFKERJU0tfSU1BR0VfQ0FDSEUp ICYmIFBMQVRGT1JNKElPUykKIEBwcm90b2NvbCBXZWJEYXRhU291cmNlUHJpdmF0ZURlbGVnYXRl CiBAcmVxdWlyZWQKIC0gKHZvaWQpZGF0YVNvdXJjZU1lbW9yeU1hcHBlZDsKIC0gKHZvaWQpZGF0 YVNvdXJjZU1lbW9yeU1hcEZhaWxlZDsKIEBlbmQKLSNlbmRpZgogCiBAaW50ZXJmYWNlIFdlYkRh dGFTb3VyY2UgKFdlYlByaXZhdGUpCiAKQEAgLTQ3LDEwICs0NSw4IEBACiAKIC0gKHZvaWQpX3Nl dERlZmVyTWFpblJlc291cmNlRGF0YUxvYWQ6KEJPT0wpZmxhZzsKIAotI2lmIEVOQUJMRShESVNL X0lNQUdFX0NBQ0hFKSAmJiBQTEFURk9STShJT1MpCiAtICh2b2lkKV9zZXRBbGxvd1RvQmVNZW1v cnlNYXBwZWQ7CiAtICh2b2lkKXNldERhdGFTb3VyY2VEZWxlZ2F0ZTooTlNPYmplY3Q8V2ViRGF0 YVNvdXJjZVByaXZhdGVEZWxlZ2F0ZT4gKilkYXRhU291cmNlRGVsZWdhdGU7CiAtIChOU09iamVj dDxXZWJEYXRhU291cmNlUHJpdmF0ZURlbGVnYXRlPiAqKWRhdGFTb3VyY2VEZWxlZ2F0ZTsKLSNl bmRpZgogCiBAZW5kCg==