123104 2013-10-21 11:01:15 -0700 Fixing mediastream debug build 2013-10-21 12:00:59 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 thiago.lacerda webkit-unassigned commit-queue eric.carlson glenn hta jer.noble kling tommyw oldest_to_newest 941902 0 thiago.lacerda 2013-10-21 11:01:15 -0700 After https://bugs.webkit.org/show_bug.cgi?id=123075 941904 1 214751 thiago.lacerda 2013-10-21 11:04:54 -0700 Created attachment 214751 Patch 941905 2 214751 kling 2013-10-21 11:06:12 -0700 Comment on attachment 214751 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214751&action=review > Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp:47 > ASSERT(type == eventNames().tonechangeEvent); If this variable is only used for the assertion, you should change it to an ASSERT_UNUSED. 941906 3 thiago.lacerda 2013-10-21 11:08:30 -0700 (In reply to comment #2) > (From update of attachment 214751 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214751&action=review > > > Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp:47 > > ASSERT(type == eventNames().tonechangeEvent); > > If this variable is only used for the assertion, you should change it to an ASSERT_UNUSED. Fine 941935 4 214758 thiago.lacerda 2013-10-21 11:34:07 -0700 Created attachment 214758 Patch 941951 5 214758 commit-queue 2013-10-21 12:00:56 -0700 Comment on attachment 214758 Patch Clearing flags on attachment: 214758 Committed r157723: <http://trac.webkit.org/changeset/157723> 941952 6 commit-queue 2013-10-21 12:00:59 -0700 All reviewed patches have been landed. Closing bug. 214751 2013-10-21 11:04:54 -0700 2013-10-21 11:34:01 -0700 Patch bug-123104-20131021150453.patch text/plain 1660 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3NzIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjA5MGI5ZTk0MmVmMjdl ZmExZGMyYjc0ZjgzZmNhODUzNzA0NGFjYS4uMWQ5MWY4MTc4NTlkYjc5Mzg3ZmIyYjljMjI1OTU3 YTc5ODkwMzAxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEwLTIxICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIEZpeGluZyBtZWRpYXN0cmVhbSBkZWJ1ZyBidWlsZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMTA0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAg ICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vUlRDRFRNRlRvbmVDaGFuZ2VFdmVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSVENEVE1GVG9uZUNoYW5nZUV2ZW50OjpjcmVhdGUpOgorCiAyMDEz LTEwLTIxICBNaWhhaSBNYWVyZWFuICA8bW1hZXJlYW5AYWRvYmUuY29tPgogCiAgICAgICAgIFtD U1MgUmVnaW9uc10gRml4IFdISVRFU1BBQ0UgaXNzdWVzIGluIHRoZSBDU1MgZ3JhbW1hci4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDRFRNRlRvbmVD aGFuZ2VFdmVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ0RU TUZUb25lQ2hhbmdlRXZlbnQuY3BwCmluZGV4IDc2NWQ4YjJjMTM2NjRkNTIwZjhhMWRlNGQ3ODlj OTEwYjUzYzRlY2EuLmRkNzZmMDczMWM5ZGE2YWEyYWMxNjI1MWFhMWU3ZTMyODVhZTkyM2UgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDRFRNRlRvbmVD aGFuZ2VFdmVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9S VENEVE1GVG9uZUNoYW5nZUV2ZW50LmNwcApAQCAtNDIsNyArNDIsNyBAQCBQYXNzUmVmUHRyPFJU Q0RUTUZUb25lQ2hhbmdlRXZlbnQ+IFJUQ0RUTUZUb25lQ2hhbmdlRXZlbnQ6OmNyZWF0ZShjb25z dCBTdHJpbmcmCiAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBSVENEVE1GVG9uZUNoYW5nZUV2ZW50 KHRvbmUpKTsKIH0KIAotUGFzc1JlZlB0cjxSVENEVE1GVG9uZUNoYW5nZUV2ZW50PiBSVENEVE1G VG9uZUNoYW5nZUV2ZW50OjpjcmVhdGUoY29uc3QgQXRvbWljU3RyaW5nJiwgY29uc3QgUlRDRFRN RlRvbmVDaGFuZ2VFdmVudEluaXQmIGluaXRpYWxpemVyKQorUGFzc1JlZlB0cjxSVENEVE1GVG9u ZUNoYW5nZUV2ZW50PiBSVENEVE1GVG9uZUNoYW5nZUV2ZW50OjpjcmVhdGUoY29uc3QgQXRvbWlj U3RyaW5nJiB0eXBlLCBjb25zdCBSVENEVE1GVG9uZUNoYW5nZUV2ZW50SW5pdCYgaW5pdGlhbGl6 ZXIpCiB7CiAgICAgQVNTRVJUKHR5cGUgPT0gZXZlbnROYW1lcygpLnRvbmVjaGFuZ2VFdmVudCk7 CiAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBSVENEVE1GVG9uZUNoYW5nZUV2ZW50KGluaXRpYWxp emVyKSk7Cg== 214758 2013-10-21 11:34:07 -0700 2013-10-21 12:00:56 -0700 Patch bug-123104-20131021153406.patch text/plain 1736 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3NzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTc0ZGFkOThjOTQyMmM5 ZGE2NWQzYjcxYTRkMTE5NDY1OTVhYzUxOC4uMTExMzg3ZjZhN2Q0MGE0NDE3MjQzZTZjZGU5YTQw MzVjODMxNGI1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEwLTIxICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIEZpeGluZyBtZWRpYXN0cmVhbSBkZWJ1ZyBidWlsZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMTA0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAg ICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vUlRDRFRNRlRvbmVDaGFuZ2VFdmVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSVENEVE1GVG9uZUNoYW5nZUV2ZW50OjpjcmVhdGUpOgorCiAyMDEz LTEwLTIxICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBNZXJn ZSBSZW5kZXJMaXN0TWFya2VyOjpzdHlsZVdpbGxDaGFuZ2UoKSBpbnRvIHN0eWxlRGlkQ2hhbmdl KCkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ0RU TUZUb25lQ2hhbmdlRXZlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVh bS9SVENEVE1GVG9uZUNoYW5nZUV2ZW50LmNwcAppbmRleCA3NjVkOGIyYzEzNjY0ZDUyMGY4YTFk ZTRkNzg5YzkxMGI1M2M0ZWNhLi41MjZlZjJjNmIzYTEyMmMxMTNlNjBiN2JjOGU5MjRmMmQ2N2Ji Yjg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ0RU TUZUb25lQ2hhbmdlRXZlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz dHJlYW0vUlRDRFRNRlRvbmVDaGFuZ2VFdmVudC5jcHAKQEAgLTQyLDkgKzQyLDkgQEAgUGFzc1Jl ZlB0cjxSVENEVE1GVG9uZUNoYW5nZUV2ZW50PiBSVENEVE1GVG9uZUNoYW5nZUV2ZW50OjpjcmVh dGUoY29uc3QgU3RyaW5nJgogICAgIHJldHVybiBhZG9wdFJlZihuZXcgUlRDRFRNRlRvbmVDaGFu Z2VFdmVudCh0b25lKSk7CiB9CiAKLVBhc3NSZWZQdHI8UlRDRFRNRlRvbmVDaGFuZ2VFdmVudD4g UlRDRFRNRlRvbmVDaGFuZ2VFdmVudDo6Y3JlYXRlKGNvbnN0IEF0b21pY1N0cmluZyYsIGNvbnN0 IFJUQ0RUTUZUb25lQ2hhbmdlRXZlbnRJbml0JiBpbml0aWFsaXplcikKK1Bhc3NSZWZQdHI8UlRD RFRNRlRvbmVDaGFuZ2VFdmVudD4gUlRDRFRNRlRvbmVDaGFuZ2VFdmVudDo6Y3JlYXRlKGNvbnN0 IEF0b21pY1N0cmluZyYgdHlwZSwgY29uc3QgUlRDRFRNRlRvbmVDaGFuZ2VFdmVudEluaXQmIGlu aXRpYWxpemVyKQogewotICAgIEFTU0VSVCh0eXBlID09IGV2ZW50TmFtZXMoKS50b25lY2hhbmdl RXZlbnQpOworICAgIEFTU0VSVF9VTlVTRUQodHlwZSwgdHlwZSA9PSBldmVudE5hbWVzKCkudG9u ZWNoYW5nZUV2ZW50KTsKICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFJUQ0RUTUZUb25lQ2hhbmdl RXZlbnQoaW5pdGlhbGl6ZXIpKTsKIH0KIAo=