123079 2013-10-19 21:35:22 -0700 Simplify TempRegisterSet - it no longer needs to be convertible to a POD since it's no longer going to be a member of a union 2013-10-19 22:39:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 123076 1 fpizlo fpizlo atrick barraclough ggaren mark.lam mhahnenberg msaboff nrotem oliver sam oldest_to_newest 941650 0 fpizlo 2013-10-19 21:35:22 -0700 A long long time ago, when TempRegisterSet was called RegisterSet and the DFG and baseline JIT had separate codepaths for inline caching, the RegisterSet was stored in a union in StructureStubInfo and so had to have a POD version of itself. None of that is true anymore, so the POD support is just superfluous. 941651 1 214689 fpizlo 2013-10-19 21:36:20 -0700 Created attachment 214689 the patch 941661 2 214689 ggaren 2013-10-19 22:35:12 -0700 Comment on attachment 214689 the patch R=ME 941663 3 fpizlo 2013-10-19 22:39:47 -0700 Landed in http://trac.webkit.org/changeset/157696 214689 2013-10-19 21:36:20 -0700 2013-10-19 22:35:12 -0700 the patch blah.patch text/plain 3071 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3NjkzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEzLTEwLTE5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg U2ltcGxpZnkgVGVtcFJlZ2lzdGVyU2V0IC0gaXQgbm8gbG9uZ2VyIG5lZWRzIHRvIGJlIGNvbnZl cnRpYmxlIHRvIGEgUE9EIHNpbmNlIGl0J3Mgbm8gbG9uZ2VyIGdvaW5nIHRvIGJlIGEgbWVtYmVy IG9mIGEgdW5pb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyMzA3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogaml0L1RlbXBSZWdpc3RlclNldC5oOgorCiAyMDEzLTEwLTE5ICBGaWxpcCBQaXpsbyAg PGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIFJlZ2lzdGVyU2V0IHRvIFRlbXBS ZWdpc3RlclNldApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UZW1wUmVnaXN0ZXJT ZXQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RlbXBSZWdpc3Rl clNldC5oCShyZXZpc2lvbiAxNTc2OTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1Rl bXBSZWdpc3RlclNldC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENv cHlyaWdodCAoQykgMjAxMiBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5 cmlnaHQgKEMpIDIwMTIsIDIwMTMgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoK ICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdp dGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRo YXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0zMiwxOCArMzIsOSBAQAogCiAjaW5jbHVk ZSAiRlBSSW5mby5oIgogI2luY2x1ZGUgIkdQUkluZm8uaCIKLSNpbmNsdWRlIDx3dGYvQml0bWFw Lmg+CiAKIG5hbWVzcGFjZSBKU0MgewogCi1zdGF0aWMgY29uc3QgdW5zaWduZWQgdG90YWxOdW1i ZXJPZlJlZ2lzdGVycyA9Ci0gICAgR1BSSW5mbzo6bnVtYmVyT2ZSZWdpc3RlcnMgKyBGUFJJbmZv OjpudW1iZXJPZlJlZ2lzdGVyczsKLQotc3RhdGljIGNvbnN0IHVuc2lnbmVkIG51bWJlck9mQnl0 ZXNJblRlbXBSZWdpc3RlclNldCA9Ci0gICAgKHRvdGFsTnVtYmVyT2ZSZWdpc3RlcnMgKyA3KSA+ PiAzOwotCi10eXBlZGVmIHVpbnQ4X3QgVGVtcFJlZ2lzdGVyU2V0UE9EW251bWJlck9mQnl0ZXNJ blRlbXBSZWdpc3RlclNldF07Ci0KIGNsYXNzIFRlbXBSZWdpc3RlclNldCB7CiBwdWJsaWM6CiAg ICAgVGVtcFJlZ2lzdGVyU2V0KCkKQEAgLTUyLDIwICs0Myw2IEBAIHB1YmxpYzoKICAgICAgICAg ICAgIG1fc2V0W2ldID0gMDsKICAgICB9CiAgICAgCi0gICAgVGVtcFJlZ2lzdGVyU2V0KGNvbnN0 IFRlbXBSZWdpc3RlclNldFBPRCYgb3RoZXIpCi0gICAgewotICAgICAgICBmb3IgKHVuc2lnbmVk IGkgPSBudW1iZXJPZkJ5dGVzSW5UZW1wUmVnaXN0ZXJTZXQ7IGktLTspCi0gICAgICAgICAgICBt X3NldFtpXSA9IG90aGVyW2ldOwotICAgIH0KLSAgICAKLSAgICBjb25zdCBUZW1wUmVnaXN0ZXJT ZXRQT0QmIGFzUE9EKCkgY29uc3QgeyByZXR1cm4gbV9zZXQ7IH0KLSAgICAKLSAgICB2b2lkIGNv cHlJbmZvKFRlbXBSZWdpc3RlclNldFBPRCYgb3RoZXIpIGNvbnN0Ci0gICAgewotICAgICAgICBm b3IgKHVuc2lnbmVkIGkgPSBudW1iZXJPZkJ5dGVzSW5UZW1wUmVnaXN0ZXJTZXQ7IGktLTspCi0g ICAgICAgICAgICBvdGhlcltpXSA9IG1fc2V0W2ldOwotICAgIH0KLSAgICAKICAgICB2b2lkIHNl dChHUFJSZWcgcmVnKQogICAgIHsKICAgICAgICAgc2V0Qml0KEdQUkluZm86OnRvSW5kZXgocmVn KSk7CkBAIC0yMDEsNyArMTc4LDEzIEBAIHByaXZhdGU6CiAgICAgICAgIHJldHVybiAhIShtX3Nl dFtpID4+IDNdICYgKDEgPDwgKGkgJiA3KSkpOwogICAgIH0KICAgICAKLSAgICBUZW1wUmVnaXN0 ZXJTZXRQT0QgbV9zZXQ7CisgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIHRvdGFsTnVtYmVyT2ZS ZWdpc3RlcnMgPQorICAgICAgICBHUFJJbmZvOjpudW1iZXJPZlJlZ2lzdGVycyArIEZQUkluZm86 Om51bWJlck9mUmVnaXN0ZXJzOworICAgIAorICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBudW1i ZXJPZkJ5dGVzSW5UZW1wUmVnaXN0ZXJTZXQgPQorICAgICAgICAodG90YWxOdW1iZXJPZlJlZ2lz dGVycyArIDcpID4+IDM7CisKKyAgICB1aW50OF90IG1fc2V0W251bWJlck9mQnl0ZXNJblRlbXBS ZWdpc3RlclNldF07CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBKU0MKQEAgLTIxMCwxMSArMTkzLDEw IEBAIHByaXZhdGU6CiAKIG5hbWVzcGFjZSBKU0MgewogCi0vLyBEZWZpbmUgVGVtcFJlZ2lzdGVy U2V0UE9EIHRvIHNvbWV0aGluZyB0aGF0IGlzIGEgUE9ELCBidXQgaXMgb3RoZXJ3aXNlIHVzZWxl c3MsCi0vLyB0byBtYWtlIGl0IGVhc2llciB0byByZWZlciB0byB0aGlzIHR5cGUgaW4gY29kZSB0 aGF0IG1heSBiZSBjb21waWxlZCB3aGVuCi0vLyB0aGUgREZHIGlzIGRpc2FibGVkLgorLy8gRGVm aW5lIFRlbXBSZWdpc3RlclNldCB0byBzb21ldGhpbmcsIHRvIG1ha2UgaXQgZWFzaWVyIHRvIHJl ZmVyIHRvIHRoaXMgdHlwZSBpbiBjb2RlIHRoYXQKKy8vIG1ha2UgYmUgY29tcGlsZWQgd2hlbiB0 aGUgSklUIGlzIGRpc2FibGVkLgogCi1zdHJ1Y3QgVGVtcFJlZ2lzdGVyU2V0UE9EIHsgfTsKK3N0 cnVjdCBUZW1wUmVnaXN0ZXJTZXQgeyB9OwogCiB9IC8vIG5hbWVzcGFjZSBKU0MKIAo=