123066 2013-10-19 12:45:31 -0700 Mac DumpRenderTree builds without NDEBUG even in release mode 2013-10-19 16:17:01 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac Unspecified RESOLVED FIXED P2 Major --- 86914 1 ap ap commit-queue mrowe oldest_to_newest 941541 0 ap 2013-10-19 12:45:31 -0700 Crazy. I noticed this when I tried to use RefPtr with an ArrayBufferView passed from a test - since that was created in NDEBUG code, the object lacked these variables, and assertions were off: #if CHECK_REF_COUNTED_LIFECYCLE bool m_deletionHasBegun; bool m_adoptionIsRequired; ThreadRestrictionVerifier m_verifier; #endif 941542 1 214661 ap 2013-10-19 12:53:25 -0700 Created attachment 214661 proposed fix 941595 2 214674 ap 2013-10-19 14:50:30 -0700 Created attachment 214674 proposed fix Dan found that this was incorrect - it fixed release builds, but added NDEBUG to debugs ones too. Changed to more closely follow what other projects do. 941609 3 214674 commit-queue 2013-10-19 16:16:59 -0700 Comment on attachment 214674 proposed fix Clearing flags on attachment: 214674 Committed r157686: <http://trac.webkit.org/changeset/157686> 941610 4 commit-queue 2013-10-19 16:17:01 -0700 All reviewed patches have been landed. Closing bug. 214661 2013-10-19 12:53:25 -0700 2013-10-19 14:50:30 -0700 proposed fix NDEBUG.txt text/plain 1910 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NzY3MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEzLTEwLTE5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIE1hYyBEdW1wUmVuZGVyVHJlZSBidWlsZHMgd2l0aG91dCBOREVCVUcgZXZl biBpbiByZWxlYXNlIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMzA2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25m aWc6IFVzZSB0aGUgc2FtZSBwYXR0ZXJuCisgICAgICAgIGFzIFdlYktpdFRlc3RSdW5uZXIuCisK IDIwMTMtMTAtMTggIFJpayBDYWJhbmllciA8Y2FiYW5pZXJAYWRvYmUuY29tPgogICAgICAgICBB ZGQgUmlrIENhYmFuaWVyIHRvIGxpc3Qgb2YgY29tbWl0dGVycwogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMDMxCkluZGV4OiBUb29scy9EdW1wUmVu ZGVyVHJlZS9tYWMvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBU b29scy9EdW1wUmVuZGVyVHJlZS9tYWMvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwkocmV2 aXNpb24gMTU3NjcyKQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0NvbmZpZ3VyYXRpb25z L0Jhc2UueGNjb25maWcJKHdvcmtpbmcgY29weSkKQEAgLTI1LDcgKzI1LDcgQEAgQ0xBTkdfQ1hY X0xBTkdVQUdFX1NUQU5EQVJEID0gZ251KysweDsKIENMQU5HX0NYWF9MSUJSQVJZID0gbGliYysr OwogQ0xBTkdfV0FSTl9DWFgwWF9FWFRFTlNJT05TID0gTk87CiBIRUFERVJfU0VBUkNIX1BBVEhT ID0gJChCVUlMVF9QUk9EVUNUU19ESVIpL3Vzci9sb2NhbC9pbmNsdWRlIEZvcndhcmRpbmdIZWFk ZXJzIG1hYy9JbnRlcm5hbEhlYWRlcnMgJChORVhUX1JPT1QpL3Vzci9sb2NhbC9pbmNsdWRlL1dl YkNvcmVUZXN0U3VwcG9ydCAkKFNSQ1JPT1QpLy4uLy4uL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p Y3U7Ci1HQ0NfUFJFUFJPQ0VTU09SX0RFRklOSVRJT05TID0gRU5BQkxFX0RBU0hCT0FSRF9TVVBQ T1JUIFdFQktJVF9WRVJTSU9OX01JTl9SRVFVSVJFRD1XRUJLSVRfVkVSU0lPTl9MQVRFU1Q7CitH Q0NfUFJFUFJPQ0VTU09SX0RFRklOSVRJT05TID0gJChERUJVR19ERUZJTkVTKSBFTkFCTEVfREFT SEJPQVJEX1NVUFBPUlQgV0VCS0lUX1ZFUlNJT05fTUlOX1JFUVVJUkVEPVdFQktJVF9WRVJTSU9O X0xBVEVTVDsKIERFQlVHX0lORk9STUFUSU9OX0ZPUk1BVCA9IGR3YXJmLXdpdGgtZHN5bTsKIFBS RUJJTkRJTkcgPSBOTwogR0NDX0NfTEFOR1VBR0VfU1RBTkRBUkQgPSBnbnU5OQpAQCAtNDAsNiAr NDAsMTAgQEAgR0NDX1dBUk5fVU5VU0VEX1ZBUklBQkxFID0gWUVTCiBXQVJOSU5HX0NGTEFHUyA9 IC1XYWxsIC1XIC1Xbm8tdW51c2VkLXBhcmFtZXRlciAtV3VuZGVmCiBMSU5LRVJfRElTUExBWVNf TUFOR0xFRF9OQU1FUyA9IFlFUzsKIAorREVCVUdfREVGSU5FU19kZWJ1ZyA9IDsKK0RFQlVHX0RF RklORVNfbm9ybWFsID0gTkRFQlVHOworREVCVUdfREVGSU5FUyA9ICQoREVCVUdfREVGSU5FU18k KENVUlJFTlRfVkFSSUFOVCkpOworCiBUQVJHRVRfTUFDX09TX1hfVkVSU0lPTl9NQUpPUiA9ICQo TUFDX09TX1hfVkVSU0lPTl9NQUpPUik7CiAKIAo= 214674 2013-10-19 14:50:30 -0700 2013-10-19 16:16:59 -0700 proposed fix NDEBUG.txt text/plain 2534 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NzY4MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEzLTEwLTE5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIE1hYyBEdW1wUmVuZGVyVHJlZSBidWlsZHMgd2l0aG91dCBOREVCVUcgZXZl biBpbiByZWxlYXNlIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyMzA2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUueGNvZGVwcm9qL3Byb2pl Y3QucGJ4cHJvajoKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvQ29uZmlndXJhdGlvbnMv QmFzZS54Y2NvbmZpZzoKKyAgICAgICAgVXNlIHRoZSBzYW1lIHBhdHRlcm4gYXMgV2ViQ29yZSBh bmQgV2ViS2l0VGVzdFJ1bm5lci4KKwogMjAxMy0xMC0xOSAgWmFuIERvYmVyc2VrICA8emRvYmVy c2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTU1MzczKTogTWFjIFdLMiBF V1MgYm90cyBpcyBhY3R1YWxseSBNYWMgV0sxIGRlYnVnCkluZGV4OiBUb29scy9EdW1wUmVuZGVy VHJlZS9EdW1wUmVuZGVyVHJlZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLnhjb2RlcHJvai9wcm9qZWN0 LnBieHByb2oJKHJldmlzaW9uIDE1NzY3MikKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBS ZW5kZXJUcmVlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oJKHdvcmtpbmcgY29weSkKQEAgLTEx MDAsNiArMTEwMCw3IEBACiAJCQlpc2EgPSBYQ0J1aWxkQ29uZmlndXJhdGlvbjsKIAkJCWJhc2VD b25maWd1cmF0aW9uUmVmZXJlbmNlID0gQkNCMjgyRjQwQ0ZBNzQ1MDAwN0U1MzNFIC8qIERlYnVn UmVsZWFzZS54Y2NvbmZpZyAqLzsKIAkJCWJ1aWxkU2V0dGluZ3MgPSB7CisJCQkJREVCVUdfREVG SU5FUyA9ICIkKERFQlVHX0RFRklORVNfZGVidWcpIjsKIAkJCQlHQ0NfT1BUSU1JWkFUSU9OX0xF VkVMID0gMDsKIAkJCX07CiAJCQluYW1lID0gRGVidWc7CkluZGV4OiBUb29scy9EdW1wUmVuZGVy VHJlZS9tYWMvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9EdW1wUmVuZGVyVHJlZS9tYWMvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwkocmV2aXNp b24gMTU3NjcyKQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0NvbmZpZ3VyYXRpb25zL0Jh c2UueGNjb25maWcJKHdvcmtpbmcgY29weSkKQEAgLTI1LDcgKzI1LDcgQEAgQ0xBTkdfQ1hYX0xB TkdVQUdFX1NUQU5EQVJEID0gZ251KysweDsKIENMQU5HX0NYWF9MSUJSQVJZID0gbGliYysrOwog Q0xBTkdfV0FSTl9DWFgwWF9FWFRFTlNJT05TID0gTk87CiBIRUFERVJfU0VBUkNIX1BBVEhTID0g JChCVUlMVF9QUk9EVUNUU19ESVIpL3Vzci9sb2NhbC9pbmNsdWRlIEZvcndhcmRpbmdIZWFkZXJz IG1hYy9JbnRlcm5hbEhlYWRlcnMgJChORVhUX1JPT1QpL3Vzci9sb2NhbC9pbmNsdWRlL1dlYkNv cmVUZXN0U3VwcG9ydCAkKFNSQ1JPT1QpLy4uLy4uL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pY3U7 Ci1HQ0NfUFJFUFJPQ0VTU09SX0RFRklOSVRJT05TID0gRU5BQkxFX0RBU0hCT0FSRF9TVVBQT1JU IFdFQktJVF9WRVJTSU9OX01JTl9SRVFVSVJFRD1XRUJLSVRfVkVSU0lPTl9MQVRFU1Q7CitHQ0Nf UFJFUFJPQ0VTU09SX0RFRklOSVRJT05TID0gJChERUJVR19ERUZJTkVTKSBFTkFCTEVfREFTSEJP QVJEX1NVUFBPUlQgV0VCS0lUX1ZFUlNJT05fTUlOX1JFUVVJUkVEPVdFQktJVF9WRVJTSU9OX0xB VEVTVDsKIERFQlVHX0lORk9STUFUSU9OX0ZPUk1BVCA9IGR3YXJmLXdpdGgtZHN5bTsKIFBSRUJJ TkRJTkcgPSBOTwogR0NDX0NfTEFOR1VBR0VfU1RBTkRBUkQgPSBnbnU5OQpAQCAtNDAsNiArNDAs MTAgQEAgR0NDX1dBUk5fVU5VU0VEX1ZBUklBQkxFID0gWUVTCiBXQVJOSU5HX0NGTEFHUyA9IC1X YWxsIC1XIC1Xbm8tdW51c2VkLXBhcmFtZXRlciAtV3VuZGVmCiBMSU5LRVJfRElTUExBWVNfTUFO R0xFRF9OQU1FUyA9IFlFUzsKIAorREVCVUdfREVGSU5FU19kZWJ1ZyA9IDsKK0RFQlVHX0RFRklO RVNfbm9ybWFsID0gTkRFQlVHOworREVCVUdfREVGSU5FUyA9ICQoREVCVUdfREVGSU5FU18kKENV UlJFTlRfVkFSSUFOVCkpOworCiBUQVJHRVRfTUFDX09TX1hfVkVSU0lPTl9NQUpPUiA9ICQoTUFD X09TX1hfVkVSU0lPTl9NQUpPUik7CiAKIAo=