123060 2013-10-19 04:54:04 -0700 Build failure for architecture with 4 argument registers 2013-10-19 07:33:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue fpizlo msaboff oliver oldest_to_newest 941487 0 jbriance 2013-10-19 04:54:04 -0700 There are missing setupArgumentsWithExecState() prototypes for architecture with 4 argument registers. There is also SH4 specific code to be removed since r157660. 941489 1 214650 jbriance 2013-10-19 05:00:46 -0700 Created attachment 214650 Add missing setupArgumentsWithExecState() prototypes + remove SH4 specific code 941502 2 214650 commit-queue 2013-10-19 07:33:21 -0700 Comment on attachment 214650 Add missing setupArgumentsWithExecState() prototypes + remove SH4 specific code Clearing flags on attachment: 214650 Committed r157668: <http://trac.webkit.org/changeset/157668> 941503 3 commit-queue 2013-10-19 07:33:23 -0700 All reviewed patches have been landed. Closing bug. 214650 2013-10-19 05:00:46 -0700 2013-10-19 07:33:21 -0700 Add missing setupArgumentsWithExecState() prototypes + remove SH4 specific code bug-123060.patch text/plain 5100 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3NjY0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDEzLTEwLTE5ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIEZpeCBidWlsZCBmYWlsdXJlIGZvciBhcmNoaXRlY3R1cmVzIHdpdGggNCBhcmd1bWVu dCByZWdpc3RlcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjMwNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGQgbWlzc2luZyBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoKSBwcm90b3R5cGVz IGZvciBhcmNoaXRlY3R1cmUgd2l0aCA0IGFyZ3VtZW50IHJlZ2lzdGVycy4KKyAgICAgICAgUmVt b3ZlIFNINCBzcGVjaWZpYyBjb2RlIG5vIGxvbmdlciBuZWVkZWQgc2luY2UgY2FsbE9wZXJhdGlv biBwcm90b3R5cGUgY2hhbmdlIGluIHIxNTc2NjAuCisKKyAgICAgICAgKiBkZmcvREZHU3BlY3Vs YXRpdmVKSVQuaDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y2FsbE9wZXJh dGlvbik6CisgICAgICAgICogaml0L0NDYWxsSGVscGVycy5oOgorICAgICAgICAoSlNDOjpDQ2Fs bEhlbHBlcnM6OnNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZSk6CisgICAgICAgICogaml0L0pJ VElubGluZXMuaDoKKyAgICAgICAgKEpTQzo6SklUOjpjYWxsT3BlcmF0aW9uKToKKwogMjAxMy0x MC0xOCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIGZpeCBGVEwgYnVpbGQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1Nw ZWN1bGF0aXZlSklULmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdTcGVjdWxhdGl2ZUpJVC5oCShyZXZpc2lvbiAxNTc2NjQpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgJKHdvcmtpbmcgY29weSkKQEAgLTE2MjMsMTIg KzE2MjMsNyBAQCBwdWJsaWM6CiAgICAgfQogICAgIEpJVENvbXBpbGVyOjpDYWxsIGNhbGxPcGVy YXRpb24oVl9KSVRPcGVyYXRpb25fRVNzaUpKSSBvcGVyYXRpb24sIFN0cnVjdHVyZVN0dWJJbmZv KiBzdHViSW5mbywgR1BSUmVnIGFyZzFUYWcsIEdQUlJlZyBhcmcxUGF5bG9hZCwgR1BSUmVnIGFy ZzJQYXlsb2FkLCBTdHJpbmdJbXBsKiB1aWQpCiAgICAgewotI2lmIENQVShTSDQpCi0gICAgICAg IC8vIFdlIGhhdmUgdG8gcHV0IHVpZCBpbiB0aGUgNHRoIGFyZ3VtZW50IHJlZ2lzdGVyIChyNykg YXMgNjQtYml0IHZhbHVlIGFyZzIgd2lsbCBiZSBwdXQgb24gc3RhY2sgZm9yIHNoNCBhcmNoaXRl Y3VyZS4KLSAgICAgICAgbV9qaXQuc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKFRydXN0ZWRJ bW1QdHIoc3R1YkluZm8pLCBhcmcxUGF5bG9hZCwgYXJnMVRhZywgVHJ1c3RlZEltbVB0cih1aWQp LCBhcmcyUGF5bG9hZCwgVHJ1c3RlZEltbTMyKEpTVmFsdWU6OkNlbGxUYWcpKTsKLSNlbHNlCiAg ICAgICAgIG1faml0LnNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShUcnVzdGVkSW1tUHRyKHN0 dWJJbmZvKSwgYXJnMVBheWxvYWQsIGFyZzFUYWcsIGFyZzJQYXlsb2FkLCBUcnVzdGVkSW1tMzIo SlNWYWx1ZTo6Q2VsbFRhZyksIFRydXN0ZWRJbW1QdHIodWlkKSk7Ci0jZW5kaWYKICAgICAgICAg cmV0dXJuIGFwcGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hlY2sob3BlcmF0aW9uKTsKICAgICB9CiAg ICAgSklUQ29tcGlsZXI6OkNhbGwgY2FsbE9wZXJhdGlvbihWX0pJVE9wZXJhdGlvbl9FQ0pKIG9w ZXJhdGlvbiwgR1BSUmVnIGFyZzEsIEdQUlJlZyBhcmcyVGFnLCBHUFJSZWcgYXJnMlBheWxvYWQs IEdQUlJlZyBhcmczVGFnLCBHUFJSZWcgYXJnM1BheWxvYWQpCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L0NDYWxsSGVscGVycy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvQ0NhbGxIZWxwZXJzLmgJKHJldmlzaW9uIDE1NzY2NCkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvQ0NhbGxIZWxwZXJzLmgJKHdvcmtpbmcgY29weSkKQEAgLTExOTYs NiArMTE5NiwxOCBAQCBwdWJsaWM6CiAgICAgICAgIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0 ZShhcmcxLCBhcmcyLCBhcmczKTsKICAgICB9CiAKKyAgICBBTFdBWVNfSU5MSU5FIHZvaWQgc2V0 dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKFRydXN0ZWRJbW1QdHIgYXJnMSwgR1BSUmVnIGFyZzIs IEdQUlJlZyBhcmczLCBUcnVzdGVkSW1tUHRyIGFyZzQpCisgICAgeworICAgICAgICBwb2tlKGFy ZzQsIFBPS0VfQVJHVU1FTlRfT0ZGU0VUKTsKKyAgICAgICAgc2V0dXBBcmd1bWVudHNXaXRoRXhl Y1N0YXRlKGFyZzEsIGFyZzIsIGFyZzMpOworICAgIH0KKworICAgIEFMV0FZU19JTkxJTkUgdm9p ZCBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoVHJ1c3RlZEltbVB0ciBhcmcxLCBHUFJSZWcg YXJnMiwgVHJ1c3RlZEltbTMyIGFyZzMsIFRydXN0ZWRJbW1QdHIgYXJnNCkKKyAgICB7CisgICAg ICAgIHBva2UoYXJnNCwgUE9LRV9BUkdVTUVOVF9PRkZTRVQpOworICAgICAgICBzZXR1cEFyZ3Vt ZW50c1dpdGhFeGVjU3RhdGUoYXJnMSwgYXJnMiwgYXJnMyk7CisgICAgfQorCiAgICAgQUxXQVlT X0lOTElORSB2b2lkIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShUcnVzdGVkSW1tUHRyIGFy ZzEsIEdQUlJlZyBhcmcyLCBHUFJSZWcgYXJnMywgVHJ1c3RlZEltbTMyIGFyZzQsIFRydXN0ZWRJ bW1QdHIgYXJnNSkKICAgICB7CiAgICAgICAgIHBva2UoYXJnNSwgUE9LRV9BUkdVTUVOVF9PRkZT RVQgKyAxKTsKQEAgLTEzNDksNiArMTM2MSwyMiBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICBw b2tlKGFyZzYsIFBPS0VfQVJHVU1FTlRfT0ZGU0VUICsgMik7CiAgICAgICAgIHBva2UoYXJnNSwg UE9LRV9BUkdVTUVOVF9PRkZTRVQgKyAxKTsKKyAgICAgICAgcG9rZShhcmc0LCBQT0tFX0FSR1VN RU5UX09GRlNFVCk7CisgICAgICAgIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShhcmcxLCBh cmcyLCBhcmczKTsKKyAgICB9CisKKyAgICBBTFdBWVNfSU5MSU5FIHZvaWQgc2V0dXBBcmd1bWVu dHNXaXRoRXhlY1N0YXRlKFRydXN0ZWRJbW1QdHIgYXJnMSwgR1BSUmVnIGFyZzIsIEdQUlJlZyBh cmczLCBHUFJSZWcgYXJnNCwgR1BSUmVnIGFyZzUsIFRydXN0ZWRJbW1QdHIgYXJnNikKKyAgICB7 CisgICAgICAgIHBva2UoYXJnNiwgUE9LRV9BUkdVTUVOVF9PRkZTRVQgKyAyKTsKKyAgICAgICAg cG9rZShhcmc1LCBQT0tFX0FSR1VNRU5UX09GRlNFVCArIDEpOworICAgICAgICBwb2tlKGFyZzQs IFBPS0VfQVJHVU1FTlRfT0ZGU0VUKTsKKyAgICAgICAgc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0 YXRlKGFyZzEsIGFyZzIsIGFyZzMpOworICAgIH0KKworICAgIEFMV0FZU19JTkxJTkUgdm9pZCBz ZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoVHJ1c3RlZEltbVB0ciBhcmcxLCBHUFJSZWcgYXJn MiwgR1BSUmVnIGFyZzMsIEdQUlJlZyBhcmc0LCBUcnVzdGVkSW1tMzIgYXJnNSwgVHJ1c3RlZElt bVB0ciBhcmc2KQorICAgIHsKKyAgICAgICAgcG9rZShhcmc2LCBQT0tFX0FSR1VNRU5UX09GRlNF VCArIDIpOworICAgICAgICBwb2tlKGFyZzUsIFBPS0VfQVJHVU1FTlRfT0ZGU0VUICsgMSk7CiAg ICAgICAgIHBva2UoYXJnNCwgUE9LRV9BUkdVTUVOVF9PRkZTRVQpOwogICAgICAgICBzZXR1cEFy Z3VtZW50c1dpdGhFeGVjU3RhdGUoYXJnMSwgYXJnMiwgYXJnMyk7CiAgICAgfQpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRJbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRJbmxpbmVzLmgJKHJldmlzaW9uIDE1NzY2NCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUSW5saW5lcy5oCSh3b3JraW5nIGNvcHkpCkBAIC01 MjIsMTIgKzUyMiw3IEBAIEFMV0FZU19JTkxJTkUgTWFjcm9Bc3NlbWJsZXI6OkNhbGwgSklUOjoK IAogQUxXQVlTX0lOTElORSBNYWNyb0Fzc2VtYmxlcjo6Q2FsbCBKSVQ6OmNhbGxPcGVyYXRpb24o Vl9KSVRPcGVyYXRpb25fRVNzaUpKSSBvcGVyYXRpb24sIFN0cnVjdHVyZVN0dWJJbmZvKiBzdHVi SW5mbywgUmVnaXN0ZXJJRCByZWdPcDFUYWcsIFJlZ2lzdGVySUQgcmVnT3AxUGF5bG9hZCwgUmVn aXN0ZXJJRCByZWdPcDJUYWcsIFJlZ2lzdGVySUQgcmVnT3AyUGF5bG9hZCwgU3RyaW5nSW1wbCog dWlkKQogewotI2lmIENQVShTSDQpCi0gICAgLy8gV2UgaGF2ZSB0byBwdXQgdWlkIGluIHRoZSA0 dGggYXJndW1lbnQgcmVnaXN0ZXIgKHI3KSBhcyA2NC1iaXQgdmFsdWUgcmVnT3AyIHdpbGwgYmUg cHV0IG9uIHN0YWNrIGZvciBzaDQgYXJjaGl0ZWN1cmUuCi0gICAgc2V0dXBBcmd1bWVudHNXaXRo RXhlY1N0YXRlKFRydXN0ZWRJbW1QdHIoc3R1YkluZm8pLCByZWdPcDFQYXlsb2FkLCByZWdPcDFU YWcsIFRydXN0ZWRJbW1QdHIodWlkKSwgcmVnT3AyUGF5bG9hZCwgcmVnT3AyVGFnKTsKLSNlbHNl CiAgICAgc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKFRydXN0ZWRJbW1QdHIoc3R1YkluZm8p LCByZWdPcDFQYXlsb2FkLCByZWdPcDFUYWcsIHJlZ09wMlBheWxvYWQsIHJlZ09wMlRhZywgVHJ1 c3RlZEltbVB0cih1aWQpKTsKLSNlbmRpZgogICAgIHJldHVybiBhcHBlbmRDYWxsV2l0aEV4Y2Vw dGlvbkNoZWNrKG9wZXJhdGlvbik7CiB9CiAK