<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>123053</bug_id>
          
          <creation_ts>2013-10-18 17:53:59 -0700</creation_ts>
          <short_desc>libWebCoreTestSupport should have explicit exports</short_desc>
          <delta_ts>2013-10-19 07:32:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Filip Pizlo">fpizlo</assigned_to>
          <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>941414</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2013-10-18 17:53:59 -0700</bug_when>
    <thetext>libWebCoreTestSupport should have explicit exports</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>941415</commentid>
    <comment_count>1</comment_count>
      <attachid>214625</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2013-10-18 17:54:31 -0700</bug_when>
    <thetext>Created attachment 214625
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>941422</commentid>
    <comment_count>2</comment_count>
      <attachid>214625</attachid>
    <who name="Build Bot">buildbot</who>
    <bug_when>2013-10-18 18:33:29 -0700</bug_when>
    <thetext>Comment on attachment 214625
Patch

Attachment 214625 did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/5818039</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>941425</commentid>
    <comment_count>3</comment_count>
      <attachid>214630</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2013-10-18 18:42:40 -0700</bug_when>
    <thetext>Created attachment 214630
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>941500</commentid>
    <comment_count>4</comment_count>
      <attachid>214630</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-10-19 07:32:17 -0700</bug_when>
    <thetext>Comment on attachment 214630
Patch

Clearing flags on attachment: 214630

Committed r157667: &lt;http://trac.webkit.org/changeset/157667&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>941501</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-10-19 07:32:19 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>214625</attachid>
            <date>2013-10-18 17:54:31 -0700</date>
            <delta_ts>2013-10-18 18:42:38 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-123053-20131018175430.patch</filename>
            <type>text/plain</type>
            <size>1827</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NzY1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEwLTE4ICBGaWxpcCBQ
aXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAgbGliV2ViQ29yZVRlc3RTdXBwb3J0
IHNob3VsZCBoYXZlIGV4cGxpY2l0IGV4cG9ydHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzA1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlIGlzIG5vIGNo
YW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL1dlYkNvcmVUZXN0
U3VwcG9ydC54Y2NvbmZpZzoKKyAgICAgICAgKiB0ZXN0aW5nL2pzL1dlYkNvcmVUZXN0U3VwcG9y
dC5oOgorCiAyMDEzLTEwLTE4ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t
PgogCiAgICAgICAgIFJlbW90ZSBMYXllciBUcmVlOiBEb3VibGUtYnVmZmVyaW5nIGFuZCBtaW5p
bWl6YXRpb24gb2YgcmVwYWludHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25z
L1dlYkNvcmVUZXN0U3VwcG9ydC54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y
ZS9Db25maWd1cmF0aW9ucy9XZWJDb3JlVGVzdFN1cHBvcnQueGNjb25maWcJKHJldmlzaW9uIDE1
NzY1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL1dlYkNvcmVUZXN0U3VwcG9y
dC54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtNDQsNSArNDQsNiBAQCBEWUxJQl9JTlNUQUxM
X05BTUVfQkFTRV9SZWxlYXNlID0gJChEWUxJCiBQUk9EVUNUX05BTUUgPSBXZWJDb3JlVGVzdFN1
cHBvcnQ7CiBFWEVDVVRBQkxFX1BSRUZJWCA9IGxpYjsKIEVYUE9SVEVEX1NZTUJPTFNfRklMRSA9
IDsKK0dDQ19TWU1CT0xTX1BSSVZBVEVfRVhURVJOID0gWUVTOwogT1RIRVJfTERGTEFHUyA9ICQo
QVNBTl9PVEhFUl9MREZMQUdTKTsKIFNFQ1RPUkRFUl9GTEFHUyA9IDsKSW5kZXg6IFNvdXJjZS9X
ZWJDb3JlL3Rlc3RpbmcvanMvV2ViQ29yZVRlc3RTdXBwb3J0LmgKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL1dlYkNvcmUvdGVzdGluZy9qcy9XZWJDb3JlVGVzdFN1cHBvcnQuaAkocmV2aXNpb24gMTU3
NjU2KQorKysgU291cmNlL1dlYkNvcmUvdGVzdGluZy9qcy9XZWJDb3JlVGVzdFN1cHBvcnQuaAko
d29ya2luZyBjb3B5KQpAQCAtMzAsOCArMzAsOCBAQCB0eXBlZGVmIGNvbnN0IHN0cnVjdCBPcGFx
dWVKU0NvbnRleHQqIEpTCiAKIG5hbWVzcGFjZSBXZWJDb3JlVGVzdFN1cHBvcnQgewogCi12b2lk
IGluamVjdEludGVybmFsc09iamVjdChKU0NvbnRleHRSZWYpOwotdm9pZCByZXNldEludGVybmFs
c09iamVjdChKU0NvbnRleHRSZWYpOwordm9pZCBpbmplY3RJbnRlcm5hbHNPYmplY3QoSlNDb250
ZXh0UmVmKSBXVEZfRVhQT1JUX1BSSVZBVEU7Cit2b2lkIHJlc2V0SW50ZXJuYWxzT2JqZWN0KEpT
Q29udGV4dFJlZikgV1RGX0VYUE9SVF9QUklWQVRFOwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl
CiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>214630</attachid>
            <date>2013-10-18 18:42:40 -0700</date>
            <delta_ts>2013-10-19 07:32:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-123053-20131018184239.patch</filename>
            <type>text/plain</type>
            <size>1958</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NzY1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTEwLTE4ICBGaWxpcCBQ
aXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAgbGliV2ViQ29yZVRlc3RTdXBwb3J0
IHNob3VsZCBoYXZlIGV4cGxpY2l0IGV4cG9ydHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzA1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlIGlzIG5vIGNo
YW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL1dlYkNvcmVUZXN0
U3VwcG9ydC54Y2NvbmZpZzoKKyAgICAgICAgKiB0ZXN0aW5nL2pzL1dlYkNvcmVUZXN0U3VwcG9y
dC5oOgorCiAyMDEzLTEwLTE4ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t
PgogCiAgICAgICAgIFJlbW90ZSBMYXllciBUcmVlOiBEb3VibGUtYnVmZmVyaW5nIGFuZCBtaW5p
bWl6YXRpb24gb2YgcmVwYWludHMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25z
L1dlYkNvcmVUZXN0U3VwcG9ydC54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y
ZS9Db25maWd1cmF0aW9ucy9XZWJDb3JlVGVzdFN1cHBvcnQueGNjb25maWcJKHJldmlzaW9uIDE1
NzY1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL1dlYkNvcmVUZXN0U3VwcG9y
dC54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtNDQsNSArNDQsNiBAQCBEWUxJQl9JTlNUQUxM
X05BTUVfQkFTRV9SZWxlYXNlID0gJChEWUxJCiBQUk9EVUNUX05BTUUgPSBXZWJDb3JlVGVzdFN1
cHBvcnQ7CiBFWEVDVVRBQkxFX1BSRUZJWCA9IGxpYjsKIEVYUE9SVEVEX1NZTUJPTFNfRklMRSA9
IDsKK0dDQ19TWU1CT0xTX1BSSVZBVEVfRVhURVJOID0gWUVTOwogT1RIRVJfTERGTEFHUyA9ICQo
QVNBTl9PVEhFUl9MREZMQUdTKTsKIFNFQ1RPUkRFUl9GTEFHUyA9IDsKSW5kZXg6IFNvdXJjZS9X
ZWJDb3JlL3Rlc3RpbmcvanMvV2ViQ29yZVRlc3RTdXBwb3J0LmgKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL1dlYkNvcmUvdGVzdGluZy9qcy9XZWJDb3JlVGVzdFN1cHBvcnQuaAkocmV2aXNpb24gMTU3
NjU2KQorKysgU291cmNlL1dlYkNvcmUvdGVzdGluZy9qcy9XZWJDb3JlVGVzdFN1cHBvcnQuaAko
d29ya2luZyBjb3B5KQpAQCAtMjgsMTAgKzI4LDE2IEBACiAKIHR5cGVkZWYgY29uc3Qgc3RydWN0
IE9wYXF1ZUpTQ29udGV4dCogSlNDb250ZXh0UmVmOwogCisjaWYgUExBVEZPUk0oTUFDKQorI2Rl
ZmluZSBURVNUX1NVUFBPUlRfRVhQT1JUIFdURl9FWFBPUlRfUFJJVkFURQorI2Vsc2UKKyNkZWZp
bmUgVEVTVF9TVVBQT1JUX0VYUE9SVAorI2VuZGlmCisKIG5hbWVzcGFjZSBXZWJDb3JlVGVzdFN1
cHBvcnQgewogCi12b2lkIGluamVjdEludGVybmFsc09iamVjdChKU0NvbnRleHRSZWYpOwotdm9p
ZCByZXNldEludGVybmFsc09iamVjdChKU0NvbnRleHRSZWYpOwordm9pZCBpbmplY3RJbnRlcm5h
bHNPYmplY3QoSlNDb250ZXh0UmVmKSBURVNUX1NVUFBPUlRfRVhQT1JUOwordm9pZCByZXNldElu
dGVybmFsc09iamVjdChKU0NvbnRleHRSZWYpIFRFU1RfU1VQUE9SVF9FWFBPUlQ7CiAKIH0gLy8g
bmFtZXNwYWNlIFdlYkNvcmUKIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>