123052 2013-10-18 17:26:29 -0700 [iOS] Upstream more ARMv7s bits 2013-10-23 09:54:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 123180 1 dbates dbates aestes benjamin cmarcelo commit-queue fpizlo ggaren mhahnenberg oldest_to_newest 941404 0 dbates 2013-10-18 17:26:29 -0700 Upstream some more bits for ARMv7{f, s}. 941405 1 214621 dbates 2013-10-18 17:27:51 -0700 Created attachment 214621 Patch 942060 2 214621 joepeck 2013-10-21 16:16:48 -0700 Comment on attachment 214621 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214621&action=review r=me > Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig:44 > CLANG_ENABLE_OBJC_ARC = $(CLANG_ENABLE_OBJC_ARC_$(CURRENT_ARCH)); > +CLANG_ENABLE_OBJC_ARC_i386 = YES; > CLANG_ENABLE_OBJC_ARC_x86_64 = YES; > CLANG_ENABLE_OBJC_ARC_arm64 = YES; > CLANG_ENABLE_OBJC_ARC_armv7 = YES; This has armv7s (out of context), should it also have armv7f? 942423 3 dbates 2013-10-22 14:52:24 -0700 (In reply to comment #2) > > Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig:44 > > CLANG_ENABLE_OBJC_ARC = $(CLANG_ENABLE_OBJC_ARC_$(CURRENT_ARCH)); > > +CLANG_ENABLE_OBJC_ARC_i386 = YES; > > CLANG_ENABLE_OBJC_ARC_x86_64 = YES; > > CLANG_ENABLE_OBJC_ARC_arm64 = YES; > > CLANG_ENABLE_OBJC_ARC_armv7 = YES; > > This has armv7s (out of context), should it also have armv7f? After talking with David Kilzer today (10/22) on IRC we can omit support for armv7f from this patch. I'll land only the armv7s parts of this patch. 942424 4 dbates 2013-10-22 14:53:31 -0700 (In reply to comment #3) > [...] I'll land only the armv7s parts of this patch. I'll also land the CLANG_ENABLE_OBJC_ARC_i386 change. 942427 5 dbates 2013-10-22 15:01:08 -0700 Committed r157819: <http://trac.webkit.org/changeset/157819> 942453 6 commit-queue 2013-10-22 15:55:04 -0700 Re-opened since this is blocked by bug 123180 942719 7 dbates 2013-10-23 09:54:30 -0700 Committed r157862: <http://trac.webkit.org/changeset/157862> 214621 2013-10-18 17:27:51 -0700 2013-10-21 16:16:47 -0700 Patch bug-123052-20131018172750.patch text/plain 5292 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3NjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 NThhMjZjZTZlM2ZkZTFhMmM3NTRjMjY3NGQyZWIxZDg5MzI1NDExLi40OTE5ODQyMzcyNWYxMGYw ZWJkZWU0NGM4ZmMwMmQ4NjMyNzdhNTI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNiBAQAogMjAxMy0xMC0xOCAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+ CiAKKyAgICAgICAgW2lPU10gVXBzdHJlYW0gQVJNdjd7Ziwgc30gYml0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMDUyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9KYXZh U2NyaXB0Q29yZS54Y2NvbmZpZzoKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9Ub29sRXhlY3V0 YWJsZS54Y2NvbmZpZzogRW5hYmxlIENMQU5HX0VOQUJMRV9PQkpDX0FSQyBmb3IgaTM4NiBhcyBJ J20KKyAgICAgICAgbW9kaWZ5aW5nIGEgZmlsZSBpbiBKYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0 aW9ucy4KKworMjAxMy0xMC0xOCAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CisK ICAgICAgICAgW2lPU10gVXBzdHJlYW0gSlNHbG9iYWxPYmplY3Q6OnNob3VsZEludGVycnVwdFNj cmlwdEJlZm9yZVRpbWVvdXQoKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTIzMDQ1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIv U291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggN2NmODE5ZmU4MTg4ZTNkMTYyNjI2OTVjM2VjYTY5 YThmMzZmYzg3NC4uNGM2YzRhZTlhMTM2NjRlMzlhMTc5MzQ1ZDk5NWFkODRmOTAyNjJmMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxMiBAQAorMjAxMy0xMC0xOCAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBs ZS5jb20+CisKKyAgICAgICAgW2lPU10gVXBzdHJlYW0gQVJNdjd7Ziwgc30gYml0cworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMDUyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0u aDoKKwogMjAxMy0xMC0xOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgog CiAgICAgICAgIFJlbW92ZSBzcGFjZXMgYmV0d2VlbiB0ZW1wbGF0ZSBhbmdsZSBicmFja2V0cwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDFhOThhMDQyOGFkZTNkMjZkMTJhNjJkOTA3NjRjOWFhNTAzNWI1ZjcuLjQ0 YjRjMzlmMjlhNTcwNDJlMzlhN2M3YjM1YWRlNGZkMGI0NzYxNzUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNCBAQAogMjAxMy0xMC0xOCAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+ CiAKKyAgICAgICAgW2lPU10gVXBzdHJlYW0gQVJNdjd7Ziwgc30gYml0cworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIzMDUyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9XZWJD b3JlLnhjY29uZmlnOgorCisyMDEzLTEwLTE4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxl LmNvbT4KKwogICAgICAgICBbaU9TXSBVcHN0cmVhbSBKU0dsb2JhbE9iamVjdDo6c2hvdWxkSW50 ZXJydXB0U2NyaXB0QmVmb3JlVGltZW91dCgpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjMwNDUKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL0NvbmZpZ3VyYXRpb25zL0phdmFTY3JpcHRDb3JlLnhjY29uZmlnIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL0phdmFTY3JpcHRDb3JlLnhjY29uZmlnCmluZGV4 IDdjMTJlZWNjMjY4ODJhYWQyNTExZGYyZDI2YjU1N2NlZTg2ZTdkYWYuLjhiMmVjNmUwZDE2OTU0 OTE2ODIyZjQ5N2NkZDdmNmJiNTg4NjNkYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9Db25maWd1cmF0aW9ucy9KYXZhU2NyaXB0Q29yZS54Y2NvbmZpZworKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvSmF2YVNjcmlwdENvcmUueGNjb25maWcKQEAg LTI4LDYgKzI4LDggQEAgSlNWQUxVRV9NT0RFTCA9ICQoSlNWQUxVRV9NT0RFTF8kKENVUlJFTlRf QVJDSCkpOwogSlNWQUxVRV9NT0RFTF8gPSBVTktOT1dOX0pTVkFMVUVfTU9ERUw7CiBKU1ZBTFVF X01PREVMX2FybXY2ID0gMzJfNjQ7CiBKU1ZBTFVFX01PREVMX2FybXY3ID0gMzJfNjQ7CitKU1ZB TFVFX01PREVMX2FybXY3ZiA9IDMyXzY0OworSlNWQUxVRV9NT0RFTF9hcm12N3MgPSAzMl82NDsK IEpTVkFMVUVfTU9ERUxfYXJtNjQgPSA2NDsKIEpTVkFMVUVfTU9ERUxfaTM4NiA9IDMyXzY0Owog SlNWQUxVRV9NT0RFTF9wcGMgPSAzMl82NDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9Db25maWd1cmF0aW9ucy9Ub29sRXhlY3V0YWJsZS54Y2NvbmZpZyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9Ub29sRXhlY3V0YWJsZS54Y2NvbmZpZwppbmRleCBm MTliYmNhZTE5ZjA2NDgwOWE5MWI1MTAzNDNmMjBlZDU1ZTRlNDBkLi4xZmZjZWU5NGJlOGQ2MzIw NjBiY2YxZDM4YjRiMTJmYTBiY2JiNjAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ29uZmlndXJhdGlvbnMvVG9vbEV4ZWN1dGFibGUueGNjb25maWcKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL1Rvb2xFeGVjdXRhYmxlLnhjY29uZmlnCkBAIC0z OCw2ICszOCw3IEBAIFNLSVBfSU5TVEFMTF9ZRVMgPSBOTzsKIAogR0NDX0VOQUJMRV9PQkpDX0dD ID0gTk87CiBDTEFOR19FTkFCTEVfT0JKQ19BUkMgPSAkKENMQU5HX0VOQUJMRV9PQkpDX0FSQ18k KENVUlJFTlRfQVJDSCkpOworQ0xBTkdfRU5BQkxFX09CSkNfQVJDX2kzODYgPSBZRVM7CiBDTEFO R19FTkFCTEVfT0JKQ19BUkNfeDg2XzY0ID0gWUVTOwogQ0xBTkdfRU5BQkxFX09CSkNfQVJDX2Fy bTY0ID0gWUVTOwogQ0xBTkdfRU5BQkxFX09CSkNfQVJDX2FybXY3ID0gWUVTOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgK aW5kZXggZTQ0N2U0NjUxNDEwNGY5Yjg1ODIyMzZiNGJmNmI0MmViNWI3YTJhMi4uYjJiNTFiMzA5 YjBlMWFiNWJjYmQ4MjMxYTRmOWYyODIxZTg5YzQ3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93 dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCkBAIC0yMjUsNiAr MjI1LDcgQEAKICNkZWZpbmUgV1RGX0FSTV9BUkNIX1ZFUlNJT04gNgogCiAjZWxpZiBkZWZpbmVk KF9fQVJNX0FSQ0hfN0FfXykgXAorICAgIHx8IGRlZmluZWQoX19BUk1fQVJDSF83Rl9fKSBcCiAg ICAgfHwgZGVmaW5lZChfX0FSTV9BUkNIXzdSX18pIFwKICAgICB8fCBkZWZpbmVkKF9fQVJNX0FS Q0hfN1NfXykKICNkZWZpbmUgV1RGX0FSTV9BUkNIX1ZFUlNJT04gNwpAQCAtMjcxLDYgKzI3Miw3 IEBACiAjZWxpZiBkZWZpbmVkKF9fQVJNX0FSQ0hfNlQyX18pIFwKICAgICB8fCBkZWZpbmVkKF9f QVJNX0FSQ0hfN19fKSBcCiAgICAgfHwgZGVmaW5lZChfX0FSTV9BUkNIXzdBX18pIFwKKyAgICB8 fCBkZWZpbmVkKF9fQVJNX0FSQ0hfN0ZfXykgXAogICAgIHx8IGRlZmluZWQoX19BUk1fQVJDSF83 TV9fKSBcCiAgICAgfHwgZGVmaW5lZChfX0FSTV9BUkNIXzdSX18pIFwKICAgICB8fCBkZWZpbmVk KF9fQVJNX0FSQ0hfN1NfXykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRp b25zL1dlYkNvcmUueGNjb25maWcgYi9Tb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9XZWJD b3JlLnhjY29uZmlnCmluZGV4IDZmZjJkNjFjODVlZTBiNTg0OTFkYTIxYjIzZWZkNmI1NTEwMDll M2QuLjIwYmFlYmVjM2EyMWUzNWRjNjQyYWM5ZDFmZTFiNGU1OWZhZTZiMTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL1dlYkNvcmUueGNjb25maWcKKysrIGIvU291 cmNlL1dlYkNvcmUvQ29uZmlndXJhdGlvbnMvV2ViQ29yZS54Y2NvbmZpZwpAQCAtMjgsNiArMjgs OCBAQCBFWFBPUlRFRF9TWU1CT0xTX0ZJTEUgPSAkKEVYUE9SVEVEX1NZTUJPTFNfRklMRV8kKENV UlJFTlRfQVJDSCkpOwogRVhQT1JURURfU1lNQk9MU19GSUxFXyA9ICQoQlVJTFRfUFJPRFVDVFNf RElSKS9EZXJpdmVkU291cmNlcy9XZWJDb3JlL1dlYkNvcmUuZXhwOwogRVhQT1JURURfU1lNQk9M U19GSUxFX2FybXY2ID0gJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYkNv cmUvV2ViQ29yZS5MUDY0LmFybXY2LmV4cDsKIEVYUE9SVEVEX1NZTUJPTFNfRklMRV9hcm12NyA9 ICQoQlVJTFRfUFJPRFVDVFNfRElSKS9EZXJpdmVkU291cmNlcy9XZWJDb3JlL1dlYkNvcmUuTFA2 NC5hcm12Ny5leHA7CitFWFBPUlRFRF9TWU1CT0xTX0ZJTEVfYXJtdjdmID0gJChCVUlMVF9QUk9E VUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYkNvcmUvV2ViQ29yZS5MUDY0LmFybXY3Zi5leHA7 CitFWFBPUlRFRF9TWU1CT0xTX0ZJTEVfYXJtdjdzID0gJChCVUlMVF9QUk9EVUNUU19ESVIpL0Rl cml2ZWRTb3VyY2VzL1dlYkNvcmUvV2ViQ29yZS5MUDY0LmFybXY3cy5leHA7CiBFWFBPUlRFRF9T WU1CT0xTX0ZJTEVfaTM4NiA9ICQoRVhQT1JURURfU1lNQk9MU19GSUxFX2kzODZfJChQTEFURk9S TV9OQU1FKSk7CiBFWFBPUlRFRF9TWU1CT0xTX0ZJTEVfaTM4Nl9pcGhvbmVzaW11bGF0b3IgPSAk KEJVSUxUX1BST0RVQ1RTX0RJUikvRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9XZWJDb3JlLkxQNjQu aTM4Ni5leHA7CiBFWFBPUlRFRF9TWU1CT0xTX0ZJTEVfaTM4Nl9tYWNvc3ggPSAkKEJVSUxUX1BS T0RVQ1RTX0RJUikvRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9XZWJDb3JlLmV4cDsK