123048 2013-10-18 16:26:10 -0700 Add option so that JSC will crash if it can't allocate executable memory for the JITs 2013-10-21 08:39:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aestes ggaren mhahnenberg msaboff oldest_to_newest 941378 0 dbates 2013-10-18 16:26:10 -0700 Add an option to JSC, called crashIfCantAllocateJITMemory. If enabled and the operating system fails to provide executable memory then we will explicitly cause a crash to make it straightforward to identify the lack of availability of executable memory. 941381 1 214615 dbates 2013-10-18 16:30:38 -0700 Created attachment 214615 Patch This patch only enables crashIfCantAllocateJITMemory on iOS for the jsc app. 941546 2 214615 ggaren 2013-10-19 13:02:22 -0700 Comment on attachment 214615 Patch r=me Is this an upstreaming patch, or do you need it for something else? 941856 3 dbates 2013-10-21 08:33:59 -0700 (In reply to comment #2) > Is this an upstreaming patch, or do you need it for something else? This is an upstreaming patch. 941858 4 dbates 2013-10-21 08:38:17 -0700 <rdar://problem/12856193> 941859 5 dbates 2013-10-21 08:39:30 -0700 Committed r157719: <http://trac.webkit.org/changeset/157719> 214615 2013-10-18 16:30:38 -0700 2013-10-19 13:02:22 -0700 Patch WK123048.patch text/plain 4346 dbates RnJvbSBkMGUxNjE3ZjIyZTRlMGM4N2MxOTJmYjRhMTlmOTliMjM4MzNlZWM2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW5pZWwgQmF0ZXMgPGRiYXRlc0B3ZWJraXQub3JnPgpEYXRl OiBGcmksIDE4IE9jdCAyMDEzIDE2OjI4OjI1IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIG9w dGlvbiBzbyB0aGF0IEpTQyB3aWxsIGNyYXNoIGlmIGl0IGNhbid0IGFsbG9jYXRlCiBleGVjdXRh YmxlIG1lbW9yeSBmb3IgdGhlIEpJVHMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyMzA0OAogPHJkYXI6Ly9wcm9ibGVtLzEyODU2MTkzPgoKUGF0Y2ggYnkgTWljaGFl bCBTYWJvZmYgPG1zYWJvZmZAYXBwbGUuY29tPiBvbiAyMDEzLTEwLTE4ClJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKQWRkZWQgbmV3IG9wdGlvbiwgY2FsbGVkIGNyYXNoSWZDYW50QWxsb2Nh dGVKSVRNZW1vcnkuIElmIHRoaXMgb3B0aW9uIGlzIHRydWUgdGhlbiB3ZSBjcmFzaAp3aGVuIGNo ZWNraW5nIHRoZSB2YWxpZGl0eSBvZiB0aGUgZXhlY3V0YWJsZSBhbGxvY2F0b3IuIFRoZSBkZWZh dWx0IHZhbHVlIGZvciB0aGlzIG9wdGlvbiBpcwpmYWxzZSwgYnV0IGpzYyBzZXRzIGl0IHRvIHRy dWUgd2hlbiBidWlsdCBmb3IgaU9TIHRvIG1ha2UgaXQgc3RyYWlnaHRmb3J3YXJkIHRvIGlkZW50 aWZ5IHdoZXRoZXIKdGhlIGFwcCBjYW4gb2J0YWluIGV4ZWN1dGFibGUgbWVtb3J5LgoKKiBqc2Mu Y3BwOiBFeHBsaWNpdGx5IGVuYWJsZSBjcmFzaElmQ2FudEFsbG9jYXRlSklUTWVtb3J5IG9uIGlP Uy4KKG1haW4pOgoqIHJ1bnRpbWUvT3B0aW9ucy5oOiBBZGRlZCBvcHRpb24gY3Jhc2hJZkNhbnRB bGxvY2F0ZUpJVE1lbW9yeS4KKiBydW50aW1lL1ZNLmNwcDoKKEpTQzo6ZW5hYmxlQXNzZW1ibGVy KTogTW9kaWZpZWQgdG8gY3Jhc2ggaWYgb3B0aW9uIGNyYXNoSWZDYW50QWxsb2NhdGVKSVRNZW1v cnkKaXMgZW5hYmxlZC4KLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAg ICAgfCAyMCArKysrKysrKysrKysrKysrKysrKwogU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5j cHAgICAgICAgICAgIHwgIDQgKysrKwogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0 aW9ucy5oIHwgIDIgKysKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcCAgICB8 ICA4ICsrKysrKystCiA0IGZpbGVzIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3MWNmODRmLi4zYjM1NDkyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMy0xMC0xOCAgTWljaGFl bCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgb3B0aW9uIHNvIHRo YXQgSlNDIHdpbGwgY3Jhc2ggaWYgaXQgY2FuJ3QgYWxsb2NhdGUgZXhlY3V0YWJsZSBtZW1vcnkg Zm9yIHRoZSBKSVRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjMwNDgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyODU2MTkzPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIG5ldyBvcHRpb24s IGNhbGxlZCBjcmFzaElmQ2FudEFsbG9jYXRlSklUTWVtb3J5LiBJZiB0aGlzIG9wdGlvbiBpcyB0 cnVlIHRoZW4gd2UgY3Jhc2gKKyAgICAgICAgd2hlbiBjaGVja2luZyB0aGUgdmFsaWRpdHkgb2Yg dGhlIGV4ZWN1dGFibGUgYWxsb2NhdG9yLiBUaGUgZGVmYXVsdCB2YWx1ZSBmb3IgdGhpcyBvcHRp b24gaXMKKyAgICAgICAgZmFsc2UsIGJ1dCBqc2Mgc2V0cyBpdCB0byB0cnVlIHdoZW4gYnVpbHQg Zm9yIGlPUyB0byBtYWtlIGl0IHN0cmFpZ2h0Zm9yd2FyZCB0byBpZGVudGlmeSB3aGV0aGVyCisg ICAgICAgIHRoZSBhcHAgY2FuIG9idGFpbiBleGVjdXRhYmxlIG1lbW9yeS4KKworICAgICAgICAq IGpzYy5jcHA6IEV4cGxpY2l0bHkgZW5hYmxlIGNyYXNoSWZDYW50QWxsb2NhdGVKSVRNZW1vcnkg b24gaU9TLgorICAgICAgICAobWFpbik6CisgICAgICAgICogcnVudGltZS9PcHRpb25zLmg6IEFk ZGVkIG9wdGlvbiBjcmFzaElmQ2FudEFsbG9jYXRlSklUTWVtb3J5LgorICAgICAgICAqIHJ1bnRp bWUvVk0uY3BwOgorICAgICAgICAoSlNDOjplbmFibGVBc3NlbWJsZXIpOiBNb2RpZmllZCB0byBj cmFzaCBpZiBvcHRpb24gY3Jhc2hJZkNhbnRBbGxvY2F0ZUpJVE1lbW9yeQorICAgICAgICBpcyBl bmFibGVkLgorCiAyMDEzLTEwLTE4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4K IAogICAgICAgICBbaU9TXSBVcHN0cmVhbSBXZWJTYWZle0dDQWN0aXZpdHlDYWxsYmFjaywgSW5j cmVtZW50YWxTd2VlcGVyfUlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2pz Yy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAppbmRleCBiMzhmNWQ1Li4zNGUz OWM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcApAQCAtNTkyLDYgKzU5MiwxMCBAQCBpbnQgbWFpbihp bnQgYXJnYywgY2hhcioqIGFyZ3YpCiAgICAgfQogI2VuZGlmCiAKKyNpZiBQTEFURk9STShJT1Mp CisgICAgT3B0aW9uczo6Y3Jhc2hJZkNhbnRBbGxvY2F0ZUpJVE1lbW9yeSgpID0gdHJ1ZTsKKyNl bmRpZgorCiAgICAgLy8gV2UgY2FuJ3QgdXNlIGRlc3RydWN0b3JzIGluIHRoZSBmb2xsb3dpbmcg Y29kZSBiZWNhdXNlIGl0IHVzZXMgV2luZG93cwogICAgIC8vIFN0cnVjdHVyZWQgRXhjZXB0aW9u IEhhbmRsaW5nCiAgICAgaW50IHJlcyA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9PcHRpb25zLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9P cHRpb25zLmgKaW5kZXggNWQ1OTUxZS4uOWRhNDU1ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL09wdGlvbnMuaApAQCAtOTQsNiArOTQsOCBAQCB0eXBlZGVmIE9wdGlvblJhbmdlIG9w dGlvblJhbmdlOwogICAgIHYoYm9vbCwgdXNlREZHSklULCB0cnVlKSBcCiAgICAgdihib29sLCB1 c2VSZWdFeHBKSVQsIHRydWUpIFwKICAgICBcCisgICAgdihib29sLCBjcmFzaElmQ2FudEFsbG9j YXRlSklUTWVtb3J5LCBmYWxzZSkgXAorICAgIFwKICAgICB2KGJvb2wsIGZvcmNlREZHQ29kZUJs b2NrTGl2ZW5lc3MsIGZhbHNlKSBcCiAgICAgXAogICAgIHYoYm9vbCwgZHVtcEdlbmVyYXRlZEJ5 dGVjb2RlcywgZmFsc2UpIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1ZNLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcAppbmRleCA5 ZjM3NGYxLi5kNjkxYWMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9WTS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCkBAIC0x MjMsOSArMTIzLDE1IEBAIGV4dGVybiBjb25zdCBIYXNoVGFibGUgcHJvbWlzZVJlc29sdmVyUHJv dG90eXBlVGFibGU7CiAjaWYgRU5BQkxFKEFTU0VNQkxFUikKIHN0YXRpYyBib29sIGVuYWJsZUFz c2VtYmxlcihFeGVjdXRhYmxlQWxsb2NhdG9yJiBleGVjdXRhYmxlQWxsb2NhdG9yKQogewotICAg IGlmICghZXhlY3V0YWJsZUFsbG9jYXRvci5pc1ZhbGlkKCkgfHwgKCFPcHRpb25zOjp1c2VKSVQo KSAmJiAhT3B0aW9uczo6dXNlUmVnRXhwSklUKCkpKQorICAgIGlmICghT3B0aW9uczo6dXNlSklU KCkgJiYgIU9wdGlvbnM6OnVzZVJlZ0V4cEpJVCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK KyAgICBpZiAoIWV4ZWN1dGFibGVBbGxvY2F0b3IuaXNWYWxpZCgpKSB7CisgICAgICAgIGlmIChP cHRpb25zOjpjcmFzaElmQ2FudEFsbG9jYXRlSklUTWVtb3J5KCkpCisgICAgICAgICAgICBDUkFT SCgpOworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorCiAjaWYgVVNFKENGKQogI2lmIENP TVBJTEVSKEdDQykgJiYgIUNPTVBJTEVSKENMQU5HKQogICAgIC8vIEZJWE1FOiByZW1vdmUgdGhp cyBvbmNlIHRoZSBFV1MgaGF2ZSBiZWVuIHVwZ3JhZGVkIHRvIExMVk0uCi0tIAoxLjguMy40IChB cHBsZSBHaXQtNDcpCgo=