123037 2013-10-18 14:16:38 -0700 Remove excess reserved space in ctiTrampoline frames for X86 and X86_64 2013-10-18 15:56:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 116888 1 mark.lam mark.lam commit-queue fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 941330 0 mark.lam 2013-10-18 14:16:38 -0700 Patch coming soon. 941350 1 214606 mark.lam 2013-10-18 15:08:45 -0700 Created attachment 214606 the patch. 941351 2 commit-queue 2013-10-18 15:09:25 -0700 Attachment 214606 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/JITStubsMSVC64.asm', u'Source/JavaScriptCore/jit/JITStubsX86.h', u'Source/JavaScriptCore/jit/JITStubsX86_64.h']" exit_code: 1 Source/JavaScriptCore/jit/JITStubsX86.h:59: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Source/JavaScriptCore/jit/JITStubsX86.h:260: Extra space before [ [whitespace/braces] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 941352 3 214606 mark.lam 2013-10-18 15:11:41 -0700 Comment on attachment 214606 the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=214606&action=review >> Source/JavaScriptCore/jit/JITStubsX86.h:59 >> + // JIT Operation can use up to 6 arguments right now. So, we need to > > Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Will fix before landing. >> Source/JavaScriptCore/jit/JITStubsX86.h:260 >> + call [esp + 0x30]; > > Extra space before [ [whitespace/braces] [5] This is not a valid issue. 941357 4 214606 ggaren 2013-10-18 15:25:18 -0700 Comment on attachment 214606 the patch. r=me 941366 5 mark.lam 2013-10-18 15:56:26 -0700 Thanks for the review. Landed in r157650: <http://trac.webkit.org/r157650>. 214606 2013-10-18 15:08:45 -0700 2013-10-18 15:25:18 -0700 the patch. bug-123037.patch text/plain 4910 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3NjQ5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEzLTEwLTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW1vdmUgZXhjZXNzIHJlc2VydmVkIHNwYWNlIGluIGN0aVRyYW1wb2xpbmUgZnJhbWVzIGZvciBY ODYgYW5kIFg4Nl82NC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyMzAzNy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGppdC9KSVRTdHVic01TVkM2NC5hc206CisgICAgICAgICogaml0L0pJVFN0dWJz WDg2Lmg6CisgICAgICAgICogaml0L0pJVFN0dWJzWDg2XzY0Lmg6CisKIDIwMTMtMTAtMTggIEZp bGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBGcmVxdWVudCBSRUxFQVNF X0FTU0VSVCBjcmFzaGVzIGluIFN0cnVjdHVyZTo6Y2hlY2tPZmZzZXRDb25zaXN0ZW5jeSBvbiBX ZWJHTCBzd2l6emxlciB0ZXN0cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRT dHVic01TVkM2NC5hc20KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9K SVRTdHVic01TVkM2NC5hc20JKHJldmlzaW9uIDE1NzY0MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9qaXQvSklUU3R1YnNNU1ZDNjQuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC00NiwxNCArNDYs MTcgQEAgY3RpVHJhbXBvbGluZSBQUk9DCiAgICAgcHVzaCByMTUKICAgICBwdXNoIHJieAogCi0g ICAgOyBEZWNyZWFzZSByc3AgdG8gcG9pbnQgdG8gdGhlIHN0YXJ0IG9mIG91ciBKSVRTdGFja0Zy YW1lCi0gICAgc3ViIHJzcCwgNThoCisgICAgOyBKSVQgb3BlcmF0aW9ucyBjYW4gdXNlIHVwIHRv IDYgYXJncyAoNCBpbiByZWdpc3RlcnMgYW5kIDIgb24gdGhlIHN0YWNrKS4KKyAgICA7IEluIGFk ZGl0aW9uLCBYODZfNjQgQUJJIHNwZWNpZmllcyB0aGF0IHRoZSB3b3JzZSBjYXNlIHN0YWNrIGFs aWdubWVudAorICAgIDsgcmVxdWlyZW1lbnQgaXMgMzIgYnl0ZXMuIEJhc2VkIG9uIHRoZXNlIGZh Y3RvcnMsIHdlIG5lZWQgdG8gcGFkIHRoZSBzdGFjaworICAgIDsgYW5kIGFkZGl0aW9uYWwgMjho IGJ5dGVzLgorICAgIHN1YiByc3AsIDI4aAogICAgIG1vdiByMTIsIDUxMgogICAgIG1vdiByMTQs IDBGRkZGMDAwMDAwMDAwMDAwaAogICAgIG1vdiByMTUsIDBGRkZGMDAwMDAwMDAwMDAyaAogICAg IG1vdiByMTMsIHI4CiAgICAgY2FsbCByY3gKLSAgICBhZGQgcnNwLCA1OGgKKyAgICBhZGQgcnNw LCAyOGgKICAgICBwb3AgcmJ4CiAgICAgcG9wIHIxNQogICAgIHBvcCByMTQKQEAgLTY0LDcgKzY3 LDcgQEAgY3RpVHJhbXBvbGluZSBQUk9DCiBjdGlUcmFtcG9saW5lIEVORFAKIAogY3RpT3BUaHJv d05vdENhdWdodCBQUk9DCi0gICAgYWRkIHJzcCwgNThoCisgICAgYWRkIHJzcCwgMjhoCiAgICAg cG9wIHJieAogICAgIHBvcCByMTUKICAgICBwb3AgcjE0CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaml0L0pJVFN0dWJzWDg2LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRTdHVic1g4Ni5oCShyZXZpc2lvbiAxNTc2NDEpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L0pJVFN0dWJzWDg2LmgJKHdvcmtpbmcgY29weSkKQEAgLTU1LDEwICs1NSwx NiBAQCBTWU1CT0xfU1RSSU5HKGN0aVRyYW1wb2xpbmUpICI6IiAiXG4iCiAgICAgInB1c2hsICVl c2kiICJcbiIKICAgICAicHVzaGwgJWVkaSIgIlxuIgogICAgICJwdXNobCAlZWJ4IiAiXG4iCi0g ICAgInN1YmwgJDB4M2MsICVlc3AiICJcbiIKLSAgICAibW92bCAweDU4KCVlc3ApLCAlZWRpIiAi XG4iCi0gICAgImNhbGwgKjB4NTAoJWVzcCkiICJcbiIKLSAgICAiYWRkbCAkMHgzYywgJWVzcCIg IlxuIgorCisgICAgLy8gSklUIE9wZXJhdGlvbiBjYW4gdXNlIHVwIHRvIDYgYXJndW1lbnRzIHJp Z2h0IG5vdy4gIFNvLCB3ZSBuZWVkIHRvCisgICAgLy8gcmVzZXJ2ZSBzcGFjZSBpbiB0aGlzIHN0 YWNrIGZyYW1lIGZvciB0aGUgb3V0LWdvaW5nIGFyZ3MuIFRvIGVuc3VyZSB0aGF0CisgICAgLy8g dGhlIHN0YWNrIHJlbWFpbnMgYWxpZ25lZCBvbiBhbiAxNiBieXRlIGJvdW5kYXJ5LCB3ZSByb3Vu ZCB0aGUgcGFkZGluZyB1cAorICAgIC8vIGJ5IDB4MWMgYnl0ZXMuCisgICAgInN1YmwgJDB4MWMs ICVlc3AiICJcbiIKKyAgICAibW92bCAweDM4KCVlc3ApLCAlZWRpIiAiXG4iCisgICAgImNhbGwg KjB4MzAoJWVzcCkiICJcbiIKKyAgICAiYWRkbCAkMHgxYywgJWVzcCIgIlxuIgorCiAgICAgInBv cGwgJWVieCIgIlxuIgogICAgICJwb3BsICVlZGkiICJcbiIKICAgICAicG9wbCAlZXNpIiAiXG4i CkBAIC03Myw3ICs3OSw3IEBAIGFzbSAoCiAiLmdsb2JsICIgU1lNQk9MX1NUUklORyhjdGlPcFRo cm93Tm90Q2F1Z2h0KSAiXG4iCiBISURFX1NZTUJPTChjdGlPcFRocm93Tm90Q2F1Z2h0KSAiXG4i CiBTWU1CT0xfU1RSSU5HKGN0aU9wVGhyb3dOb3RDYXVnaHQpICI6IiAiXG4iCi0gICAgImFkZGwg JDB4M2MsICVlc3AiICJcbiIKKyAgICAiYWRkbCAkMHgxYywgJWVzcCIgIlxuIgogICAgICJwb3Bs ICVlYngiICJcbiIKICAgICAicG9wbCAlZWRpIiAiXG4iCiAgICAgInBvcGwgJWVzaSIgIlxuIgpA QCAtMjQ4LDExICsyNTQsMTEgQEAgZXh0ZXJuICJDIiB7CiAgICAgICAgICAgICBwdXNoIGVzaTsK ICAgICAgICAgICAgIHB1c2ggZWRpOwogICAgICAgICAgICAgcHVzaCBlYng7Ci0gICAgICAgICAg ICBzdWIgZXNwLCAweDNjOworICAgICAgICAgICAgc3ViIGVzcCwgMHgxYzsKICAgICAgICAgICAg IG1vdiBlY3gsIGVzcDsKLSAgICAgICAgICAgIG1vdiBlZGksIFtlc3AgKyAweDU4XTsKLSAgICAg ICAgICAgIGNhbGwgW2VzcCArIDB4NTBdOwotICAgICAgICAgICAgYWRkIGVzcCwgMHgzYzsKKyAg ICAgICAgICAgIG1vdiBlZGksIFtlc3AgKyAweDM4XTsKKyAgICAgICAgICAgIGNhbGwgW2VzcCAr IDB4MzBdOworICAgICAgICAgICAgYWRkIGVzcCwgMHgxYzsKICAgICAgICAgICAgIHBvcCBlYng7 CiAgICAgICAgICAgICBwb3AgZWRpOwogICAgICAgICAgICAgcG9wIGVzaTsKQEAgLTI2NCw3ICsy NzAsNyBAQCBleHRlcm4gIkMiIHsKICAgICBfX2RlY2xzcGVjKG5ha2VkKSB2b2lkIGN0aU9wVGhy b3dOb3RDYXVnaHQoKQogICAgIHsKICAgICAgICAgX19hc20gewotICAgICAgICAgICAgYWRkIGVz cCwgMHgzYzsKKyAgICAgICAgICAgIGFkZCBlc3AsIDB4MWM7CiAgICAgICAgICAgICBwb3AgZWJ4 OwogICAgICAgICAgICAgcG9wIGVkaTsKICAgICAgICAgICAgIHBvcCBlc2k7CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzWDg2XzY0LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVic1g4Nl82NC5oCShyZXZpc2lvbiAxNTc2NDEp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzWDg2XzY0LmgJKHdvcmtpbmcg Y29weSkKQEAgLTU3LDIwICs1NywxNyBAQCBTWU1CT0xfU1RSSU5HKGN0aVRyYW1wb2xpbmUpICI6 IiAiXG4iCiAgICAgInB1c2hxICVyMTQiICJcbiIKICAgICAicHVzaHEgJXIxNSIgIlxuIgogICAg ICJwdXNocSAlcmJ4IiAiXG4iCi0gICAgLy8gRm9ybSB0aGUgSklUIHN0dWJzIGFyZWEKLSAgICAi cHVzaHEgJXI5IiAiXG4iCi0gICAgInB1c2hxICVyOCIgIlxuIgotICAgICJwdXNocSAlcmN4IiAi XG4iCi0gICAgInB1c2hxICVyZHgiICJcbiIKLSAgICAicHVzaHEgJXJzaSIgIlxuIgotICAgICJw dXNocSAlcmRpIiAiXG4iCi0gICAgInN1YnEgJDB4NDgsICVyc3AiICJcbiIKKworICAgIC8vIFRo ZSBYODZfNjQgQUJJIHNwZWNpZmllcyB0aGF0IHRoZSB3b3JzZSBjYXNlIHN0YWNrIGFsaWdubWVu dCByZXF1aXJlbWVudAorICAgIC8vIGlzIDMyIGJ5dGVzLgorICAgICJzdWJxICQweDgsICVyc3Ai ICJcbiIKKwogICAgICJtb3ZxICQ1MTIsICVyMTIiICJcbiIKICAgICAibW92cSAkMHhGRkZGMDAw MDAwMDAwMDAwLCAlcjE0IiAiXG4iCiAgICAgIm1vdnEgJDB4RkZGRjAwMDAwMDAwMDAwMiwgJXIx NSIgIlxuIgogICAgICJtb3ZxICVyZHgsICVyMTMiICJcbiIKICAgICAiY2FsbCAqJXJkaSIgIlxu IgotICAgICJhZGRxICQweDc4LCAlcnNwIiAiXG4iCisgICAgImFkZHEgJDB4OCwgJXJzcCIgIlxu IgogICAgICJwb3BxICVyYngiICJcbiIKICAgICAicG9wcSAlcjE1IiAiXG4iCiAgICAgInBvcHEg JXIxNCIgIlxuIgpAQCAtODcsNyArODQsNyBAQCBhc20gKAogIi5nbG9ibCAiIFNZTUJPTF9TVFJJ TkcoY3RpT3BUaHJvd05vdENhdWdodCkgIlxuIgogSElERV9TWU1CT0woY3RpT3BUaHJvd05vdENh dWdodCkgIlxuIgogU1lNQk9MX1NUUklORyhjdGlPcFRocm93Tm90Q2F1Z2h0KSAiOiIgIlxuIgot ICAgICJhZGRxICQweDc4LCAlcnNwIiAiXG4iCisgICAgImFkZHEgJDB4OCwgJXJzcCIgIlxuIgog ICAgICJwb3BxICVyYngiICJcbiIKICAgICAicG9wcSAlcjE1IiAiXG4iCiAgICAgInBvcHEgJXIx NCIgIlxuIgo=