123022 2013-10-18 07:50:23 -0700 Cleanup webkit.org/team.html 2013-10-18 10:02:05 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 mtiborinf webkit-unassigned commit-queue dbates galpeter ossy oldest_to_newest 941194 0 mtiborinf 2013-10-18 07:50:23 -0700 The annoteWithWikiData function is now obsolete as there the data it tries to fetch does not exists. 941197 1 214571 mtiborinf 2013-10-18 07:53:06 -0700 Created attachment 214571 patch Removed the annoteWithWikiData function, because data it tries to fetch does not exists. 941235 2 214571 ap 2013-10-18 09:37:47 -0700 Comment on attachment 214571 patch I think that this whole page is broken by design, as it presents data from committers.json that has a different meaning. committers.json is a reasonably authoritative source for committer and reviewer privilege information, plus it's a source of data for bugzilla autocomplete. But bugzilla autocomplete hints != team. 941245 3 214571 commit-queue 2013-10-18 10:02:03 -0700 Comment on attachment 214571 patch Clearing flags on attachment: 214571 Committed r157638: <http://trac.webkit.org/changeset/157638> 941246 4 commit-queue 2013-10-18 10:02:05 -0700 All reviewed patches have been landed. Closing bug. 214571 2013-10-18 07:53:06 -0700 2013-10-18 10:02:02 -0700 patch diff_annotateWithwikiData.txt text/plain 3797 mtiborinf ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvd2Vi a2l0Lm9yZy9DaGFuZ2VMb2cKaW5kZXggZmE1Nzk5NC4uZTMwM2ZiZSAxMDA2NDQKLS0tIGEvV2Vi c2l0ZXMvd2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMy0xMC0xOCAgVGlib3IgTWVzemFyb3MgIDx0bWVz emFyb3NAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIENsZWFudXAgd2Via2l0Lm9yZy90ZWFt Lmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy MzAyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl bW92ZWQgdGhlIGFubm90ZVdpdGhXaWtpRGF0YSBmdW5jdGlvbiwgYmVjYXVzZSBkYXRhIGl0IHRy aWVzIHRvIGZldGNoIGRvZXMgbm90IGV4aXN0cy4KKworICAgICAgICAqIHRlYW0uaHRtbDoKKwog MjAxMy0xMC0wOCAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAg IFJlZmluZWQgcG93ZXIgbWFuYWdlbWVudCBpbiBTdW5TcGlkZXIgMS4wLjIKZGlmZiAtLWdpdCBh L1dlYnNpdGVzL3dlYmtpdC5vcmcvdGVhbS5odG1sIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy90ZWFt Lmh0bWwKaW5kZXggMTE1Y2NlMy4uYzc3YjEwNCAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvd2Via2l0 Lm9yZy90ZWFtLmh0bWwKKysrIGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy90ZWFtLmh0bWwKQEAgLTE1 Nyw1OCArMTU3LDYgQEAgZnVuY3Rpb24gZmluZExpc3RDaGlsZEZvckNvbnRyaWJ1dG9yKGNvbnRy aWJ1dG9yKSB7CiAgICAgcmV0dXJuIG51bGw7CiB9CiAKLWZ1bmN0aW9uIGFubm90YXRlV2l0aFdp a2lEYXRhKCkgewotICAgIGZ1bmN0aW9uIGFubm90YXRlRm9yQ29udHJpYnV0b3IoY29udHJpYnV0 b3IpIHsKLSAgICAgICAgdmFyIGxpc3RJdGVtID0gZmluZExpc3RDaGlsZEZvckNvbnRyaWJ1dG9y KGNvbnRyaWJ1dG9yKTsKLSAgICAgICAgaWYgKCFsaXN0SXRlbSkgewotICAgICAgICAgICAgdmFy IGxpc3RFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoY29udHJpYnV0b3Iua2luZCAr ICdzJyk7Ci0gICAgICAgICAgICB2YXIgbGlzdEl0ZW0gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50 KCdsaScpOwotICAgICAgICAgICAgbGlzdEVsZW1lbnQuYXBwZW5kQ2hpbGQobGlzdEl0ZW0pOwot ICAgICAgICAgICAgbGlzdEl0ZW0uc3R5bGUuYmFja2dyb3VuZENvbG9yID0gJ3JlZCc7Ci0gICAg ICAgICAgICBwb3B1bGF0ZUNvbnRyaWJ1dG9yTGlzdEl0ZW0obGlzdEl0ZW0sIGNvbnRyaWJ1dG9y KTsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIHZhciBhZmZpbGlhdGlvbkNvbnRhaW5l ciA9IGxpc3RJdGVtLnF1ZXJ5U2VsZWN0b3IoJy5hZmZpbGlhdGlvbicpOwotICAgICAgICAgICAg dmFyIGFmZmlsaWF0aW9uID0gZm9ybWF0QWZmaWxpYXRpb24oY29udHJpYnV0b3IpOwotICAgICAg ICAgICAgaWYgKGFmZmlsaWF0aW9uICYmICghYWZmaWxpYXRpb25Db250YWluZXIgfHwgYWZmaWxp YXRpb25Db250YWluZXIudGV4dENvbnRlbnQgIT0gYWZmaWxpYXRpb24pKSB7Ci0gICAgICAgICAg ICAgICAgYWRkVGV4dChsaXN0SXRlbSwgJyAnKTsKLSAgICAgICAgICAgICAgICBhZGRXcmFwcGVk VGV4dChsaXN0SXRlbSwgJ2VtJywgeydzdHlsZSc6ICdiYWNrZ3JvdW5kLWNvbG9yOnJlZCd9LCBh ZmZpbGlhdGlvbik7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KLSAgICB9Ci0KLSAgICB2YXIg d2Via2l0VGVhbVdpa2lVcmwgPSAnaHR0cDovL3RyYWMud2Via2l0Lm9yZy93aWtpL1dlYktpdCUy MFRlYW0nOwotICAgIHZhciB4aHIgPSBuZXcgWE1MSHR0cFJlcXVlc3QoKTsKLSAgICB4aHIub25s b2FkID0gZnVuY3Rpb24gKCkgewotICAgICAgICBpZiAodGhpcy5zdGF0dXMgIT09IDIwMCkKLSAg ICAgICAgICAgIHJldHVybiB0aGlzLm9uZXJyb3IoKTsKLQotICAgICAgICB2YXIgbGluZXMgPSB0 aGlzLnJlc3BvbnNlVGV4dC5zcGxpdCgnXG4nKTsKLSAgICAgICAgLy8gTWF0Y2ggbGluZXMgbGlr ZSAqICcnJ1J5b3N1a2UgTml3YScnJyAocm5pd2EpICcnR29vZ2xlJycKLSAgICAgICAgdmFyIHRl YW1XaWtpQ29udHJpYnV0b3JFbnRyeVBhdHRlcm4gPSAvXlxzK1wqXHMrJycnKFteJ10rKScnJ1xz KihcKChbXiddKylcKVxzKik/KCcnKFteJ10rKScnKT9ccyokLzsKLSAgICAgICAgZm9yICh2YXIg aSA9IDA7IGkgPCBsaW5lcy5sZW5ndGg7IGkrKykgewotICAgICAgICAgICAgdmFyIG1hdGNoID0g bGluZXNbaV0ubWF0Y2goL1w9XHMrKFJldmlld2VyfENvbW1pdHRlcnxDb250cmlidXRvcilzXHMr PS9pKTsKLSAgICAgICAgICAgIGlmIChtYXRjaCkgewotICAgICAgICAgICAgICAgIHZhciBjdXJy ZW50S2luZCA9IG1hdGNoWzFdLnRvTG93ZXJDYXNlKCk7Ci0gICAgICAgICAgICAgICAgY29udGlu dWU7Ci0gICAgICAgICAgICB9Ci0KLSAgICAgICAgICAgIC8vIFN0cmlwIHNwZWNpYWwgSFRNTCBj aGFyYWN0ZXJzCi0gICAgICAgICAgICBtYXRjaCA9IGxpbmVzW2ldLnJlcGxhY2UoL1t7fTw+IiU7 JisvXS9nLCAnJykubWF0Y2godGVhbVdpa2lDb250cmlidXRvckVudHJ5UGF0dGVybik7Ci0gICAg ICAgICAgICBpZiAoY3VycmVudEtpbmQgJiYgbWF0Y2gpIHsKLSAgICAgICAgICAgICAgICBhbm5v dGF0ZUZvckNvbnRyaWJ1dG9yKHsKLSAgICAgICAgICAgICAgICAgICAga2luZDogY3VycmVudEtp bmQsCi0gICAgICAgICAgICAgICAgICAgIG5hbWU6IG1hdGNoWzFdLAotICAgICAgICAgICAgICAg ICAgICBuaWNrczogbWF0Y2hbM10gPyBtYXRjaFszXS5zcGxpdCgvLFxzKi8pIDogbnVsbCwKLSAg ICAgICAgICAgICAgICAgICAgYWZmaWxpYXRpb246IG1hdGNoWzVdCi0gICAgICAgICAgICAgICAg fSk7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KLSAgICB9Ci0gICAgeGhyLm9uZXJyb3IgPSBm dW5jdGlvbiAoKSB7IGFsZXJ0KCdDb3VsZCBub3Qgb2J0YWluIGh0dHA6Ly90cmFjLndlYmtpdC5v cmcvd2lraS9XZWJLaXQlMjBUZWFtJyk7IH07Ci0gICAgeGhyLm9wZW4oJ0dFVCcsIHdlYmtpdFRl YW1XaWtpVXJsICsgJz9mb3JtYXQ9dHh0Jyk7Ci0gICAgeGhyLnNlbmQoKTsKLX0KLQogdmFyIHho ciA9IG5ldyBYTUxIdHRwUmVxdWVzdCgpOwogeGhyLm9ubG9hZCA9IGZ1bmN0aW9uICgpIHsKICAg ICBpZiAodGhpcy5zdGF0dXMgIT09IDIwMCkKQEAgLTIxOCw5ICsxNjYsNiBAQCB4aHIub25sb2Fk ID0gZnVuY3Rpb24gKCkgewogICAgIHBvcHVsYXRlQ29udHJpYnV0b3JMaXN0KGNvbnRyaWJ1dG9y cywgJ3Jldmlld2VyJyk7CiAgICAgcG9wdWxhdGVDb250cmlidXRvckxpc3QoY29udHJpYnV0b3Jz LCAnY29tbWl0dGVyJyk7CiAgICAgcG9wdWxhdGVDb250cmlidXRvckxpc3QoY29udHJpYnV0b3Jz LCAnY29udHJpYnV0b3InKTsKLQotICAgIGlmIChsb2NhdGlvbi5zZWFyY2guaW5kZXhPZignYW5u b3RhdGUnKSA+PSAwKQotICAgICAgICBhbm5vdGF0ZVdpdGhXaWtpRGF0YSgpOwogfTsKIHhoci5v bmVycm9yID0gZnVuY3Rpb24gKCkgeyBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29udGFpbmVy JykudGV4dENvbnRlbnQgPSAnQ291bGQgbm90IG9idGFpbiBjb250cmlidXRvcnMuanNvbic7IH07 CiB4aHIub3BlbignR0VUJywgc3ZuVHJ1bmtVcmwgKyAnVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vY29uZmlnL2NvbnRyaWJ1dG9ycy5qc29uJyk7Cgo=