122993 2013-10-17 14:01:08 -0700 Web Inspector: [CSS Regions] Crash when highlighting a node of a flow with no regions 2013-10-17 15:06:44 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 achicu achicu commit-queue graouts joepeck timothy webkit-bug-importer WebkitBugTracker oldest_to_newest 940949 0 achicu 2013-10-17 14:01:08 -0700 When a node inside a flow thread with no regions is highlighted, WebCore crashes. 0 com.apple.JavaScriptCore 0x0000000107c3dfaa WTFCrash + 42 1 com.apple.WebCore 0x0000000109faf8f4 WebCore::buildObjectForRendererFragments(WebCore::RenderObject*, WebCore::HighlightConfig const&) + 324 2 com.apple.WebCore 0x0000000109faf5be WebCore::InspectorOverlay::buildObjectForHighlightedNode() const + 494 3 com.apple.WebCore 0x0000000109faefe4 WebCore::InspectorOverlay::drawNodeHighlight() + 36 4 com.apple.WebCore 0x0000000109faeabe WebCore::InspectorOverlay::update() + 558 5 com.apple.WebCore 0x0000000109faecba WebCore::InspectorOverlay::highlightNode(WebCore::Node*, WebCore::HighlightConfig const&) + 106 6 com.apple.WebCore 0x0000000109f5af65 WebCore::InspectorDOMAgent::highlightNode(WTF::String*, WTF::RefPtr<WebCore::InspectorObject> const&, int const*, WTF::String const*) + 485 7 com.apple.WebCore 0x0000000109f5aff2 non-virtual thunk to WebCore::InspectorDOMAgent::highlightNode(WTF::String*, WTF::RefPtr<WebCore::InspectorObject> const&, int const*, WTF::String const*) + 82 8 com.apple.WebCore 0x0000000109ee13c1 WebCore::InspectorBackendDispatcherImpl::DOM_highlightNode(long, WebCore::InspectorObject*) + 785 9 com.apple.WebCore 0x0000000109ef6c7e WebCore::InspectorBackendDispatcherImpl::dispatch(WTF::String const&) + 1838 10 com.apple.WebCore 0x0000000109f0feb0 WebCore::InspectorController::dispatchMessageFromFrontend(WTF::String const&) + 96 11 com.apple.WebCore 0x0000000109f88afe WebCore::InspectorBackendDispatchTask::onTimer(WebCore::Timer<WebCore::InspectorBackendDispatchTask>*) + 110 12 com.apple.WebCore 0x0000000109f88ee3 WebCore::Timer<WebCore::InspectorBackendDispatchTask>::fired() + 115 13 com.apple.WebCore 0x000000010add4f13 WebCore::ThreadTimers::sharedTimerFiredInternal() + 307 14 com.apple.WebCore 0x000000010add4c29 WebCore::ThreadTimers::sharedTimerFired() + 25 15 com.apple.WebCore 0x000000010ab6f463 WebCore::timerFired(__CFRunLoopTimer*, void*) + 67 16 com.apple.CoreFoundation 0x00007fff894db804 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 20 17 com.apple.CoreFoundation 0x00007fff894db31d __CFRunLoopDoTimer + 557 18 com.apple.CoreFoundation 0x00007fff894c0ad9 __CFRunLoopRun + 1529 19 com.apple.CoreFoundation 0x00007fff894c00e2 CFRunLoopRunSpecific + 290 20 DumpRenderTree 0x000000010750a0c0 runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 4912 (DumpRenderTree.mm:1415) 21 DumpRenderTree 0x0000000107508d1a runTestingServerLoop() + 282 (DumpRenderTree.mm:861) 22 DumpRenderTree 0x0000000107508705 dumpRenderTree(int, char const**) + 405 (DumpRenderTree.mm:916) 23 DumpRenderTree 0x000000010750a978 main + 296 (DumpRenderTree.mm:959) 24 libdyld.dylib 0x00007fff8c0347e1 start + 1 940951 1 webkit-bug-importer 2013-10-17 14:02:19 -0700 <rdar://problem/15255110> 940971 2 214510 achicu 2013-10-17 14:19:47 -0700 Created attachment 214510 Patch V1 940976 3 214510 joepeck 2013-10-17 14:28:59 -0700 Comment on attachment 214510 Patch V1 View in context: https://bugs.webkit.org/attachment.cgi?id=214510&action=review r=me > LayoutTests/inspector-protocol/dom/highlight-flow-with-no-region.html:19 > + if (msg.error) { > + InspectorTest.log(msg.error.message); > + InspectorTest.completeTest(); > + return; > + } I created a helper for this in LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js named InspectorTest.checkForError: InspectorTest.checkForError = function(responseObject) { if (responseObject.error) { InspectorTest.log("PROTOCOL ERROR: " + responseObject.error.message); InspectorTest.completeTest(); throw "PROTOCOL ERROR"; } } So instead of these if blocks you can just do: InspectorTest.checkForError(msg); 940980 4 214514 achicu 2013-10-17 14:35:44 -0700 Created attachment 214514 Patch V2 Thanks! 940999 5 214514 commit-queue 2013-10-17 15:06:42 -0700 Comment on attachment 214514 Patch V2 Clearing flags on attachment: 214514 Committed r157605: <http://trac.webkit.org/changeset/157605> 941000 6 commit-queue 2013-10-17 15:06:44 -0700 All reviewed patches have been landed. Closing bug. 214510 2013-10-17 14:19:47 -0700 2013-10-17 14:35:44 -0700 Patch V1 bug122993.patch text/plain 5992 achicu ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmNzgyMmMxLi40ZmE3OThiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMTAt MTcgIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgorCisgICAgICAgIFdl YiBJbnNwZWN0b3I6IFtDU1MgUmVnaW9uc10gQ3Jhc2ggd2hlbiBoaWdobGlnaHRpbmcgYSBub2Rl IG9mIGEgZmxvdyB3aXRoIG5vIHJlZ2lvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyMjk5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZGVkIHRlc3QgdG8gY2hlY2sgdGhhdCBET00uaGlnaGxpZ2h0 Tm9kZSBpcyBub3QgY3Jhc2hpbmcgV2ViQ29yZSB3aGVuIHRoZSBub2RlIGlzIGluc2lkZQorICAg ICAgICBhIGZsb3cgd2l0aCBubyBhc3NvY2lhdGVkIHJlZ2lvbnMuCisKKyAgICAgICAgKiBpbnNw ZWN0b3ItcHJvdG9jb2wvZG9tL2hpZ2hsaWdodC1mbG93LXdpdGgtbm8tcmVnaW9uLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogaW5zcGVjdG9yLXByb3RvY29sL2RvbS9oaWdobGlnaHQt Zmxvdy13aXRoLW5vLXJlZ2lvbi5odG1sOiBBZGRlZC4KKwogMjAxMy0xMC0xNiAgQ29tbWl0IFF1 ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjE1NzUyOS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci1wcm90 b2NvbC9kb20vaGlnaGxpZ2h0LWZsb3ctd2l0aC1uby1yZWdpb24tZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yLXByb3RvY29sL2RvbS9oaWdobGlnaHQtZmxvdy13aXRoLW5vLXJl Z2lvbi1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uOTBj YzZkZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9k b20vaGlnaGxpZ2h0LWZsb3ctd2l0aC1uby1yZWdpb24tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEg QEAKK1Rlc3RpbmcgdGhhdCB0aGUgYmFja2VuZCBpcyBub3QgY3Jhc2hpbmcgd2hlbiBoaWdobGln aHRpbmcgYSBub2RlIHRoYXQgaGFzIG5vIGFzc29jaWF0ZWQgcmVnaW9uLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvaW5zcGVjdG9yLXByb3RvY29sL2RvbS9oaWdobGlnaHQtZmxvdy13aXRoLW5v LXJlZ2lvbi5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yLXByb3RvY29sL2RvbS9oaWdobGln aHQtZmxvdy13aXRoLW5vLXJlZ2lvbi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAuLmIxY2I3YjYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3It cHJvdG9jb2wvZG9tL2hpZ2hsaWdodC1mbG93LXdpdGgtbm8tcmVnaW9uLmh0bWwKQEAgLTAsMCAr MSw1OCBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBz cmM9Ii4uLy4uL2h0dHAvdGVzdHMvaW5zcGVjdG9yLXByb3RvY29sL3Jlc291cmNlcy9wcm90b2Nv bC10ZXN0LmpzIj48L3NjcmlwdD4KKzxzdHlsZT4KKyNmbG93IHsKKyAgICAtd2Via2l0LWZsb3ct aW50bzogZmxvdzsKK30KKzwvc3R5bGU+Cis8c2NyaXB0PgorZnVuY3Rpb24gdGVzdCgpCit7Cisg ICAgSW5zcGVjdG9yVGVzdC5zZW5kQ29tbWFuZCgiRE9NLmdldERvY3VtZW50Iiwge30sIG9uR290 RG9jdW1lbnQpOworCisgICAgZnVuY3Rpb24gb25Hb3REb2N1bWVudChtc2cpIHsKKyAgICAgICAg aWYgKG1zZy5lcnJvcikgeworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5sb2cobXNnLmVycm9y Lm1lc3NhZ2UpOworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5jb21wbGV0ZVRlc3QoKTsKKyAg ICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorICAgICAgICB2YXIgbm9kZSA9IG1zZy5yZXN1 bHQucm9vdDsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5zZW5kQ29tbWFuZCgiRE9NLnF1ZXJ5U2Vs ZWN0b3IiLCB7ICJub2RlSWQiOiBub2RlLm5vZGVJZCwgInNlbGVjdG9yIjogIiNpbnNwZWN0ZWRF bGVtZW50IiB9LCBvblF1ZXJ5U2VsZWN0b3IpOworICAgIH0KKworICAgIGZ1bmN0aW9uIG9uUXVl cnlTZWxlY3Rvcihtc2cpIHsKKyAgICAgICAgaWYgKG1zZy5lcnJvcikgeworICAgICAgICAgICAg SW5zcGVjdG9yVGVzdC5sb2cobXNnLmVycm9yLm1lc3NhZ2UpOworICAgICAgICAgICAgSW5zcGVj dG9yVGVzdC5jb21wbGV0ZVRlc3QoKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQor ICAgICAgICB2YXIgbm9kZSA9IG1zZy5yZXN1bHQ7CisgICAgICAgIHZhciBoaWdobGlnaHRDb25m aWcgPSB7CisgICAgICAgICAgICBzaG93SW5mbzogdHJ1ZSwKKyAgICAgICAgICAgIGNvbnRlbnRD b2xvcjoge3I6IDI1NSwgZzogMjU1LCBiOiAyNTV9LAorICAgICAgICAgICAgcGFkZGluZ0NvbG9y OiB7cjogMjU1LCBnOiAyNTUsIGI6IDI1NX0sCisgICAgICAgICAgICBib3JkZXJDb2xvcjoge3I6 IDI1NSwgZzogMjU1LCBiOiAyNTV9LAorICAgICAgICAgICAgbWFyZ2luQ29sb3I6IHtyOiAyNTUs IGc6IDI1NSwgYjogMjU1fSwKKyAgICAgICAgfTsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5zZW5k Q29tbWFuZCgiRE9NLmhpZ2hsaWdodE5vZGUiLCB7ICJoaWdobGlnaHRDb25maWciOiBoaWdobGln aHRDb25maWcsICJub2RlSWQiOiBub2RlLm5vZGVJZCB9LCBvbkhpZ2hsaWdodENvbXBsZXRlKTsK KyAgICB9CisKKyAgICBmdW5jdGlvbiBvbkhpZ2hsaWdodENvbXBsZXRlKG1zZykgeworICAgICAg ICBpZiAobXNnLmVycm9yKQorICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5sb2cobXNnLmVycm9y KTsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5jb21wbGV0ZVRlc3QoKTsKKyAgICB9Cit9Cis8L3Nj cmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKworPGRpdiBpZD0iZmxv dyI+CisgICAgPGRpdiBpZD0iaW5zcGVjdGVkRWxlbWVudCI+PC9kaXY+Cis8L2Rpdj4KKworPHA+ VGVzdGluZyB0aGF0IHRoZSBiYWNrZW5kIGlzIG5vdCBjcmFzaGluZyB3aGVuIGhpZ2hsaWdodGlu ZyBhIG5vZGUgdGhhdCBoYXMgbm8gYXNzb2NpYXRlZCByZWdpb24uPC9wPgorCis8L2JvZHk+Cis8 L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggMzYzOTk3MS4uY2YzOTY4ZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE5IEBACisyMDEzLTEwLTE3ICBBbGV4YW5kcnUgQ2hpY3VsaXRhICA8YWNoaWN1QGFkb2Jl LmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ1NTIFJlZ2lvbnNdIENyYXNoIHdoZW4g aGlnaGxpZ2h0aW5nIGEgbm9kZSBvZiBhIGZsb3cgd2l0aCBubyByZWdpb25zCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI5OTMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBpbnNwZWN0b3ItcHJv dG9jb2wvZG9tL2hpZ2hsaWdodC1mbG93LXdpdGgtbm8tcmVnaW9uLmh0bWwKKworICAgICAgICBF dmVuIGlmIGEgbmFtZWQgZmxvdyBoYXMgbm8gcmVnaW9ucyB0aGUgY29udGVudCBvZiB0aGUgZmxv dyB3aWxsIHN0aWxsIGhhdmUgcmVuZGVyZXIgb2JqZWN0cyBjcmVhdGVkLgorICAgICAgICBSZW1v dmVkIHRoZSBhc3N1bXB0aW9uIHRoYXQgYWxsIHJlbmRlcmVycyBpbnNpZGUgYSBSZW5kZXJGbG93 VGhyZWFkIHdpbGwgYWx3YXlzIGhhdmUgYW4gZW5jbG9zaW5nIFJlbmRlclJlZ2lvbi4KKworICAg ICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmJ1aWxkT2JqZWN0Rm9yUmVuZGVyZXJGcmFnbWVudHMpOgorICAgICAgICAoV2ViQ29yZTo6SW5z cGVjdG9yT3ZlcmxheTo6YnVpbGRPYmplY3RGb3JIaWdobGlnaHRlZE5vZGUpOgorCiAyMDEzLTEw LTE2ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBUYWtlIFJl bmRlck9iamVjdHMgb3V0IG9mIHRoZSBhcmVuYS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JPdmVybGF5LmNwcAppbmRleCA3OTM0NTljLi43MjVkY2U4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwCkBAIC01MDEsNyArNTAx LDcgQEAgc3RhdGljIFBhc3NSZWZQdHI8SW5zcGVjdG9yQXJyYXk+IGJ1aWxkT2JqZWN0Rm9yUmVu ZGVyZXJGcmFnbWVudHMoUmVuZGVyT2JqZWN0KgogICAgICAgICBSZW5kZXJSZWdpb24qIGVuZFJl Z2lvbiA9IG51bGxwdHI7CiAgICAgICAgIGNvbnRhaW5pbmdGbG93VGhyZWFkLT5nZXRSZWdpb25S YW5nZUZvckJveChlbmNsb3NpbmdCb3gsIHN0YXJ0UmVnaW9uLCBlbmRSZWdpb24pOwogICAgICAg ICBpZiAoIXN0YXJ0UmVnaW9uKSB7Ci0gICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK KyAgICAgICAgICAgIC8vIFRoZSBmbG93IGhhcyBubyB2aXNpYmxlIHJlZ2lvbnMuIFRoZSByZW5k ZXJlciBpcyBub3QgdmlzaWJsZSBvbiBzY3JlZW4uCiAgICAgICAgICAgICByZXR1cm4gbnVsbHB0 cjsKICAgICAgICAgfQogICAgICAgICBjb25zdCBSZW5kZXJSZWdpb25MaXN0JiByZWdpb25MaXN0 ID0gY29udGFpbmluZ0Zsb3dUaHJlYWQtPnJlbmRlclJlZ2lvbkxpc3QoKTsKQEAgLTU5MSwxMyAr NTkxLDE3IEBAIFBhc3NSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBJbnNwZWN0b3JPdmVybGF5Ojpi dWlsZE9iamVjdEZvckhpZ2hsaWdodGVkTm9kZSgpIGNvCiAgICAgaWYgKCFyZW5kZXJlcikKICAg ICAgICAgcmV0dXJuIG51bGxwdHI7CiAKKyAgICBSZWZQdHI8SW5zcGVjdG9yQXJyYXk+IGhpZ2hs aWdodEZyYWdtZW50cyA9IGJ1aWxkT2JqZWN0Rm9yUmVuZGVyZXJGcmFnbWVudHMocmVuZGVyZXIs IG1fbm9kZUhpZ2hsaWdodENvbmZpZyk7CisgICAgaWYgKCFoaWdobGlnaHRGcmFnbWVudHMpCisg ICAgICAgIHJldHVybiBudWxscHRyOworCiAgICAgUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gaGln aGxpZ2h0T2JqZWN0ID0gSW5zcGVjdG9yT2JqZWN0OjpjcmVhdGUoKTsKIAogICAgIC8vIFRoZSBt YWluIHZpZXcncyBzY3JvbGwgb2Zmc2V0IGlzIHNoYXJlZCBhY3Jvc3MgYWxsIHF1YWRzLgogICAg IEZyYW1lVmlldyogbWFpblZpZXcgPSBtX3BhZ2UtPm1haW5GcmFtZSgpLnZpZXcoKTsKICAgICBo aWdobGlnaHRPYmplY3QtPnNldE9iamVjdCgic2Nyb2xsIiwgYnVpbGRPYmplY3RGb3JQb2ludCgh bWFpblZpZXctPmRlbGVnYXRlc1Njcm9sbGluZygpID8gbWFpblZpZXctPnZpc2libGVDb250ZW50 UmVjdCgpLmxvY2F0aW9uKCkgOiBGbG9hdFBvaW50KCkpKTsKIAotICAgIGhpZ2hsaWdodE9iamVj dC0+c2V0QXJyYXkoImZyYWdtZW50cyIsIGJ1aWxkT2JqZWN0Rm9yUmVuZGVyZXJGcmFnbWVudHMo cmVuZGVyZXIsIG1fbm9kZUhpZ2hsaWdodENvbmZpZykpOworICAgIGhpZ2hsaWdodE9iamVjdC0+ c2V0QXJyYXkoImZyYWdtZW50cyIsIGhpZ2hsaWdodEZyYWdtZW50cy5yZWxlYXNlKCkpOwogCiAg ICAgaWYgKG1fbm9kZUhpZ2hsaWdodENvbmZpZy5zaG93SW5mbykgewogICAgICAgICBSZWZQdHI8 SW5zcGVjdG9yT2JqZWN0PiBlbGVtZW50SW5mbyA9IGJ1aWxkT2JqZWN0Rm9yRWxlbWVudEluZm8o bm9kZSk7Cg== 214514 2013-10-17 14:35:44 -0700 2013-10-17 15:06:42 -0700 Patch V2 bug122993_v2.patch text/plain 5752 achicu ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmNzgyMmMxLi5lMjcwMWE3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMTAt MTcgIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgorCisgICAgICAgIFdl YiBJbnNwZWN0b3I6IFtDU1MgUmVnaW9uc10gQ3Jhc2ggd2hlbiBoaWdobGlnaHRpbmcgYSBub2Rl IG9mIGEgZmxvdyB3aXRoIG5vIHJlZ2lvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyMjk5MworCisgICAgICAgIFJldmlld2VkIGJ5IEpvc2VwaCBQ ZWNvcmFyby4KKworICAgICAgICBBZGRlZCB0ZXN0IHRvIGNoZWNrIHRoYXQgRE9NLmhpZ2hsaWdo dE5vZGUgaXMgbm90IGNyYXNoaW5nIFdlYkNvcmUgd2hlbiB0aGUgbm9kZSBpcyBpbnNpZGUKKyAg ICAgICAgYSBmbG93IHdpdGggbm8gYXNzb2NpYXRlZCByZWdpb25zLgorCisgICAgICAgICogaW5z cGVjdG9yLXByb3RvY29sL2RvbS9oaWdobGlnaHQtZmxvdy13aXRoLW5vLXJlZ2lvbi1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGluc3BlY3Rvci1wcm90b2NvbC9kb20vaGlnaGxpZ2h0 LWZsb3ctd2l0aC1uby1yZWdpb24uaHRtbDogQWRkZWQuCisKIDIwMTMtMTAtMTYgIENvbW1pdCBR dWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJv bGxpbmcgb3V0IHIxNTc1MjkuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJv dG9jb2wvZG9tL2hpZ2hsaWdodC1mbG93LXdpdGgtbm8tcmVnaW9uLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9kb20vaGlnaGxpZ2h0LWZsb3ctd2l0aC1uby1y ZWdpb24tZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjkw Y2M2ZGYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wv ZG9tL2hpZ2hsaWdodC1mbG93LXdpdGgtbm8tcmVnaW9uLWV4cGVjdGVkLnR4dApAQCAtMCwwICsx IEBACitUZXN0aW5nIHRoYXQgdGhlIGJhY2tlbmQgaXMgbm90IGNyYXNoaW5nIHdoZW4gaGlnaGxp Z2h0aW5nIGEgbm9kZSB0aGF0IGhhcyBubyBhc3NvY2lhdGVkIHJlZ2lvbi4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9kb20vaGlnaGxpZ2h0LWZsb3ctd2l0aC1u by1yZWdpb24uaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9kb20vaGlnaGxp Z2h0LWZsb3ctd2l0aC1uby1yZWdpb24uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi5iNDlkNTkyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9y LXByb3RvY29sL2RvbS9oaWdobGlnaHQtZmxvdy13aXRoLW5vLXJlZ2lvbi5odG1sCkBAIC0wLDAg KzEsNDkgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIg c3JjPSIuLi8uLi9odHRwL3Rlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9yZXNvdXJjZXMvcHJvdG9j b2wtdGVzdC5qcyI+PC9zY3JpcHQ+Cis8c3R5bGU+CisjZmxvdyB7CisgICAgLXdlYmtpdC1mbG93 LWludG86IGZsb3c7Cit9Cis8L3N0eWxlPgorPHNjcmlwdD4KK2Z1bmN0aW9uIHRlc3QoKQorewor ICAgIEluc3BlY3RvclRlc3Quc2VuZENvbW1hbmQoIkRPTS5nZXREb2N1bWVudCIsIHt9LCBvbkdv dERvY3VtZW50KTsKKworICAgIGZ1bmN0aW9uIG9uR290RG9jdW1lbnQobXNnKSB7CisgICAgICAg IEluc3BlY3RvclRlc3QuY2hlY2tGb3JFcnJvcihtc2cpOworICAgICAgICB2YXIgbm9kZSA9IG1z Zy5yZXN1bHQucm9vdDsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5zZW5kQ29tbWFuZCgiRE9NLnF1 ZXJ5U2VsZWN0b3IiLCB7ICJub2RlSWQiOiBub2RlLm5vZGVJZCwgInNlbGVjdG9yIjogIiNpbnNw ZWN0ZWRFbGVtZW50IiB9LCBvblF1ZXJ5U2VsZWN0b3IpOworICAgIH0KKworICAgIGZ1bmN0aW9u IG9uUXVlcnlTZWxlY3Rvcihtc2cpIHsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5jaGVja0ZvckVy cm9yKG1zZyk7CisgICAgICAgIHZhciBub2RlID0gbXNnLnJlc3VsdDsKKyAgICAgICAgdmFyIGhp Z2hsaWdodENvbmZpZyA9IHsKKyAgICAgICAgICAgIHNob3dJbmZvOiB0cnVlLAorICAgICAgICAg ICAgY29udGVudENvbG9yOiB7cjogMjU1LCBnOiAyNTUsIGI6IDI1NX0sCisgICAgICAgICAgICBw YWRkaW5nQ29sb3I6IHtyOiAyNTUsIGc6IDI1NSwgYjogMjU1fSwKKyAgICAgICAgICAgIGJvcmRl ckNvbG9yOiB7cjogMjU1LCBnOiAyNTUsIGI6IDI1NX0sCisgICAgICAgICAgICBtYXJnaW5Db2xv cjoge3I6IDI1NSwgZzogMjU1LCBiOiAyNTV9LAorICAgICAgICB9OworICAgICAgICBJbnNwZWN0 b3JUZXN0LnNlbmRDb21tYW5kKCJET00uaGlnaGxpZ2h0Tm9kZSIsIHsgImhpZ2hsaWdodENvbmZp ZyI6IGhpZ2hsaWdodENvbmZpZywgIm5vZGVJZCI6IG5vZGUubm9kZUlkIH0sIG9uSGlnaGxpZ2h0 Q29tcGxldGUpOworICAgIH0KKworICAgIGZ1bmN0aW9uIG9uSGlnaGxpZ2h0Q29tcGxldGUobXNn KSB7CisgICAgICAgIEluc3BlY3RvclRlc3QuY2hlY2tGb3JFcnJvcihtc2cpOworICAgICAgICBJ bnNwZWN0b3JUZXN0LmNvbXBsZXRlVGVzdCgpOworICAgIH0KK30KKzwvc2NyaXB0PgorPC9oZWFk PgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorCis8ZGl2IGlkPSJmbG93Ij4KKyAgICA8ZGl2 IGlkPSJpbnNwZWN0ZWRFbGVtZW50Ij48L2Rpdj4KKzwvZGl2PgorCis8cD5UZXN0aW5nIHRoYXQg dGhlIGJhY2tlbmQgaXMgbm90IGNyYXNoaW5nIHdoZW4gaGlnaGxpZ2h0aW5nIGEgbm9kZSB0aGF0 IGhhcyBubyBhc3NvY2lhdGVkIHJlZ2lvbi48L3A+CisKKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCAzNjM5OTcxLi5iZGVhMmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIw MTMtMTAtMTcgIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgorCisgICAg ICAgIFdlYiBJbnNwZWN0b3I6IFtDU1MgUmVnaW9uc10gQ3Jhc2ggd2hlbiBoaWdobGlnaHRpbmcg YSBub2RlIG9mIGEgZmxvdyB3aXRoIG5vIHJlZ2lvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjk5MworCisgICAgICAgIFJldmlld2VkIGJ5IEpv c2VwaCBQZWNvcmFyby4KKworICAgICAgICBUZXN0OiBpbnNwZWN0b3ItcHJvdG9jb2wvZG9tL2hp Z2hsaWdodC1mbG93LXdpdGgtbm8tcmVnaW9uLmh0bWwKKworICAgICAgICBFdmVuIGlmIGEgbmFt ZWQgZmxvdyBoYXMgbm8gcmVnaW9ucyB0aGUgY29udGVudCBvZiB0aGUgZmxvdyB3aWxsIHN0aWxs IGhhdmUgcmVuZGVyZXIgb2JqZWN0cyBjcmVhdGVkLgorICAgICAgICBSZW1vdmVkIHRoZSBhc3N1 bXB0aW9uIHRoYXQgYWxsIHJlbmRlcmVycyBpbnNpZGUgYSBSZW5kZXJGbG93VGhyZWFkIHdpbGwg YWx3YXlzIGhhdmUgYW4gZW5jbG9zaW5nIFJlbmRlclJlZ2lvbi4KKworICAgICAgICAqIGluc3Bl Y3Rvci9JbnNwZWN0b3JPdmVybGF5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkT2JqZWN0 Rm9yUmVuZGVyZXJGcmFnbWVudHMpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yT3Zlcmxh eTo6YnVpbGRPYmplY3RGb3JIaWdobGlnaHRlZE5vZGUpOgorCiAyMDEzLTEwLTE2ICBBbmRyZWFz IEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBUYWtlIFJlbmRlck9iamVjdHMg b3V0IG9mIHRoZSBhcmVuYS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JPdmVybGF5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JP dmVybGF5LmNwcAppbmRleCA3OTM0NTljLi43MjVkY2U4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwCkBAIC01MDEsNyArNTAxLDcgQEAgc3RhdGlj IFBhc3NSZWZQdHI8SW5zcGVjdG9yQXJyYXk+IGJ1aWxkT2JqZWN0Rm9yUmVuZGVyZXJGcmFnbWVu dHMoUmVuZGVyT2JqZWN0KgogICAgICAgICBSZW5kZXJSZWdpb24qIGVuZFJlZ2lvbiA9IG51bGxw dHI7CiAgICAgICAgIGNvbnRhaW5pbmdGbG93VGhyZWFkLT5nZXRSZWdpb25SYW5nZUZvckJveChl bmNsb3NpbmdCb3gsIHN0YXJ0UmVnaW9uLCBlbmRSZWdpb24pOwogICAgICAgICBpZiAoIXN0YXJ0 UmVnaW9uKSB7Ci0gICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAg IC8vIFRoZSBmbG93IGhhcyBubyB2aXNpYmxlIHJlZ2lvbnMuIFRoZSByZW5kZXJlciBpcyBub3Qg dmlzaWJsZSBvbiBzY3JlZW4uCiAgICAgICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICAgICAg fQogICAgICAgICBjb25zdCBSZW5kZXJSZWdpb25MaXN0JiByZWdpb25MaXN0ID0gY29udGFpbmlu Z0Zsb3dUaHJlYWQtPnJlbmRlclJlZ2lvbkxpc3QoKTsKQEAgLTU5MSwxMyArNTkxLDE3IEBAIFBh c3NSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBJbnNwZWN0b3JPdmVybGF5OjpidWlsZE9iamVjdEZv ckhpZ2hsaWdodGVkTm9kZSgpIGNvCiAgICAgaWYgKCFyZW5kZXJlcikKICAgICAgICAgcmV0dXJu IG51bGxwdHI7CiAKKyAgICBSZWZQdHI8SW5zcGVjdG9yQXJyYXk+IGhpZ2hsaWdodEZyYWdtZW50 cyA9IGJ1aWxkT2JqZWN0Rm9yUmVuZGVyZXJGcmFnbWVudHMocmVuZGVyZXIsIG1fbm9kZUhpZ2hs aWdodENvbmZpZyk7CisgICAgaWYgKCFoaWdobGlnaHRGcmFnbWVudHMpCisgICAgICAgIHJldHVy biBudWxscHRyOworCiAgICAgUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gaGlnaGxpZ2h0T2JqZWN0 ID0gSW5zcGVjdG9yT2JqZWN0OjpjcmVhdGUoKTsKIAogICAgIC8vIFRoZSBtYWluIHZpZXcncyBz Y3JvbGwgb2Zmc2V0IGlzIHNoYXJlZCBhY3Jvc3MgYWxsIHF1YWRzLgogICAgIEZyYW1lVmlldyog bWFpblZpZXcgPSBtX3BhZ2UtPm1haW5GcmFtZSgpLnZpZXcoKTsKICAgICBoaWdobGlnaHRPYmpl Y3QtPnNldE9iamVjdCgic2Nyb2xsIiwgYnVpbGRPYmplY3RGb3JQb2ludCghbWFpblZpZXctPmRl bGVnYXRlc1Njcm9sbGluZygpID8gbWFpblZpZXctPnZpc2libGVDb250ZW50UmVjdCgpLmxvY2F0 aW9uKCkgOiBGbG9hdFBvaW50KCkpKTsKIAotICAgIGhpZ2hsaWdodE9iamVjdC0+c2V0QXJyYXko ImZyYWdtZW50cyIsIGJ1aWxkT2JqZWN0Rm9yUmVuZGVyZXJGcmFnbWVudHMocmVuZGVyZXIsIG1f bm9kZUhpZ2hsaWdodENvbmZpZykpOworICAgIGhpZ2hsaWdodE9iamVjdC0+c2V0QXJyYXkoImZy YWdtZW50cyIsIGhpZ2hsaWdodEZyYWdtZW50cy5yZWxlYXNlKCkpOwogCiAgICAgaWYgKG1fbm9k ZUhpZ2hsaWdodENvbmZpZy5zaG93SW5mbykgewogICAgICAgICBSZWZQdHI8SW5zcGVjdG9yT2Jq ZWN0PiBlbGVtZW50SW5mbyA9IGJ1aWxkT2JqZWN0Rm9yRWxlbWVudEluZm8obm9kZSk7Cg==