12299 2007-01-17 07:17:21 -0800 REGRESSION: Page changes title when command-clicking on named anchor link 2007-01-21 19:04:23 -0800 1 1 1 Unclassified WebKit Page Loading 420+ Mac OS X 10.4 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 ddkilzer darin oldest_to_newest 34501 0 ddkilzer 2007-01-17 07:17:21 -0800 Summary: When command-clicking on an anchor link (<a href="#foo">link</a>), the title of the current page changes when a new tab is created. Steps to reproduce: 1. Open Attachment 12006 from Bug 11960. 2. Command-click on the link. Expected Results: Page title of current tab should not change from its URL. Actual Results: Page title of current page changes from its URL to: "unknown" failed to load Regression: This is a regression from shipping Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8L127). Notes: See Bug 11960 Comment #7 for original details. Tested on locally-built debug build of WebKit r18906 with Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8L127). 34407 1 mrowe 2007-01-17 14:23:31 -0800 <rdar://problem/4930503> 33747 2 darin 2007-01-21 18:16:34 -0800 When I tried this I hit an assertion. The problem seems to be that when the policy delegate set the policy to ignore, we keep doing way too much. Specifically, it looks like FrameLoader::continueFragmentScrollAfterNavigationPolicy doesn't look at the shouldContinute boolean at all. 33741 3 12592 darin 2007-01-21 18:25:56 -0800 Created attachment 12592 patch with change log 33731 4 12592 mjs 2007-01-21 18:56:35 -0800 Comment on attachment 12592 patch with change log r=me 33722 5 darin 2007-01-21 19:04:23 -0800 Committed revision 19022. 12592 2007-01-21 18:25:56 -0800 2007-01-21 18:56:35 -0800 patch with change log AnchorScrollPolicyPatch.txt text/plain 1471 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxOTAyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDctMDEtMjEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IDxyZGFyOi8vcHJvYmxlbS80OTMwNTAzPiBSRUdSRVNTSU9OOiBQYWdlIGNoYW5nZXMgdGl0bGUg d2hlbgorICAgICAgICAgIGNvbW1hbmQtY2xpY2tpbmcgb24gbmFtZWQgYW5jaG9yIGxpbmsgKDEy Mjk5KQorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkZyYW1lTG9hZGVyOjpjb250aW51ZUZyYWdtZW50U2Nyb2xsQWZ0ZXJOYXZpZ2F0aW9uUG9s aWN5KToKKyAgICAgICAgUmV0dXJuIGlmIHNob3VsZENvbnRpbnVlIGlzIGZhbHNlLiBUaGlzIG1h dGNoZXMgdGhlIG90aGVyIHNpbWlsYXIKKyAgICAgICAgZnVuY3Rpb25zIGFuZCBwcmV2ZW50cyB1 cyBmcm9tIGRvaW5nIGV4dHJhIHdvcmsgaW4gdGhlICJpZ25vcmUiIGNhc2UuCisKIDIwMDctMDEt MjEgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluLgpJbmRleDogV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNpb24gMTkwMTYpCisrKyBX ZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxMzksMTAg KzMxMzksMTMgQEAgdm9pZCBGcmFtZUxvYWRlcjo6Y2FsbENvbnRpbnVlRnJhZ21lbnRTYwogCiB2 b2lkIEZyYW1lTG9hZGVyOjpjb250aW51ZUZyYWdtZW50U2Nyb2xsQWZ0ZXJOYXZpZ2F0aW9uUG9s aWN5KGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgYm9vbCBzaG91bGRDb250aW51ZSkK IHsKLSAgICBLVVJMIFVSTCA9IHJlcXVlc3QudXJsKCk7Ci0gICAgCiAgICAgYm9vbCBpc1JlZGly ZWN0ID0gbV9xdWlja1JlZGlyZWN0Q29taW5nOwogICAgIG1fcXVpY2tSZWRpcmVjdENvbWluZyA9 IGZhbHNlOworCisgICAgaWYgKCFzaG91bGRDb250aW51ZSkKKyAgICAgICAgcmV0dXJuOworCisg ICAgS1VSTCBVUkwgPSByZXF1ZXN0LnVybCgpOwogICAgIAogICAgIG1fZG9jdW1lbnRMb2FkZXIt PnJlcGxhY2VSZXF1ZXN0VVJMRm9yQW5jaG9yU2Nyb2xsKFVSTCk7CiAgICAgaWYgKCFpc1JlZGly ZWN0ICYmICFzaG91bGRUcmVhdFVSTEFzU2FtZUFzQ3VycmVudChVUkwpKSB7Cg==