122974 2013-10-17 11:04:44 -0700 Remove saving callFrameRegister to JITStackFrame in JITCompiler::compileFunction() 2013-10-17 11:56:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 121756 1 msaboff msaboff oldest_to_newest 940847 0 msaboff 2013-10-17 11:04:44 -0700 This is no longer needed as the stack check and arity check are now operations. Change is to delete two instances of move(stackPointerRegister, GPRInfo::argumentGPR0); poke(GPRInfo::callFrameRegister, OBJECT_OFFSETOF(struct JITStackFrame, callFrame) / sizeof(void*)); in Source/JavaScriptCore/dfg/DFGJITCompiler.cpp 940868 1 214475 msaboff 2013-10-17 11:32:08 -0700 Created attachment 214475 Patch 940873 2 214475 ggaren 2013-10-17 11:46:34 -0700 Comment on attachment 214475 Patch r=me 940883 3 msaboff 2013-10-17 11:56:07 -0700 Committed r157586: <http://trac.webkit.org/changeset/157586> 214475 2013-10-17 11:32:08 -0700 2013-10-17 11:46:34 -0700 Patch 122974.patch text/plain 2281 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3NTgyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTEwLTE3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJlbW92ZSBzYXZpbmcgY2FsbEZyYW1lUmVnaXN0ZXIgdG8gSklUU3RhY2tGcmFtIGluIEpJ VENvbXBpbGVyOjpjb21waWxlRnVuY3Rpb24oKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyOTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRWxpbWluYXRlZCB1bm5lZWRlZCBzdG9yaW5nIHRvIEpJVFN0 YWNrRnJhbWUuCisKKyAgICAgICAgKiBkZmcvREZHSklUQ29tcGlsZXIuY3BwOgorICAgICAgICAo SlNDOjpERkc6OkpJVENvbXBpbGVyOjpjb21waWxlRnVuY3Rpb24pOgorCiAyMDEzLTEwLTE3ICBN aWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFRyYW5zaXRpb24g Y3RpX29wX3Rocm93IGFuZCBjdGlfdm1fdGhyb3cgdG8gYSBKSVQgb3BlcmF0aW9uCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVyLmNwcAkocmV2aXNpb24g MTU3NTgyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdKSVRDb21waWxlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTM4MCw4ICszODAsNiBAQCB2b2lkIEpJVENvbXBpbGVyOjpjb21w aWxlRnVuY3Rpb24oKQogICAgIC8vIHdlIG5lZWQgdG8gY2FsbCBvdXQgdG8gYSBoZWxwZXIgZnVu Y3Rpb24gdG8gY2hlY2sgd2hldGhlciBtb3JlIHNwYWNlIGlzIGF2YWlsYWJsZS4KICAgICAvLyBG SVhNRTogY2hhbmdlIHRoaXMgZnJvbSBhIGN0aSBjYWxsIHRvIGEgREZHIHN0eWxlIG9wZXJhdGlv biAobm9ybWFsIEMgY2FsbGluZyBjb252ZW50aW9ucykuCiAgICAgc3RhY2tDaGVjay5saW5rKHRo aXMpOwotICAgIG1vdmUoc3RhY2tQb2ludGVyUmVnaXN0ZXIsIEdQUkluZm86OmFyZ3VtZW50R1BS MCk7Ci0gICAgcG9rZShHUFJJbmZvOjpjYWxsRnJhbWVSZWdpc3RlciwgT0JKRUNUX09GRlNFVE9G KHN0cnVjdCBKSVRTdGFja0ZyYW1lLCBjYWxsRnJhbWUpIC8gc2l6ZW9mKHZvaWQqKSk7CiAKICAg ICBlbWl0U3RvcmVDb2RlT3JpZ2luKENvZGVPcmlnaW4oMCkpOwogICAgIG1fc3BlY3VsYXRpdmUt PmNhbGxPcGVyYXRpb25XaXRoQ2FsbEZyYW1lUm9sbGJhY2tPbkV4Y2VwdGlvbihvcGVyYXRpb25T dGFja0NoZWNrLCBtX2NvZGVCbG9jayk7CkBAIC0zOTcsOCArMzk1LDYgQEAgdm9pZCBKSVRDb21w aWxlcjo6Y29tcGlsZUZ1bmN0aW9uKCkKIAogICAgIGxvYWQzMihBc3NlbWJseUhlbHBlcnM6OnBh eWxvYWRGb3IoKFZpcnR1YWxSZWdpc3RlcilKU1N0YWNrOjpBcmd1bWVudENvdW50KSwgR1BSSW5m bzo6cmVnVDEpOwogICAgIGJyYW5jaDMyKEFib3ZlT3JFcXVhbCwgR1BSSW5mbzo6cmVnVDEsIFRy dXN0ZWRJbW0zMihtX2NvZGVCbG9jay0+bnVtUGFyYW1ldGVycygpKSkubGlua1RvKGZyb21Bcml0 eUNoZWNrLCB0aGlzKTsKLSAgICBtb3ZlKHN0YWNrUG9pbnRlclJlZ2lzdGVyLCBHUFJJbmZvOjph cmd1bWVudEdQUjApOwotICAgIHBva2UoR1BSSW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIsIE9CSkVD VF9PRkZTRVRPRihzdHJ1Y3QgSklUU3RhY2tGcmFtZSwgY2FsbEZyYW1lKSAvIHNpemVvZih2b2lk KikpOwogICAgIGVtaXRTdG9yZUNvZGVPcmlnaW4oQ29kZU9yaWdpbigwKSk7CiAgICAgbV9zcGVj dWxhdGl2ZS0+Y2FsbE9wZXJhdGlvbldpdGhDYWxsRnJhbWVSb2xsYmFja09uRXhjZXB0aW9uKG1f Y29kZUJsb2NrLT5tX2lzQ29uc3RydWN0b3IgPyBvcGVyYXRpb25Db25zdHJ1Y3RBcml0eUNoZWNr IDogb3BlcmF0aW9uQ2FsbEFyaXR5Q2hlY2ssIEdQUkluZm86OnJlZ1QwKTsKICAgICBicmFuY2hU ZXN0MzIoWmVybywgR1BSSW5mbzo6cmVnVDApLmxpbmtUbyhmcm9tQXJpdHlDaGVjaywgdGhpcyk7 Cg==