122973 2013-10-17 10:53:44 -0700 Eliminate uses of JITSTACKFRAME_ARGS_INDEX as scratch area for thunks 2013-10-17 15:58:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 121756 122978 1 msaboff ggaren ggaren oldest_to_newest 940835 0 msaboff 2013-10-17 10:53:44 -0700 Various thinks use JITSTACKFRAME_ARGS_INDEX as a scratch area in Source/JavaScriptCore/jit/ThunkGenerators.cpp. 940995 1 ggaren 2013-10-17 14:58:07 -0700 Michael said he is fixing this as a part of Bug 122980. 940997 2 msaboff 2013-10-17 15:03:49 -0700 (In reply to comment #1) > Michael said he is fixing this as a part of Bug 122980. I'm not working on this one. 941024 3 214526 ggaren 2013-10-17 15:53:23 -0700 Created attachment 214526 Patch 941026 4 ggaren 2013-10-17 15:58:45 -0700 Committed r157609: <http://trac.webkit.org/changeset/157609> 214526 2013-10-17 15:53:23 -0700 2013-10-17 15:54:58 -0700 Patch bug-122973-20131017155312.patch text/plain 4609 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3NjA3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDEzLTEwLTE3ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgRWxpbWluYXRlIHVzZXMgb2YgSklUU1RBQ0tGUkFNRV9BUkdTX0lOREVYIGFzIHNjcmF0Y2gg YXJlYSBmb3IgdGh1bmtzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjI5NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGppdC9UaHVua0dlbmVyYXRvcnMuY3BwOgorICAgICAgICAoSlNDOjp0aHJvd0V4 Y2VwdGlvbkZyb21DYWxsU2xvd1BhdGhHZW5lcmF0b3IpOiBUaGlzIHdhcyBhbGwgZGVhZCBjb2Rl LAorICAgICAgICBzbyBJIHJlbW92ZWQgaXQuCisKKyAgICAgICAgVGhlIGNvZGUgYWN0ZWQgYXMg aWYgaXQgbmVlZGVkIHRvIHBhc3MgYW4gYXJndW1lbnQgdG8KKyAgICAgICAgbG9va3VwRXhjZXB0 aW9uSGFuZGxlciwgYW5kIGFzIGlmIGl0IHBhc3NlZCB0aGF0IGFyZ3VtZW50IHRvIGl0c2VsZgor ICAgICAgICB0aHJvdWdoIEpJVFN0YWNrRnJhbWUuIEhvd2V2ZXIsIGxvb2t1cEV4Y2VwdGlvbkhh bmRsZXIgZG9lcyBub3QgdGFrZQorICAgICAgICBhbiBhcmd1bWVudCAob3RoZXIgdGhhbiB0aGUg ZGVmYXVsdCBFeGVjU3RhdGUgYXJndW1lbnQpLCBhbmQgdGhlIGNvZGUKKyAgICAgICAgZGlkIG5v dCBpbml0aWFsaXplIHRoZSB0aGluZyB0aGF0IGl0IHRob3VnaHQgaXQgcGFzc2VkIHRvIGl0c2Vs ZiEKKwogMjAxMy0xMC0xNyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJ1biBKYXZhU2NyaXB0Q29yZSB0ZXN0cyBhZ2FpbiBvbiBXaW5kb3dz LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dlbmVyYXRvcnMuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNw cAkocmV2aXNpb24gMTU3NjAzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9UaHVua0dl bmVyYXRvcnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NiwyOSArNTYsMjQgQEAgaW5saW5lIHZv aWQgZW1pdFBvaW50ZXJWYWxpZGF0aW9uKENDYWxsSAogI2VuZGlmCiB9CiAKKy8vIFdlIHdpbGwg anVtcCBoZXJlIGlmIHRoZSBKSVQgY29kZSB0cmllcyB0byBtYWtlIGEgY2FsbCwgYnV0IHRoZQor Ly8gbGlua2luZyBoZWxwZXIgKEMrKyBjb2RlKSBkZWNpZGVzIHRvIHRocm93IGFuIGV4Y2VwdGlv biBpbnN0ZWFkLgogTWFjcm9Bc3NlbWJsZXJDb2RlUmVmIHRocm93RXhjZXB0aW9uRnJvbUNhbGxT bG93UGF0aEdlbmVyYXRvcihWTSogdm0pCiB7CiAgICAgQ0NhbGxIZWxwZXJzIGppdCh2bSk7CiAg ICAgCi0gICAgLy8gV2Ugd2lsbCBqdW1wIHRvIGhlcmUgaWYgdGhlIEpJVCBjb2RlIHRoaW5rcyBp dCdzIG1ha2luZyBhIGNhbGwsIGJ1dCB0aGUKLSAgICAvLyBsaW5raW5nIGhlbHBlciAoQysrIGNv ZGUpIGRlY2lkZWQgdG8gdGhyb3cgYW4gZXhjZXB0aW9uIGluc3RlYWQuIFdlIHdpbGwKLSAgICAv LyBoYXZlIHNhdmVkIHRoZSBjYWxsUmV0dXJuSW5kZXggaW4gdGhlIGZpcnN0IGFyZ3VtZW50cyBv ZiBKSVRTdGFja0ZyYW1lLgotICAgIC8vIE5vdGUgdGhhdCB0aGUgcmV0dXJuIGFkZHJlc3Mgd2ls bCBiZSBvbiB0aGUgc3RhY2sgYXQgdGhpcyBwb2ludCwgc28gd2UKLSAgICAvLyBuZWVkIHRvIHJl bW92ZSBpdCBhbmQgZHJvcCBpdCBvbiB0aGUgZmxvb3IsIHNpbmNlIHdlIGRvbid0IGNhcmUgYWJv dXQgaXQuCi0gICAgLy8gRmluYWxseSBub3RlIHRoYXQgdGhlIGNhbGwgZnJhbWUgcmVnaXN0ZXIg cG9pbnRzIGF0IHRoZSBjYWxsZWUgZnJhbWUsIHNvCi0gICAgLy8gd2UgbmVlZCB0byBwb3AgaXQu CisgICAgLy8gVGhlIGNhbGwgcHVzaGVkIGEgcmV0dXJuIGFkZHJlc3MsIHNvIHdlIG5lZWQgdG8g cG9wIGl0IGJhY2sgb2ZmIHRvIHJlLWFsaWduIHRoZSBzdGFjaywKKyAgICAvLyBldmVuIHRob3Vn aCB3ZSB3b24ndCB1c2UgaXQuCiAgICAgaml0LnByZXNlcnZlUmV0dXJuQWRkcmVzc0FmdGVyQ2Fs bChHUFJJbmZvOjpub25QcmVzZXJ2ZWROb25SZXR1cm5HUFIpOworCisgICAgLy8gVGhlIENhbGxG cmFtZSByZWdpc3RlciBwb2ludHMgdG8gdGhlIChmYWlsZWQpIGNhbGxlZSBmcmFtZSwgc28gd2Ug bmVlZCB0byBwb3AgYmFjayBvbmUgZnJhbWUuCiAgICAgaml0LmxvYWRQdHIoCiAgICAgICAgIEND YWxsSGVscGVyczo6QWRkcmVzcygKICAgICAgICAgICAgIEdQUkluZm86OmNhbGxGcmFtZVJlZ2lz dGVyLAogICAgICAgICAgICAgc3RhdGljX2Nhc3Q8cHRyZGlmZl90PihzaXplb2YoUmVnaXN0ZXIp KSAqIEpTU3RhY2s6OkNhbGxlckZyYW1lKSwKICAgICAgICAgR1BSSW5mbzo6Y2FsbEZyYW1lUmVn aXN0ZXIpOwotI2lmIFVTRShKU1ZBTFVFNjQpCi0gICAgaml0LnBlZWs2NChHUFJJbmZvOjpub25Q cmVzZXJ2ZWROb25SZXR1cm5HUFIsIEpJVFNUQUNLRlJBTUVfQVJHU19JTkRFWCk7Ci0jZWxzZQot ICAgIGppdC5wZWVrKEdQUkluZm86Om5vblByZXNlcnZlZE5vblJldHVybkdQUiwgSklUU1RBQ0tG UkFNRV9BUkdTX0lOREVYKTsKLSNlbmRpZgotICAgIGppdC5zZXR1cEFyZ3VtZW50c1dpdGhFeGVj U3RhdGUoR1BSSW5mbzo6bm9uUHJlc2VydmVkTm9uUmV0dXJuR1BSKTsKKworICAgIGppdC5zZXR1 cEFyZ3VtZW50c0V4ZWNTdGF0ZSgpOwogICAgIGppdC5tb3ZlKENDYWxsSGVscGVyczo6VHJ1c3Rl ZEltbVB0cihiaXR3aXNlX2Nhc3Q8dm9pZCo+KGxvb2t1cEV4Y2VwdGlvbkhhbmRsZXIpKSwgR1BS SW5mbzo6bm9uQXJnR1BSMCk7CiAgICAgZW1pdFBvaW50ZXJWYWxpZGF0aW9uKGppdCwgR1BSSW5m bzo6bm9uQXJnR1BSMCk7CiAgICAgaml0LmNhbGwoR1BSSW5mbzo6bm9uQXJnR1BSMCk7CkBAIC0x MDAsMTEgKzk1LDYgQEAgc3RhdGljIHZvaWQgc2xvd1BhdGhGb3IoCiAgICAgICAgICAgICBHUFJJ bmZvOjpjYWxsRnJhbWVSZWdpc3RlciwKICAgICAgICAgICAgIHN0YXRpY19jYXN0PHB0cmRpZmZf dD4oc2l6ZW9mKFJlZ2lzdGVyKSkgKiBKU1N0YWNrOjpSZXR1cm5QQykpOwogICAgIGppdC5zdG9y ZVB0cihHUFJJbmZvOjpjYWxsRnJhbWVSZWdpc3RlciwgJnZtLT50b3BDYWxsRnJhbWUpOwotI2lm IFVTRShKU1ZBTFVFNjQpCi0gICAgaml0LnBva2U2NChHUFJJbmZvOjpub25QcmVzZXJ2ZWROb25S ZXR1cm5HUFIsIEpJVFNUQUNLRlJBTUVfQVJHU19JTkRFWCk7Ci0jZWxzZQotICAgIGppdC5wb2tl KEdQUkluZm86Om5vblByZXNlcnZlZE5vblJldHVybkdQUiwgSklUU1RBQ0tGUkFNRV9BUkdTX0lO REVYKTsKLSNlbmRpZgogICAgIGppdC5zZXR1cEFyZ3VtZW50c0V4ZWNTdGF0ZSgpOwogICAgIGpp dC5tb3ZlKENDYWxsSGVscGVyczo6VHJ1c3RlZEltbVB0cihiaXR3aXNlX2Nhc3Q8dm9pZCo+KHNs b3dQYXRoRnVuY3Rpb24pKSwgR1BSSW5mbzo6bm9uQXJnR1BSMCk7CiAgICAgZW1pdFBvaW50ZXJW YWxpZGF0aW9uKGppdCwgR1BSSW5mbzo6bm9uQXJnR1BSMCk7CkBAIC0xMzYsMTAgKzEyNiw4IEBA IHN0YXRpYyBNYWNyb0Fzc2VtYmxlckNvZGVSZWYgbGlua0ZvclRodW4KICAgICAvLyBUaGUgcmV0 dXJuIGFkZHJlc3MgaXMgb24gdGhlIHN0YWNrIG9yIGluIHRoZSBsaW5rIHJlZ2lzdGVyLiBXZSB3 aWxsIGhlbmNlCiAgICAgLy8gc2F2ZSB0aGUgcmV0dXJuIGFkZHJlc3MgdG8gdGhlIGNhbGwgZnJh bWUgd2hpbGUgd2UgbWFrZSBhIEMrKyBmdW5jdGlvbiBjYWxsCiAgICAgLy8gdG8gcGVyZm9ybSBs aW5raW5nIGFuZCBsYXp5IGNvbXBpbGF0aW9uIGlmIG5lY2Vzc2FyeS4gV2UgZXhwZWN0IHRoZSBj YWxsZWUKLSAgICAvLyB0byBiZSBpbiBub25BcmdHUFIwL25vbkFyZ0dQUjEgKHBheWxvYWQvdGFn KSwgdGhlIGNhbGwgZnJhbWUgdG8gaGF2ZSBhbHJlYWR5Ci0gICAgLy8gYmVlbiBhZGp1c3RlZCwg bm9uUHJlc2VydmVkTm9uUmV0dXJuR1BSIGhvbGRzIHRoZSBleGNlcHRpb24gaGFuZGxlciBpbmRl eCwKLSAgICAvLyBhbmQgYWxsIG90aGVyIHJlZ2lzdGVycyB0byBiZSBhdmFpbGFibGUgZm9yIHVz ZS4gV2UgdXNlIEpJVFN0YWNrRnJhbWU6OmFyZ3MKLSAgICAvLyB0byBzYXZlIGltcG9ydGFudCBp bmZvcm1hdGlvbiBhY3Jvc3MgY2FsbHMuCisgICAgLy8gdG8gYmUgaW4gbm9uQXJnR1BSMC9ub25B cmdHUFIxIChwYXlsb2FkL3RhZyksIHRoZSBDYWxsRnJhbWUgdG8gaGF2ZSBhbHJlYWR5CisgICAg Ly8gYmVlbiBhZGp1c3RlZCwgYW5kIGFsbCBvdGhlciByZWdpc3RlcnMgdG8gYmUgYXZhaWxhYmxl IGZvciB1c2UuCiAgICAgCiAgICAgQ0NhbGxIZWxwZXJzIGppdCh2bSk7CiAgICAgCg==