122958 2013-10-17 05:27:36 -0700 [WK2] REGRESSION(r156472): scrolling coordinator is always enabled incorrectly. 2013-10-17 10:58:34 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 adusnoki webkit-unassigned commit-queue darin marcelo.lira noam ossy sam thorton oldest_to_newest 940735 0 adusnoki 2013-10-17 05:27:36 -0700 http://trac.webkit.org/changeset/156472/trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 324 m_useThreadedScrolling = parameters.store.getBoolValueForKey(WebPreferencesKey::threadedScrollingEnabledKey()); 325 m_page->settings().setScrollingCoordinatorEnabled(m_useThreadedScrolling); You can easily reproduce it on WebKitNix's MiniBrowser in desktop mode where scrolling doesn't work at all. I think the lines above should be in #if ENABLE(THREADED_SCROLLING) guard. USE(COORDINATED_GRAPHICS) platforms set ScrollingCoordinatorEnabled in WebPage::setUseFixedLayout(bool fixed) depends on mobile or desktop mode. 940742 1 214446 adusnoki 2013-10-17 05:40:58 -0700 Created attachment 214446 Proposed patch 940829 2 thorton 2013-10-17 10:32:14 -0700 Whoops. This might explain what happened on Lion a few days ago :| 940840 3 214446 commit-queue 2013-10-17 10:58:31 -0700 Comment on attachment 214446 Proposed patch Clearing flags on attachment: 214446 Committed r157580: <http://trac.webkit.org/changeset/157580> 940841 4 commit-queue 2013-10-17 10:58:34 -0700 All reviewed patches have been landed. Closing bug. 214446 2013-10-17 05:40:58 -0700 2013-10-17 10:58:31 -0700 Proposed patch patch text/plain 1416 adusnoki ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmZGU0MDFkLi4yZTRjYjNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTMtMTAtMTcgIEF0dGlsYSBEdXNub2tpICA8aDA0NzY3OUBzdHVkLnUtc3plZ2VkLmh1 PgorCisgICAgICAgIFtXSzJdIFJFR1JFU1NJT04ocjE1NjQ3Mik6IHNjcm9sbGluZyBjb29yZGlu YXRvciBpcyBhbHdheXMgZW5hYmxlZCBpbmNvcnJlY3RseS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjk1OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2Uu Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpXZWJQYWdlKTogTWlzc2luZyBFTkFCTEUo VEhSRUFERURfU0NST0xMSU5HKSBndWFyZCBhZGRlZC4KKwogMjAxMy0xMC0xNCAgQ3NhYmEgT3N6 dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtXSzJdW0VmbF1bU291cF0g TWFrZSBOZXR3b3JrUHJvY2Vzc01haW5Vbml4IGhhbmRsZSBwcm94eSBzZXR0aW5ncy4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCA2ZjQ5YzY0 Li4yNDQwYjc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv V2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwCkBAIC0zMDcsOCArMzA3LDEwIEBAIFdlYlBhZ2U6OldlYlBhZ2UodWludDY0X3QgcGFn ZUlELCBjb25zdCBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzKQogCiAgICAg bV9wYWdlID0gYWRvcHRQdHIobmV3IFBhZ2UocGFnZUNsaWVudHMpKTsKIAorI2lmIEVOQUJMRShU SFJFQURFRF9TQ1JPTExJTkcpCiAgICAgbV91c2VUaHJlYWRlZFNjcm9sbGluZyA9IHBhcmFtZXRl cnMuc3RvcmUuZ2V0Qm9vbFZhbHVlRm9yS2V5KFdlYlByZWZlcmVuY2VzS2V5Ojp0aHJlYWRlZFNj cm9sbGluZ0VuYWJsZWRLZXkoKSk7CiAgICAgbV9wYWdlLT5zZXR0aW5ncygpLnNldFNjcm9sbGlu Z0Nvb3JkaW5hdG9yRW5hYmxlZChtX3VzZVRocmVhZGVkU2Nyb2xsaW5nKTsKKyNlbmRpZgogCiAg ICAgbV9kcmF3aW5nQXJlYSA9IERyYXdpbmdBcmVhOjpjcmVhdGUodGhpcywgcGFyYW1ldGVycyk7 CiAgICAgbV9kcmF3aW5nQXJlYS0+c2V0UGFpbnRpbmdFbmFibGVkKGZhbHNlKTsK