122945 2013-10-17 00:30:12 -0700 WebCore::fillWithEmptyClients adopts new empty clients before leaking their pointers 2013-10-22 13:15:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan andersca commit-queue darin japhet oldest_to_newest 940676 0 zan 2013-10-17 00:30:12 -0700 WebCore::fillWithEmptyClients adopts new empty clients before leaking their pointers 940679 1 214428 zan 2013-10-17 00:42:38 -0700 Created attachment 214428 Patch 941714 2 214428 andersca 2013-10-20 12:38:05 -0700 Comment on attachment 214428 Patch These should just use NeverDestroyed instead. 941726 3 darin 2013-10-20 19:18:06 -0700 (In reply to comment #2) > These should just use NeverDestroyed instead. So you prefer NeverDestroyed<unique_ptr<X>> to, say, X& for these kinds of globals? 941862 4 zan 2013-10-21 08:50:48 -0700 (In reply to comment #3) > (In reply to comment #2) > > These should just use NeverDestroyed instead. > > So you prefer NeverDestroyed<unique_ptr<X>> to, say, X& for these kinds of globals? std::unique_ptr isn't that useful (or required) here. 941874 5 darin 2013-10-21 09:45:35 -0700 I believe there is an argument in favor of it that Anders may wish to make. I’d like to hear more from him. 941886 6 andersca 2013-10-21 10:07:15 -0700 (In reply to comment #3) > (In reply to comment #2) > > These should just use NeverDestroyed instead. > > So you prefer NeverDestroyed<unique_ptr<X>> to, say, X& for these kinds of globals? No, just NeverDestroyed<X>. 941903 7 darin 2013-10-21 11:01:31 -0700 (In reply to comment #6) > No, just NeverDestroyed<X>. Oh, right. Sorry, I guess I overlooked that possibility. Does seem better to avoid the heap memory allocation altogether. 942225 8 214834 zan 2013-10-22 04:07:31 -0700 Created attachment 214834 Patch 942388 9 214834 zan 2013-10-22 13:15:06 -0700 Comment on attachment 214834 Patch Clearing flags on attachment: 214834 Committed r157807: <http://trac.webkit.org/changeset/157807> 942389 10 zan 2013-10-22 13:15:14 -0700 All reviewed patches have been landed. Closing bug. 214428 2013-10-17 00:42:38 -0700 2013-10-22 04:07:25 -0700 Patch bug-122945-20131017004237.patch text/plain 2542 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3NTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGM2MDM1NDVjYzVmYjUz NjcyMGRlZWE5YzNhZjhlYTg5ODZhNTBhOC4uNDZmOWI4ZTE2OGQzYjIwOTEwZDI2NDQ1NjEzNTky Y2I0MjdiNjRkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEwLTE3ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJDb3JlOjpmaWxs V2l0aEVtcHR5Q2xpZW50cyBhZG9wdHMgbmV3IGVtcHR5IGNsaWVudHMgYmVmb3JlIGxlYWtpbmcg dGhlaXIgcG9pbnRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyMjk0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogbG9hZGVyL0VtcHR5Q2xpZW50cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpmaWxs V2l0aEVtcHR5Q2xpZW50cyk6IERvbid0IGFkb3B0IHRoZSBuZXcgZW1wdHkgY2xpZW50cyBvYmpl Y3RzIHJpZ2h0IGJlZm9yZSBsZWFraW5nIHRoZWlyIHBvaW50ZXJzCisgICAgICAgIHRvIHRoZSBz dGF0aWMgbmFrZWQgcG9pbnRlciB2YXJpYWJsZXMgLSBkaXJlY3RseSBzdG9yZSB0aGUgcG9pbnRl cnMgb2YgdGhvc2Ugb2JqZWN0cyBpbnN0ZWFkLgorCiAyMDEzLTEwLTE2ICBLeXVuZ1RhZSBLaW0g IDxrdGYua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIER1cmluZyBlZGl0aW5nLCBtZXJnZSBp bmxpbmUgc3R5bGUgd2l0aCBvdmVycmlkaW5nIG90aGVyIGF1dGhvciBzdHlsZXMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9FbXB0eUNsaWVudHMuY3BwIGIvU291cmNlL1dlYkNv cmUvbG9hZGVyL0VtcHR5Q2xpZW50cy5jcHAKaW5kZXggMzcwMjcyYzcyY2U0YWM0Zjc5ZGY2ZWUw NTNlMGRiZTcxYWVmN2Q4Ni4uOTNjOTE2NzBlNzczMmU2ZTAyYjljMjBmMTM5NjAwYjhiYTk0NjBj ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0VtcHR5Q2xpZW50cy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0VtcHR5Q2xpZW50cy5jcHAKQEAgLTQ0LDIzICs0NCwy MyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHZvaWQgZmlsbFdpdGhFbXB0eUNsaWVudHMoUGFn ZTo6UGFnZUNsaWVudHMmIHBhZ2VDbGllbnRzKQogewotICAgIHN0YXRpYyBDaHJvbWVDbGllbnQq IGR1bW15Q2hyb21lQ2xpZW50ID0gYWRvcHRQdHIobmV3IEVtcHR5Q2hyb21lQ2xpZW50KS5sZWFr UHRyKCk7CisgICAgc3RhdGljIENocm9tZUNsaWVudCogZHVtbXlDaHJvbWVDbGllbnQgPSBuZXcg RW1wdHlDaHJvbWVDbGllbnQ7CiAgICAgcGFnZUNsaWVudHMuY2hyb21lQ2xpZW50ID0gZHVtbXlD aHJvbWVDbGllbnQ7CiAKICNpZiBFTkFCTEUoQ09OVEVYVF9NRU5VUykKLSAgICBzdGF0aWMgQ29u dGV4dE1lbnVDbGllbnQqIGR1bW15Q29udGV4dE1lbnVDbGllbnQgPSBhZG9wdFB0cihuZXcgRW1w dHlDb250ZXh0TWVudUNsaWVudCkubGVha1B0cigpOworICAgIHN0YXRpYyBDb250ZXh0TWVudUNs aWVudCogZHVtbXlDb250ZXh0TWVudUNsaWVudCA9IG5ldyBFbXB0eUNvbnRleHRNZW51Q2xpZW50 OwogICAgIHBhZ2VDbGllbnRzLmNvbnRleHRNZW51Q2xpZW50ID0gZHVtbXlDb250ZXh0TWVudUNs aWVudDsKICNlbmRpZgogCiAjaWYgRU5BQkxFKERSQUdfU1VQUE9SVCkKLSAgICBzdGF0aWMgRHJh Z0NsaWVudCogZHVtbXlEcmFnQ2xpZW50ID0gYWRvcHRQdHIobmV3IEVtcHR5RHJhZ0NsaWVudCku bGVha1B0cigpOworICAgIHN0YXRpYyBEcmFnQ2xpZW50KiBkdW1teURyYWdDbGllbnQgPSBuZXcg RW1wdHlEcmFnQ2xpZW50OwogICAgIHBhZ2VDbGllbnRzLmRyYWdDbGllbnQgPSBkdW1teURyYWdD bGllbnQ7CiAjZW5kaWYKIAotICAgIHN0YXRpYyBFZGl0b3JDbGllbnQqIGR1bW15RWRpdG9yQ2xp ZW50ID0gYWRvcHRQdHIobmV3IEVtcHR5RWRpdG9yQ2xpZW50KS5sZWFrUHRyKCk7CisgICAgc3Rh dGljIEVkaXRvckNsaWVudCogZHVtbXlFZGl0b3JDbGllbnQgPSBuZXcgRW1wdHlFZGl0b3JDbGll bnQ7CiAgICAgcGFnZUNsaWVudHMuZWRpdG9yQ2xpZW50ID0gZHVtbXlFZGl0b3JDbGllbnQ7CiAK LSAgICBzdGF0aWMgSW5zcGVjdG9yQ2xpZW50KiBkdW1teUluc3BlY3RvckNsaWVudCA9IGFkb3B0 UHRyKG5ldyBFbXB0eUluc3BlY3RvckNsaWVudCkubGVha1B0cigpOworICAgIHN0YXRpYyBJbnNw ZWN0b3JDbGllbnQqIGR1bW15SW5zcGVjdG9yQ2xpZW50ID0gbmV3IEVtcHR5SW5zcGVjdG9yQ2xp ZW50OwogICAgIHBhZ2VDbGllbnRzLmluc3BlY3RvckNsaWVudCA9IGR1bW15SW5zcGVjdG9yQ2xp ZW50OwogCiAgICAgc3RhdGljIEZyYW1lTG9hZGVyQ2xpZW50KiBkdW1teUZyYW1lTG9hZGVyQ2xp ZW50ID0gbmV3IEVtcHR5RnJhbWVMb2FkZXJDbGllbnQ7Cg== 214834 2013-10-22 04:07:31 -0700 2013-10-22 13:15:06 -0700 Patch bug-122945-20131022040731.patch text/plain 3271 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3Nzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDMxN2NmZmJhZTUxYjNj NjZiNjFlYWZjYTIwMjM4YWE1OTRiZDVhZi4uYWJiMmVmOGNiMTJjZjJmYmRiNzNjNTk2ZmNmM2U1 OGM5ZDc5ZjEyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEwLTIyICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJDb3JlOjpmaWxs V2l0aEVtcHR5Q2xpZW50cyBhZG9wdHMgbmV3IGVtcHR5IGNsaWVudHMgYmVmb3JlIGxlYWtpbmcg dGhlaXIgcG9pbnRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyMjk0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogbG9hZGVyL0VtcHR5Q2xpZW50cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpmaWxs V2l0aEVtcHR5Q2xpZW50cyk6IFN0b3JlIHRoZSBzdGF0aWMgZW1wdHkgY2xpZW50cyBhcyBOZXZl ckRlc3Ryb3llZCwgcmF0aGVyIHRoYW4KKyAgICAgICAgYWRvcHRpbmcgdGhlIHBvaW50ZXIgb2Yg ZWFjaCBoZWFwLWFsbG9jYXRlZCBvYmplY3QgYW5kIHRoZW4gaW1tZWRpYXRlbHkgbGVha2luZyB0 aGF0IHBvaW50ZXIuCisKIDIwMTMtMTAtMjEgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBs ZS5jb20+CiAKICAgICAgICAgW1dJTl0gUHJvcGVybHkgc3VwcG9ydCByZXZlcnNlIGFuaW1hdGlv bnMgd2l0aG91dCBuZWVkaW5nIHNvZnR3YXJlIGZhbGxiYWNrLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvbG9hZGVyL0VtcHR5Q2xpZW50cy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv RW1wdHlDbGllbnRzLmNwcAppbmRleCAzNzAyNzJjNzJjZTRhYzRmNzlkZjZlZTA1M2UwZGJlNzFh ZWY3ZDg2Li5mYzI0YWNiOWRlYjJiNDEwMDRiNzZmMDE0ZDgyNjQ4ZmRhMDBjMmM4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRzLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvRW1wdHlDbGllbnRzLmNwcApAQCAtMzUsNiArMzUsNyBAQAogI2luY2x1 ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiRnJhbWVOZXR3b3JraW5nQ29udGV4dC5oIgogI2luY2x1 ZGUgIkhUTUxGb3JtRWxlbWVudC5oIgorI2luY2x1ZGUgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgog CiAjaWYgRU5BQkxFKElOUFVUX1RZUEVfQ09MT1IpCiAjaW5jbHVkZSAiQ29sb3JDaG9vc2VyLmgi CkBAIC00NCwyNyArNDUsMjcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiB2b2lkIGZpbGxXaXRo RW1wdHlDbGllbnRzKFBhZ2U6OlBhZ2VDbGllbnRzJiBwYWdlQ2xpZW50cykKIHsKLSAgICBzdGF0 aWMgQ2hyb21lQ2xpZW50KiBkdW1teUNocm9tZUNsaWVudCA9IGFkb3B0UHRyKG5ldyBFbXB0eUNo cm9tZUNsaWVudCkubGVha1B0cigpOwotICAgIHBhZ2VDbGllbnRzLmNocm9tZUNsaWVudCA9IGR1 bW15Q2hyb21lQ2xpZW50OworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxFbXB0eUNocm9tZUNs aWVudD4gZHVtbXlDaHJvbWVDbGllbnQ7CisgICAgcGFnZUNsaWVudHMuY2hyb21lQ2xpZW50ID0g JmR1bW15Q2hyb21lQ2xpZW50LmdldCgpOwogCiAjaWYgRU5BQkxFKENPTlRFWFRfTUVOVVMpCi0g ICAgc3RhdGljIENvbnRleHRNZW51Q2xpZW50KiBkdW1teUNvbnRleHRNZW51Q2xpZW50ID0gYWRv cHRQdHIobmV3IEVtcHR5Q29udGV4dE1lbnVDbGllbnQpLmxlYWtQdHIoKTsKLSAgICBwYWdlQ2xp ZW50cy5jb250ZXh0TWVudUNsaWVudCA9IGR1bW15Q29udGV4dE1lbnVDbGllbnQ7CisgICAgc3Rh dGljIE5ldmVyRGVzdHJveWVkPEVtcHR5Q29udGV4dE1lbnVDbGllbnQ+IGR1bW15Q29udGV4dE1l bnVDbGllbnQ7CisgICAgcGFnZUNsaWVudHMuY29udGV4dE1lbnVDbGllbnQgPSAmZHVtbXlDb250 ZXh0TWVudUNsaWVudC5nZXQoKTsKICNlbmRpZgogCiAjaWYgRU5BQkxFKERSQUdfU1VQUE9SVCkK LSAgICBzdGF0aWMgRHJhZ0NsaWVudCogZHVtbXlEcmFnQ2xpZW50ID0gYWRvcHRQdHIobmV3IEVt cHR5RHJhZ0NsaWVudCkubGVha1B0cigpOwotICAgIHBhZ2VDbGllbnRzLmRyYWdDbGllbnQgPSBk dW1teURyYWdDbGllbnQ7CisgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPEVtcHR5RHJhZ0NsaWVu dD4gZHVtbXlEcmFnQ2xpZW50OworICAgIHBhZ2VDbGllbnRzLmRyYWdDbGllbnQgPSAmZHVtbXlE cmFnQ2xpZW50LmdldCgpOwogI2VuZGlmCiAKLSAgICBzdGF0aWMgRWRpdG9yQ2xpZW50KiBkdW1t eUVkaXRvckNsaWVudCA9IGFkb3B0UHRyKG5ldyBFbXB0eUVkaXRvckNsaWVudCkubGVha1B0cigp OwotICAgIHBhZ2VDbGllbnRzLmVkaXRvckNsaWVudCA9IGR1bW15RWRpdG9yQ2xpZW50OworICAg IHN0YXRpYyBOZXZlckRlc3Ryb3llZDxFbXB0eUVkaXRvckNsaWVudD4gZHVtbXlFZGl0b3JDbGll bnQ7CisgICAgcGFnZUNsaWVudHMuZWRpdG9yQ2xpZW50ID0gJmR1bW15RWRpdG9yQ2xpZW50Lmdl dCgpOwogCi0gICAgc3RhdGljIEluc3BlY3RvckNsaWVudCogZHVtbXlJbnNwZWN0b3JDbGllbnQg PSBhZG9wdFB0cihuZXcgRW1wdHlJbnNwZWN0b3JDbGllbnQpLmxlYWtQdHIoKTsKLSAgICBwYWdl Q2xpZW50cy5pbnNwZWN0b3JDbGllbnQgPSBkdW1teUluc3BlY3RvckNsaWVudDsKKyAgICBzdGF0 aWMgTmV2ZXJEZXN0cm95ZWQ8RW1wdHlJbnNwZWN0b3JDbGllbnQ+IGR1bW15SW5zcGVjdG9yQ2xp ZW50OworICAgIHBhZ2VDbGllbnRzLmluc3BlY3RvckNsaWVudCA9ICZkdW1teUluc3BlY3RvckNs aWVudC5nZXQoKTsKIAotICAgIHN0YXRpYyBGcmFtZUxvYWRlckNsaWVudCogZHVtbXlGcmFtZUxv YWRlckNsaWVudCA9IG5ldyBFbXB0eUZyYW1lTG9hZGVyQ2xpZW50OwotICAgIHBhZ2VDbGllbnRz LmxvYWRlckNsaWVudEZvck1haW5GcmFtZSA9IGR1bW15RnJhbWVMb2FkZXJDbGllbnQ7CisgICAg c3RhdGljIE5ldmVyRGVzdHJveWVkPEVtcHR5RnJhbWVMb2FkZXJDbGllbnQ+IGR1bW15RnJhbWVM b2FkZXJDbGllbnQ7CisgICAgcGFnZUNsaWVudHMubG9hZGVyQ2xpZW50Rm9yTWFpbkZyYW1lID0g JmR1bW15RnJhbWVMb2FkZXJDbGllbnQuZ2V0KCk7CiB9CiAKIGNsYXNzIEVtcHR5UG9wdXBNZW51 IDogcHVibGljIFBvcHVwTWVudSB7Cg==