122935 2013-10-16 19:24:17 -0700 Support multiple repositories in submitting results to --results-server-host 2013-10-16 19:40:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa ap commit-queue dfarler glenn simon.fraser oldest_to_newest 940618 0 rniwa 2013-10-16 19:24:17 -0700 Support multiple repositories in submitting results to --results-server-host 940619 1 214415 rniwa 2013-10-16 19:24:52 -0700 Created attachment 214415 Fixes the bug 940621 2 214415 ap 2013-10-16 19:30:18 -0700 Comment on attachment 214415 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=214415&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:402 > + ('master', 'build.webkit.org' if master_name == 'webkit.org' else master_name), # FIXME: Pass in build.webkit.org. webkit.org is hardcoded in TestResultsServer, won't this break the flakiness dashboard? 940622 3 rniwa 2013-10-16 19:31:47 -0700 (In reply to comment #2) > (From update of attachment 214415 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214415&action=review > > > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:402 > > + ('master', 'build.webkit.org' if master_name == 'webkit.org' else master_name), # FIXME: Pass in build.webkit.org. > > webkit.org is hardcoded in TestResultsServer, won't this break the flakiness dashboard? This code is not used by the existing TestResultsServer. It's for the new flakiness dashboard I'm creating. 940624 4 rniwa 2013-10-16 19:35:08 -0700 Committed r157553: <http://trac.webkit.org/changeset/157553> 940625 5 214415 ap 2013-10-16 19:36:29 -0700 Comment on attachment 214415 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=214415&action=review >>> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:402 >>> + ('master', 'build.webkit.org' if master_name == 'webkit.org' else master_name), # FIXME: Pass in build.webkit.org. >> >> webkit.org is hardcoded in TestResultsServer, won't this break the flakiness dashboard? > > This code is not used by the existing TestResultsServer. It's for the new flakiness dashboard I'm creating. It's super confusing that code in layout_tests/controllers/manager.py is not universal. 940626 6 rniwa 2013-10-16 19:40:59 -0700 (In reply to comment #5) > (From update of attachment 214415 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214415&action=review > > >>> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:402 > >>> + ('master', 'build.webkit.org' if master_name == 'webkit.org' else master_name), # FIXME: Pass in build.webkit.org. > >> > >> webkit.org is hardcoded in TestResultsServer, won't this break the flakiness dashboard? > > > > This code is not used by the existing TestResultsServer. It's for the new flakiness dashboard I'm creating. > > It's super confusing that code in layout_tests/controllers/manager.py is not universal. Well, the idea is to get rid of the old code because it's a bloated mess. 214415 2013-10-16 19:24:52 -0700 2013-10-16 19:36:29 -0700 Fixes the bug bug-122935-20131016192451.patch text/plain 5187 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE1NzU1MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDEzLTEwLTE2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFN1cHBvcnQgbXVsdGlwbGUgcmVwb3NpdG9yaWVzIGluIHN1Ym1pdHRpbmcgcmVz dWx0cyB0byAtLXJlc3VsdHMtc2VydmVyLWhvc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjkzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbW9ldmQgLS1nb3QtcmV2aXNpb24gYW5kIGFkZGVkIHRo ZSBsb2dpYyB0byBleHRyYWN0IHJldmlzaW9uIGluZm9ybWF0aW9uCisgICAgICAgIGZyb20gbXVs dGlwbGUgcmVwb3NpdG9yaWVzIGFzIGRvbmUgaW4gcnVuLXBlcmYtdGVzdHMuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5Ogor ICAgICAgICAoTWFuYWdlci51cGxvYWRfcmVzdWx0cyk6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weToKKyAgICAgICAgKHBhcnNlX2Fy Z3MpOgorCiAyMDEzLTEwLTE2ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAg ICAgICBBZGQgUGFzc1JlZiBhbmQgY3JlYXRlUmVmQ291bnRlZCBzbyB3ZSBjYW4gaW1wcm92ZSBj cmVhdGlvbiBvZiBSZWZDb3VudGVkIG9iamVjdHMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQkocmV2aXNp b24gMTU3NDU5KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dl YmtpdF90ZXN0cy5weQkod29ya2luZyBjb3B5KQpAQCAtMjkxLDggKzI5MSw2IEBAIGRlZiBwYXJz ZV9hcmdzKGFyZ3MpOgogICAgICAgICAgICAgaGVscD0oIlRoZSBuYW1lIG9mIHRoZSBidWlsZHNs YXZlIHVzZWQuIGUuZy4gYXBwbGUtbWFjcHJvLTYuIikpLAogICAgICAgICBvcHRwYXJzZS5tYWtl X29wdGlvbigiLS1idWlsZC1udW1iZXIiLCBkZWZhdWx0PSJEVU1NWV9CVUlMRF9OVU1CRVIiLAog ICAgICAgICAgICAgaGVscD0oIlRoZSBidWlsZCBudW1iZXIgb2YgdGhlIGJ1aWxkZXIgcnVubmlu ZyB0aGlzIHNjcmlwdC4iKSksCi0gICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWdvdC1y ZXZpc2lvbiIsIGRlZmF1bHQ9IiIsCi0gICAgICAgICAgICBoZWxwPSgiVGhlIHJldmlzaW9uIG51 bWJlci4gZS5nLiAxMjM0NSIpKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tdGVz dC1yZXN1bHRzLXNlcnZlciIsIGRlZmF1bHQ9IiIsCiAgICAgICAgICAgICBoZWxwPSgiSWYgc3Bl Y2lmaWVkLCB1cGxvYWQgcmVzdWx0cyBqc29uIGZpbGVzIHRvIHRoaXMgYXBwZW5naW5lIHNlcnZl ci4iKSksCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXJlc3VsdHMtc2VydmVyLWhv c3QiLCBkZWZhdWx0PSIiLApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvY29udHJvbGxlcnMvbWFuYWdlci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5CShyZXZpc2lvbiAxNTc0 NTkpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9t YW5hZ2VyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0MCw3IEBAIGltcG9ydCByYW5kb20K IGltcG9ydCBzeXMKIGltcG9ydCB0aW1lCiAKK2Zyb20gd2Via2l0cHkuY29tbW9uLmNoZWNrb3V0 LnNjbS5kZXRlY3Rpb24gaW1wb3J0IFNDTURldGVjdG9yCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5u ZXQuZmlsZV91cGxvYWRlciBpbXBvcnQgRmlsZVVwbG9hZGVyCiBmcm9tIHdlYmtpdHB5LmxheW91 dF90ZXN0cy5jb250cm9sbGVycy5sYXlvdXRfdGVzdF9maW5kZXIgaW1wb3J0IExheW91dFRlc3RG aW5kZXIKIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLmNvbnRyb2xsZXJzLmxheW91dF90ZXN0 X3J1bm5lciBpbXBvcnQgTGF5b3V0VGVzdFJ1bm5lcgpAQCAtMzc3LDMxICszNzgsMzcgQEAgY2xh c3MgTWFuYWdlcihvYmplY3QpOgogICAgICAgICAgICAgc2VsZi5fZmlsZXN5c3RlbS5yZW1vdmUo cmVzdWx0c19qc29uX3BhdGgpCiAKICAgICBkZWYgdXBsb2FkX3Jlc3VsdHMoc2VsZiwgcmVzdWx0 c19qc29uX3BhdGgsIHN0YXJ0X3RpbWUsIGVuZF90aW1lKToKLSAgICAgICAgaG9zdCA9IHNlbGYu X29wdGlvbnMucmVzdWx0c19zZXJ2ZXJfaG9zdAotICAgICAgICBpZiBub3QgaG9zdDoKKyAgICAg ICAgaG9zdG5hbWUgPSBzZWxmLl9vcHRpb25zLnJlc3VsdHNfc2VydmVyX2hvc3QKKyAgICAgICAg aWYgbm90IGhvc3RuYW1lOgogICAgICAgICAgICAgcmV0dXJuCiAgICAgICAgIG1hc3Rlcl9uYW1l ID0gc2VsZi5fb3B0aW9ucy5tYXN0ZXJfbmFtZQogICAgICAgICBidWlsZGVyX25hbWUgPSBzZWxm Ll9vcHRpb25zLmJ1aWxkZXJfbmFtZQogICAgICAgICBidWlsZF9udW1iZXIgPSBzZWxmLl9vcHRp b25zLmJ1aWxkX251bWJlcgogICAgICAgICBidWlsZF9zbGF2ZSA9IHNlbGYuX29wdGlvbnMuYnVp bGRfc2xhdmUKLSAgICAgICAgZ290X3JldmlzaW9uID0gc2VsZi5fb3B0aW9ucy5nb3RfcmV2aXNp b24KLSAgICAgICAgaWYgbm90IG1hc3Rlcl9uYW1lIG9yIG5vdCBidWlsZGVyX25hbWUgb3Igbm90 IGJ1aWxkX251bWJlciBvciBub3QgYnVpbGRfc2xhdmUgb3Igbm90IGdvdF9yZXZpc2lvbjoKLSAg ICAgICAgICAgIF9sb2cuZXJyb3IoIi0tcmVzdWx0cy1kYXNoYm9hcmQtaG9zdCB3YXMgc2V0LCBi dXQgLS1tYXN0ZXItbmFtZSwgLS1idWlsZGVyLW5hbWUsIC0tYnVpbGQtbnVtYmVyLCAtLWJ1aWxk LXNsYXZlLCBvciAtLWdvdC1yZXZpc2lvbiB3YXMgbm90LiBOb3QgdXBsb2FkaW5nIEpTT04gZmls ZXMuIikKKyAgICAgICAgaWYgbm90IG1hc3Rlcl9uYW1lIG9yIG5vdCBidWlsZGVyX25hbWUgb3Ig bm90IGJ1aWxkX251bWJlciBvciBub3QgYnVpbGRfc2xhdmU6CisgICAgICAgICAgICBfbG9nLmVy cm9yKCItLXJlc3VsdHMtc2VydmVyLWhvc3Qgd2FzIHNldCwgYnV0IC0tbWFzdGVyLW5hbWUsIC0t YnVpbGRlci1uYW1lLCAtLWJ1aWxkLW51bWJlciwgb3IgLS1idWlsZC1zbGF2ZSB3YXMgbm90LiBO b3QgdXBsb2FkaW5nIEpTT04gZmlsZXMuIikKICAgICAgICAgICAgIHJldHVybgogCi0gICAgICAg IF9sb2cuaW5mbygiVXBsb2FkaW5nIEpTT04gZmlsZXMgZm9yIG1hc3RlcjogJXMgYnVpbGRlcjog JXMgYnVpbGQ6ICVzIHNsYXZlOiAlcyB0byAlcyIsIG1hc3Rlcl9uYW1lLCBidWlsZGVyX25hbWUs IGJ1aWxkX251bWJlciwgYnVpbGRfc2xhdmUsIGhvc3QpCisgICAgICAgIHJldmlzaW9ucyA9IHt9 CisgICAgICAgICMgRklYTUU6IFRoaXMgY29kZSBpcyBkdXBsaWNhdGVkIGluIFBlcmZUZXN0UnVu bmVyLl9nZW5lcmF0ZV9yZXN1bHRzX2RpY3QKKyAgICAgICAgZm9yIChuYW1lLCBwYXRoKSBpbiBz ZWxmLl9wb3J0LnJlcG9zaXRvcnlfcGF0aHMoKToKKyAgICAgICAgICAgIHNjbSA9IFNDTURldGVj dG9yKHNlbGYuX3BvcnQuaG9zdC5maWxlc3lzdGVtLCBzZWxmLl9wb3J0Lmhvc3QuZXhlY3V0aXZl KS5kZXRlY3Rfc2NtX3N5c3RlbShwYXRoKSBvciBzZWxmLl9wb3J0Lmhvc3Quc2NtKCkKKyAgICAg ICAgICAgIHJldmlzaW9uID0gc2NtLnN2bl9yZXZpc2lvbihwYXRoKQorICAgICAgICAgICAgcmV2 aXNpb25zW25hbWVdID0geydyZXZpc2lvbic6IHJldmlzaW9uLCAndGltZXN0YW1wJzogc2NtLnRp bWVzdGFtcF9vZl9yZXZpc2lvbihwYXRoLCByZXZpc2lvbil9CisKKyAgICAgICAgX2xvZy5pbmZv KCJVcGxvYWRpbmcgSlNPTiBmaWxlcyBmb3IgbWFzdGVyOiAlcyBidWlsZGVyOiAlcyBidWlsZDog JXMgc2xhdmU6ICVzIHRvICVzIiwgbWFzdGVyX25hbWUsIGJ1aWxkZXJfbmFtZSwgYnVpbGRfbnVt YmVyLCBidWlsZF9zbGF2ZSwgaG9zdG5hbWUpCiAKICAgICAgICAgYXR0cnMgPSBbCi0gICAgICAg ICAgICAoJ21hc3RlcicsIG1hc3Rlcl9uYW1lKSwKKyAgICAgICAgICAgICgnbWFzdGVyJywgJ2J1 aWxkLndlYmtpdC5vcmcnIGlmIG1hc3Rlcl9uYW1lID09ICd3ZWJraXQub3JnJyBlbHNlIG1hc3Rl cl9uYW1lKSwgICMgRklYTUU6IFBhc3MgaW4gYnVpbGQud2Via2l0Lm9yZy4KICAgICAgICAgICAg ICgnYnVpbGRlcl9uYW1lJywgYnVpbGRlcl9uYW1lKSwKICAgICAgICAgICAgICgnYnVpbGRfbnVt YmVyJywgYnVpbGRfbnVtYmVyKSwKICAgICAgICAgICAgICgnYnVpbGRfc2xhdmUnLCBidWlsZF9z bGF2ZSksCi0gICAgICAgICAgICAoJ3JldmlzaW9uJywgZ290X3JldmlzaW9uKSwKKyAgICAgICAg ICAgICgncmV2aXNpb25zJywganNvbi5kdW1wcyhyZXZpc2lvbnMpKSwKICAgICAgICAgICAgICgn c3RhcnRfdGltZScsIHN0cihzdGFydF90aW1lKSksCiAgICAgICAgICAgICAoJ2VuZF90aW1lJywg c3RyKGVuZF90aW1lKSksCiAgICAgICAgIF0KIAotICAgICAgICB1cGxvYWRlciA9IEZpbGVVcGxv YWRlcigiaHR0cDovLyVzL2FwaS9yZXBvcnQiICUgaG9zdCwgMzYwKQorICAgICAgICB1cGxvYWRl ciA9IEZpbGVVcGxvYWRlcigiaHR0cDovLyVzL2FwaS9yZXBvcnQiICUgaG9zdG5hbWUsIDM2MCkK ICAgICAgICAgdHJ5OgogICAgICAgICAgICAgcmVzcG9uc2UgPSB1cGxvYWRlci51cGxvYWRfYXNf bXVsdGlwYXJ0X2Zvcm1fZGF0YShzZWxmLl9maWxlc3lzdGVtLCBbKCdyZXN1bHRzLmpzb24nLCBy ZXN1bHRzX2pzb25fcGF0aCldLCBhdHRycykKICAgICAgICAgICAgIGlmIG5vdCByZXNwb25zZToK