122917 2013-10-16 14:25:23 -0700 Architecture specific implementation in DFG could be avoided 2013-10-16 15:08:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue msaboff oldest_to_newest 940532 0 jbriance 2013-10-16 14:25:23 -0700 When using ARM architecture with HARD_FP, we have FPRInfo::argumentFPR0 == FPRInfo::returnValueFPR == ARMRegisters::d0, so we don't need a specific implementation for this case of the 2 following functions, the fallback one is fine. JITCompiler::Call appendCallWithExceptionCheckSetResult(const FunctionPtr& function, FPRReg result) JITCompiler::Call appendCallSetResult(const FunctionPtr& function, FPRReg result) 940534 1 214396 jbriance 2013-10-16 14:27:23 -0700 Created attachment 214396 Remove useless architecture specific implementation in DFG. 940541 2 214396 commit-queue 2013-10-16 15:08:48 -0700 Comment on attachment 214396 Remove useless architecture specific implementation in DFG. Clearing flags on attachment: 214396 Committed r157532: <http://trac.webkit.org/changeset/157532> 940542 3 commit-queue 2013-10-16 15:08:50 -0700 All reviewed patches have been landed. Closing bug. 214396 2013-10-16 14:27:23 -0700 2013-10-16 15:08:47 -0700 Remove useless architecture specific implementation in DFG. bug-122917.patch text/plain 2437 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3NTI4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTEwLTE2ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFJlbW92ZSB1c2VsZXNzIGFyY2hpdGVjdHVyZSBzcGVjaWZpYyBpbXBsZW1lbnRhdGlv biBpbiBERkcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjI5MTcuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2l0aCBDUFUoQVJNKSAmJiBDUFUoQVJNX0hBUkRGUCkgYXJjaGl0ZWN0dXJlLCB0aGUgZmFs bGJhY2sgaW1wbGVtZW50YXRpb24gaXMgZmluZQorICAgICAgICBhcyBGUFJJbmZvOjphcmd1bWVu dEZQUjAgPT0gRlBSSW5mbzo6cmV0dXJuVmFsdWVGUFIgaW4gdGhpcyBjYXNlLgorCisgICAgICAg ICogZGZnL0RGR1NwZWN1bGF0aXZlSklULmg6CisKIDIwMTMtMTAtMTYgIE1hcmsgTGFtICA8bWFy ay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFRyYW5zaXRpb24gdm9pZCBjdGlfb3BfdGVhcl9v ZmYqIG1ldGhvZHMgdG8gSklUIG9wZXJhdGlvbnMgZm9yIDMyIGJpdC4KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmgJKHJldmlzaW9uIDE1NzUy NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuaAkod29y a2luZyBjb3B5KQpAQCAtMTgwMSwyMyArMTgwMSw3IEBAIHB1YmxpYzoKICAgICAgICAgfQogICAg ICAgICByZXR1cm4gY2FsbDsKICAgICB9Ci0jZWxpZiBDUFUoQVJNKQotI2lmIENQVShBUk1fSEFS REZQKQotICAgIEpJVENvbXBpbGVyOjpDYWxsIGFwcGVuZENhbGxXaXRoRXhjZXB0aW9uQ2hlY2tT ZXRSZXN1bHQoY29uc3QgRnVuY3Rpb25QdHImIGZ1bmN0aW9uLCBGUFJSZWcgcmVzdWx0KQotICAg IHsKLSAgICAgICAgSklUQ29tcGlsZXI6OkNhbGwgY2FsbCA9IGFwcGVuZENhbGxXaXRoRXhjZXB0 aW9uQ2hlY2soZnVuY3Rpb24pOwotICAgICAgICBpZiAocmVzdWx0ICE9IEludmFsaWRGUFJSZWcp Ci0gICAgICAgICAgICBtX2ppdC5tb3ZlRG91YmxlKEZQUkluZm86OmFyZ3VtZW50RlBSMCwgcmVz dWx0KTsKLSAgICAgICAgcmV0dXJuIGNhbGw7Ci0gICAgfQotICAgIEpJVENvbXBpbGVyOjpDYWxs IGFwcGVuZENhbGxTZXRSZXN1bHQoY29uc3QgRnVuY3Rpb25QdHImIGZ1bmN0aW9uLCBGUFJSZWcg cmVzdWx0KQotICAgIHsKLSAgICAgICAgSklUQ29tcGlsZXI6OkNhbGwgY2FsbCA9IGFwcGVuZENh bGwoZnVuY3Rpb24pOwotICAgICAgICBpZiAocmVzdWx0ICE9IEludmFsaWRGUFJSZWcpCi0gICAg ICAgICAgICBtX2ppdC5tb3ZlRG91YmxlKEZQUkluZm86OmFyZ3VtZW50RlBSMCwgcmVzdWx0KTsK LSAgICAgICAgcmV0dXJuIGNhbGw7Ci0gICAgfQotI2Vsc2UKKyNlbGlmIENQVShBUk0pICYmICFD UFUoQVJNX0hBUkRGUCkKICAgICBKSVRDb21waWxlcjo6Q2FsbCBhcHBlbmRDYWxsV2l0aEV4Y2Vw dGlvbkNoZWNrU2V0UmVzdWx0KGNvbnN0IEZ1bmN0aW9uUHRyJiBmdW5jdGlvbiwgRlBSUmVnIHJl c3VsdCkKICAgICB7CiAgICAgICAgIEpJVENvbXBpbGVyOjpDYWxsIGNhbGwgPSBhcHBlbmRDYWxs V2l0aEV4Y2VwdGlvbkNoZWNrKGZ1bmN0aW9uKTsKQEAgLTE4MzIsOCArMTgxNiw3IEBAIHB1Ymxp YzoKICAgICAgICAgICAgIG1faml0LmFzc2VtYmxlcigpLnZtb3YocmVzdWx0LCBHUFJJbmZvOjpy ZXR1cm5WYWx1ZUdQUiwgR1BSSW5mbzo6cmV0dXJuVmFsdWVHUFIyKTsKICAgICAgICAgcmV0dXJu IGNhbGw7CiAgICAgfQotI2VuZGlmIC8vIENQVShBUk1fSEFSREZQKQotI2Vsc2UKKyNlbHNlIC8v IENQVShYODZfNjQpIHx8IChDUFUoQVJNKSAmJiBDUFUoQVJNX0hBUkRGUCkpIHx8IENQVShBUk02 NCkgfHwgQ1BVKE1JUFMpIHx8IENQVShTSDQpCiAgICAgSklUQ29tcGlsZXI6OkNhbGwgYXBwZW5k Q2FsbFdpdGhFeGNlcHRpb25DaGVja1NldFJlc3VsdChjb25zdCBGdW5jdGlvblB0ciYgZnVuY3Rp b24sIEZQUlJlZyByZXN1bHQpCiAgICAgewogICAgICAgICBKSVRDb21waWxlcjo6Q2FsbCBjYWxs ID0gYXBwZW5kQ2FsbFdpdGhFeGNlcHRpb25DaGVjayhmdW5jdGlvbik7Cg==