122902 2013-10-16 09:16:01 -0700 r157411 fails run-javascriptcore-tests when run with Baseline JIT 2013-10-16 16:55:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam fpizlo fpizlo mark.lam mhahnenberg msaboff roger_fong oldest_to_newest 940397 0 mark.lam 2013-10-16 09:16:01 -0700 http://trac.webkit.org/changeset/157411 introduced a crash in run-javascriptcore-tests when running only the baseline JIT (no LLINT, no DFG). 940398 1 mark.lam 2013-10-16 09:16:42 -0700 It does not crash in r157409. Only started with r157411. 940399 2 mark.lam 2013-10-16 09:18:23 -0700 FYI, I was doing testing with 32-bit builds. Haven't checked if the crash manifests on 64-bit builds yet. 940430 3 mark.lam 2013-10-16 10:46:11 -0700 (In reply to comment #2) > FYI, I was doing testing with 32-bit builds. Haven't checked if the crash manifests on 64-bit builds yet. Correction: it's not a crash. It's a testapi failure, and run-javascriptcore-tests simply did not continue running thereafter. The issue also manifests on 64-bit builds. The failures are: FAIL: PropertyCatchalls.x should be 4 but instead is 5. FAIL: Test script returned unexpected value: 940502 4 fpizlo 2013-10-16 13:04:06 -0700 I'm looking at this. 940567 5 214402 fpizlo 2013-10-16 16:25:27 -0700 Created attachment 214402 the patch 940568 6 214402 mhahnenberg 2013-10-16 16:27:21 -0700 Comment on attachment 214402 the patch r=me 940586 7 fpizlo 2013-10-16 16:55:18 -0700 Landed in http://trac.webkit.org/changeset/157541 214402 2013-10-16 16:25:27 -0700 2013-10-16 16:27:21 -0700 the patch blah.patch text/plain 1855 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3NTM2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDEzLTEwLTE2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg cjE1NzQxMSBmYWlscyBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMgd2hlbiBydW4gd2l0aCBCYXNl bGluZSBKSVQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyMjkwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAK KyAgICAgICAgSXQgdHVybnMgb3V0IHRoYXQgdGhpcyB3YXMgYSBsb25nLXN0YW5kaW5nIGJ1ZyBp biB0aGUgREZHIFB1dEJ5SWQgcmVwYXRjaGluZyBsb2dpYy4gSXQncworICAgICAgICBub3QgbGVn YWwgdG8gcGF0Y2ggaWYgdGhlIHR5cGVJbmZvIHRlbGxzIHlvdSB0aGF0IHlvdSBjYW4ndCBwYXRj aC4gVGhlIG9sZCBKSVQncyBwYXRjaGluZworICAgICAgICBsb2dpYyBkaWQgdGhpcyByaWdodCwg YW5kIHRoZSBERkcncyBHZXRCeUlkIHBhdGNoaW5nIGxvZ2ljIGRpZCBpdCByaWdodDsgYnV0IERG RyBQdXRCeUlkCisgICAgICAgIGRpZG4ndC4gVHVybnMgb3V0IHRoYXQgdGhlcmUncyBldmVuIGEg aGVscGZ1bCBtZXRob2QsCisgICAgICAgIFN0cnVjdHVyZTo6cHJvcGVydHlBY2Nlc3Nlc0FyZUNh Y2hlYWJsZSgpLCB0aGF0IHdpbGwgZXZlbiBkbyBhbGwgb2YgdGhlIGNoZWNrcyBmb3IgeW91IQor CisgICAgICAgICogaml0L1JlcGF0Y2guY3BwOgorICAgICAgICAoSlNDOjp0cnlDYWNoZVB1dEJ5 SUQpOgorCiAyMDEzLTEwLTE2ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTU3NTI5LgpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9SZXBhdGNoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L1JlcGF0Y2guY3BwCShyZXZpc2lvbiAxNTc1MjQpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L1JlcGF0Y2guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NDks NyArOTQ5LDcgQEAgc3RhdGljIGJvb2wgdHJ5Q2FjaGVQdXRCeUlEKEV4ZWNTdGF0ZSogZQogICAg IAogICAgIGlmICghc2xvdC5pc0NhY2hlYWJsZSgpKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0g ICAgaWYgKHN0cnVjdHVyZS0+aXNVbmNhY2hlYWJsZURpY3Rpb25hcnkoKSkKKyAgICBpZiAoIXN0 cnVjdHVyZS0+cHJvcGVydHlBY2Nlc3Nlc0FyZUNhY2hlYWJsZSgpKQogICAgICAgICByZXR1cm4g ZmFsc2U7CiAKICAgICAvLyBPcHRpbWl6ZSBzZWxmIGFjY2Vzcy4KQEAgLTEwMjYsNyArMTAyNiw3 IEBAIHN0YXRpYyBib29sIHRyeUJ1aWxkUHV0QnlJZExpc3QoRXhlY1N0YXQKICAgICAKICAgICBp ZiAoIXNsb3QuaXNDYWNoZWFibGUoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIGlmIChz dHJ1Y3R1cmUtPmlzVW5jYWNoZWFibGVEaWN0aW9uYXJ5KCkpCisgICAgaWYgKCFzdHJ1Y3R1cmUt PnByb3BlcnR5QWNjZXNzZXNBcmVDYWNoZWFibGUoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwog CiAgICAgLy8gT3B0aW1pemUgc2VsZiBhY2Nlc3MuCg==