122885 2013-10-16 00:05:00 -0700 Remove more of the UNINTERRUPTED_SEQUENCE thing 2013-10-16 01:39:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue fpizlo yannick.poirier oldest_to_newest 940294 0 jbriance 2013-10-16 00:05:00 -0700 The UNINTERRUPTED_SEQUENCE thing was not completely removed by http://trac.webkit.org/changeset/157481: the 2 following function implementation remain in JITInlines.h file, leading to build failure for SH4 architure. void JIT::beginUninterruptedSequence(int, int); void JIT::endUninterruptedSequence(int, int, int); 940295 1 214345 jbriance 2013-10-16 00:09:32 -0700 Created attachment 214345 Remove beginUninterruptedSequence and endUninterruptedSequence functions Fix the following compilation error: In file included from /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/jit/JITCall32_64.cpp:35:0: /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/jit/JITInlines.h:121:81: error: no ‘void JSC::JIT::beginUninterruptedSequence(int, int)’ member function declared in class ‘JSC::JIT’ /local/jbriance/WebKit/cmake-sh4/webkit/Source/JavaScriptCore/jit/JITInlines.h:147:88: error: no ‘void JSC::JIT::endUninterruptedSequence(int, int, int)’ member function declared in class ‘JSC::JIT’ 940297 2 214345 jbriance 2013-10-16 00:20:58 -0700 Comment on attachment 214345 Remove beginUninterruptedSequence and endUninterruptedSequence functions I forgot to remove something else, I'll submit another patch soon 940301 3 214346 jbriance 2013-10-16 00:56:39 -0700 Created attachment 214346 Remove beginUninterruptedSequence and endUninterruptedSequence functions (2) 940310 4 214346 kling 2013-10-16 01:15:14 -0700 Comment on attachment 214346 Remove beginUninterruptedSequence and endUninterruptedSequence functions (2) rs=me 940321 5 214346 commit-queue 2013-10-16 01:39:17 -0700 Comment on attachment 214346 Remove beginUninterruptedSequence and endUninterruptedSequence functions (2) Clearing flags on attachment: 214346 Committed r157500: <http://trac.webkit.org/changeset/157500> 940322 6 commit-queue 2013-10-16 01:39:18 -0700 All reviewed patches have been landed. Closing bug. 214345 2013-10-16 00:09:32 -0700 2013-10-16 00:20:58 -0700 Remove beginUninterruptedSequence and endUninterruptedSequence functions bug-122885.patch text/plain 2996 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3NDk1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEzLTEwLTE2ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFJlbW92ZSBtb3JlIG9mIHRoZSBVTklOVEVSUlVQVEVEX1NFUVVFTkNFIHRoaW5nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI4ODUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCB3YXMgbm90 IGNvbXBsZXRlbHkgcmVtb3ZlZCBieSByMTU3NDgxLCBsZWFkaW5nIHRvIGJ1aWxkIGZhaWx1cmUg Zm9yIHNoNCBhcmNoaXRlY3R1cmUuCisKKyAgICAgICAgKiBqaXQvSklUSW5saW5lcy5oOgorCiAy MDEzLTEwLTE1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgR2V0 IHJpZCBvZiB0aGUgU3RydWN0dXJlU3R1YkluZm86OnBhdGNoIHVuaW9uCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0pJVElubGluZXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0pJVElubGluZXMuaAkocmV2aXNpb24gMTU3NDk0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRJbmxpbmVzLmgJKHdvcmtpbmcgY29weSkKQEAgLTExNiw2 OCArMTE2LDYgQEAgQUxXQVlTX0lOTElORSBib29sIEpJVDo6YXRKdW1wVGFyZ2V0KCkKICAgICBy ZXR1cm4gZmFsc2U7CiB9CiAKLSNpZiBkZWZpbmVkKEFTU0VNQkxFUl9IQVNfQ09OU1RBTlRfUE9P TCkgJiYgQVNTRU1CTEVSX0hBU19DT05TVEFOVF9QT09MCi0KLUFMV0FZU19JTkxJTkUgdm9pZCBK SVQ6OmJlZ2luVW5pbnRlcnJ1cHRlZFNlcXVlbmNlKGludCBpbnNuU3BhY2UsIGludCBjb25zdFNw YWNlKQotewotI2lmIENQVShBUk1fVFJBRElUSU9OQUwpCi0jaWZuZGVmIE5ERUJVRwotICAgIC8v IEVuc3VyZSB0aGUgbGFiZWwgYWZ0ZXIgdGhlIHNlcXVlbmNlIGNhbiBhbHNvIGZpdAotICAgIGlu c25TcGFjZSArPSBzaXplb2YoQVJNV29yZCk7Ci0gICAgY29uc3RTcGFjZSArPSBzaXplb2YodWlu dDY0X3QpOwotI2VuZGlmCi0KLSAgICBlbnN1cmVTcGFjZShpbnNuU3BhY2UsIGNvbnN0U3BhY2Up OwotCi0jZWxpZiBDUFUoU0g0KQotI2lmbmRlZiBOREVCVUcKLSAgICBpbnNuU3BhY2UgKz0gc2l6 ZW9mKFNINFdvcmQpOwotICAgIGNvbnN0U3BhY2UgKz0gc2l6ZW9mKHVpbnQ2NF90KTsKLSNlbmRp ZgotCi0gICAgbV9hc3NlbWJsZXIuZW5zdXJlU3BhY2UoaW5zblNwYWNlICsgbV9hc3NlbWJsZXIu bWF4SW5zdHJ1Y3Rpb25TaXplICsgMiwgY29uc3RTcGFjZSArIDgpOwotI2VuZGlmCi0KLSNpZm5k ZWYgTkRFQlVHCi0gICAgbV91bmludGVycnVwdGVkSW5zdHJ1Y3Rpb25TZXF1ZW5jZUJlZ2luID0g bGFiZWwoKTsKLSAgICBtX3VuaW50ZXJydXB0ZWRDb25zdGFudFNlcXVlbmNlQmVnaW4gPSBzaXpl T2ZDb25zdGFudFBvb2woKTsKLSNlbmRpZgotfQotCi1BTFdBWVNfSU5MSU5FIHZvaWQgSklUOjpl bmRVbmludGVycnVwdGVkU2VxdWVuY2UoaW50IGluc25TcGFjZSwgaW50IGNvbnN0U3BhY2UsIGlu dCBkc3QpCi17Ci0jaWZuZGVmIE5ERUJVRwotICAgIC8qIFRoZXJlIGFyZSBzZXZlcmFsIGNhc2Vz IHdoZW4gdGhlIHVuaW50ZXJydXB0ZWQgc2VxdWVuY2UgaXMgbGFyZ2VyIHRoYW4KLSAgICAgKiBt YXhpbXVtIHJlcXVpcmVkIG9mZnNldCBmb3IgcGF0aGluZyB0aGUgc2FtZSBzZXF1ZW5jZS4gRWcu OiBpZiBpbiBhCi0gICAgICogdW5pbnRlcnJ1cHRlZCBzZXF1ZW5jZSB0aGUgbGFzdCBtYWNyb2Fz c2VtYmxlcidzIGluc3RydWN0aW9uIGlzIGEgc3R1YgotICAgICAqIGNhbGwsIGl0IGVtaXRzIHN0 b3JlIGluc3RydWN0aW9uKHMpIHdoaWNoIHNob3VsZCBub3QgYmUgaW5jbHVkZWQgaW4gdGhlCi0g ICAgICogY2FsY3VsYXRpb24gb2YgbGVuZ3RoIG9mIHVuaW50ZXJydXB0ZWQgc2VxdWVuY2UuIFNv LCB0aGUgaW5zblNwYWNlIGFuZAotICAgICAqIGNvbnN0U3BhY2Ugc2hvdWxkIGJlIHVwcGVyIGxp bWl0IGluc3RlYWQgb2YgaGFyZCBsaW1pdC4KLSAgICAgKi8KLQotI2lmIENQVShTSDQpCi0gICAg aWYgKChkc3QgPiAxNSkgfHwgKGRzdCA8IC0xNikpIHsKLSAgICAgICAgaW5zblNwYWNlICs9IDg7 Ci0gICAgICAgIGNvbnN0U3BhY2UgKz0gMjsKLSAgICB9Ci0KLSAgICBpZiAoKChkc3QgPj0gLTE2 KSAmJiAoZHN0IDwgMCkpIHx8ICgoZHN0ID4gNykgJiYgKGRzdCA8PSAxNSkpKQotICAgICAgICBp bnNuU3BhY2UgKz0gODsKLSNlbHNlCi0gICAgVU5VU0VEX1BBUkFNKGRzdCk7Ci0jZW5kaWYKLQot ICAgIEFTU0VSVChkaWZmZXJlbmNlQmV0d2VlbihtX3VuaW50ZXJydXB0ZWRJbnN0cnVjdGlvblNl cXVlbmNlQmVnaW4sIGxhYmVsKCkpIDw9IGluc25TcGFjZSk7Ci0gICAgQVNTRVJUKHNpemVPZkNv bnN0YW50UG9vbCgpIC0gbV91bmludGVycnVwdGVkQ29uc3RhbnRTZXF1ZW5jZUJlZ2luIDw9IGNv bnN0U3BhY2UpOwotI2Vsc2UKLSAgICBVTlVTRURfUEFSQU0oaW5zblNwYWNlKTsKLSAgICBVTlVT RURfUEFSQU0oY29uc3RTcGFjZSk7Ci0gICAgVU5VU0VEX1BBUkFNKGRzdCk7Ci0jZW5kaWYKLX0K LQotI2VuZGlmIC8vIEFTU0VNQkxFUl9IQVNfQ09OU1RBTlRfUE9PTAotCiBBTFdBWVNfSU5MSU5F IHZvaWQgSklUOjp1cGRhdGVUb3BDYWxsRnJhbWUoKQogewogICAgIEFTU0VSVChzdGF0aWNfY2Fz dDxpbnQ+KG1fYnl0ZWNvZGVPZmZzZXQpID49IDApOwo= 214346 2013-10-16 00:56:39 -0700 2013-10-16 01:39:16 -0700 Remove beginUninterruptedSequence and endUninterruptedSequence functions (2) bug-122885_2.patch text/plain 3672 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3NDk2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTEwLTE2ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFJlbW92ZSBtb3JlIG9mIHRoZSBVTklOVEVSUlVQVEVEX1NFUVVFTkNFIHRoaW5nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI4ODUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCB3YXMgbm90 IGNvbXBsZXRlbHkgcmVtb3ZlZCBieSByMTU3NDgxLCBsZWFkaW5nIHRvIGJ1aWxkIGZhaWx1cmUg Zm9yIHNoNCBhcmNoaXRlY3R1cmUuCisKKyAgICAgICAgKiBqaXQvSklULmg6CisgICAgICAgICog aml0L0pJVElubGluZXMuaDoKKwogMjAxMy0xMC0xNSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBw bGUuY29tPgogCiAgICAgICAgIEdldCByaWQgb2YgdGhlIFN0cnVjdHVyZVN0dWJJbmZvOjpwYXRj aCB1bmlvbgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVQuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5oCShyZXZpc2lvbiAxNTc0OTQpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5oCSh3b3JraW5nIGNvcHkpCkBAIC05MDcs MTIgKzkwNyw2IEBAIG5hbWVzcGFjZSBKU0MgewogI2VuZGlmCiAgICAgICAgIHVuc2lnbmVkIG1f anVtcFRhcmdldHNQb3NpdGlvbjsKIAotI2lmbmRlZiBOREVCVUcKLSNpZiBkZWZpbmVkKEFTU0VN QkxFUl9IQVNfQ09OU1RBTlRfUE9PTCkgJiYgQVNTRU1CTEVSX0hBU19DT05TVEFOVF9QT09MCi0g ICAgICAgIExhYmVsIG1fdW5pbnRlcnJ1cHRlZEluc3RydWN0aW9uU2VxdWVuY2VCZWdpbjsKLSAg ICAgICAgaW50IG1fdW5pbnRlcnJ1cHRlZENvbnN0YW50U2VxdWVuY2VCZWdpbjsKLSNlbmRpZgot I2VuZGlmCiAgICAgICAgIE93blB0cjxKSVREaXNhc3NlbWJsZXI+IG1fZGlzYXNzZW1ibGVyOwog ICAgICAgICBSZWZQdHI8UHJvZmlsZXI6OkNvbXBpbGF0aW9uPiBtX2NvbXBpbGF0aW9uOwogICAg ICAgICBXZWFrUmFuZG9tIG1fcmFuZG9tR2VuZXJhdG9yOwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2ppdC9KSVRJbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRJbmxpbmVzLmgJKHJldmlzaW9uIDE1NzQ5NCkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvSklUSW5saW5lcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYsNjggKzExNiw2 IEBAIEFMV0FZU19JTkxJTkUgYm9vbCBKSVQ6OmF0SnVtcFRhcmdldCgpCiAgICAgcmV0dXJuIGZh bHNlOwogfQogCi0jaWYgZGVmaW5lZChBU1NFTUJMRVJfSEFTX0NPTlNUQU5UX1BPT0wpICYmIEFT U0VNQkxFUl9IQVNfQ09OU1RBTlRfUE9PTAotCi1BTFdBWVNfSU5MSU5FIHZvaWQgSklUOjpiZWdp blVuaW50ZXJydXB0ZWRTZXF1ZW5jZShpbnQgaW5zblNwYWNlLCBpbnQgY29uc3RTcGFjZSkKLXsK LSNpZiBDUFUoQVJNX1RSQURJVElPTkFMKQotI2lmbmRlZiBOREVCVUcKLSAgICAvLyBFbnN1cmUg dGhlIGxhYmVsIGFmdGVyIHRoZSBzZXF1ZW5jZSBjYW4gYWxzbyBmaXQKLSAgICBpbnNuU3BhY2Ug Kz0gc2l6ZW9mKEFSTVdvcmQpOwotICAgIGNvbnN0U3BhY2UgKz0gc2l6ZW9mKHVpbnQ2NF90KTsK LSNlbmRpZgotCi0gICAgZW5zdXJlU3BhY2UoaW5zblNwYWNlLCBjb25zdFNwYWNlKTsKLQotI2Vs aWYgQ1BVKFNINCkKLSNpZm5kZWYgTkRFQlVHCi0gICAgaW5zblNwYWNlICs9IHNpemVvZihTSDRX b3JkKTsKLSAgICBjb25zdFNwYWNlICs9IHNpemVvZih1aW50NjRfdCk7Ci0jZW5kaWYKLQotICAg IG1fYXNzZW1ibGVyLmVuc3VyZVNwYWNlKGluc25TcGFjZSArIG1fYXNzZW1ibGVyLm1heEluc3Ry dWN0aW9uU2l6ZSArIDIsIGNvbnN0U3BhY2UgKyA4KTsKLSNlbmRpZgotCi0jaWZuZGVmIE5ERUJV RwotICAgIG1fdW5pbnRlcnJ1cHRlZEluc3RydWN0aW9uU2VxdWVuY2VCZWdpbiA9IGxhYmVsKCk7 Ci0gICAgbV91bmludGVycnVwdGVkQ29uc3RhbnRTZXF1ZW5jZUJlZ2luID0gc2l6ZU9mQ29uc3Rh bnRQb29sKCk7Ci0jZW5kaWYKLX0KLQotQUxXQVlTX0lOTElORSB2b2lkIEpJVDo6ZW5kVW5pbnRl cnJ1cHRlZFNlcXVlbmNlKGludCBpbnNuU3BhY2UsIGludCBjb25zdFNwYWNlLCBpbnQgZHN0KQot ewotI2lmbmRlZiBOREVCVUcKLSAgICAvKiBUaGVyZSBhcmUgc2V2ZXJhbCBjYXNlcyB3aGVuIHRo ZSB1bmludGVycnVwdGVkIHNlcXVlbmNlIGlzIGxhcmdlciB0aGFuCi0gICAgICogbWF4aW11bSBy ZXF1aXJlZCBvZmZzZXQgZm9yIHBhdGhpbmcgdGhlIHNhbWUgc2VxdWVuY2UuIEVnLjogaWYgaW4g YQotICAgICAqIHVuaW50ZXJydXB0ZWQgc2VxdWVuY2UgdGhlIGxhc3QgbWFjcm9hc3NlbWJsZXIn cyBpbnN0cnVjdGlvbiBpcyBhIHN0dWIKLSAgICAgKiBjYWxsLCBpdCBlbWl0cyBzdG9yZSBpbnN0 cnVjdGlvbihzKSB3aGljaCBzaG91bGQgbm90IGJlIGluY2x1ZGVkIGluIHRoZQotICAgICAqIGNh bGN1bGF0aW9uIG9mIGxlbmd0aCBvZiB1bmludGVycnVwdGVkIHNlcXVlbmNlLiBTbywgdGhlIGlu c25TcGFjZSBhbmQKLSAgICAgKiBjb25zdFNwYWNlIHNob3VsZCBiZSB1cHBlciBsaW1pdCBpbnN0 ZWFkIG9mIGhhcmQgbGltaXQuCi0gICAgICovCi0KLSNpZiBDUFUoU0g0KQotICAgIGlmICgoZHN0 ID4gMTUpIHx8IChkc3QgPCAtMTYpKSB7Ci0gICAgICAgIGluc25TcGFjZSArPSA4OwotICAgICAg ICBjb25zdFNwYWNlICs9IDI7Ci0gICAgfQotCi0gICAgaWYgKCgoZHN0ID49IC0xNikgJiYgKGRz dCA8IDApKSB8fCAoKGRzdCA+IDcpICYmIChkc3QgPD0gMTUpKSkKLSAgICAgICAgaW5zblNwYWNl ICs9IDg7Ci0jZWxzZQotICAgIFVOVVNFRF9QQVJBTShkc3QpOwotI2VuZGlmCi0KLSAgICBBU1NF UlQoZGlmZmVyZW5jZUJldHdlZW4obV91bmludGVycnVwdGVkSW5zdHJ1Y3Rpb25TZXF1ZW5jZUJl Z2luLCBsYWJlbCgpKSA8PSBpbnNuU3BhY2UpOwotICAgIEFTU0VSVChzaXplT2ZDb25zdGFudFBv b2woKSAtIG1fdW5pbnRlcnJ1cHRlZENvbnN0YW50U2VxdWVuY2VCZWdpbiA8PSBjb25zdFNwYWNl KTsKLSNlbHNlCi0gICAgVU5VU0VEX1BBUkFNKGluc25TcGFjZSk7Ci0gICAgVU5VU0VEX1BBUkFN KGNvbnN0U3BhY2UpOwotICAgIFVOVVNFRF9QQVJBTShkc3QpOwotI2VuZGlmCi19Ci0KLSNlbmRp ZiAvLyBBU1NFTUJMRVJfSEFTX0NPTlNUQU5UX1BPT0wKLQogQUxXQVlTX0lOTElORSB2b2lkIEpJ VDo6dXBkYXRlVG9wQ2FsbEZyYW1lKCkKIHsKICAgICBBU1NFUlQoc3RhdGljX2Nhc3Q8aW50Piht X2J5dGVjb2RlT2Zmc2V0KSA+PSAwKTsK