122875 2013-10-15 18:58:15 -0700 Build fix after r157478 2013-10-15 21:06:38 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song andersca cmarcelo commit-queue gyuyoung.kim luiz noam rniwa ryuan.choi thorton zeno oldest_to_newest 940222 0 jinwoo7.song 2013-10-15 18:58:15 -0700 Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp.o [ 86%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp.o In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:33:0: /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/WebCoreArgumentCoders.h:90:19: error: redefinition of 'struct CoreIPC::ArgumentCoder<WebCore::FloatPoint3D>' In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:29:0: /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:62:19: error: previous definition of 'struct CoreIPC::ArgumentCoder<WebCore::FloatPoint3D>' make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:27:0: /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/WebCoreArgumentCoders.h:90:19: error: redefinition of 'struct CoreIPC::ArgumentCoder<WebCore::FloatPoint3D>' In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:25:0: /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:62:19: error: previous definition of 'struct CoreIPC::ArgumentCoder<WebCore::FloatPoint3D>' make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp.o] Error 1 make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2 940223 1 214329 jinwoo7.song 2013-10-15 19:01:55 -0700 Created attachment 214329 Patch 940230 2 214329 gyuyoung.kim 2013-10-15 19:41:11 -0700 Comment on attachment 214329 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214329&action=review Noam needs to take a look this. > Source/WebKit2/ChangeLog:3 > + Build fix after r157478 It looks insufficient bug title. > Source/WebKit2/ChangeLog:7 > + Any description ? 940242 3 214336 jinwoo7.song 2013-10-15 20:20:58 -0700 Created attachment 214336 Patch 940243 4 214329 jinwoo7.song 2013-10-15 20:21:50 -0700 Comment on attachment 214329 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214329&action=review >> Source/WebKit2/ChangeLog:3 >> + Build fix after r157478 > > It looks insufficient bug title. Changed title. >> Source/WebKit2/ChangeLog:7 >> + > > Any description ? done. 940246 5 214336 gyuyoung.kim 2013-10-15 20:32:01 -0700 Comment on attachment 214336 Patch LGTM 940257 6 214336 commit-queue 2013-10-15 21:06:33 -0700 Comment on attachment 214336 Patch Clearing flags on attachment: 214336 Committed r157484: <http://trac.webkit.org/changeset/157484> 940258 7 commit-queue 2013-10-15 21:06:38 -0700 All reviewed patches have been landed. Closing bug. 214329 2013-10-15 19:01:55 -0700 2013-10-15 20:21:50 -0700 Patch bug-122875-20131016110153.patch text/plain 2605 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3NDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTY5YzA0ZDJjMDg5MTBl YWNhMTNhNjZhOTI5NDM1NjFlNTZhOThiNC4uYmMxZmFiMzIzNjQxZTU2ODFmZjYyYTI5ZTFkYjQ2 MzgwMTMwNzlhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEwLTE1ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBCdWlsZCBmaXgg YWZ0ZXIgcjE1NzQ3OAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTIyODc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzQXJn dW1lbnRDb2RlcnMuY3BwOgorICAgICAgICAqIFNoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nv b3JkaW5hdGVkR3JhcGhpY3NBcmd1bWVudENvZGVycy5oOgorCiAyMDEzLTEwLTE1ICBEZWFuIEph Y2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgRU5BQkxFX1dFQl9BTklNQVRJ T05TIGZsYWcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Db29yZGluYXRlZEdy YXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NBcmd1bWVudENvZGVycy5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzQXJndW1l bnRDb2RlcnMuY3BwCmluZGV4IGU0MjI3YWViMGFmMDM0ZjhkZGJlYWMxZjMwYjI2M2JmZjUzOTk4 ZjguLjMxYmM5NjE4MmVkY2YxMjAwN2I4ZDNhODYwZTQxMjc3MGM0Y2E3OWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3Jh cGhpY3NBcmd1bWVudENvZGVycy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0FyZ3VtZW50Q29kZXJzLmNwcApAQCAt NzksMTYgKzc5LDYgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKIAogbmFtZXNwYWNlIENvcmVJ UEMgewogCi12b2lkIEFyZ3VtZW50Q29kZXI8RmxvYXRQb2ludDNEPjo6ZW5jb2RlKEFyZ3VtZW50 RW5jb2RlciYgZW5jb2RlciwgY29uc3QgRmxvYXRQb2ludDNEJiBmbG9hdFBvaW50M0QpCi17Ci0g ICAgU2ltcGxlQXJndW1lbnRDb2RlcjxGbG9hdFBvaW50M0Q+OjplbmNvZGUoZW5jb2RlciwgZmxv YXRQb2ludDNEKTsKLX0KLQotYm9vbCBBcmd1bWVudENvZGVyPEZsb2F0UG9pbnQzRD46OmRlY29k ZShBcmd1bWVudERlY29kZXImIGRlY29kZXIsIEZsb2F0UG9pbnQzRCYgZmxvYXRQb2ludDNEKQot ewotICAgIHJldHVybiBTaW1wbGVBcmd1bWVudENvZGVyPEZsb2F0UG9pbnQzRD46OmRlY29kZShk ZWNvZGVyLCBmbG9hdFBvaW50M0QpOwotfQotCiB2b2lkIEFyZ3VtZW50Q29kZXI8TGVuZ3RoPjo6 ZW5jb2RlKEFyZ3VtZW50RW5jb2RlciYgZW5jb2RlciwgY29uc3QgTGVuZ3RoJiBsZW5ndGgpCiB7 CiAgICAgU2ltcGxlQXJndW1lbnRDb2RlcjxMZW5ndGg+OjplbmNvZGUoZW5jb2RlciwgbGVuZ3Ro KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNz L0Nvb3JkaW5hdGVkR3JhcGhpY3NBcmd1bWVudENvZGVycy5oIGIvU291cmNlL1dlYktpdDIvU2hh cmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0FyZ3VtZW50Q29kZXJz LmgKaW5kZXggZDQyYWU3OWRmMjRhMTAxZTM0NTBhMzU2NzE4MzIxMDIzYzk1MmJjNC4uYTAzZGRh ZDFjZmRiNDkyYjI4OTAyNTU1OTNhYzllYWEzYWUyMzRlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0FyZ3Vt ZW50Q29kZXJzLmgKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvQ29vcmRpbmF0ZWRHcmFwaGljc0FyZ3VtZW50Q29kZXJzLmgKQEAgLTU5LDExICs1OSw2IEBA IHN0cnVjdCBHcmFwaGljc1N1cmZhY2VUb2tlbjsKIAogbmFtZXNwYWNlIENvcmVJUEMgewogCi10 ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1bWVudENvZGVyPFdlYkNvcmU6OkZsb2F0UG9pbnQzRD4gewot ICAgIHN0YXRpYyB2b2lkIGVuY29kZShBcmd1bWVudEVuY29kZXImLCBjb25zdCBXZWJDb3JlOjpG bG9hdFBvaW50M0QmKTsKLSAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVyJiwg V2ViQ29yZTo6RmxvYXRQb2ludDNEJik7Ci19OwotCiB0ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1bWVu dENvZGVyPFdlYkNvcmU6Okxlbmd0aD4gewogICAgIHN0YXRpYyB2b2lkIGVuY29kZShBcmd1bWVu dEVuY29kZXImLCBjb25zdCBXZWJDb3JlOjpMZW5ndGgmKTsKICAgICBzdGF0aWMgYm9vbCBkZWNv ZGUoQXJndW1lbnREZWNvZGVyJiwgV2ViQ29yZTo6TGVuZ3RoJik7Cg== 214336 2013-10-15 20:20:58 -0700 2013-10-15 21:06:32 -0700 Patch bug-122875-20131016122056.patch text/plain 2812 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3NDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTY5YzA0ZDJjMDg5MTBl YWNhMTNhNjZhOTI5NDM1NjFlNTZhOThiNC4uMzU3YjhlOTYyNDJhOWRmYzEzNTE2ZGE1ZWJhZTRh M2M5MGMyODA1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTEwLTE1ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBSZW1vdmVkIGFy Z3VtZW50IGNvZGVycyBmb3IgRmxvYXRQb2ludDNEIGluIENvb2RpbmF0ZWRHcmFwaGljc0FyZ3Vt ZW50Q29kZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTIyODc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQXJndW1lbnQgY29kZXJzIGZvciBGbG9hdFBvaW50M0QgaXMgYWRkZWQgaW4gV2ViQ29yZUFy Z3VtZW50Q29kZXJzIGFmdGVyIHIxNTc0NzgKKyAgICAgICAgYW5kIGl0IGNhdXNlZCByZWRlZmlu aXRpb24gYnVpbGQgZXJyb3IgaW4gRUZMIHBvcnQuCisKKyAgICAgICAgKiBTaGFyZWQvQ29vcmRp bmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzQXJndW1lbnRDb2RlcnMuY3BwOgorICAg ICAgICAqIFNoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NBcmd1 bWVudENvZGVycy5oOgorCiAyMDEzLTEwLTE1ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNv bT4KIAogICAgICAgICBBZGQgRU5BQkxFX1dFQl9BTklNQVRJT05TIGZsYWcKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3Jh cGhpY3NBcmd1bWVudENvZGVycy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQ29vcmRpbmF0 ZWRHcmFwaGljcy9Db29yZGluYXRlZEdyYXBoaWNzQXJndW1lbnRDb2RlcnMuY3BwCmluZGV4IGU0 MjI3YWViMGFmMDM0ZjhkZGJlYWMxZjMwYjI2M2JmZjUzOTk4ZjguLjMxYmM5NjE4MmVkY2YxMjAw N2I4ZDNhODYwZTQxMjc3MGM0Y2E3OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NBcmd1bWVudENvZGVycy5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRp bmF0ZWRHcmFwaGljc0FyZ3VtZW50Q29kZXJzLmNwcApAQCAtNzksMTYgKzc5LDYgQEAgdXNpbmcg bmFtZXNwYWNlIFdlYktpdDsKIAogbmFtZXNwYWNlIENvcmVJUEMgewogCi12b2lkIEFyZ3VtZW50 Q29kZXI8RmxvYXRQb2ludDNEPjo6ZW5jb2RlKEFyZ3VtZW50RW5jb2RlciYgZW5jb2RlciwgY29u c3QgRmxvYXRQb2ludDNEJiBmbG9hdFBvaW50M0QpCi17Ci0gICAgU2ltcGxlQXJndW1lbnRDb2Rl cjxGbG9hdFBvaW50M0Q+OjplbmNvZGUoZW5jb2RlciwgZmxvYXRQb2ludDNEKTsKLX0KLQotYm9v bCBBcmd1bWVudENvZGVyPEZsb2F0UG9pbnQzRD46OmRlY29kZShBcmd1bWVudERlY29kZXImIGRl Y29kZXIsIEZsb2F0UG9pbnQzRCYgZmxvYXRQb2ludDNEKQotewotICAgIHJldHVybiBTaW1wbGVB cmd1bWVudENvZGVyPEZsb2F0UG9pbnQzRD46OmRlY29kZShkZWNvZGVyLCBmbG9hdFBvaW50M0Qp OwotfQotCiB2b2lkIEFyZ3VtZW50Q29kZXI8TGVuZ3RoPjo6ZW5jb2RlKEFyZ3VtZW50RW5jb2Rl ciYgZW5jb2RlciwgY29uc3QgTGVuZ3RoJiBsZW5ndGgpCiB7CiAgICAgU2ltcGxlQXJndW1lbnRD b2RlcjxMZW5ndGg+OjplbmNvZGUoZW5jb2RlciwgbGVuZ3RoKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkR3JhcGhpY3NB cmd1bWVudENvZGVycy5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhp Y3MvQ29vcmRpbmF0ZWRHcmFwaGljc0FyZ3VtZW50Q29kZXJzLmgKaW5kZXggZDQyYWU3OWRmMjRh MTAxZTM0NTBhMzU2NzE4MzIxMDIzYzk1MmJjNC4uYTAzZGRhZDFjZmRiNDkyYjI4OTAyNTU1OTNh YzllYWEzYWUyMzRlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0Nvb3JkaW5h dGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGljc0FyZ3VtZW50Q29kZXJzLmgKKysrIGIvU291 cmNlL1dlYktpdDIvU2hhcmVkL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRHcmFwaGlj c0FyZ3VtZW50Q29kZXJzLmgKQEAgLTU5LDExICs1OSw2IEBAIHN0cnVjdCBHcmFwaGljc1N1cmZh Y2VUb2tlbjsKIAogbmFtZXNwYWNlIENvcmVJUEMgewogCi10ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1 bWVudENvZGVyPFdlYkNvcmU6OkZsb2F0UG9pbnQzRD4gewotICAgIHN0YXRpYyB2b2lkIGVuY29k ZShBcmd1bWVudEVuY29kZXImLCBjb25zdCBXZWJDb3JlOjpGbG9hdFBvaW50M0QmKTsKLSAgICBz dGF0aWMgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVyJiwgV2ViQ29yZTo6RmxvYXRQb2ludDNE Jik7Ci19OwotCiB0ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1bWVudENvZGVyPFdlYkNvcmU6Okxlbmd0 aD4gewogICAgIHN0YXRpYyB2b2lkIGVuY29kZShBcmd1bWVudEVuY29kZXImLCBjb25zdCBXZWJD b3JlOjpMZW5ndGgmKTsKICAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVyJiwg V2ViQ29yZTo6TGVuZ3RoJik7Cg==