122830 2013-10-15 07:32:35 -0700 [WinCairo] Build fails. 2013-10-15 09:38:12 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 0 peavo webkit-unassigned bfulgham commit-queue oldest_to_newest 939959 0 peavo 2013-10-15 07:32:35 -0700 The WinCairo build fails to compile: >..\platform\network\NetworkStorageSessionStub.cpp(49): error C2556: 'WTF::PassOwnPtr WebCore::NetworkStorageSession::createPrivateBrowsingSession(const WTF::String &)' : overloaded function differs only by return type from 'std::unique_ptr<_Ty> WebCore::NetworkStorageSession::createPrivateBrowsingSession(const WTF::String &)' with [ T=WebCore::NetworkStorageSession ] and [ _Ty=WebCore::NetworkStorageSession ] webcore\platform\network\NetworkStorageSession.h(49) : see declaration of 'WebCore::NetworkStorageSession::createPrivateBrowsingSession' 1>..\platform\network\NetworkStorageSessionStub.cpp(49): error C2371: 'WebCore::NetworkStorageSession::createPrivateBrowsingSession' : redefinition; different basic types webcore\platform\network\NetworkStorageSession.h(49) : see declaration of 'WebCore::NetworkStorageSession::createPrivateBrowsingSession 939960 1 214257 peavo 2013-10-15 07:36:48 -0700 Created attachment 214257 Patch 939984 2 214257 bfulgham 2013-10-15 09:15:56 -0700 Comment on attachment 214257 Patch r=me 940005 3 214257 commit-queue 2013-10-15 09:38:11 -0700 Comment on attachment 214257 Patch Clearing flags on attachment: 214257 Committed r157450: <http://trac.webkit.org/changeset/157450> 940006 4 commit-queue 2013-10-15 09:38:12 -0700 All reviewed patches have been landed. Closing bug. 214257 2013-10-15 07:36:48 -0700 2013-10-15 09:38:11 -0700 Patch bug-122830-20131015163614.patch text/plain 1308 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NzQ0OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEwLTE1ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQnVp bGQgZmFpbHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjI4MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0b3JhZ2VTZXNzaW9uU3R1Yi5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpOZXR3b3JrU3RvcmFnZVNlc3Npb246OmNyZWF0ZVByaXZhdGVCcm93c2lu Z1Nlc3Npb24pOiBVcGRhdGUgdG8gbmV3IHJldHVybiB0eXBlLgorCiAyMDEzLTEwLTE1ICBBbmRy ZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBGaWxlSWNvbkxvYWRlciBz aG91bGQgbm90IGJlIHJlZi1jb3VudGVkLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9OZXR3b3JrU3RvcmFnZVNlc3Npb25TdHViLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL05ldHdvcmtTdG9yYWdlU2Vzc2lvblN0dWIuY3Bw CShyZXZpc2lvbiAxNTc0NDkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL05l dHdvcmtTdG9yYWdlU2Vzc2lvblN0dWIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NSw3ICs0NSw3 IEBAIE5ldHdvcmtpbmdDb250ZXh0KiBOZXR3b3JrU3RvcmFnZVNlc3Npb24KICAgICByZXR1cm4g bV9jb250ZXh0LmdldCgpOwogfQogCi1QYXNzT3duUHRyPE5ldHdvcmtTdG9yYWdlU2Vzc2lvbj4g TmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpjcmVhdGVQcml2YXRlQnJvd3NpbmdTZXNzaW9uKGNvbnN0 IFN0cmluZyYpCitzdGQ6OnVuaXF1ZV9wdHI8TmV0d29ya1N0b3JhZ2VTZXNzaW9uPiBOZXR3b3Jr U3RvcmFnZVNlc3Npb246OmNyZWF0ZVByaXZhdGVCcm93c2luZ1Nlc3Npb24oY29uc3QgU3RyaW5n JikKIHsKICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICByZXR1cm4gbnVsbHB0cjsK