122790 2013-10-14 16:33:46 -0700 Windows XP stack and heap sizes should be unspecified, not 0 2013-10-17 15:45:27 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Critical --- 0 alex.christensen webkit-unassigned bfulgham commit-queue roger_fong oldest_to_newest 939717 0 alex.christensen 2013-10-14 16:33:46 -0700 The stack sizes of 0 was causing WinCairo to crash 100% of the time immediately upon opening WinLauncher because there were problems with making new threads with pthreadVC2.dll. The fix requires this and a change to WinCairoRequirements which Anthony already emailed to Brent. 939720 1 214208 alex.christensen 2013-10-14 16:36:22 -0700 Created attachment 214208 Patch 941002 2 roger_fong 2013-10-17 15:07:58 -0700 Can you say in the ChangeLog that the fix is for XP in general? (Since it fixes AppleWin XP too) Unofficial r+ 941005 3 214518 alex.christensen 2013-10-17 15:10:18 -0700 Created attachment 214518 patch 941006 4 214518 ggaren 2013-10-17 15:19:55 -0700 Comment on attachment 214518 patch r=me 941020 5 214518 commit-queue 2013-10-17 15:45:26 -0700 Comment on attachment 214518 patch Clearing flags on attachment: 214518 Committed r157608: <http://trac.webkit.org/changeset/157608> 941021 6 commit-queue 2013-10-17 15:45:27 -0700 All reviewed patches have been landed. Closing bug. 214208 2013-10-14 16:36:22 -0700 2013-10-17 15:10:18 -0700 Patch bug-122790-20131014173621.patch text/plain 1640 alex.christensen SW5kZXg6IFdlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0TGli cmFyaWVzL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3NDI5KQorKysgV2ViS2l0TGlicmFyaWVzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEwLTE0ICBBbnRo b255IEpvaG5zb24gIDxhbnRob255LmpvaG5zb25AZmxleHNpbS5jb20+CisKKyAgICAgICAgQ3Jh c2ggZml4IGZvciBXaW5DYWlybyBvbiBXaW5kb3dzIFhQLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyNzkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3aW4vdG9vbHMvdnNwcm9wcy9jb21tb24ucHJv cHM6CisgICAgICAgIFJlcGxhY2VkIHN0YWNrIGFuZCBoZWFwIHNpemVzIG9mIHplcm8gd2l0aCBi bGFuayBzdGFjayBhbmQgaGVhcCBzaXplcy4KKwogMjAxMy0xMC0xMCAgRmlsaXAgUGl6bG8gIDxm cGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSB0aGUgYmluYXJ5IGRyb3BzIHRvIHRo ZSBsYXRlc3QgdmVyc2lvbiBvZiBMTFZNLCBidWlsdCB3aXRob3V0IC1mdmlzaWJpbGl0eT1oaWRk ZW4KSW5kZXg6IFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9jb21tb24ucHJvcHMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3Byb3BzL2NvbW1vbi5w cm9wcwkocmV2aXNpb24gMTU3NDI3KQorKysgV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3By b3BzL2NvbW1vbi5wcm9wcwkod29ya2luZyBjb3B5KQpAQCAtMTg0LDEwICsxODQsMTQgQEAgY21k IC9jCiAgICAgICA8SWdub3JlQWxsRGVmYXVsdExpYnJhcmllcz5mYWxzZTwvSWdub3JlQWxsRGVm YXVsdExpYnJhcmllcz4NCiAgICAgICA8QXNzZW1ibHlEZWJ1Zz5mYWxzZTwvQXNzZW1ibHlEZWJ1 Zz4NCiAgICAgICA8U3ViU3lzdGVtPldpbmRvd3M8L1N1YlN5c3RlbT4NCi0gICAgICA8SGVhcFJl c2VydmVTaXplPjA8L0hlYXBSZXNlcnZlU2l6ZT4NCi0gICAgICA8SGVhcENvbW1pdFNpemU+MDwv SGVhcENvbW1pdFNpemU+DQotICAgICAgPFN0YWNrUmVzZXJ2ZVNpemU+MDwvU3RhY2tSZXNlcnZl U2l6ZT4NCi0gICAgICA8U3RhY2tDb21taXRTaXplPjA8L1N0YWNrQ29tbWl0U2l6ZT4NCisgICAg ICA8SGVhcFJlc2VydmVTaXplPg0KKyAgICAgIDwvSGVhcFJlc2VydmVTaXplPg0KKyAgICAgIDxI ZWFwQ29tbWl0U2l6ZT4NCisgICAgICA8L0hlYXBDb21taXRTaXplPg0KKyAgICAgIDxTdGFja1Jl c2VydmVTaXplPg0KKyAgICAgIDwvU3RhY2tSZXNlcnZlU2l6ZT4NCisgICAgICA8U3RhY2tDb21t aXRTaXplPg0KKyAgICAgIDwvU3RhY2tDb21taXRTaXplPg0KICAgICAgIDxMYXJnZUFkZHJlc3NB d2FyZT4NCiAgICAgICA8L0xhcmdlQWRkcmVzc0F3YXJlPg0KICAgICAgIDxMaW5rVGltZUNvZGVH ZW5lcmF0aW9uPkRlZmF1bHQ8L0xpbmtUaW1lQ29kZUdlbmVyYXRpb24+DQo= 214518 2013-10-17 15:10:18 -0700 2013-10-17 15:45:25 -0700 patch patch text/plain 1609 alex.christensen SW5kZXg6IFdlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0TGli cmFyaWVzL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3NDI5KQorKysgV2ViS2l0TGlicmFyaWVzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEwLTE0ICBBbnRo b255IEpvaG5zb24gIDxhbnRob255LmpvaG5zb25AZmxleHNpbS5jb20+CisKKyAgICAgICAgQ3Jh c2ggZml4IGZvciBXaW5kb3dzIFhQLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTIyNzkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiB3aW4vdG9vbHMvdnNwcm9wcy9jb21tb24ucHJvcHM6CisgICAgICAg IFJlcGxhY2VkIHN0YWNrIGFuZCBoZWFwIHNpemVzIG9mIHplcm8gd2l0aCBibGFuayBzdGFjayBh bmQgaGVhcCBzaXplcy4KKwogMjAxMy0xMC0xMCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUu Y29tPgogCiAgICAgICAgIFVwZGF0ZSB0aGUgYmluYXJ5IGRyb3BzIHRvIHRoZSBsYXRlc3QgdmVy c2lvbiBvZiBMTFZNLCBidWlsdCB3aXRob3V0IC1mdmlzaWJpbGl0eT1oaWRkZW4KSW5kZXg6IFdl YktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9jb21tb24ucHJvcHMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3Byb3BzL2NvbW1vbi5wcm9wcwkocmV2aXNp b24gMTU3NDI3KQorKysgV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3Byb3BzL2NvbW1vbi5w cm9wcwkod29ya2luZyBjb3B5KQpAQCAtMTg0LDEwICsxODQsMTQgQEAgY21kIC9jCiAgICAgICA8 SWdub3JlQWxsRGVmYXVsdExpYnJhcmllcz5mYWxzZTwvSWdub3JlQWxsRGVmYXVsdExpYnJhcmll cz4KICAgICAgIDxBc3NlbWJseURlYnVnPmZhbHNlPC9Bc3NlbWJseURlYnVnPgogICAgICAgPFN1 YlN5c3RlbT5XaW5kb3dzPC9TdWJTeXN0ZW0+Ci0gICAgICA8SGVhcFJlc2VydmVTaXplPjA8L0hl YXBSZXNlcnZlU2l6ZT4KLSAgICAgIDxIZWFwQ29tbWl0U2l6ZT4wPC9IZWFwQ29tbWl0U2l6ZT4K LSAgICAgIDxTdGFja1Jlc2VydmVTaXplPjA8L1N0YWNrUmVzZXJ2ZVNpemU+Ci0gICAgICA8U3Rh Y2tDb21taXRTaXplPjA8L1N0YWNrQ29tbWl0U2l6ZT4KKyAgICAgIDxIZWFwUmVzZXJ2ZVNpemU+ CisgICAgICA8L0hlYXBSZXNlcnZlU2l6ZT4KKyAgICAgIDxIZWFwQ29tbWl0U2l6ZT4KKyAgICAg IDwvSGVhcENvbW1pdFNpemU+CisgICAgICA8U3RhY2tSZXNlcnZlU2l6ZT4KKyAgICAgIDwvU3Rh Y2tSZXNlcnZlU2l6ZT4KKyAgICAgIDxTdGFja0NvbW1pdFNpemU+CisgICAgICA8L1N0YWNrQ29t bWl0U2l6ZT4KICAgICAgIDxMYXJnZUFkZHJlc3NBd2FyZT4KICAgICAgIDwvTGFyZ2VBZGRyZXNz QXdhcmU+CiAgICAgICA8TGlua1RpbWVDb2RlR2VuZXJhdGlvbj5EZWZhdWx0PC9MaW5rVGltZUNv ZGVHZW5lcmF0aW9uPg==