122776 2013-10-14 13:57:55 -0700 Crash in WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>::createBidiRunsForLine 2013-10-14 23:18:09 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED BlinkMergeCandidate, InRadar P2 Normal --- 1 rniwa rniwa commit-queue darin enrica esprehn+autocc glenn kondapallykalyan mitz mmaxfield roger_fong webkit-bug-importer oldest_to_newest 939629 0 rniwa 2013-10-14 13:57:55 -0700 Crash in WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>::createBidiRunsForLine 939630 1 214185 rniwa 2013-10-14 13:58:49 -0700 Created attachment 214185 Fixes the bug 939636 2 rniwa 2013-10-14 14:25:08 -0700 Merge https://chromium.googlesource.com/chromium/blink/+/aca89bc4d984705a1f94b623dae0ab03e239a248 https://code.google.com/p/chromium/issues/detail?id=166847 939649 3 214185 ap 2013-10-14 14:44:17 -0700 Comment on attachment 214185 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=214185&action=review > LayoutTests/fast/text/whitespace/whitespace-and-margin-wrap-after-list-marker-crash.html:7 > + testRunner.dumpAsText(); Indentation. 939653 4 rniwa 2013-10-14 14:50:48 -0700 (In reply to comment #3) > (From update of attachment 214185 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214185&action=review > > > LayoutTests/fast/text/whitespace/whitespace-and-margin-wrap-after-list-marker-crash.html:7 > > + testRunner.dumpAsText(); > > Indentation. Will fix. 939687 5 214185 darin 2013-10-14 16:01:42 -0700 Comment on attachment 214185 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=214185&action=review > Source/WebCore/ChangeLog:29 > + While looking at the code, I also discovered we used INT_MAX as a magic value > + for a midpoint's position, but the variable is actually an unsigned. I changed > + the magic value to be UINT_MAX. I don’t see this change. 939726 6 rniwa 2013-10-14 16:57:09 -0700 (In reply to comment #5) > (From update of attachment 214185 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214185&action=review > > > Source/WebCore/ChangeLog:29 > > + While looking at the code, I also discovered we used INT_MAX as a magic value > > + for a midpoint's position, but the variable is actually an unsigned. I changed > > + the magic value to be UINT_MAX. > > I don’t see this change. Oops, you're right. That's because we already have this fix in WebKit. 939804 7 rniwa 2013-10-14 20:00:15 -0700 Landed in http://trac.webkit.org/changeset/157436. 939868 8 webkit-bug-importer 2013-10-14 23:18:09 -0700 <rdar://problem/15228657> 214185 2013-10-14 13:58:49 -0700 2013-10-14 16:01:41 -0700 Fixes the bug bug-122776-20131014135848.patch text/plain 4870 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NzQxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM4IEBACisyMDEzLTEwLTE0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENyYXNoIGluIFdlYkNvcmU6OkJp ZGlSZXNvbHZlcjxXZWJDb3JlOjpJbmxpbmVJdGVyYXRvciwgV2ViQ29yZTo6QmlkaVJ1bj46OmNy ZWF0ZUJpZGlSdW5zRm9yTGluZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTIyNzc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTWVyZ2UgaHR0cHM6Ly9jaHJvbWl1bS5nb29nbGVzb3VyY2UuY29tL2Nocm9t aXVtL2JsaW5rLysvYWNhODliYzRkOTg0NzA1YTFmOTRiNjIzZGFlMGFiMDNlMjM5YTI0OAorCisg ICAgICAgIEZpeCBtb2RpZmljYXRpb24gb2Ygd2hpdGVzcGFjZSBlbmRwb2ludHMgdG8gbm90IGFz c3VtZSBpdCdzIG9wZXJhdGluZyBvbiBSZW5kZXJUZXh0cworCisgICAgICAgIER1cmluZyBsaW5l IGxheW91dCwgd2UgdXNlIG1pZHBvaW50cyB0byBpZGVudGlmeSBSZW5kZXJPYmplY3RzLCBvciBw YXJ0cyBvZgorICAgICAgICBSZW5kZXJPYmplY3RzLCB0aGF0IGRvbid0IG5lZWQgSW5saW5lQm94 ZXMsIHVzdWFsbHkgYmVjYXVzZSBvZiBjb2xsYXBzZWQgd2hpdGVzcGFjZS4KKworICAgICAgICBQ cmlvciB0byBhY3R1YWxseSBjcmVhdGluZyBCaWRpUnVucyAodGhlIHByZWN1cnNvciB0byBJbmxp bmVCb3hlcyksIHdlIHVzZQorICAgICAgICBjaGVja01pZHBvaW50cyB0byBmaXggdXAgb3VyIGxp bmVNaWRwb2ludFN0YXRlIHRvIGhhbmRsZSB0aGUgY2FzZSB3aGVyZSB3ZSBzdGFydAorICAgICAg ICBpZ25vcmluZyBzcGFjZXMgaW4gb3VyIGxpbmUsIGJ1dCBkb24ndCBzdG9wIHVudGlsIHNvbWV3 aGVyZSBvbiB0aGUgZm9sbG93aW5nIGxpbmUuCisgICAgICAgIFByZXZpb3VzbHksIHRoaXMgZnVu Y3Rpb24gYXNzdW1lZCB0aGF0IHRoZSBmaW5hbCBtaWRwb2ludCAoY2FsbGVkIGFuIGVuZHBvaW50 KQorICAgICAgICB3YXMgYSBSZW5kZXJUZXh0LCBidXQgdGhpcyBhc3N1bXB0aW9uIGlzIHdyb25n IGlmIHdlIGhhdmUgYSBiZWdpbm5pbmcgbWlkcG9pbnQKKyAgICAgICAgY3JlYXRlZCBieSBzaG91 bGRTa2lwV2hpdGVzcGFjZUFmdGVyU3RhcnRPYmplY3QgKHdoaWNoIGhhbmRsZXMgaW5saW5lcyBh bmQgbGlzdAorICAgICAgICBtYXJrZXJzKSBhbmQgbm8gZW5kcG9pbnQgb24gdGhhdCBsaW5lLiBJ biB0aGF0IGNhc2UsIHdlJ2QgaW5zdGVhZCBhZGp1c3QgdGhlCisgICAgICAgIHBvc2l0aW9uIGJh Y2t3YXJkcyBvbiB0aGUgYmVnaW5uaW5nIG1pZHBvaW50LCB3aGljaCB3b3VsZCBjYXVzZSB1cyB0 byBmYWlsIHRvCisgICAgICAgIGNyZWF0ZSBhbiBJbmxpbmVCb3ggZm9yIHRoZSBpbmxpbmUgb3Ig bGlzdCBtYXJrZXIuIEluIHRoZSBuZXcgdGVzdCBhZGRlZCwgdGhpcworICAgICAgICB3b3VsZCBh Y3R1YWxseSB0cmlnZ2VyIGEgY3Jhc2ggZHVlIHRvIGFuIGFzc3VtcHRpb24gd2hlbiB2aXN1YWxs eSByZS1vcmRlcmluZworICAgICAgICBCaWRpUnVucyB0aGF0IGEgbm9uLWVtcHR5IGxpbmUgd291 bGQgYWN0dWFsbHkgY29udGFpbiBhdCBsZWFzdCBvbmUgc3VjaCBydW4uCisKKyAgICAgICAgV2hp bGUgbG9va2luZyBhdCB0aGUgY29kZSwgSSBhbHNvIGRpc2NvdmVyZWQgd2UgdXNlZCBJTlRfTUFY IGFzIGEgbWFnaWMgdmFsdWUKKyAgICAgICAgZm9yIGEgbWlkcG9pbnQncyBwb3NpdGlvbiwgYnV0 IHRoZSB2YXJpYWJsZSBpcyBhY3R1YWxseSBhbiB1bnNpZ25lZC4gSSBjaGFuZ2VkCisgICAgICAg IHRoZSBtYWdpYyB2YWx1ZSB0byBiZSBVSU5UX01BWC4KKworICAgICAgICBUZXN0OiBmYXN0L3Rl eHQvd2hpdGVzcGFjZS93aGl0ZXNwYWNlLWFuZC1tYXJnaW4td3JhcC1hZnRlci1saXN0LW1hcmtl ci1jcmFzaC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNoZWNrTWlkcG9pbnRzKToKKwogMjAxMy0xMC0xNCAg VGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBWaXJ0dWFs aXplIFBsYXRmb3JtQ0FMYXllcgpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrTGluZUxheW91dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAJKHJldmlzaW9uIDE1NzQxNCkKKysrIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yMDcsNyArMjA3LDcgQEAgc3RhdGljIHZvaWQgY2hlY2tNaWRwb2ludHMoTGluZU1p ZHBvaW50UwogICAgICAgICBpZiAoY3VycnBvaW50ID09IGxCcmVhaykgewogICAgICAgICAgICAg Ly8gV2UgaGl0IHRoZSBsaW5lIGJyZWFrIGJlZm9yZSB0aGUgc3RhcnQgcG9pbnQuICBTaGF2ZSBv ZmYgdGhlIHN0YXJ0IHBvaW50LgogICAgICAgICAgICAgbGluZU1pZHBvaW50U3RhdGUubnVtTWlk cG9pbnRzLS07Ci0gICAgICAgICAgICBpZiAoZW5kcG9pbnQubV9vYmotPnN0eWxlKCktPmNvbGxh cHNlV2hpdGVTcGFjZSgpKQorICAgICAgICAgICAgaWYgKGVuZHBvaW50Lm1fb2JqLT5zdHlsZSgp LT5jb2xsYXBzZVdoaXRlU3BhY2UoKSAmJiBlbmRwb2ludC5tX29iai0+aXNUZXh0KCkpCiAgICAg ICAgICAgICAgICAgZW5kcG9pbnQubV9wb3MtLTsKICAgICAgICAgfQogICAgIH0KSW5kZXg6IExh eW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJ KHJldmlzaW9uIDE1NzQxOSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTEwLTE0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJr aXQub3JnPgorCisgICAgICAgIENyYXNoIGluIFdlYkNvcmU6OkJpZGlSZXNvbHZlcjxXZWJDb3Jl OjpJbmxpbmVJdGVyYXRvciwgV2ViQ29yZTo6QmlkaVJ1bj46OmNyZWF0ZUJpZGlSdW5zRm9yTGlu ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyNzc2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0 L3RleHQvd2hpdGVzcGFjZS93aGl0ZXNwYWNlLWFuZC1tYXJnaW4td3JhcC1hZnRlci1saXN0LW1h cmtlci1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGV4dC93aGl0 ZXNwYWNlL3doaXRlc3BhY2UtYW5kLW1hcmdpbi13cmFwLWFmdGVyLWxpc3QtbWFya2VyLWNyYXNo Lmh0bWw6IEFkZGVkLgorCiAyMDEzLTEwLTE0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBw bGUuY29tPgogCiAgICAgICAgIHdpbmRvdy5jcnlwdG8gZG9lc24ndCBwcmVzZXJ2ZSBjdXN0b20g cHJvcGVydGllcwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3doaXRlc3BhY2Uvd2hpdGVz cGFjZS1hbmQtbWFyZ2luLXdyYXAtYWZ0ZXItbGlzdC1tYXJrZXItY3Jhc2gtZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvdGV4dC93aGl0ZXNwYWNlL3doaXRlc3Bh Y2UtYW5kLW1hcmdpbi13cmFwLWFmdGVyLWxpc3QtbWFya2VyLWNyYXNoLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvdGV4dC93aGl0ZXNwYWNlL3doaXRlc3Bh Y2UtYW5kLW1hcmdpbi13cmFwLWFmdGVyLWxpc3QtbWFya2VyLWNyYXNoLWV4cGVjdGVkLnR4dAko d29ya2luZyBjb3B5KQpAQCAtMCwwICsxIEBACitUZXN0IHBhc3NlcyBpZiB0aGVyZSBpcyBubyBj cmFzaC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdGV4dC93aGl0ZXNwYWNlL3doaXRlc3BhY2Ut YW5kLW1hcmdpbi13cmFwLWFmdGVyLWxpc3QtbWFya2VyLWNyYXNoLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3doaXRlc3BhY2Uvd2hpdGVzcGFjZS1hbmQtbWFyZ2lu LXdyYXAtYWZ0ZXItbGlzdC1tYXJrZXItY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91 dFRlc3RzL2Zhc3QvdGV4dC93aGl0ZXNwYWNlL3doaXRlc3BhY2UtYW5kLW1hcmdpbi13cmFwLWFm dGVyLWxpc3QtbWFya2VyLWNyYXNoLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMCBA QAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5IGRpcj0ncnRsJz4KKzxkaXYgc3R5bGU9 Jy13ZWJraXQtcnRsLW9yZGVyaW5nOiB2aXN1YWw7Jz48bGk+PHNwYW4gc3R5bGU9Im1hcmdpbjog MjAwMDsiPiBUZXN0IHBhc3NlcyBpZiB0aGVyZSBpcyBubyBjcmFzaC4KKzxzY3JpcHQ+CitpZiAo d2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworPC9z Y3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==