122770 2013-10-14 12:05:28 -0700 window.crypto doesn't preserve custom properties 2013-10-31 13:30:50 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 122679 1 ap ap cdumez commit-queue esprehn+autocc ggaren kondapallykalyan mhahnenberg sam oldest_to_newest 939585 0 ap 2013-10-14 12:05:28 -0700 GC doesn't preserve Crypto wrapper even when it's observable. 939593 1 214179 ap 2013-10-14 12:26:19 -0700 Created attachment 214179 proposed fix 939595 2 commit-queue 2013-10-14 12:28:22 -0700 Attachment 214179 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/security/crypto-gc-expected.txt', u'LayoutTests/security/crypto-gc.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/Crypto.cpp', u'Source/WebCore/page/Crypto.h', u'Source/WebCore/page/Crypto.idl', u'Source/WebCore/page/DOMWindow.cpp']" exit_code: 1 Source/WebCore/page/Crypto.h:57: The parameter name "document" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style. 939596 3 214179 mhahnenberg 2013-10-14 12:31:57 -0700 Comment on attachment 214179 proposed fix r=me 939616 4 ap 2013-10-14 13:27:28 -0700 Committed r157417. 939812 5 214179 ggaren 2013-10-14 20:13:17 -0700 Comment on attachment 214179 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=214179&action=review > Source/WebCore/page/DOMWindow.cpp:596 > + // FIXME: Why is crypto not available when the window is not currently displayed in a frame? > if (!isCurrentlyDisplayedInFrame()) > return 0; Shenanigans! 214179 2013-10-14 12:26:19 -0700 2013-10-14 20:13:17 -0700 proposed fix CryptoGC.txt text/plain 6850 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NzQxMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDEzLTEwLTE0ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIHdpbmRvdy5jcnlwdG8gZG9l c24ndCBwcmVzZXJ2ZSBjdXN0b20gcHJvcGVydGllcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyNzcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogc2VjdXJpdHkvY3J5cHRvLWdjLmh0bWwKKwor ICAgICAgICBHZW5lcmF0ZSBpc1JlYWNoYWJsZUZyb21PcGFxdWVSb290cyB0aGF0IG1ha2VzIENy eXB0byBsaXZlIGFzIGxvbmcgYXMgdGhlIGRvY3VtZW50CisgICAgICAgIGxpdmVzIChiZWNhdXNl IHRoYXQncyB3aGVuIGl0J3Mgb2JzZXJ2YWJsZSB0aHJvdWdoIHdpbmRvdyBvYmplY3QpLgorCisg ICAgICAgICogcGFnZS9DcnlwdG8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q3J5cHRvOjpDcnlw dG8pOgorICAgICAgICAoV2ViQ29yZTo6Q3J5cHRvOjp+Q3J5cHRvKToKKyAgICAgICAgKFdlYkNv cmU6OkNyeXB0bzo6ZG9jdW1lbnQpOgorICAgICAgICAqIHBhZ2UvQ3J5cHRvLmg6CisgICAgICAg IChXZWJDb3JlOjpDcnlwdG86OmNyZWF0ZSk6CisgICAgICAgIE1hZGUgQ3J5cHRvIGEgQ29udGV4 dERlc3RydWN0aW9uT2JzZXJ2ZXIsIHNvIHRoYXQgaXQgY2FuIHJlcG9ydCBpdHMgZG9jdW1lbnQg dG8gYmluZGluZ3MuCisgICAgICAgIFJlbW92ZWQgU2NyaXB0V3JhcHBhYmxlLCBiZWNhdXNlIGl0 IHNlZW1zIHRvIGhhdmUgc2VydmVkIG5vIHB1cnBvc2UgaW4gdGhpcyBjbGFzcy4KKworICAgICAg ICAqIHBhZ2UvQ3J5cHRvLmlkbDogQWRkZWQgR2VuZXJhdGVJc1JlYWNoYWJsZS4gUmVtb3ZlZCBJ bXBsZW1lbnRhdGlvbkxhY2tzVlRhYmxlLAorICAgICAgICBiZWNhdXNlIHRoZSBjbGFzcyBub3cg aGFzIGEgdnRhYmxlLCBhbmQgY2FuIGJlIGNoZWNrZWQgZm9yIGJpbmRpbmdzIGludGVncml0eS4K KworICAgICAgICAqIHBhZ2UvRE9NV2luZG93LmNwcDogKFdlYkNvcmU6OkRPTVdpbmRvdzo6Y3J5 cHRvKTogUGFzcyBhIGRvY3VtZW50IHdoZW4gY3JlYXRpbmcKKyAgICAgICAgY3J5cHRvLgorCiAy MDEzLTEwLTE0ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAg IFtXaW5dIEJ1aWxkIGZpeCBhZnRlciByMTIyNzM3LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGFn ZS9DcnlwdG8uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvQ3J5cHRvLmNw cAkocmV2aXNpb24gMTU3NDA5KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9DcnlwdG8uY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zMCw4ICszMCw4IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5j bHVkZSAiQ3J5cHRvLmgiCiAKKyNpbmNsdWRlICJEb2N1bWVudC5oIgogI2luY2x1ZGUgIkV4Y2Vw dGlvbkNvZGUuaCIKLSNpbmNsdWRlICJTY3JpcHRXcmFwcGFibGVJbmxpbmVzLmgiCiAjaW5jbHVk ZSA8cnVudGltZS9BcnJheUJ1ZmZlclZpZXcuaD4KICNpbmNsdWRlIDx3dGYvQ3J5cHRvZ3JhcGhp Y2FsbHlSYW5kb21OdW1iZXIuaD4KIApAQCAtNDYsMTAgKzQ2LDIwIEBAIGJvb2wgaXNJbnRlZ2Vy QXJyYXkoQXJyYXlCdWZmZXJWaWV3KiBhcnIKIAogfQogCi1DcnlwdG86OkNyeXB0bygpCitDcnlw dG86OkNyeXB0byhEb2N1bWVudCYgZG9jdW1lbnQpCisgICAgOiBDb250ZXh0RGVzdHJ1Y3Rpb25P YnNlcnZlcigmZG9jdW1lbnQpCiB7CiB9CiAKK0NyeXB0bzo6fkNyeXB0bygpCit7Cit9CisKK0Rv Y3VtZW50KiBDcnlwdG86OmRvY3VtZW50KCkgY29uc3QKK3sKKyAgICByZXR1cm4gdG9Eb2N1bWVu dChzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpOworfQorCiB2b2lkIENyeXB0bzo6Z2V0UmFuZG9t VmFsdWVzKEFycmF5QnVmZmVyVmlldyogYXJyYXksIEV4Y2VwdGlvbkNvZGUmIGVjKQogewogICAg IGlmICghYXJyYXkgfHwgIWlzSW50ZWdlckFycmF5KGFycmF5KSkgewpJbmRleDogU291cmNlL1dl YkNvcmUvcGFnZS9DcnlwdG8uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0Ny eXB0by5oCShyZXZpc2lvbiAxNTc0MDkpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0NyeXB0by5o CSh3b3JraW5nIGNvcHkpCkBAIC0yOSw3ICsyOSw3IEBACiAjaWZuZGVmIENyeXB0b19oCiAjZGVm aW5lIENyeXB0b19oCiAKLSNpbmNsdWRlICJTY3JpcHRXcmFwcGFibGUuaCIKKyNpbmNsdWRlICJD b250ZXh0RGVzdHJ1Y3Rpb25PYnNlcnZlci5oIgogI2luY2x1ZGUgPHd0Zi9Gb3J3YXJkLmg+CiAj aW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgpA QCAtNDIsMTQgKzQyLDE5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdHlwZWRlZiBpbnQgRXhj ZXB0aW9uQ29kZTsKIAotY2xhc3MgQ3J5cHRvIDogcHVibGljIFNjcmlwdFdyYXBwYWJsZSwgcHVi bGljIFJlZkNvdW50ZWQ8Q3J5cHRvPiB7CitjbGFzcyBEb2N1bWVudDsKKworY2xhc3MgQ3J5cHRv IDogcHVibGljIENvbnRleHREZXN0cnVjdGlvbk9ic2VydmVyLCBwdWJsaWMgUmVmQ291bnRlZDxD cnlwdG8+IHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUGFzc1JlZlB0cjxDcnlwdG8+IGNyZWF0ZSgp IHsgcmV0dXJuIGFkb3B0UmVmKG5ldyBDcnlwdG8oKSk7IH0KKyAgICBzdGF0aWMgUGFzc1JlZlB0 cjxDcnlwdG8+IGNyZWF0ZShEb2N1bWVudCYgZG9jdW1lbnQpIHsgcmV0dXJuIGFkb3B0UmVmKG5l dyBDcnlwdG8oZG9jdW1lbnQpKTsgfQorICAgIHZpcnR1YWwgfkNyeXB0bygpOworCisgICAgRG9j dW1lbnQqIGRvY3VtZW50KCkgY29uc3Q7CiAKICAgICB2b2lkIGdldFJhbmRvbVZhbHVlcyhKU0M6 OkFycmF5QnVmZmVyVmlldyosIEV4Y2VwdGlvbkNvZGUmKTsKIAogcHJpdmF0ZToKLSAgICBDcnlw dG8oKTsKKyAgICBDcnlwdG8oRG9jdW1lbnQmIGRvY3VtZW50KTsKIH07CiAKIH0KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BhZ2UvQ3J5cHRvLmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wYWdlL0NyeXB0by5pZGwJKHJldmlzaW9uIDE1NzQwOSkKKysrIFNvdXJjZS9XZWJDb3JlL3Bh Z2UvQ3J5cHRvLmlkbAkod29ya2luZyBjb3B5KQpAQCAtMjgsNyArMjgsNyBAQAogCiBbCiAgICAg Tm9JbnRlcmZhY2VPYmplY3QsCi0gICAgSW1wbGVtZW50YXRpb25MYWNrc1ZUYWJsZSwKKyAgICBH ZW5lcmF0ZUlzUmVhY2hhYmxlPUltcGxEb2N1bWVudCwKICAgICBPcGVyYXRpb25zTm90RGVsZXRh YmxlCiBdIGludGVyZmFjZSBDcnlwdG8gewogICAgIFtDdXN0b20sIFJhaXNlc0V4Y2VwdGlvbl0g QXJyYXlCdWZmZXJWaWV3IGdldFJhbmRvbVZhbHVlcyhBcnJheUJ1ZmZlclZpZXcgYXJyYXkpOwpJ bmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAkocmV2aXNpb24gMTU3NDA5KQorKysgU291 cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OTEsMTAg KzU5MSwxMSBAQCBIaXN0b3J5KiBET01XaW5kb3c6Omhpc3RvcnkoKSBjb25zdAogCiBDcnlwdG8q IERPTVdpbmRvdzo6Y3J5cHRvKCkgY29uc3QKIHsKKyAgICAvLyBGSVhNRTogV2h5IGlzIGNyeXB0 byBub3QgYXZhaWxhYmxlIHdoZW4gdGhlIHdpbmRvdyBpcyBub3QgY3VycmVudGx5IGRpc3BsYXll ZCBpbiBhIGZyYW1lPwogICAgIGlmICghaXNDdXJyZW50bHlEaXNwbGF5ZWRJbkZyYW1lKCkpCiAg ICAgICAgIHJldHVybiAwOwogICAgIGlmICghbV9jcnlwdG8pCi0gICAgICAgIG1fY3J5cHRvID0g Q3J5cHRvOjpjcmVhdGUoKTsKKyAgICAgICAgbV9jcnlwdG8gPSBDcnlwdG86OmNyZWF0ZSgqZG9j dW1lbnQoKSk7CiAgICAgcmV0dXJuIG1fY3J5cHRvLmdldCgpOwogfQogCkluZGV4OiBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZp c2lvbiAxNTc0MTEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAg LTEsMyArMSwxMyBAQAorMjAxMy0xMC0xNCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxl LmNvbT4KKworICAgICAgICB3aW5kb3cuY3J5cHRvIGRvZXNuJ3QgcHJlc2VydmUgY3VzdG9tIHBy b3BlcnRpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyMjc3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogc2VjdXJpdHkvY3J5cHRvLWdjLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogc2Vj dXJpdHkvY3J5cHRvLWdjLmh0bWw6IEFkZGVkLgorCiAyMDEzLTEwLTE0ICBGaWxpcCBQaXpsbyAg PGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQmFzZWxpbmUgSklUIHNob3VsZCB1c2UgdGhl IERGRydzIFB1dEJ5SWQgSUMKSW5kZXg6IExheW91dFRlc3RzL3NlY3VyaXR5L2NyeXB0by1nYy1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc2VjdXJpdHkvY3J5cHRvLWdj LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3NlY3VyaXR5L2NyeXB0 by1nYy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAorVGVzdCB0 aGF0IHdpbmRvdy5jcnlwdG8gd3JhcHBlciBwcmVzZXJ2ZXMgY3VzdG9tIHByb3BlcnRpZXMuCisK K09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZv bGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIHdpbmRvdy5jcnlwdG8uZm9vIGlz ICJiYXIiCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUK KwoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvc2VjdXJpdHkvY3J5cHRvLWdjLWV4 cGVjdGVkLnR4dApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkFkZGVkOiBzdm46bWltZS10eXBlCiMjIC0wLDAgKzEgIyMK K3RleHQvcGxhaW4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBwcm9wZXJ0eQpBZGRlZDogc3ZuOmVv bC1zdHlsZQojIyAtMCwwICsxICMjCituYXRpdmUKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBwcm9w ZXJ0eQpJbmRleDogTGF5b3V0VGVzdHMvc2VjdXJpdHkvY3J5cHRvLWdjLmh0bWwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvc2VjdXJpdHkvY3J5cHRvLWdjLmh0bWwJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9zZWN1cml0eS9jcnlwdG8tZ2MuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MCwwICsxLDM4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8bWV0YSBjaGFy c2V0PSJ1dGYtOCI+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48 L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHNjcmlwdD4KKworZGVzY3JpcHRpb24oIlRlc3Qg dGhhdCB3aW5kb3cuY3J5cHRvIHdyYXBwZXIgcHJlc2VydmVzIGN1c3RvbSBwcm9wZXJ0aWVzLiIp OworanNUZXN0SXNBc3luYyA9IHRydWU7CisKK2Z1bmN0aW9uIHN0YXJ0VGVzdCgpCit7CisgICAg d2luZG93LmNyeXB0by5mb28gPSAiYmFyIjsKKyAgICBnYygpOworICAgIHNldFRpbWVvdXQoY29u dGludWVUZXN0LCAxMCk7Cit9CisKK2Z1bmN0aW9uIGNvbnRpbnVlVGVzdCgpCit7CisgICAgZ2Mo KTsKKyAgICBzZXRUaW1lb3V0KGZpbmlzaFRlc3QsIDEwKTsKK30KKworZnVuY3Rpb24gZmluaXNo VGVzdCgpCit7CisgICAgZ2MoKTsKKyAgICBzaG91bGRCZSgnd2luZG93LmNyeXB0by5mb28nLCAn ImJhciInKTsKKyAgICBmaW5pc2hKU1Rlc3QoKTsKK30KKword2luZG93Lm9ubG9hZCA9IHN0YXJ0 VGVzdDsKKworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9z dC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBM YXlvdXRUZXN0cy9zZWN1cml0eS9jcnlwdG8tZ2MuaHRtbApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFkZGVkOiBzdm46 bWltZS10eXBlCiMjIC0wLDAgKzEgIyMKK3RleHQvaHRtbApcIE5vIG5ld2xpbmUgYXQgZW5kIG9m IHByb3BlcnR5Cg==