122765 2013-10-14 11:10:25 -0700 Add FTL support for LogicalNot(string) 2013-10-14 16:29:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 nrotem webkit-unassigned commit-queue fpizlo ggaren mark.lam oldest_to_newest 939546 0 nrotem 2013-10-14 11:10:25 -0700 Add FTL support for LogicalNot(string) 939548 1 214169 nrotem 2013-10-14 11:11:32 -0700 Created attachment 214169 Patch 939635 2 214169 fpizlo 2013-10-14 14:17:17 -0700 Comment on attachment 214169 Patch Why isn't the String case handled in boolify()? The point of boolify() is that Branch and LogicalNot handle the same inputs. 939639 3 214187 nrotem 2013-10-14 14:27:48 -0700 Created attachment 214187 Patch 939662 4 214187 commit-queue 2013-10-14 15:08:08 -0700 Comment on attachment 214187 Patch Rejecting attachment 214187 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 214187, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /git.webkit.org/WebKit 8b2f263..68083b5 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 157423 = 8b2f263c03d7a0ea8b8ac23380bc631fab14f5ec r157424 = 68083b5599c1cfca0f6963f8256eeaadc01fc70e Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/3952908 939666 5 nrotem 2013-10-14 15:18:32 -0700 This error looks unrelated to the patch: Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Username: Use of uninitialized value $username in chomp at /usr/share/git-core/perl/Git/SVN/Prompt.pm line 114. error: git-svn died of signal 11 939672 6 214187 commit-queue 2013-10-14 15:35:56 -0700 Comment on attachment 214187 Patch Rejecting attachment 214187 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 214187, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: t.org/repository/webkit/trunk ... Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Password for 'commit-queue@webkit.org': Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Username: Use of uninitialized value $username in chomp at /usr/share/git-core/perl/Git/SVN/Prompt.pm line 114. error: git-svn died of signal 11 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.appspot.com/results/3885941 939711 7 mark.lam 2013-10-14 16:29:53 -0700 On behalf of Nadav, landed in r157429: <http://trac.webkit.org/r157429>. 214169 2013-10-14 11:11:32 -0700 2013-10-14 14:27:46 -0700 Patch bug-122765-20131014111131.patch text/plain 2288 nrotem U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3NDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ZDJiN2Y0MDBlZjk0ODRiYTVhYzkwZThhYmZmMzVkYzgyOWRmMjllLi4xODMzYmNmMDFlNThjYjE3 YWMzOWU5YmM0MzRkZThjNjUwNzA5MDNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMy0xMC0xNCAgTmFkYXYgUm90ZW0gIDxucm90ZW1AYXBwbGUuY29tPgor CisgICAgICAgIEFkZCBGVEwgc3VwcG9ydCBmb3IgTG9naWNhbE5vdChzdHJpbmcpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI3NjUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgIFRoaXMgcGF0Y2ggaXMgdGVz dGVkIGJ5OgorICAgICAgIHJlZ3Jlc3Mvc2NyaXB0LXRlc3RzL2Vtc2NyaXB0ZW4tY3ViZTJoYXNo LmpzLmZ0bC1lYWdlcgorCisgICAgICAgICogZnRsL0ZUTENhcGFiaWxpdGllcy5jcHA6CisgICAg ICAgIChKU0M6OkZUTDo6Y2FuQ29tcGlsZSk6CisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9M TFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6Y29tcGlsZUxvZ2lj YWxOb3QpOgorCiAyMDEzLTEwLTEzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAog ICAgICAgICBUcmFuc2l0aW9uIG1pc2MgY3RpX29wXyogSklUU3R1YnMgdG8gSklUIG9wZXJhdGlv bnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTENhcGFiaWxpdGll cy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTENhcGFiaWxpdGllcy5jcHAKaW5k ZXggZDdlN2E3MzdiMjliYTdiMWU2YTk3OTYyYzY1NGQ2MDE4ZDcwMjg3Mi4uNGJjYTk1NzcyMDFm MGRlYWQ0MzcxMzU4NmI4ZjFkOGNhNzk1MGJjZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9mdGwvRlRMQ2FwYWJpbGl0aWVzLmNwcApAQCAtMTg4LDYgKzE4OCw3IEBAIGlubGluZSBDYXBh YmlsaXR5TGV2ZWwgY2FuQ29tcGlsZShOb2RlKiBub2RlKQogICAgICAgICBjYXNlIEJvb2xlYW5V c2U6CiAgICAgICAgIGNhc2UgSW50MzJVc2U6CiAgICAgICAgIGNhc2UgTnVtYmVyVXNlOgorICAg ICAgICBjYXNlIFN0cmluZ1VzZToKICAgICAgICAgY2FzZSBPYmplY3RPck90aGVyVXNlOgogICAg ICAgICAgICAgYnJlYWs7CiAgICAgICAgIGRlZmF1bHQ6CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCmluZGV4IDExMzE1N2Y3MTdjNTE3MTJmZGY3 NGFiODhmNWVlM2I0MGFmNmM1ODMuLjI4OTIxZDA5MmYzZWZhNzVkYTA5MTNjNzU0YzY0NDhhZjA2 OTdiMDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdU b0xMVk0uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xM Vk0uY3BwCkBAIC0xODY5LDYgKzE4NjksMTYgQEAgcHJpdmF0ZToKICAgICAKICAgICB2b2lkIGNv bXBpbGVMb2dpY2FsTm90KCkKICAgICB7CisgICAgICAgIC8vIEhhbmRsZSBMb2dpY2FsTm90IG9w ZXJhdGlvbnMgb24gU3RyaW5ncy4KKyAgICAgICAgaWYgKG1fbm9kZS0+Y2hpbGQxKCkudXNlS2lu ZCgpID09IFN0cmluZ1VzZSkgeworICAgICAgICAgICAgTFZhbHVlIHN0cmluZ1ZhbHVlID0gbG93 U3RyaW5nKG1fbm9kZS0+Y2hpbGQxKCkpOworICAgICAgICAgICAgTFZhbHVlIGxlbmd0aCA9IG1f b3V0LmxvYWQzMihzdHJpbmdWYWx1ZSwgbV9oZWFwcy5KU1N0cmluZ19sZW5ndGgpOworICAgICAg ICAgICAgTFZhbHVlIHBvc0xlbiA9IG1fb3V0LmVxdWFsKGxlbmd0aCwgbV9vdXQuaW50MzJaZXJv KTsKKyAgICAgICAgICAgIHNldEJvb2xlYW4ocG9zTGVuKTsKKyAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgfQorCisgICAgICAgIC8vIEhhbmRsZSBudW1lcmljIGJvb2xzLgogICAgICAgICBz ZXRCb29sZWFuKG1fb3V0LmJpdE5vdChib29saWZ5KG1fbm9kZS0+Y2hpbGQxKCkpKSk7CiAgICAg fQogICAgIAo= 214187 2013-10-14 14:27:48 -0700 2013-10-14 15:35:56 -0700 Patch bug-122765-20131014142747.patch text/plain 2243 nrotem U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3NDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy ZDJiN2Y0MDBlZjk0ODRiYTVhYzkwZThhYmZmMzVkYzgyOWRmMjllLi4xODMzYmNmMDFlNThjYjE3 YWMzOWU5YmM0MzRkZThjNjUwNzA5MDNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMy0xMC0xNCAgTmFkYXYgUm90ZW0gIDxucm90ZW1AYXBwbGUuY29tPgor CisgICAgICAgIEFkZCBGVEwgc3VwcG9ydCBmb3IgTG9naWNhbE5vdChzdHJpbmcpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI3NjUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgIFRoaXMgcGF0Y2ggaXMgdGVz dGVkIGJ5OgorICAgICAgIHJlZ3Jlc3Mvc2NyaXB0LXRlc3RzL2Vtc2NyaXB0ZW4tY3ViZTJoYXNo LmpzLmZ0bC1lYWdlcgorCisgICAgICAgICogZnRsL0ZUTENhcGFiaWxpdGllcy5jcHA6CisgICAg ICAgIChKU0M6OkZUTDo6Y2FuQ29tcGlsZSk6CisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9M TFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6Y29tcGlsZUxvZ2lj YWxOb3QpOgorCiAyMDEzLTEwLTEzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAog ICAgICAgICBUcmFuc2l0aW9uIG1pc2MgY3RpX29wXyogSklUU3R1YnMgdG8gSklUIG9wZXJhdGlv bnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTENhcGFiaWxpdGll cy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTENhcGFiaWxpdGllcy5jcHAKaW5k ZXggZDdlN2E3MzdiMjliYTdiMWU2YTk3OTYyYzY1NGQ2MDE4ZDcwMjg3Mi4uNGJjYTk1NzcyMDFm MGRlYWQ0MzcxMzU4NmI4ZjFkOGNhNzk1MGJjZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9mdGwvRlRMQ2FwYWJpbGl0aWVzLmNwcApAQCAtMTg4LDYgKzE4OCw3IEBAIGlubGluZSBDYXBh YmlsaXR5TGV2ZWwgY2FuQ29tcGlsZShOb2RlKiBub2RlKQogICAgICAgICBjYXNlIEJvb2xlYW5V c2U6CiAgICAgICAgIGNhc2UgSW50MzJVc2U6CiAgICAgICAgIGNhc2UgTnVtYmVyVXNlOgorICAg ICAgICBjYXNlIFN0cmluZ1VzZToKICAgICAgICAgY2FzZSBPYmplY3RPck90aGVyVXNlOgogICAg ICAgICAgICAgYnJlYWs7CiAgICAgICAgIGRlZmF1bHQ6CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3BwCmluZGV4IDExMzE1N2Y3MTdjNTE3MTJmZGY3 NGFiODhmNWVlM2I0MGFmNmM1ODMuLmZlMDliMDg5NzIwYWI4MmQwODQ5NWQ0Y2M1MmYwN2I0MGY5 ZDU0NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdU b0xMVk0uY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xM Vk0uY3BwCkBAIC0yMDg2LDYgKzIwODYsMTEgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICBl cXVhbE51bGxPclVuZGVmaW5lZCgKICAgICAgICAgICAgICAgICAgICAgZWRnZSwgQ2VsbENhc2VT cGVjdWxhdGVzT2JqZWN0LCBTcGVjdWxhdGVOdWxsT3JVbmRlZmluZWQsCiAgICAgICAgICAgICAg ICAgICAgIE1hbnVhbE9wZXJhbmRTcGVjdWxhdGlvbikpOworICAgICAgICBjYXNlIFN0cmluZ1Vz ZTogeworICAgICAgICAgICAgTFZhbHVlIHN0cmluZ1ZhbHVlID0gbG93U3RyaW5nKG1fbm9kZS0+ Y2hpbGQxKCkpOworICAgICAgICAgICAgTFZhbHVlIGxlbmd0aCA9IG1fb3V0LmxvYWQzMihzdHJp bmdWYWx1ZSwgbV9oZWFwcy5KU1N0cmluZ19sZW5ndGgpOworICAgICAgICAgICAgcmV0dXJuIG1f b3V0Lm5vdEVxdWFsKGxlbmd0aCwgbV9vdXQuaW50MzJaZXJvKTsKKyAgICAgICAgfQogICAgICAg ICBkZWZhdWx0OgogICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAg ICAgICAgICAgIHJldHVybiAwOwo=