122749 2013-10-14 05:16:51 -0700 [EFL] Buildfix after r157393 2013-10-14 06:38:25 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 k.czech webkit-unassigned andersca commit-queue esprehn+autocc glenn gyuyoung.kim kling lucas.de.marchi macpherson menard svillar oldest_to_newest 939421 0 k.czech 2013-10-14 05:16:51 -0700 /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/css/CSSCalculationValue.cpp: In function 'bool WebCore::hasDoubleValue(WebCore::CSSPrimitiveValue::UnitTypes)': /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/css/CSSCalculationValue.cpp:84:12: error: enumeration value 'CSS_FR' not handled in switch [-Werror=switch] 939422 1 214144 k.czech 2013-10-14 05:19:54 -0700 Created attachment 214144 Patch 939423 2 214144 kling 2013-10-14 05:22:50 -0700 Comment on attachment 214144 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214144&action=review > Source/WebCore/css/CSSCalculationValue.cpp:114 > + case CSSPrimitiveValue::CSS_FR: Is this correct? It seems that CSS_FR would be represented by a double value internally. 939425 3 214144 kling 2013-10-14 05:45:11 -0700 Comment on attachment 214144 Patch hasDoubleValue() should return true for CSS_FR. 939430 4 214147 k.czech 2013-10-14 06:12:37 -0700 Created attachment 214147 Patch 939431 5 k.czech 2013-10-14 06:15:06 -0700 (In reply to comment #3) > (From update of attachment 214144 [details]) > hasDoubleValue() should return true for CSS_FR. Yes, you are right. Thanks. 939433 6 214147 andersca 2013-10-14 06:38:21 -0700 Comment on attachment 214147 Patch Clearing flags on attachment: 214147 Committed r157397: <http://trac.webkit.org/changeset/157397> 939434 7 andersca 2013-10-14 06:38:25 -0700 All reviewed patches have been landed. Closing bug. 214144 2013-10-14 05:19:54 -0700 2013-10-14 06:12:37 -0700 Patch buildfix.patch text/plain 1264 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2NDI4YTczLi44Njc1Zjc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTMtMTAtMTQgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CiAK KyAgICAgICAgW0VGTF0gQnVpbGRmaXggYWZ0ZXIgcjE1NzM5MworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyNzQ5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVpbGRmaXggd2l0aCBlcnJvciBlbnVtZXJh dGlvbiB2YWx1ZSAnQ1NTX0ZSJyBub3QgaGFuZGxlZCBpbiBzd2l0Y2guCisKKyAgICAgICAgKiBj c3MvQ1NTQ2FsY3VsYXRpb25WYWx1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpoYXNEb3VibGVW YWx1ZSk6CisKKzIwMTMtMTAtMTQgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5j b20+CisKICAgICAgICAgW0VGTF0gUHJlc2VudCByZXBsYWNlZCBvYmplY3RzIHdpdGggMHhGRkZD IGNoYXJhY3RlcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTIyNzQ0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlv blZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlvblZhbHVlLmNwcApp bmRleCBiZGYwNDljLi5iMmU1ZjBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT Q2FsY3VsYXRpb25WYWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NhbGN1bGF0 aW9uVmFsdWUuY3BwCkBAIC0xMTEsNiArMTExLDcgQEAgc3RhdGljIGJvb2wgaGFzRG91YmxlVmFs dWUoQ1NTUHJpbWl0aXZlVmFsdWU6OlVuaXRUeXBlcyB0eXBlKQogICAgIGNhc2UgQ1NTUHJpbWl0 aXZlVmFsdWU6OkNTU19EUEk6CiAgICAgY2FzZSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX0RQQ006 CiAgICAgICAgIHJldHVybiB0cnVlOworICAgIGNhc2UgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19G UjoKICAgICBjYXNlIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NfVU5LTk9XTjoKICAgICBjYXNlIENT U1ByaW1pdGl2ZVZhbHVlOjpDU1NfU1RSSU5HOgogICAgIGNhc2UgQ1NTUHJpbWl0aXZlVmFsdWU6 OkNTU19VUkk6Cg== 214147 2013-10-14 06:12:37 -0700 2013-10-14 06:38:21 -0700 Patch buildfix.patch text/plain 1277 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2NDI4YTczLi44Njc1Zjc0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTMtMTAtMTQgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CiAK KyAgICAgICAgW0VGTF0gQnVpbGRmaXggYWZ0ZXIgcjE1NzM5MworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyNzQ5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVpbGRmaXggd2l0aCBlcnJvciBlbnVtZXJh dGlvbiB2YWx1ZSAnQ1NTX0ZSJyBub3QgaGFuZGxlZCBpbiBzd2l0Y2guCisKKyAgICAgICAgKiBj c3MvQ1NTQ2FsY3VsYXRpb25WYWx1ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpoYXNEb3VibGVW YWx1ZSk6CisKKzIwMTMtMTAtMTQgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5j b20+CisKICAgICAgICAgW0VGTF0gUHJlc2VudCByZXBsYWNlZCBvYmplY3RzIHdpdGggMHhGRkZD IGNoYXJhY3RlcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTIyNzQ0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlv blZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlvblZhbHVlLmNwcApp bmRleCBiZGYwNDljLi43NTFhNzFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT Q2FsY3VsYXRpb25WYWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NhbGN1bGF0 aW9uVmFsdWUuY3BwCkBAIC04Miw2ICs4Miw3IEBAIHN0YXRpYyBDYWxjdWxhdGlvbkNhdGVnb3J5 IHVuaXRDYXRlZ29yeShDU1NQcmltaXRpdmVWYWx1ZTo6VW5pdFR5cGVzIHR5cGUpCiBzdGF0aWMg Ym9vbCBoYXNEb3VibGVWYWx1ZShDU1NQcmltaXRpdmVWYWx1ZTo6VW5pdFR5cGVzIHR5cGUpCiB7 CiAgICAgc3dpdGNoICh0eXBlKSB7CisgICAgY2FzZSBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX0ZS OgogICAgIGNhc2UgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1CRVI6CiAgICAgY2FzZSBDU1NQ cmltaXRpdmVWYWx1ZTo6Q1NTX1BBUlNFUl9JTlRFR0VSOgogICAgIGNhc2UgQ1NTUHJpbWl0aXZl VmFsdWU6OkNTU19QRVJDRU5UQUdFOgo=