122717 2013-10-13 00:00:42 -0700 Rewrite Document::body and Document::head in modern style, way clearer and shorter 2019-02-06 09:02:56 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 122733 1 darin darin ap buildbot cdumez commit-queue eflews.bot esprehn+autocc gtk-ews gyuyoung.kim kangil.han kling philn rniwa xan.lopez oldest_to_newest 939209 0 darin 2013-10-13 00:00:42 -0700 Rewrite Document::body and Document::head in modern style, way clearer and shorter 939210 1 214087 darin 2013-10-13 00:01:10 -0700 Created attachment 214087 Patch 939211 2 214087 eflews.bot 2013-10-13 00:05:36 -0700 Comment on attachment 214087 Patch Attachment 214087 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/3867590 939214 3 214087 eflews.bot 2013-10-13 00:09:02 -0700 Comment on attachment 214087 Patch Attachment 214087 did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/3953510 939218 4 214087 buildbot 2013-10-13 00:29:10 -0700 Comment on attachment 214087 Patch Attachment 214087 did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/3951470 939221 5 214087 buildbot 2013-10-13 00:39:09 -0700 Comment on attachment 214087 Patch Attachment 214087 did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/3953516 939222 6 214087 buildbot 2013-10-13 00:45:03 -0700 Comment on attachment 214087 Patch Attachment 214087 did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/3952496 939224 7 214087 gtk-ews 2013-10-13 01:15:55 -0700 Comment on attachment 214087 Patch Attachment 214087 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/3403655 939303 8 darin 2013-10-13 12:19:47 -0700 Committed r157381: <http://trac.webkit.org/changeset/157381> 939312 9 ap 2013-10-13 14:11:56 -0700 This broke a lot of tests, I'm going to roll out. <http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/10752> 939315 10 commit-queue 2013-10-13 14:14:48 -0700 Re-opened since this is blocked by bug 122733 939317 11 ap 2013-10-13 14:15:35 -0700 Andreas is going to see if he can fix real quick. 939322 12 kling 2013-10-13 15:09:58 -0700 (In reply to comment #11) > Andreas is going to see if he can fix real quick. https://trac.webkit.org/r157383 https://trac.webkit.org/r157384 That was a silly bug, I should have caught it in review. 939329 13 darin 2013-10-13 15:46:25 -0700 I don’t know why I didn’t test. I could have sworn I did. I don’t get why childrenOfType takes a pointer, but doesn’t handle null. We should fix that. 939330 14 darin 2013-10-13 15:46:35 -0700 By making it take a reference. 1502872 15 lforschler 2019-02-06 09:02:56 -0800 Mass moving XML DOM bugs to the "DOM" Component. 214087 2013-10-13 00:01:10 -0700 2013-10-13 01:15:55 -0700 Patch bug-122717-20131013000110.patch text/plain 2375 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3MzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWUyODVhMWI1Yjc3MDdh Y2M3OTg3MDFiMTJmZTkxY2EyYjlkODU3ZC4uMzFiZDk3NWJmZDUyOWRmZTA0NTI3NWExMDkyMzVi MTNjMzU2YzU1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEwLTEzICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXdyaXRlIERvY3VtZW50Ojpi b2R5IGFuZCBEb2N1bWVudDo6aGVhZCBpbiBtb2Rlcm4gc3R5bGUsIHdheSBjbGVhcmVyIGFuZCBz aG9ydGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjI3MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6Ym9keSk6IFVz ZSBpdGVyYXRvciB0byBtYWtlIHRoaXMgd2F5IGVhc2llciB0byByZWFkLgorICAgICAgICAoV2Vi Q29yZTo6RG9jdW1lbnQ6OmhlYWQpOiBEaXR0by4KKwogMjAxMy0xMC0xMiAgRGFyaW4gQWRsZXIg IDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIG51bGxwdHIgaW4gRG9jdW1lbnQuY3Bw CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCA4ZmU2MTc5NmI1YTczNWE0MTRmMDExMGQyYmU2 ZmQ4OTc1MmQxMjNlLi5lMzVhNjJhMzEwNmMxYWJiODk1YWE1M2NmZTJhZjY2NmJjYWU4NjgzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTIzMTEsMjAgKzIzMTEsMTEgQEAgdm9pZCBEb2N1 bWVudDo6aW1wbGljaXRPcGVuKCkKIAogSFRNTEVsZW1lbnQqIERvY3VtZW50Ojpib2R5KCkgY29u c3QKIHsKLSAgICBOb2RlKiBkZSA9IGRvY3VtZW50RWxlbWVudCgpOwotICAgIGlmICghZGUpCi0g ICAgICAgIHJldHVybiBudWxscHRyOwotICAgIAotICAgIC8vIHRyeSB0byBwcmVmZXIgYSBGUkFN RVNFVCBlbGVtZW50IG92ZXIgQk9EWQotICAgIE5vZGUqIGJvZHkgPSBudWxscHRyOwotICAgIGZv ciAoTm9kZSogaSA9IGRlLT5maXJzdENoaWxkKCk7IGk7IGkgPSBpLT5uZXh0U2libGluZygpKSB7 Ci0gICAgICAgIGlmIChpLT5oYXNUYWdOYW1lKGZyYW1lc2V0VGFnKSkKLSAgICAgICAgICAgIHJl dHVybiB0b0hUTUxFbGVtZW50KGkpOwotICAgICAgICAKLSAgICAgICAgaWYgKGktPmhhc1RhZ05h bWUoYm9keVRhZykgJiYgIWJvZHkpCi0gICAgICAgICAgICBib2R5ID0gaTsKLSAgICB9Ci0gICAg cmV0dXJuIHRvSFRNTEVsZW1lbnQoYm9keSk7CisgICAgLy8gSWYgdGhlIGRvY3VtZW50IGVsZW1l bnQgY29udGFpbnMgYm90aCBhIGZyYW1lc2V0IGFuZCBhIGJvZHksIHRoZSBmcmFtZXNldCB3aW5z LgorICAgIGF1dG8gZWxlbWVudCA9IGRvY3VtZW50RWxlbWVudCgpOworICAgIGlmIChhdXRvIGZy YW1lc2V0ID0gY2hpbGRyZW5PZlR5cGU8SFRNTEZyYW1lc2V0RWxlbWVudD4oZWxlbWVudCkpCisg ICAgICAgIHJldHVybiBmcmFtZXNldDsKKyAgICByZXR1cm4gY2hpbGRyZW5PZlR5cGU8SFRNTEJv ZHlFbGVtZW50PihlbGVtZW50KS5maXJzdCgpOwogfQogCiB2b2lkIERvY3VtZW50OjpzZXRCb2R5 KFBhc3NSZWZQdHI8SFRNTEVsZW1lbnQ+IHBycE5ld0JvZHksIEV4Y2VwdGlvbkNvZGUmIGVjKQpA QCAtMjM1NCwxNSArMjM0NSw3IEBAIHZvaWQgRG9jdW1lbnQ6OnNldEJvZHkoUGFzc1JlZlB0cjxI VE1MRWxlbWVudD4gcHJwTmV3Qm9keSwgRXhjZXB0aW9uQ29kZSYgZWMpCiAKIEhUTUxIZWFkRWxl bWVudCogRG9jdW1lbnQ6OmhlYWQoKQogewotICAgIE5vZGUqIGRlID0gZG9jdW1lbnRFbGVtZW50 KCk7Ci0gICAgaWYgKCFkZSkKLSAgICAgICAgcmV0dXJuIG51bGxwdHI7Ci0KLSAgICBmb3IgKE5v ZGUqIGUgPSBkZS0+Zmlyc3RDaGlsZCgpOyBlOyBlID0gZS0+bmV4dFNpYmxpbmcoKSkKLSAgICAg ICAgaWYgKGUtPmhhc1RhZ05hbWUoaGVhZFRhZykpCi0gICAgICAgICAgICByZXR1cm4gc3RhdGlj X2Nhc3Q8SFRNTEhlYWRFbGVtZW50Kj4oZSk7Ci0KLSAgICByZXR1cm4gbnVsbHB0cjsKKyAgICBy ZXR1cm4gY2hpbGRyZW5PZlR5cGU8SFRNTEhlYWRFbGVtZW50Pihkb2N1bWVudEVsZW1lbnQoKSku Zmlyc3QoKTsKIH0KIAogdm9pZCBEb2N1bWVudDo6Y2xvc2UoKQo=