122700 2013-10-12 13:46:00 -0700 [Soup] The NeverDestroyed<std::unique_ptr<NetworkStorageSession>> variable in defaultSession() should be static 2013-10-12 23:06:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan cdumez commit-queue danw darin gustavo mrobinson rakuco oldest_to_newest 939117 0 zan 2013-10-12 13:46:00 -0700 [Soup] The NeverDestroyed<std::unique_ptr<NetworkStorageSession>> variable in defaultSession() should be static 939118 1 214064 zan 2013-10-12 13:51:58 -0700 Created attachment 214064 Patch 939121 2 214064 zan 2013-10-12 14:13:23 -0700 Comment on attachment 214064 Patch Clearing flags on attachment: 214064 Committed r157347: <http://trac.webkit.org/changeset/157347> 939122 3 zan 2013-10-12 14:13:30 -0700 All reviewed patches have been landed. Closing bug. 939131 4 darin 2013-10-12 15:17:05 -0700 Oops, did I forget the "static" in any other NeverDestroyed lines? Someone should check with grep. 939195 5 zan 2013-10-12 23:06:58 -0700 No, all NeverDestroyed declarations are now static. 214064 2013-10-12 13:51:58 -0700 2013-10-12 14:13:23 -0700 Patch bug-122700-20131012225157.patch text/plain 1515 zan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1NzM0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTEwLTEyICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbU291cF0gVGhlIE5ldmVy RGVzdHJveWVkPHN0ZDo6dW5pcXVlX3B0cjxOZXR3b3JrU3RvcmFnZVNlc3Npb24+PiB2YXJpYWJs ZSBpbiBkZWZhdWx0U2Vzc2lvbigpIHNob3VsZCBiZSBzdGF0aWMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjcwMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL05l dHdvcmtTdG9yYWdlU2Vzc2lvblNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZGVmYXVsdFNl c3Npb24pOiBUaGUgTmV2ZXJEZXN0cm95ZWQgdmFyaWFibGUgc2hvdWxkIGJlIHN0YXRpYyB0byBh dm9pZCBpdHMgcmVpbml0aWFsaXphdGlvbiBldmVyeSB0aW1lCisgICAgICAgIHRoZSBmdW5jdGlv biBpcyBjYWxsZWQuIFRoaXMgd2FzIGV4cG9zZWQgYnkgcjE1NzMzNyBhbmQgc2hvdWxkIGZpeCB0 aGUgc3Vic2VxdWVudCBjcmFzaGVzLgorCiAyMDEzLTEwLTEyICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIGxpbmUgZGlydHlpbmcgY29kZSB0byBSZW5k ZXJUZXh0TGluZUJveGVzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvTmV0d29ya1N0b3JhZ2VTZXNzaW9uU291cC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL05ldHdvcmtTdG9yYWdlU2Vzc2lvblNvdXAuY3Bw CShyZXZpc2lvbiAxNTczNDUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvTmV0d29ya1N0b3JhZ2VTZXNzaW9uU291cC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQyLDcg KzQyLDcgQEAgTmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpOZXR3b3JrU3RvcmFnZVNlcwogc3RhdGlj IHN0ZDo6dW5pcXVlX3B0cjxOZXR3b3JrU3RvcmFnZVNlc3Npb24+JiBkZWZhdWx0U2Vzc2lvbigp CiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsKLSAgICBOZXZlckRlc3Ryb3llZDxzdGQ6 OnVuaXF1ZV9wdHI8TmV0d29ya1N0b3JhZ2VTZXNzaW9uPj4gc2Vzc2lvbjsKKyAgICBzdGF0aWMg TmV2ZXJEZXN0cm95ZWQ8c3RkOjp1bmlxdWVfcHRyPE5ldHdvcmtTdG9yYWdlU2Vzc2lvbj4+IHNl c3Npb247CiAgICAgcmV0dXJuIHNlc3Npb247CiB9CiAK