122698 2013-10-12 11:58:16 -0700 Change callOnMainThread to take an std::function 2013-10-13 09:11:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 939108 0 andersca 2013-10-12 11:58:16 -0700 Change callOnMainThread to take an std::function 939109 1 214061 andersca 2013-10-12 12:01:01 -0700 Created attachment 214061 Patch 939110 2 commit-queue 2013-10-12 12:02:04 -0700 Attachment 214061 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/MainThread.cpp', u'Source/WTF/wtf/MainThread.h']" exit_code: 1 Source/WTF/wtf/MainThread.h:48: Extra space before ( in function call [whitespace/parens] [4] Source/WTF/wtf/MainThread.cpp:233: Extra space before ( in function call [whitespace/parens] [4] Source/WTF/wtf/MainThread.cpp:235: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/MainThread.cpp:236: Extra space before ( in function call [whitespace/parens] [4] Source/WTF/wtf/MainThread.cpp:240: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 939113 3 214061 buildbot 2013-10-12 12:41:40 -0700 Comment on attachment 214061 Patch Attachment 214061 did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/3582033 939114 4 214063 andersca 2013-10-12 13:20:18 -0700 Created attachment 214063 Patch 939115 5 commit-queue 2013-10-12 13:22:24 -0700 Attachment 214063 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/MainThread.cpp', u'Source/WTF/wtf/MainThread.h']" exit_code: 1 Source/WTF/wtf/MainThread.h:48: Extra space before ( in function call [whitespace/parens] [4] Source/WTF/wtf/MainThread.cpp:233: Extra space before ( in function call [whitespace/parens] [4] Source/WTF/wtf/MainThread.cpp:235: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WTF/wtf/MainThread.cpp:236: Extra space before ( in function call [whitespace/parens] [4] Source/WTF/wtf/MainThread.cpp:240: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 939129 6 214063 buildbot 2013-10-12 14:59:39 -0700 Comment on attachment 214063 Patch Attachment 214063 did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/3788079 939136 7 214063 darin 2013-10-12 16:25:37 -0700 Comment on attachment 214063 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=214063&action=review >> Source/WTF/wtf/MainThread.cpp:240 >> + callOnMainThread(+callFunctionObject, std::make_unique<std::function<void ()>>(std::move(function)).release()); > > Extra space before ( in function call [whitespace/parens] [4] What does the "+" here mean? Whatever it means, it seems that Windows does not understand it: 1>..\wtf\MainThread.cpp(240): error C2675: unary '+' : 'WTF::`anonymous-namespace'::<lambda0>' does not define this operator or a conversion to a type acceptable to the predefined operator 939286 8 andersca 2013-10-13 09:07:01 -0700 (In reply to comment #7) > (From update of attachment 214063 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=214063&action=review > > >> Source/WTF/wtf/MainThread.cpp:240 > >> + callOnMainThread(+callFunctionObject, std::make_unique<std::function<void ()>>(std::move(function)).release()); > > > > Extra space before ( in function call [whitespace/parens] [4] > > What does the "+" here mean? Whatever it means, it seems that Windows does not understand it: > > 1>..\wtf\MainThread.cpp(240): error C2675: unary '+' : 'WTF::`anonymous-namespace'::<lambda0>' does not define this operator or a conversion to a type acceptable to the predefined operator It explictly converts the lambda to a function pointer. Looks like MSVC doesn't support converting lambdas to function pointers, so I'm going to have to use a regular function instead. 939287 9 andersca 2013-10-13 09:11:46 -0700 Committed r157374: <http://trac.webkit.org/changeset/157374> 214061 2013-10-12 12:01:01 -0700 2013-10-12 13:20:15 -0700 Patch bug-122698-20131012120105.patch text/plain 2851 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3MzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGRlZWU2YmRiMGNhMDVjNzhkNmI3OTY4 MTJiZTZhNmEwNTAyODhmNDYuLmYwMjMyMTg1ZjU2NjM5NWJiMTA2NjkwMzQ2MjRjMTFmMTcxYzc3 YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMTAtMTIgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBDaGFuZ2UgY2FsbE9uTWFpblRocmVhZCB0byB0 YWtlIGFuIHN0ZDo6ZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyMjY5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgd2lsbCBsZXQgdXMgcGFzcyBhbnl0aGluZyB0aGF0IGNhbiBiZSBj b252ZXJ0ZWQgdG8gYW4gc3RkOjpmdW5jdGlvbiAoaW5jbHVkaW5nIGxhbWJkYXMgYW5kCisgICAg ICAgIFdURjo6RnVuY3Rpb24gb2JqZWN0cykgdG8gY2FsbE9uTWFpblRocmVhZC4KKworICAgICAg ICAqIHd0Zi9NYWluVGhyZWFkLmNwcDoKKyAgICAgICAgKFdURjo6Y2FsbE9uTWFpblRocmVhZCk6 CisgICAgICAgICogd3RmL01haW5UaHJlYWQuaDoKKwogMjAxMy0xMC0xMSAgRGFyaW4gQWRsZXIg IDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2hhbmdlIG1vc3QgY2FsbCBzaXRlcyB0byBj YWxsIElDVSBkaXJlY3RseSBpbnN0ZWFkIG9mIHRocm91Z2ggV1RGOjpVbmljb2RlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9NYWluVGhyZWFkLmNwcCBiL1NvdXJjZS9XVEYvd3RmL01haW5U aHJlYWQuY3BwCmluZGV4IGQxNmY5NWE1NzIyN2NlOWI1MmRlYzYzOTJiZDFiOWRmZTEwYjA2ZjIu LjIwYjEzMzBlN2E1NTIyMGVlMDc2ZmZlNTY2NmE0ZGYyY2U5YjM0MjAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvd3RmL01haW5UaHJlYWQuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL01haW5UaHJl YWQuY3BwCkBAIC0yMzAsMTYgKzIzMCwxNCBAQCB2b2lkIGNhbmNlbENhbGxPbk1haW5UaHJlYWQo TWFpblRocmVhZEZ1bmN0aW9uKiBmdW5jdGlvbiwgdm9pZCogY29udGV4dCkKICAgICB9CiB9CiAK LXN0YXRpYyB2b2lkIGNhbGxGdW5jdGlvbk9iamVjdCh2b2lkKiBjb250ZXh0KQordm9pZCBjYWxs T25NYWluVGhyZWFkKHN0ZDo6ZnVuY3Rpb248dm9pZCAoKT4gZnVuY3Rpb24pCiB7Ci0gICAgRnVu Y3Rpb248dm9pZCAoKT4qIGZ1bmN0aW9uID0gc3RhdGljX2Nhc3Q8RnVuY3Rpb248dm9pZCAoKT4q Pihjb250ZXh0KTsKLSAgICAoKmZ1bmN0aW9uKSgpOwotICAgIGRlbGV0ZSBmdW5jdGlvbjsKLX0K KyAgICBhdXRvIGNhbGxGdW5jdGlvbk9iamVjdCA9IFtdKHZvaWQqIGNvbnRleHQpIHsKKyAgICAg ICAgYXV0byBmdW5jdGlvbiA9IHN0ZDo6dW5pcXVlX3B0cjxzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+ PihzdGF0aWNfY2FzdDxzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+Kj4oY29udGV4dCkpOworICAgICAg ICAoKmZ1bmN0aW9uKSgpOworICAgIH07CiAKLXZvaWQgY2FsbE9uTWFpblRocmVhZChjb25zdCBG dW5jdGlvbjx2b2lkICgpPiYgZnVuY3Rpb24pCi17Ci0gICAgY2FsbE9uTWFpblRocmVhZChjYWxs RnVuY3Rpb25PYmplY3QsIG5ldyBGdW5jdGlvbjx2b2lkICgpPihmdW5jdGlvbikpOworICAgIGNh bGxPbk1haW5UaHJlYWQoY2FsbEZ1bmN0aW9uT2JqZWN0LCBzdGQ6Om1ha2VfdW5pcXVlPHN0ZDo6 ZnVuY3Rpb248dm9pZCAoKT4+KHN0ZDo6bW92ZShmdW5jdGlvbikpLnJlbGVhc2UoKSk7CiB9CiAK IHZvaWQgc2V0TWFpblRocmVhZENhbGxiYWNrc1BhdXNlZChib29sIHBhdXNlZCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL01haW5UaHJlYWQuaCBiL1NvdXJjZS9XVEYvd3RmL01haW5UaHJl YWQuaAppbmRleCA4MzhkNTQ3ZGMxOGUyZjNiNGMzYjdkOWFhMzMyYjIyYWEyYzc0ZmQzLi5hNWNi ODQzYzk3Y2FlYTZhMDhiZWI1ZjRmMDJiMjkyOTBiYWEyNGFlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V1RGL3d0Zi9NYWluVGhyZWFkLmgKKysrIGIvU291cmNlL1dURi93dGYvTWFpblRocmVhZC5oCkBA IC0zMCw2ICszMCw3IEBACiAjaWZuZGVmIE1haW5UaHJlYWRfaAogI2RlZmluZSBNYWluVGhyZWFk X2gKIAorI2luY2x1ZGUgPGZ1bmN0aW9uYWw+CiAjaW5jbHVkZSA8c3RkaW50Lmg+CiAKIG5hbWVz cGFjZSBXVEYgewpAQCAtNDQsOSArNDUsOCBAQCBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBjYWxs T25NYWluVGhyZWFkKE1haW5UaHJlYWRGdW5jdGlvbiosIHZvaWQqIGNvbnRleHQpOwogV1RGX0VY UE9SVF9QUklWQVRFIHZvaWQgY2FsbE9uTWFpblRocmVhZEFuZFdhaXQoTWFpblRocmVhZEZ1bmN0 aW9uKiwgdm9pZCogY29udGV4dCk7CiBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBjYW5jZWxDYWxs T25NYWluVGhyZWFkKE1haW5UaHJlYWRGdW5jdGlvbiosIHZvaWQqIGNvbnRleHQpOwogCi10ZW1w bGF0ZTx0eXBlbmFtZT4gY2xhc3MgRnVuY3Rpb247Ci1XVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBj YWxsT25NYWluVGhyZWFkKGNvbnN0IEZ1bmN0aW9uPHZvaWQgKCk+Jik7Ci0gICAgCitXVEZfRVhQ T1JUX1BSSVZBVEUgdm9pZCBjYWxsT25NYWluVGhyZWFkKHN0ZDo6ZnVuY3Rpb248dm9pZCAoKT4p OworCiBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBzZXRNYWluVGhyZWFkQ2FsbGJhY2tzUGF1c2Vk KGJvb2wgcGF1c2VkKTsKIAogV1RGX0VYUE9SVF9QUklWQVRFIGJvb2wgaXNNYWluVGhyZWFkKCk7 Cg== 214063 2013-10-12 13:20:18 -0700 2013-10-12 16:25:37 -0700 Patch bug-122698-20131012132022.patch text/plain 2852 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3MzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGRlZWU2YmRiMGNhMDVjNzhkNmI3OTY4 MTJiZTZhNmEwNTAyODhmNDYuLmYwMjMyMTg1ZjU2NjM5NWJiMTA2NjkwMzQ2MjRjMTFmMTcxYzc3 YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTMtMTAtMTIgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBDaGFuZ2UgY2FsbE9uTWFpblRocmVhZCB0byB0 YWtlIGFuIHN0ZDo6ZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyMjY5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgd2lsbCBsZXQgdXMgcGFzcyBhbnl0aGluZyB0aGF0IGNhbiBiZSBj b252ZXJ0ZWQgdG8gYW4gc3RkOjpmdW5jdGlvbiAoaW5jbHVkaW5nIGxhbWJkYXMgYW5kCisgICAg ICAgIFdURjo6RnVuY3Rpb24gb2JqZWN0cykgdG8gY2FsbE9uTWFpblRocmVhZC4KKworICAgICAg ICAqIHd0Zi9NYWluVGhyZWFkLmNwcDoKKyAgICAgICAgKFdURjo6Y2FsbE9uTWFpblRocmVhZCk6 CisgICAgICAgICogd3RmL01haW5UaHJlYWQuaDoKKwogMjAxMy0xMC0xMSAgRGFyaW4gQWRsZXIg IDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2hhbmdlIG1vc3QgY2FsbCBzaXRlcyB0byBj YWxsIElDVSBkaXJlY3RseSBpbnN0ZWFkIG9mIHRocm91Z2ggV1RGOjpVbmljb2RlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9NYWluVGhyZWFkLmNwcCBiL1NvdXJjZS9XVEYvd3RmL01haW5U aHJlYWQuY3BwCmluZGV4IGQxNmY5NWE1NzIyN2NlOWI1MmRlYzYzOTJiZDFiOWRmZTEwYjA2ZjIu LjdiNTNlOTU4MzFhYmIzZWJjOGE2Y2Y3YWUwZmUyNGM3NzUzMjQ0OWUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvd3RmL01haW5UaHJlYWQuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL01haW5UaHJl YWQuY3BwCkBAIC0yMzAsMTYgKzIzMCwxNCBAQCB2b2lkIGNhbmNlbENhbGxPbk1haW5UaHJlYWQo TWFpblRocmVhZEZ1bmN0aW9uKiBmdW5jdGlvbiwgdm9pZCogY29udGV4dCkKICAgICB9CiB9CiAK LXN0YXRpYyB2b2lkIGNhbGxGdW5jdGlvbk9iamVjdCh2b2lkKiBjb250ZXh0KQordm9pZCBjYWxs T25NYWluVGhyZWFkKHN0ZDo6ZnVuY3Rpb248dm9pZCAoKT4gZnVuY3Rpb24pCiB7Ci0gICAgRnVu Y3Rpb248dm9pZCAoKT4qIGZ1bmN0aW9uID0gc3RhdGljX2Nhc3Q8RnVuY3Rpb248dm9pZCAoKT4q Pihjb250ZXh0KTsKLSAgICAoKmZ1bmN0aW9uKSgpOwotICAgIGRlbGV0ZSBmdW5jdGlvbjsKLX0K KyAgICBhdXRvIGNhbGxGdW5jdGlvbk9iamVjdCA9IFtdKHZvaWQqIGNvbnRleHQpIHsKKyAgICAg ICAgYXV0byBmdW5jdGlvbiA9IHN0ZDo6dW5pcXVlX3B0cjxzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+ PihzdGF0aWNfY2FzdDxzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+Kj4oY29udGV4dCkpOworICAgICAg ICAoKmZ1bmN0aW9uKSgpOworICAgIH07CiAKLXZvaWQgY2FsbE9uTWFpblRocmVhZChjb25zdCBG dW5jdGlvbjx2b2lkICgpPiYgZnVuY3Rpb24pCi17Ci0gICAgY2FsbE9uTWFpblRocmVhZChjYWxs RnVuY3Rpb25PYmplY3QsIG5ldyBGdW5jdGlvbjx2b2lkICgpPihmdW5jdGlvbikpOworICAgIGNh bGxPbk1haW5UaHJlYWQoK2NhbGxGdW5jdGlvbk9iamVjdCwgc3RkOjptYWtlX3VuaXF1ZTxzdGQ6 OmZ1bmN0aW9uPHZvaWQgKCk+PihzdGQ6Om1vdmUoZnVuY3Rpb24pKS5yZWxlYXNlKCkpOwogfQog CiB2b2lkIHNldE1haW5UaHJlYWRDYWxsYmFja3NQYXVzZWQoYm9vbCBwYXVzZWQpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9NYWluVGhyZWFkLmggYi9Tb3VyY2UvV1RGL3d0Zi9NYWluVGhy ZWFkLmgKaW5kZXggODM4ZDU0N2RjMThlMmYzYjRjM2I3ZDlhYTMzMmIyMmFhMmM3NGZkMy4uYTVj Yjg0M2M5N2NhZWE2YTA4YmViNWY0ZjAyYjI5MjkwYmFhMjRhZSAxMDA2NDQKLS0tIGEvU291cmNl L1dURi93dGYvTWFpblRocmVhZC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL01haW5UaHJlYWQuaApA QCAtMzAsNiArMzAsNyBAQAogI2lmbmRlZiBNYWluVGhyZWFkX2gKICNkZWZpbmUgTWFpblRocmVh ZF9oCiAKKyNpbmNsdWRlIDxmdW5jdGlvbmFsPgogI2luY2x1ZGUgPHN0ZGludC5oPgogCiBuYW1l c3BhY2UgV1RGIHsKQEAgLTQ0LDkgKzQ1LDggQEAgV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgY2Fs bE9uTWFpblRocmVhZChNYWluVGhyZWFkRnVuY3Rpb24qLCB2b2lkKiBjb250ZXh0KTsKIFdURl9F WFBPUlRfUFJJVkFURSB2b2lkIGNhbGxPbk1haW5UaHJlYWRBbmRXYWl0KE1haW5UaHJlYWRGdW5j dGlvbiosIHZvaWQqIGNvbnRleHQpOwogV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgY2FuY2VsQ2Fs bE9uTWFpblRocmVhZChNYWluVGhyZWFkRnVuY3Rpb24qLCB2b2lkKiBjb250ZXh0KTsKIAotdGVt cGxhdGU8dHlwZW5hbWU+IGNsYXNzIEZ1bmN0aW9uOwotV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQg Y2FsbE9uTWFpblRocmVhZChjb25zdCBGdW5jdGlvbjx2b2lkICgpPiYpOwotICAgIAorV1RGX0VY UE9SVF9QUklWQVRFIHZvaWQgY2FsbE9uTWFpblRocmVhZChzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+ KTsKKwogV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQgc2V0TWFpblRocmVhZENhbGxiYWNrc1BhdXNl ZChib29sIHBhdXNlZCk7CiAKIFdURl9FWFBPUlRfUFJJVkFURSBib29sIGlzTWFpblRocmVhZCgp Owo=