122691 2013-10-12 04:44:12 -0700 Potential register trampling in JIT since r157313. 2013-10-12 08:13:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue mark.lam msaboff oldest_to_newest 939073 0 jbriance 2013-10-12 04:44:12 -0700 In the following function of jit/CCallHelpers.h, arg2 will be crushed if (arg2 == GPRInfo::argumentGPR1): ALWAYS_INLINE void setupArgumentsWithExecState(TrustedImmPtr arg1, GPRReg arg2, TrustedImm32 arg3) { move(arg1, GPRInfo::argumentGPR1); move(arg2, GPRInfo::argumentGPR2); move(arg3, GPRInfo::argumentGPR3); move(GPRInfo::callFrameRegister, GPRInfo::argumentGPR0); } 939074 1 214053 jbriance 2013-10-12 04:46:50 -0700 Created attachment 214053 Fix potential register trampling in JIT. 939083 2 214053 commit-queue 2013-10-12 08:13:43 -0700 Comment on attachment 214053 Fix potential register trampling in JIT. Clearing flags on attachment: 214053 Committed r157339: <http://trac.webkit.org/changeset/157339> 939084 3 commit-queue 2013-10-12 08:13:45 -0700 All reviewed patches have been landed. Closing bug. 214053 2013-10-12 04:46:50 -0700 2013-10-12 08:13:42 -0700 Fix potential register trampling in JIT. bug-122691.patch text/plain 1270 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3MzM2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTEwLTEyICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIEZpeCBwb3RlbnRpYWwgcmVnaXN0ZXIgdHJhbXBsaW5nIGluIEpJVCBzaW5jZSByMTU3 MzEzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIy NjkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBq aXQvQ0NhbGxIZWxwZXJzLmg6CisgICAgICAgIChKU0M6OkNDYWxsSGVscGVyczo6c2V0dXBBcmd1 bWVudHNXaXRoRXhlY1N0YXRlKToKKwogMjAxMy0xMC0xMiAgSnVsaWVuIEJyaWFuY2VhdSAgPGpi cmlhbmNlQGNpc2NvLmNvbT4KIAogICAgICAgICBbc2g0XSBBZGQgbWlzc2luZyBzcGFjZXMgaW4g SklUU3R1YnNTSDQuaApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9DQ2FsbEhlbHBl cnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0NDYWxsSGVscGVy cy5oCShyZXZpc2lvbiAxNTczMzUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0NDYWxs SGVscGVycy5oCSh3b3JraW5nIGNvcHkpCkBAIC05NDksOCArOTQ5LDggQEAgcHVibGljOgogCiAg ICAgQUxXQVlTX0lOTElORSB2b2lkIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShUcnVzdGVk SW1tUHRyIGFyZzEsIEdQUlJlZyBhcmcyLCBUcnVzdGVkSW1tMzIgYXJnMykKICAgICB7Ci0gICAg ICAgIG1vdmUoYXJnMSwgR1BSSW5mbzo6YXJndW1lbnRHUFIxKTsKICAgICAgICAgbW92ZShhcmcy LCBHUFJJbmZvOjphcmd1bWVudEdQUjIpOworICAgICAgICBtb3ZlKGFyZzEsIEdQUkluZm86OmFy Z3VtZW50R1BSMSk7CiAgICAgICAgIG1vdmUoYXJnMywgR1BSSW5mbzo6YXJndW1lbnRHUFIzKTsK ICAgICAgICAgbW92ZShHUFJJbmZvOjpjYWxsRnJhbWVSZWdpc3RlciwgR1BSSW5mbzo6YXJndW1l bnRHUFIwKTsKICAgICB9Cg==