122690 2013-10-12 01:45:35 -0700 [sh4] Missing spaces in JITStubsSH4.h 2013-10-12 02:24:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue oldest_to_newest 939065 0 jbriance 2013-10-12 01:45:35 -0700 Missing spaces in JITStubsSH4.h break the sh4 build when using a C++11 sh4 compiler: [ 50%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/jit/JITStubs.cpp.o In file included from /home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/jit/JITStubs.cpp:93:0: /home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/jit/JITStubsSH4.h:89:5: erreur: unable to find string literal operator 'operator"" SYMBOL_STRING' /home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/jit/JITStubsSH4.h:113:5: erreur: unable to find string literal operator 'operator"" SYMBOL_STRING' /home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/jit/JITStubs.cpp:427:1: erreur: unable to find string literal operator 'operator"" SYMBOL_STRING' /home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/jit/JITStubs.cpp:439:1: erreur: unable to find string literal operator 'operator"" SYMBOL_STRING' /home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/jit/JITStubs.cpp:450:1: erreur: unable to find string literal operator 'operator"" SYMBOL_STRING' /home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/jit/JITStubs.cpp:463:1: erreur: unable to find string literal operator 'operator"" SYMBOL_STRING' [...] 939066 1 214052 jbriance 2013-10-12 01:49:02 -0700 Created attachment 214052 Add missing spaces in JITStubsSH4.h 939070 2 214052 commit-queue 2013-10-12 02:24:12 -0700 Comment on attachment 214052 Add missing spaces in JITStubsSH4.h Clearing flags on attachment: 214052 Committed r157335: <http://trac.webkit.org/changeset/157335> 939071 3 commit-queue 2013-10-12 02:24:14 -0700 All reviewed patches have been landed. Closing bug. 214052 2013-10-12 01:49:02 -0700 2013-10-12 02:24:12 -0700 Add missing spaces in JITStubsSH4.h bug-122690.patch text/plain 3056 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3MzMyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDEzLTEwLTEyICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFtzaDRdIEFkZCBtaXNzaW5nIHNwYWNlcyBpbiBKSVRTdHVic1NINC5oCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI2OTAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGppdC9KSVRTdHVic1NI NC5oOiBTcGFjZSBiZXR3ZWVuIHN0cmluZyBjb25jYXRlbmF0aW9uIGlzIG1hbmRhdG9yeSB3aXRo IEMrKzExCisKIDIwMTMtMTAtMTEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIENoYW5nZSBtb3N0IGNhbGwgc2l0ZXMgdG8gY2FsbCBJQ1UgZGlyZWN0bHkgaW5zdGVh ZCBvZiB0aHJvdWdoIFdURjo6VW5pY29kZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9KSVRTdHVic1NINC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv SklUU3R1YnNTSDQuaAkocmV2aXNpb24gMTU3MzMyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9KSVRTdHVic1NINC5oCSh3b3JraW5nIGNvcHkpCkBAIC04Niw3ICs4Niw3IEBAIGFzbSB2 b2xhdGlsZSAoCiAiLmdsb2JsICIgU1lNQk9MX1NUUklORyhjdGlWTVRocm93VHJhbXBvbGluZSkg IlxuIgogSElERV9TWU1CT0woY3RpVk1UaHJvd1RyYW1wb2xpbmUpICJcbiIKIFNZTUJPTF9TVFJJ TkcoY3RpVk1UaHJvd1RyYW1wb2xpbmUpICI6IiAiXG4iCi0gICAgIm1vdi5sIC5MMiJTWU1CT0xf U1RSSU5HKGN0aV92bV90aHJvdykiLHIwIiAiXG4iCisgICAgIm1vdi5sIC5MMiIgU1lNQk9MX1NU UklORyhjdGlfdm1fdGhyb3cpICIscjAiICJcbiIKICAgICAibW92IHIxNSwgcjQiICJcbiIKICAg ICAibW92LmwgQChyMCxyMTIpLHIxMSIgIlxuIgogICAgICJqc3IgQHIxMSIgIlxuIgpAQCAtMTAz LDE0ICsxMDMsMTQgQEAgU1lNQk9MX1NUUklORyhjdGlWTVRocm93VHJhbXBvbGluZSkgIjoiCiAg ICAgInJ0cyIgIlxuIgogICAgICJub3AiICJcbiIKICAgICAiLmFsaWduIDIiICJcbiIKLSAgICAi LkwyIlNZTUJPTF9TVFJJTkcoY3RpX3ZtX3Rocm93KSI6LmxvbmcgIiBTWU1CT0xfU1RSSU5HKGN0 aV92bV90aHJvdykiQEdPVCBcbiIKKyAgICAiLkwyIiBTWU1CT0xfU1RSSU5HKGN0aV92bV90aHJv dykgIjoubG9uZyAiIFNZTUJPTF9TVFJJTkcoY3RpX3ZtX3Rocm93KSAiQEdPVCBcbiIKICk7CiAK IGFzbSB2b2xhdGlsZSAoCiAiLmdsb2JsICIgU1lNQk9MX1NUUklORyhjdGlWTUhhbmRsZUV4Y2Vw dGlvbikgIlxuIgogSElERV9TWU1CT0woY3RpVk1IYW5kbGVFeGNlcHRpb24pICJcbiIKIFNZTUJP TF9TVFJJTkcoY3RpVk1IYW5kbGVFeGNlcHRpb24pICI6IiAiXG4iCi0gICAgIm1vdi5sIC5MMiJT WU1CT0xfU1RSSU5HKGN0aV92bV9oYW5kbGVfZXhjZXB0aW9uKSIscjAiICJcbiIKKyAgICAibW92 LmwgLkwyIiBTWU1CT0xfU1RSSU5HKGN0aV92bV9oYW5kbGVfZXhjZXB0aW9uKSAiLHIwIiAiXG4i CiAgICAgIm1vdiByMTQsIHI0IiAiXG4iCiAgICAgIm1vdi5sIEAocjAscjEyKSxyMTEiICJcbiIK ICAgICAianNyIEByMTEiICJcbiIKQEAgLTEyMSw3ICsxMjEsNyBAQCBTWU1CT0xfU1RSSU5HKGN0 aVZNSGFuZGxlRXhjZXB0aW9uKSAiOiIKICAgICAicnRzIiAiXG4iCiAgICAgIm5vcCIgIlxuIgog ICAgICIuYWxpZ24gMiIgIlxuIgotICAgICIuTDIiU1lNQk9MX1NUUklORyhjdGlfdm1faGFuZGxl X2V4Y2VwdGlvbikiOi5sb25nICIgU1lNQk9MX1NUUklORyhjdGlfdm1faGFuZGxlX2V4Y2VwdGlv bikiQEdPVCBcbiIKKyAgICAiLkwyIiBTWU1CT0xfU1RSSU5HKGN0aV92bV9oYW5kbGVfZXhjZXB0 aW9uKSAiOi5sb25nICIgU1lNQk9MX1NUUklORyhjdGlfdm1faGFuZGxlX2V4Y2VwdGlvbikgIkBH T1QgXG4iCiApOwogCiBhc20gdm9sYXRpbGUgKApAQCAtMTUyLDcgKzE1Miw3IEBAIFNZTUJPTF9T VFJJTkcoY3RpT3BUaHJvd05vdENhdWdodCkgIjoiICIKICAgICBTWU1CT0xfU1RSSU5HKGN0aV8j I29wKSAiOiIgIlxuIiBcCiAgICAgInN0cyBwciwgcjExIiAiXG4iIFwKICAgICAibW92LmwgcjEx LCBAKCIgU1RSSU5HSVpFX1ZBTFVFX09GKFRIVU5LX1JFVFVSTl9BRERSRVNTX09GRlNFVCkgIiwg cjE1KSIgIlxuIiBcCi0gICAgIm1vdi5sIC5MMiJTWU1CT0xfU1RSSU5HKEpJVFN0dWJUaHVua2Vk XyMjb3ApIixyMCIgIlxuIiBcCisgICAgIm1vdi5sIC5MMiIgU1lNQk9MX1NUUklORyhKSVRTdHVi VGh1bmtlZF8jI29wKSAiLHIwIiAiXG4iIFwKICAgICAibW92LmwgQChyMCxyMTIpLHIxMSIgIlxu IiBcCiAgICAgImpzciBAcjExIiAiXG4iIFwKICAgICAibm9wIiAiXG4iIFwKQEAgLTE2MSw3ICsx NjEsNyBAQCBTWU1CT0xfU1RSSU5HKGN0aU9wVGhyb3dOb3RDYXVnaHQpICI6IiAiCiAgICAgInJ0 cyIgIlxuIiBcCiAgICAgIm5vcCIgIlxuIiBcCiAgICAgIi5hbGlnbiAyIiAiXG4iIFwKLSAgICAi LkwyIlNZTUJPTF9TVFJJTkcoSklUU3R1YlRodW5rZWRfIyNvcCkiOi5sb25nICIgU1lNQk9MX1NU UklORyhKSVRTdHViVGh1bmtlZF8jI29wKSJAR09UIFxuIiBcCisgICAgIi5MMiIgU1lNQk9MX1NU UklORyhKSVRTdHViVGh1bmtlZF8jI29wKSAiOi5sb25nICIgU1lNQk9MX1NUUklORyhKSVRTdHVi VGh1bmtlZF8jI29wKSAiQEdPVCBcbiIgXAogICAgICk7IFwKICAgICBydHlwZSBKSVRTdHViVGh1 bmtlZF8jI29wKFNUVUJfQVJHU19ERUNMQVJBVElPTikKIAo=