122689 2013-10-12 01:36:39 -0700 [sh4] Add missing test32 implementation in macro assembler 2013-10-12 02:17:49 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue oldest_to_newest 939063 0 jbriance 2013-10-12 01:36:39 -0700 sh4 build broken since http://trac.webkit.org/changeset/157329 [ 40%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGSpeculativeJIT32_64.cpp.o /home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: In member function 'void JSC::DFG::SpeculativeJIT::compileStringZeroLength(JSC::DFG::Node*)': /home/ubuntu/work/sh4/webkit/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4182:11: erreur: 'class JSC::DFG::JITCompiler' has no member named 'test32' make[3]: *** [Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGSpeculativeJIT.cpp.o] Error 1 939064 1 214051 jbriance 2013-10-12 01:40:09 -0700 Created attachment 214051 test32 implementation in sh4 macro assembler. 939068 2 214051 commit-queue 2013-10-12 02:17:48 -0700 Comment on attachment 214051 test32 implementation in sh4 macro assembler. Clearing flags on attachment: 214051 Committed r157334: <http://trac.webkit.org/changeset/157334> 939069 3 commit-queue 2013-10-12 02:17:49 -0700 All reviewed patches have been landed. Closing bug. 214051 2013-10-12 01:40:09 -0700 2013-10-12 02:17:47 -0700 test32 implementation in sh4 macro assembler. bug-122689.patch text/plain 1770 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3MzMyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTEwLTEyICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFtzaDRdIEFkZCBtaXNzaW5nIHRlc3QzMiBpbXBsZW1lbnRhdGlvbiBpbiBtYWNybyBh c3NlbWJsZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjI2ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fz c2VtYmxlclNINDo6dGVzdDMyKToKKwogMjAxMy0xMC0xMSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBh cHBsZS5jb20+CiAKICAgICAgICAgQ2hhbmdlIG1vc3QgY2FsbCBzaXRlcyB0byBjYWxsIElDVSBk aXJlY3RseSBpbnN0ZWFkIG9mIHRocm91Z2ggV1RGOjpVbmljb2RlCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyU0g0LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclNINC5oCShyZXZp c2lvbiAxNTczMzIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyU0g0LmgJKHdvcmtpbmcgY29weSkKQEAgLTE3NjgsNiArMTc2OCwyNiBAQCBwdWJsaWM6 CiAgICAgICAgIG1fYXNzZW1ibGVyLm1vdkltbTgoMSwgZGVzdCk7CiAgICAgfQogCisgICAgdm9p ZCB0ZXN0MzIoUmVzdWx0Q29uZGl0aW9uIGNvbmQsIEFkZHJlc3MgYWRkcmVzcywgVHJ1c3RlZElt bTMyIG1hc2ssIFJlZ2lzdGVySUQgZGVzdCkKKyAgICB7CisgICAgICAgIEFTU0VSVCgoY29uZCA9 PSBaZXJvKSB8fCAoY29uZCA9PSBOb25aZXJvKSk7CisKKyAgICAgICAgbG9hZDMyKGFkZHJlc3Ms IGRlc3QpOworICAgICAgICBpZiAobWFzay5tX3ZhbHVlID09IC0xKQorICAgICAgICAgICAgY29t cGFyZTMyKDAsIGRlc3QsIHN0YXRpY19jYXN0PFJlbGF0aW9uYWxDb25kaXRpb24+KGNvbmQpKTsK KyAgICAgICAgZWxzZQorICAgICAgICAgICAgdGVzdGxJbW0obWFzay5tX3ZhbHVlLCBkZXN0KTsK KyAgICAgICAgaWYgKGNvbmQgIT0gTm9uWmVybykgeworICAgICAgICAgICAgbV9hc3NlbWJsZXIu bW92dChkZXN0KTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCisgICAgICAgIG1f YXNzZW1ibGVyLmVuc3VyZVNwYWNlKG1fYXNzZW1ibGVyLm1heEluc3RydWN0aW9uU2l6ZSArIDQp OworICAgICAgICBtX2Fzc2VtYmxlci5tb3ZJbW04KDAsIGRlc3QpOworICAgICAgICBtX2Fzc2Vt Ymxlci5icmFuY2goQlRfT1BDT0RFLCAwKTsKKyAgICAgICAgbV9hc3NlbWJsZXIubW92SW1tOCgx LCBkZXN0KTsKKyAgICB9CisKICAgICB2b2lkIGxvYWRQdHJMaW5rUmVnKEltcGxpY2l0QWRkcmVz cyBhZGRyZXNzKQogICAgIHsKICAgICAgICAgUmVnaXN0ZXJJRCBzY3IgPSBjbGFpbVNjcmF0Y2go KTsK