122685 2013-10-11 17:25:21 -0700 Move firstPositiveWidth/adjustLogicalLineTop functions where they're actually used 2013-10-11 23:01:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 121261 1 zoltan zoltan commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 939014 0 zoltan 2013-10-11 17:25:21 -0700 I'm working on the refactoring of RenderBlockLineLayout. For the better readability, I moved firstPositiveWidth and adjustLogicalLineTop functions above pushShapeContentOverflowBelowTheContentBox where these're actually used. 939015 1 214038 zoltan 2013-10-11 17:33:02 -0700 Created attachment 214038 Patch 939060 2 214038 commit-queue 2013-10-11 23:01:46 -0700 Comment on attachment 214038 Patch Clearing flags on attachment: 214038 Committed r157332: <http://trac.webkit.org/changeset/157332> 939061 3 commit-queue 2013-10-11 23:01:49 -0700 All reviewed patches have been landed. Closing bug. 214038 2013-10-11 17:33:02 -0700 2013-10-11 23:01:45 -0700 Patch bug-122685-20131011173301.patch text/plain 4065 zoltan U3VidmVyc2lvbiBSZXZpc2lvbjogMTU3MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmYwNzM4YzgxMjZiNGZl Y2Y0Mzk0ODRmYWRhNDNhYzFjYzVlOTE5ZC4uZWMzZWI1NjM5MTEyZjI2MmFjZjUxYTk3ZWZmNzQ1 YTAzOWU5OGEzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEzLTEwLTExICBab2x0 YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgogCisgICAgICAgIE1vdmUgZmlyc3RQb3Np dGl2ZVdpZHRoL2FkanVzdExvZ2ljYWxMaW5lVG9wIGZ1bmN0aW9ucyB3aGVyZSB0aGV5J3JlIGFj dHVhbGx5IHVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyMjY4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEknbSB3b3JraW5nIG9uIHRoZSByZWZhY3RvcmluZyBvZiBSZW5kZXJCbG9ja0xpbmVMYXlv dXQsIHByb2dyZXNzIHRyYWNrZWQgdW5kZXIgYnVnICMxMjEyNjEuIEZvciB0aGUgYmV0dGVyIHJl YWRhYmlsaXR5LCBJIG1vdmVkCisgICAgICAgIGZpcnN0UG9zaXRpdmVXaWR0aCBhbmQgYWRqdXN0 TG9naWNhbExpbmVUb3AgZnVuY3Rpb25zIGFib3ZlIHB1c2hTaGFwZUNvbnRlbnRPdmVyZmxvd0Jl bG93VGhlQ29udGVudEJveCwgd2hlcmUgdGhlc2UncmUgYWN0dWFsbHkgdXNlZC4KKworICAgICAg ICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHJlbmRlcmlu Zy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Zmlyc3RQb3Np dGl2ZVdpZHRoKToKKyAgICAgICAgKFdlYkNvcmU6OmFkanVzdExvZ2ljYWxMaW5lVG9wKToKKwor MjAxMy0xMC0xMSAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KKwogICAgICAg ICBbQ1NTIFNoYXBlc10gVXNlIHRoZSBmbG9hdGluZ09iamVjdCdzIGxvZ2ljYWwgY29vcmRpbmF0 ZXMgdG8gZGV0ZXJtaW5lIGl0cyBzaXplIGluIGNvbXB1dGVMb2dpY2FsTG9jYXRpb25Gb3JGbG9h dAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTIyNjYz CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVM YXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91 dC5jcHAKaW5kZXggYTY4NGJlYTQ2NjlmNzIyNjNiY2NmNGI5Y2MzZTk3NDg2ZDg0NWMxNy4uNWRh MTIxZmU4ZTQ3MmY4ZjZiOGYzMjI0OTk4YjljNWJkYmY0NTA0YSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKQEAgLTEzNDEsMjgg KzEzNDEsNiBAQCBpbmxpbmUgY29uc3QgSW5saW5lSXRlcmF0b3ImIFJlbmRlckJsb2NrRmxvdzo6 cmVzdGFydExheW91dFJ1bnNBbmRGbG9hdHNJblJhbmdlKAogfQogCiAjaWYgRU5BQkxFKENTU19T SEFQRVMpCi1zdGF0aWMgaW5saW5lIGZsb2F0IGZpcnN0UG9zaXRpdmVXaWR0aChjb25zdCBXb3Jk TWVhc3VyZW1lbnRzJiB3b3JkTWVhc3VyZW1lbnRzKQotewotICAgIGZvciAoc2l6ZV90IGkgPSAw OyBpIDwgd29yZE1lYXN1cmVtZW50cy5zaXplKCk7ICsraSkgewotICAgICAgICBpZiAod29yZE1l YXN1cmVtZW50c1tpXS53aWR0aCA+IDApCi0gICAgICAgICAgICByZXR1cm4gd29yZE1lYXN1cmVt ZW50c1tpXS53aWR0aDsKLSAgICB9Ci0gICAgcmV0dXJuIDA7Ci19Ci0KLXN0YXRpYyBpbmxpbmUg TGF5b3V0VW5pdCBhZGp1c3RMb2dpY2FsTGluZVRvcChTaGFwZUluc2lkZUluZm8qIHNoYXBlSW5z aWRlSW5mbywgSW5saW5lSXRlcmF0b3Igc3RhcnQsIElubGluZUl0ZXJhdG9yIGVuZCwgY29uc3Qg V29yZE1lYXN1cmVtZW50cyYgd29yZE1lYXN1cmVtZW50cykKLXsKLSAgICBpZiAoIXNoYXBlSW5z aWRlSW5mbyB8fCBlbmQgIT0gc3RhcnQpCi0gICAgICAgIHJldHVybiAwOwotCi0gICAgZmxvYXQg bWluV2lkdGggPSBmaXJzdFBvc2l0aXZlV2lkdGgod29yZE1lYXN1cmVtZW50cyk7Ci0gICAgQVNT RVJUKG1pbldpZHRoIHx8IHdvcmRNZWFzdXJlbWVudHMuaXNFbXB0eSgpKTsKLSAgICBpZiAobWlu V2lkdGggPiAwICYmIHNoYXBlSW5zaWRlSW5mby0+YWRqdXN0TG9naWNhbExpbmVUb3AobWluV2lk dGgpKQotICAgICAgICByZXR1cm4gc2hhcGVJbnNpZGVJbmZvLT5sb2dpY2FsTGluZVRvcCgpOwot Ci0gICAgcmV0dXJuIHNoYXBlSW5zaWRlSW5mby0+c2hhcGVMb2dpY2FsQm90dG9tKCk7Ci19Ci0K IHN0YXRpYyBpbmxpbmUgdm9pZCBwdXNoU2hhcGVDb250ZW50T3ZlcmZsb3dCZWxvd1RoZUNvbnRl bnRCb3goUmVuZGVyQmxvY2tGbG93KiBibG9jaywgU2hhcGVJbnNpZGVJbmZvKiBzaGFwZUluc2lk ZUluZm8sIExheW91dFVuaXQgbGluZVRvcCwgTGF5b3V0VW5pdCBsaW5lSGVpZ2h0KQogewogICAg IEFTU0VSVChzaGFwZUluc2lkZUluZm8pOwpAQCAtMTQ3Niw2ICsxNDU0LDI4IEBAIHZvaWQgUmVu ZGVyQmxvY2tGbG93Ojp1cGRhdGVTaGFwZUFuZFNlZ21lbnRzRm9yQ3VycmVudExpbmVJbkZsb3dU aHJlYWQoU2hhcGVJbnNpCiAgICAgICAgIHB1c2hTaGFwZUNvbnRlbnRPdmVyZmxvd0JlbG93VGhl Q29udGVudEJveCh0aGlzLCBzaGFwZUluc2lkZUluZm8sIGxpbmVUb3AsIGxpbmVIZWlnaHQpOwog fQogCitzdGF0aWMgaW5saW5lIGZsb2F0IGZpcnN0UG9zaXRpdmVXaWR0aChjb25zdCBXb3JkTWVh c3VyZW1lbnRzJiB3b3JkTWVhc3VyZW1lbnRzKQoreworICAgIGZvciAoc2l6ZV90IGkgPSAwOyBp IDwgd29yZE1lYXN1cmVtZW50cy5zaXplKCk7ICsraSkgeworICAgICAgICBpZiAod29yZE1lYXN1 cmVtZW50c1tpXS53aWR0aCA+IDApCisgICAgICAgICAgICByZXR1cm4gd29yZE1lYXN1cmVtZW50 c1tpXS53aWR0aDsKKyAgICB9CisgICAgcmV0dXJuIDA7Cit9CisKK3N0YXRpYyBpbmxpbmUgTGF5 b3V0VW5pdCBhZGp1c3RMb2dpY2FsTGluZVRvcChTaGFwZUluc2lkZUluZm8qIHNoYXBlSW5zaWRl SW5mbywgSW5saW5lSXRlcmF0b3Igc3RhcnQsIElubGluZUl0ZXJhdG9yIGVuZCwgY29uc3QgV29y ZE1lYXN1cmVtZW50cyYgd29yZE1lYXN1cmVtZW50cykKK3sKKyAgICBpZiAoIXNoYXBlSW5zaWRl SW5mbyB8fCBlbmQgIT0gc3RhcnQpCisgICAgICAgIHJldHVybiAwOworCisgICAgZmxvYXQgbWlu V2lkdGggPSBmaXJzdFBvc2l0aXZlV2lkdGgod29yZE1lYXN1cmVtZW50cyk7CisgICAgQVNTRVJU KG1pbldpZHRoIHx8IHdvcmRNZWFzdXJlbWVudHMuaXNFbXB0eSgpKTsKKyAgICBpZiAobWluV2lk dGggPiAwICYmIHNoYXBlSW5zaWRlSW5mby0+YWRqdXN0TG9naWNhbExpbmVUb3AobWluV2lkdGgp KQorICAgICAgICByZXR1cm4gc2hhcGVJbnNpZGVJbmZvLT5sb2dpY2FsTGluZVRvcCgpOworCisg ICAgcmV0dXJuIHNoYXBlSW5zaWRlSW5mby0+c2hhcGVMb2dpY2FsQm90dG9tKCk7Cit9CisKIGJv b2wgUmVuZGVyQmxvY2tGbG93OjphZGp1c3RMb2dpY2FsTGluZVRvcEFuZExvZ2ljYWxIZWlnaHRJ Zk5lZWRlZChTaGFwZUluc2lkZUluZm8qIHNoYXBlSW5zaWRlSW5mbywgTGF5b3V0VW5pdCBhYnNv bHV0ZUxvZ2ljYWxUb3AsIExpbmVMYXlvdXRTdGF0ZSYgbGF5b3V0U3RhdGUsIElubGluZUJpZGlS ZXNvbHZlciYgcmVzb2x2ZXIsIEZsb2F0aW5nT2JqZWN0KiBsYXN0RmxvYXRGcm9tUHJldmlvdXNM aW5lLCBJbmxpbmVJdGVyYXRvciYgZW5kLCBXb3JkTWVhc3VyZW1lbnRzJiB3b3JkTWVhc3VyZW1l bnRzKQogewogICAgIExheW91dFVuaXQgYWRqdXN0ZWRMb2dpY2FsTGluZVRvcCA9IGFkanVzdExv Z2ljYWxMaW5lVG9wKHNoYXBlSW5zaWRlSW5mbywgcmVzb2x2ZXIucG9zaXRpb24oKSwgZW5kLCB3 b3JkTWVhc3VyZW1lbnRzKTsK