122666 2013-10-11 11:44:33 -0700 Fix handling of indirect stackmap locations in FTL OSR exit 2013-10-11 18:31:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 122487 1 fpizlo fpizlo atrick barraclough ggaren mark.lam mhahnenberg msaboff nrotem sam oldest_to_newest 938898 0 fpizlo 2013-10-11 11:44:33 -0700 Patch forthcoming. 938902 1 214008 fpizlo 2013-10-11 11:47:53 -0700 Created attachment 214008 the patch 939011 2 214008 mhahnenberg 2013-10-11 16:54:19 -0700 Comment on attachment 214008 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=214008&action=review r=me > Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp:70 > + jit.push(GPRInfo::regT0); Might be good to comment why we're seemingly randomly pushing here. 939021 3 fpizlo 2013-10-11 18:31:58 -0700 Landed in http://trac.webkit.org/changeset/157326 214008 2013-10-11 11:47:53 -0700 2013-10-11 16:54:19 -0700 the patch blah.patch text/plain 4703 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3MzA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDEzLTEwLTExICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg Rml4IGhhbmRsaW5nIG9mIGluZGlyZWN0IHN0YWNrbWFwIGxvY2F0aW9ucyBpbiBGVEwgT1NSIGV4 aXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMjY2 NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAg ICAgV2l0aCB0aGlzIGNoYW5nZSwgdGhlIGxsdm0ud2Via2l0LnN0YWNrbWFwLWJhc2VkIE9TUiBl eGl0IG9ubHkgZmFpbHMgb25lIHRlc3QsIGRvd24gZnJvbQorICAgICAgICBmaXZlIHRlc3RzIHBy ZXZpb3VzbHkuCisKKyAgICAgICAgKiBmdGwvRlRMTG9jYXRpb24uY3BwOgorICAgICAgICAoSlND OjpGVEw6OkxvY2F0aW9uOjpncHIpOiBJdCdzIE9LIHRvIGNhbGwgdGhpcyBtZXRob2Qgd2hlbiBr aW5kKCkgPT0gSW5kaXJlY3QsIHNvIGFzc2VydGluZyB0aGF0IGlzR1BSKCkgaXMgd3Jvbmc7IGNo YW5nZSB0byBhc3NlcnQgdGhhdCBpbnZvbHZlc0dQUigpLgorICAgICAgICAoSlNDOjpGVEw6Okxv Y2F0aW9uOjpyZXN0b3JlSW50byk6IFN0YWNrLXJlbGF0ZWQgcmVnaXN0ZXJzIGFyZW4ndCBzYXZl ZCB0byB0aGUgc2NyYXRjaCBidWZmZXIsIHNvIHVzZSB0aGVtIGRpcmVjdGx5LgorICAgICAgICAq IGZ0bC9GVExMb2NhdGlvbi5oOiBBZGQgY29tbWVudCBhYm91dCByZXF1aXJlbWVudHMgZm9yIHN0 YWNrIGxheW91dC4KKyAgICAgICAgKiBmdGwvRlRMT1NSRXhpdENvbXBpbGVyLmNwcDoKKyAgICAg ICAgKEpTQzo6RlRMOjpjb21waWxlU3R1YldpdGhPU1JFeGl0U3RhY2ttYXApOiBNYWtlIGVub3Vn aCByb29tIG9uIHRoZSBzdGFjayBzbyB0aGF0IHNhdmVBbGxSZWdpc3RlcnMoKSBoYXMgYSBzY3Jh dGNocGFkIHRvIHNhdmUgdGhpbmdzIHRvLiBXaXRob3V0IHRoaXMsIHNhdmVBbGxSZWdpc3RlcnMo KSBtYXkgY2xvYmJlciBhIHNwaWxsZWQgdmFsdWUuCisKIDIwMTMtMTAtMTEgIE9saXZlciBIdW50 ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBTZXBhcmF0ZSBvdXQgYXJyYXkgaXRlcmF0 aW9uIGludHJpbnNpY3MKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG9jYXRp b24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG9jYXRp b24uY3BwCShyZXZpc2lvbiAxNTcyOTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZU TExvY2F0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODcsNyArODcsNyBAQCBHUFJSZWcgTG9j YXRpb246OmdwcigpIGNvbnN0CiAgICAgLy8gZm9yIGV4YW1wbGUsIHRoZSBhcmNoaXRlY3R1cmUg ZW5jb2RlcyBDWCBhcyAxIGFuZCBEWCBhcyAyIHdoaWxlIER3YXJmIGRvZXMgdGhlCiAgICAgLy8g b3Bwb3NpdGUuIEhlbmNlIHdlIG5lZWQgdGhlIHN3aXRjaC4KICAgICAKLSAgICBBU1NFUlQoaXNH UFIoKSk7CisgICAgQVNTRVJUKGludm9sdmVzR1BSKCkpOwogICAgIAogICAgIHN3aXRjaCAoZHdh cmZSZWdOdW0oKSkgewogICAgIGNhc2UgMDoKQEAgLTEyNyw2ICsxMjcsMTIgQEAgRlBSUmVnIExv Y2F0aW9uOjpmcHIoKSBjb25zdAogdm9pZCBMb2NhdGlvbjo6cmVzdG9yZUludG8oTWFjcm9Bc3Nl bWJsZXImIGppdCwgY2hhciogc2F2ZWRSZWdpc3RlcnMsIEdQUlJlZyByZXN1bHQpIGNvbnN0CiB7 CiAgICAgaWYgKGlzR1BSKCkpIHsKKyAgICAgICAgaWYgKE1hY3JvQXNzZW1ibGVyOjppc1N0YWNr UmVsYXRlZChncHIoKSkpIHsKKyAgICAgICAgICAgIC8vIFRoZXNlIGRvbid0IGdldCBzYXZlZC4K KyAgICAgICAgICAgIGppdC5tb3ZlKGdwcigpLCByZXN1bHQpOworICAgICAgICAgICAgcmV0dXJu OworICAgICAgICB9CisgICAgICAgIAogICAgICAgICBqaXQubG9hZDY0KHNhdmVkUmVnaXN0ZXJz ICsgb2Zmc2V0T2ZHUFIoZ3ByKCkpLCByZXN1bHQpOwogICAgICAgICByZXR1cm47CiAgICAgfQpA QCAtMTQzLDYgKzE0OSwxMiBAQCB2b2lkIExvY2F0aW9uOjpyZXN0b3JlSW50byhNYWNyb0Fzc2Vt YmxlCiAgICAgICAgIHJldHVybjsKICAgICAgICAgCiAgICAgY2FzZSBJbmRpcmVjdDoKKyAgICAg ICAgaWYgKE1hY3JvQXNzZW1ibGVyOjppc1N0YWNrUmVsYXRlZChncHIoKSkpIHsKKyAgICAgICAg ICAgIC8vIFRoZXNlIGRvbid0IGdldCBzYXZlZC4KKyAgICAgICAgICAgIGppdC5sb2FkNjQoTWFj cm9Bc3NlbWJsZXI6OkFkZHJlc3MoZ3ByKCksIG9mZnNldCgpKSwgcmVzdWx0KTsKKyAgICAgICAg ICAgIHJldHVybjsKKyAgICAgICAgfQorICAgICAgICAKICAgICAgICAgaml0LmxvYWQ2NChzYXZl ZFJlZ2lzdGVycyArIG9mZnNldE9mR1BSKGdwcigpKSwgcmVzdWx0KTsKICAgICAgICAgaml0Lmxv YWQ2NChNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhyZXN1bHQsIG9mZnNldCgpKSwgcmVzdWx0KTsK ICAgICAgICAgcmV0dXJuOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb2Nh dGlvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG9jYXRp b24uaAkocmV2aXNpb24gMTU3MjkyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExM b2NhdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNTUsNyArMTU1LDExIEBAIHB1YmxpYzoKICAg ICAKICAgICAvLyBBc3N1bWluZyB0aGF0IGFsbCByZWdpc3RlcnMgYXJlIHNhdmVkIHRvIHRoZSBz YXZlZFJlZ2lzdGVycyBidWZmZXIgYWNjb3JkaW5nCiAgICAgLy8gdG8gRlRMU2F2ZVJlc3RvcmUg Y29udmVudGlvbiwgdGhpcyBsb2FkcyB0aGUgdmFsdWUgaW50byB0aGUgZ2l2ZW4gcmVnaXN0ZXIu Ci0gICAgLy8gVGhlIGNvZGUgdGhhdCB0aGlzIGdlbmVyYXRlcyBpc24ndCBleGFjdGx5IHN1cGVy IGZhc3QuCisgICAgLy8gVGhlIGNvZGUgdGhhdCB0aGlzIGdlbmVyYXRlcyBpc24ndCBleGFjdGx5 IHN1cGVyIGZhc3QuIFRoaXMgYXNzdW1lcyB0aGF0IEZQCisgICAgLy8gYW5kIFNQIGNvbnRhaW4g dGhlIHNhbWUgdmFsdWVzIHRoYXQgdGhleSB3b3VsZCBoYXZlIGNvbnRhaW5lZCBpbiB0aGUgb3Jp Z2luYWwKKyAgICAvLyBmcmFtZS4gSWYgd2UgZGlkIHB1c2ggdGhpbmdzIG9udG8gdGhlIHN0YWNr IHRoZW4gcHJvYmFibHkgd2UnbGwgaGF2ZSB0byBjaGFuZ2UKKyAgICAvLyB0aGUgc2lnbmF0dXJl IG9mIHRoaXMgbWV0aG9kIHRvIHRha2UgYSBzdGFjayBvZmZzZXQgZm9yIHN0YWNrLXJlbGF0aXZl CisgICAgLy8gaW5kaXJlY3RzLgogICAgIHZvaWQgcmVzdG9yZUludG8oTWFjcm9Bc3NlbWJsZXIm LCBjaGFyKiBzYXZlZFJlZ2lzdGVycywgR1BSUmVnIHJlc3VsdCkgY29uc3Q7CiAgICAgCiBwcml2 YXRlOgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExPU1JFeGl0Q29tcGlsZXIu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMT1NSRXhpdENv bXBpbGVyLmNwcAkocmV2aXNpb24gMTU3MjkyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0 bC9GVExPU1JFeGl0Q29tcGlsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NywxMCArNjcsMTUg QEAgc3RhdGljIHZvaWQgY29tcGlsZVN0dWJXaXRoT1NSRXhpdFN0YWNrbQogICAgIEVuY29kZWRK U1ZhbHVlKiBzY3JhdGNoID0gc2NyYXRjaEJ1ZmZlciA/IHN0YXRpY19jYXN0PEVuY29kZWRKU1Zh bHVlKj4oc2NyYXRjaEJ1ZmZlci0+ZGF0YUJ1ZmZlcigpKSA6IDA7CiAgICAgY2hhciogcmVnaXN0 ZXJTY3JhdGNoID0gYml0d2lzZV9jYXN0PGNoYXIqPihzY3JhdGNoICsgZXhpdC5tX3ZhbHVlcy5z aXplKCkpOwogICAgIAorICAgIGppdC5wdXNoKEdQUkluZm86OnJlZ1QwKTsKICAgICBzYXZlQWxs UmVnaXN0ZXJzKGppdCwgcmVnaXN0ZXJTY3JhdGNoKTsKICAgICAKICAgICAvLyBCcmluZyB0aGUg c3RhY2sgYmFjayBpbnRvIGEgc2FuZSBmb3JtLgogICAgIGppdC5wb3AoR1BSSW5mbzo6cmVnVDAp OworICAgIGppdC5wb3AoR1BSSW5mbzo6cmVnVDApOworICAgIAorICAgIC8vIFRoZSByZW1haW5p bmcgY29kZSBhc3N1bWVzIHRoYXQgU1AvRlAgYXJlIGluIHRoZSBzYW1lIHN0YXRlIHRoYXQgdGhl eSB3ZXJlIGluIHRoZSBGVEwncworICAgIC8vIGNhbGwgZnJhbWUuCiAgICAgCiAgICAgLy8gR2V0 IHRoZSBjYWxsIGZyYW1lIGFuZCB0YWcgdGhpbmdpZXMuCiAgICAgcmVjb3JkLT5sb2NhdGlvbnNb MF0ucmVzdG9yZUludG8oaml0LCBqaXRDb2RlLT5zdGFja21hcHMsIHJlZ2lzdGVyU2NyYXRjaCwg R1BSSW5mbzo6Y2FsbEZyYW1lUmVnaXN0ZXIpOwo=