122629 2013-10-10 18:50:28 -0700 FTL shouldn't pass i1's into llvm.webkit.stackmap's 2013-10-10 23:36:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo atrick barraclough ggaren mark.lam mhahnenberg msaboff nrotem oliver sam oldest_to_newest 938640 0 fpizlo 2013-10-10 18:50:28 -0700 Patch forthcoming. <rdar://problem/15203037> 938641 1 213953 fpizlo 2013-10-10 18:52:28 -0700 Created attachment 213953 the patch 938650 2 213953 sam 2013-10-10 19:38:10 -0700 Comment on attachment 213953 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=213953&action=review > Source/JavaScriptCore/ChangeLog:10 > + FTL shouldn't pass i1's into llvm.webkit.stackmap's > + https://bugs.webkit.org/show_bug.cgi?id=122629 > + <rdar://problem/15203037> > + > + Reviewed by NOBODY (OOPS!). > + > + * ftl/FTLLowerDFGToLLVM.cpp: > + (JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode): Why? 938708 3 nrotem 2013-10-10 23:22:16 -0700 i1 is not a legal type because it does not fit into a register on most targets. LLVM can't "legalize" stack maps because we did not add support for stack maps with illegal types. r=me. 938714 4 fpizlo 2013-10-10 23:31:51 -0700 (In reply to comment #3) > i1 is not a legal type because it does not fit into a register on most targets. LLVM can't "legalize" stack maps because we did not add support for stack maps with illegal types. r=me. What Nadav said. I'll put this into the comment. Basically, the stackmap support that LLVM provides us with requires us to legalize types ourselves. Which is fine. I had just forgotten that rule and accidentally let i1's slip through. 938715 5 fpizlo 2013-10-10 23:36:43 -0700 Landed in http://trac.webkit.org/changeset/157293 213953 2013-10-10 18:52:28 -0700 2013-10-10 19:38:10 -0700 the patch blah.patch text/plain 1486 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU3Mjg1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEzLTEwLTEwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIHNob3VsZG4ndCBwYXNzIGkxJ3MgaW50byBsbHZtLndlYmtpdC5zdGFja21hcCdzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjI2MjkKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzE1MjAzMDM3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcDoKKyAgICAg ICAgKEpTQzo6RlRMOjpMb3dlckRGR1RvTExWTTo6YWRkRXhpdEFyZ3VtZW50Rm9yTm9kZSk6CisK IDIwMTMtMTAtMDkgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBG dXJ0aGVyIGltcHJvdmUgQXJyYXlJdGVyYXRvciBwZXJmb3JtYW5jZQpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHJldmlzaW9uIDE1 NzI4NSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0xMVk0uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zNDQyLDcgKzM0NDIsMTIgQEAgcHJpdmF0ZToKICAgICAgICAg CiAgICAgICAgIHZhbHVlID0gbV9ib29sZWFuVmFsdWVzLmdldChub2RlKTsKICAgICAgICAgaWYg KGlzVmFsaWQodmFsdWUpKSB7Ci0gICAgICAgICAgICBhZGRFeGl0QXJndW1lbnQoZXhpdCwgYXJn dW1lbnRzLCBpbmRleCwgVmFsdWVGb3JtYXRCb29sZWFuLCB2YWx1ZS52YWx1ZSgpKTsKKyAgICAg ICAgICAgIExWYWx1ZSB2YWx1ZVRvUGFzczsKKyAgICAgICAgICAgIGlmIChPcHRpb25zOjpmdGxP U1JFeGl0VXNlc1N0YWNrbWFwKCkpCisgICAgICAgICAgICAgICAgdmFsdWVUb1Bhc3MgPSBtX291 dC56ZXJvRXh0KHZhbHVlLnZhbHVlKCksIG1fb3V0LmludDMyKTsKKyAgICAgICAgICAgIGVsc2UK KyAgICAgICAgICAgICAgICB2YWx1ZVRvUGFzcyA9IHZhbHVlLnZhbHVlKCk7CisgICAgICAgICAg ICBhZGRFeGl0QXJndW1lbnQoZXhpdCwgYXJndW1lbnRzLCBpbmRleCwgVmFsdWVGb3JtYXRCb29s ZWFuLCB2YWx1ZVRvUGFzcyk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICAg ICAgCg==